Skip to contentSkip to conversation

openssl: Add missing perl module runtime dependencies for ptests

PATCH In review Khem Raj 3 participants 15 messages Sep 30, 2022 – Oct 4, 2022

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 openssl: Add missing perl module runtime dependencies for ptests

---
 meta/recipes-connectivity/openssl/openssl_3.0.5.bb | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
meta/recipes-connectivity/openssl/openssl_3.0.5.bb +10 -1
index 04aff04fab..119e58ed24 100644
@@ -243,7 +243,16 @@ CONFFILES:openssl-conf = "${sysconfdir}/ssl/openssl.cnf"
 
 RRECOMMENDS:libcrypto += "openssl-conf ${PN}-ossl-module-legacy"
 RDEPENDS:${PN}-misc = "perl"
-RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules bash sed"
+RDEPENDS:${PN}-ptest += "bash sed openssl-bin \
+                         perl perl-modules \
+                         perl-module-file-spec-functions \
+                         perl-module-findbin perl-module-harness perl-module-tap-base \
+                         perl-module-tap-object perl-module-tap-parser-sourcehandler-executable \
+                         perl-module-tap-formatter-file perl-module-tap-formatter-session \
+                         perl-module-tap-formatter-base perl-module-tap-parser \
+                         perl-module-tap-parser-scheduler perl-module-test-more \
+                         perl-module-pod-text perl-module-encode-encoding \
+                         "
 
 RDEPENDS:${PN}-bin += "openssl-conf"
 
Signature · 1 line
2.37.3
#1 lore raw

meta/recipes-connectivity/openssl/openssl_3.0.5.bb CONFFILES:openssl-conf = "${sysconfdir}/ssl/openssl.cnf" · line 247

Quoted 3 lines · Khem Raj via lists.openembedded.org
meta/recipes-connectivity/openssl/openssl_3.0.5.bb +2 -1
-RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules bash sed"
+RDEPENDS:${PN}-ptest += "bash sed openssl-bin \
+                         perl perl-modules \

I thought the point of perl-modules was to depend on the entire standard library, so isn’t this a bug in perl-modules?

Ross

#2 lore raw
Quoted 10 lines · Ross Burton via lists.openembedded.org

meta/recipes-connectivity/openssl/openssl_3.0.5.bb CONFFILES:openssl-conf = "${sysconfdir}/ssl/openssl.cnf" · line 247

Quoted 3 lines · Khem Raj via lists.openembedded.org
meta/recipes-connectivity/openssl/openssl_3.0.5.bb +2 -1
-RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules bash sed"
+RDEPENDS:${PN}-ptest += "bash sed openssl-bin \
+                         perl perl-modules \

I thought the point of perl-modules was to depend on the entire standard library, so isn’t this a bug in perl-modules?

My perl-modules RRECOMMENDS on, eg, perl-module-tap-parser.

Are you building an image with recommendations turned off?

Ross

author
#3 lore raw
Quoted 12 lines · Ross Burton
Quoted 3 lines

On 30 Sep 2022, at 11:16, Ross Burton via lists.openembedded.org

Quoted 2 lines · <[email protected]> wrote:

On 30 Sep 2022, at 05:16, Khem Raj via lists.openembedded.org <raj.khem=

Quoted 5 lines · [email protected]> wrote:

meta/recipes-connectivity/openssl/openssl_3.0.5.bb CONFFILES:openssl-conf = "${sysconfdir}/ssl/openssl.cnf" · line 247

Quoted 3 lines
meta/recipes-connectivity/openssl/openssl_3.0.5.bb +2 -1
-RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules bash sed"
+RDEPENDS:${PN}-ptest += "bash sed openssl-bin \
+                         perl perl-modules \

I thought the point of perl-modules was to depend on the entire standard

Quoted 5 lines

library, so isn’t this a bug in perl-modules?

My perl-modules RRECOMMENDS on, eg, perl-module-tap-parser.

Are you building an image with recommendations turned off?

Good point I will check in think it worked fine with glibc but not with musl based images I see that Perl-modules is fully empty in packages-split area so soMething does not add up

Quoted 3 lines

Ross

#4 lore raw
Quoted 5 lines · Khem Raj via lists.openembedded.org

Good point I will check in think it worked fine with glibc but not with musl based images I see that Perl-modules is fully empty in packages-split area so soMething does not add up

It will be empty as it’s a metapackage, but it should have lots of rrecommends.

Ross

author
#5 lore raw
Quoted 11 lines · Ross Burton
Quoted 3 lines

On 30 Sep 2022, at 17:03, Khem Raj via lists.openembedded.org <raj.khem=

Quoted 2 lines · [email protected]> wrote:

Good point I will check in think it worked fine with glibc but not with

musl based images I see that Perl-modules is fully empty in packages-split area so soMething does not add up

It will be empty as it’s a metapackage, but it should have lots of rrecommends.

Right that was the point the folder should not have been empty it should have had those rdepends control files

Quoted 2 lines

Ross

#6 lore raw
Quoted 7 lines · Khem Raj
Quoted 1 line

Good point I will check in think it worked fine with glibc but not with musl based images I see that Perl-modules is fully empty in packages-split area so soMething does not add up

It will be empty as it’s a metapackage, but it should have lots of rrecommends.

Right that was the point the folder should not have been empty it should have had those rdepends control files

My perl-modules pkgdata built with musl:

RRECOMMENDS:perl-modules: perl-module-cpan perl-module-unicore perl-module-b perl-module-compress-raw-bzip2 perl-module-compress-raw-zlib perl-module-cwd perl-module-data-dumper perl-module-devel-peek perl-module-digest-md5 perl-module-digest-sha perl-module-encode-byte perl-module-encode-cn […]

Can you retest? Unless you’re running in a no-recommends build I can’t see how this can be.

Arguably, perl-modules should depends on the packages, otherwise it totally breaks in no-recommends environments. If you install perl-modules you want the entire library, not just a fraction of it.

Ross

author
#7 lore raw
Quoted 10 lines · Ross Burton
Quoted 8 lines · Khem Raj
Quoted 1 line

Good point I will check in think it worked fine with glibc but not with musl based images I see that Perl-modules is fully empty in packages-split area so soMething does not add up

It will be empty as it’s a metapackage, but it should have lots of rrecommends.

Right that was the point the folder should not have been empty it should have had those rdepends control files

Quoted 7 lines

My perl-modules pkgdata built with musl:

RRECOMMENDS:perl-modules: perl-module-cpan perl-module-unicore perl-module-b perl-module-compress-raw-bzip2 perl-module-compress-raw-zlib perl-module-cwd perl-module-data-dumper perl-module-devel-peek perl-module-digest-md5 perl-module-digest-sha perl-module-encode-byte perl-module-encode-cn […]

Can you retest? Unless you’re running in a no-recommends build I can’t see how this can be.

Arguably, perl-modules should depends on the packages, otherwise it totally breaks in no-recommends environments. If you install perl-modules you want the entire library, not just a fraction of it.

are you building with opkg ?

Quoted 2 lines

Ross

author
#8 lore raw
Quoted 14 lines · Khem Raj
Quoted 12 lines · Ross Burton
Quoted 8 lines · Khem Raj
Quoted 1 line

Good point I will check in think it worked fine with glibc but not with musl based images I see that Perl-modules is fully empty in packages-split area so soMething does not add up

It will be empty as it’s a metapackage, but it should have lots of rrecommends.

Right that was the point the folder should not have been empty it should have had those rdepends control files

My perl-modules pkgdata built with musl:

Quoted 7 lines
Quoted 5 lines

RRECOMMENDS:perl-modules: perl-module-cpan perl-module-unicore perl-module-b perl-module-compress-raw-bzip2 perl-module-compress-raw-zlib perl-module-cwd perl-module-data-dumper perl-module-devel-peek perl-module-digest-md5 perl-module-digest-sha perl-module-encode-byte perl-module-encode-cn […]

Can you retest? Unless you’re running in a no-recommends build I can’t see how this can be.

Arguably, perl-modules should depends on the packages, otherwise it totally breaks in no-recommends environments. If you install perl-modules you want the entire library, not just a fraction of it.

are you building with opkg ?

and here is my list of bad recommendations

BAD_RECOMMENDATIONS += "eudev-hwdb udev-hwdb libmodule-build-perl"

Quoted 3 lines
Quoted 3 lines

Ross

author
#9 lore raw
Quoted 20 lines · Khem Raj
Quoted 18 lines · Khem Raj
Quoted 16 lines · Ross Burton
Quoted 8 lines · Khem Raj
Quoted 1 line

Good point I will check in think it worked fine with glibc but not with musl based images I see that Perl-modules is fully empty in packages-split area so soMething does not add up

It will be empty as it’s a metapackage, but it should have lots of rrecommends.

Right that was the point the folder should not have been empty it should have had those rdepends control files

My perl-modules pkgdata built with musl:

RRECOMMENDS:perl-modules: perl-module-cpan perl-module-unicore perl-module-b perl-module-compress-raw-bzip2 perl-module-compress-raw-zlib perl-module-cwd perl-module-data-dumper perl-module-devel-peek perl-module-digest-md5 perl-module-digest-sha perl-module-encode-byte perl-module-encode-cn […]

Can you retest? Unless you’re running in a no-recommends build I can’t see how this can be.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Arguably, perl-modules should depends on the packages, otherwise it totally breaks in no-recommends environments. If you install perl-modules you want the entire library, not just a fraction of it.

are you building with opkg ?

and here is my list of bad recommendations

BAD_RECOMMENDATIONS += "eudev-hwdb udev-hwdb libmodule-build-perl"

OK my RRECOMMENDS:perl-modules are fine similar to Ross, however they does not get pulled into final image when openssl-ptest is added to IMAGE_INSTALL

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Ross

#10 lore raw
Quoted 3 lines

OK my RRECOMMENDS:perl-modules are fine similar to Ross, however they does not get pulled into final image when openssl-ptest is added to IMAGE_INSTALL

That’s definitely worth looking into. This isn’t the solution, assuming you’re not disabling recommendations in your image recipe.

Ross

author
#11 lore raw
Quoted 7 lines · Ross Burton
Quoted 3 lines

OK my RRECOMMENDS:perl-modules are fine similar to Ross, however they does not get pulled into final image when openssl-ptest is added to IMAGE_INSTALL

That’s definitely worth looking into. This isn’t the solution, assuming you’re not disabling recommendations in your image recipe.

Core-image-ptest works so hmm I don’t know what’s wrong with my image

Quoted 13 lines

Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#171349):
https://lists.openembedded.org/g/openembedded-core/message/171349
Mute This Topic: https://lists.openembedded.org/mt/94010252/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

author
#12 lore raw
Quoted 10 lines · Khem Raj
Quoted 6 lines · Ross Burton
Quoted 4 lines

OK my RRECOMMENDS:perl-modules are fine similar to Ross, however they does not get pulled into final image when openssl-ptest is added to IMAGE_INSTALL

Quoted 5 lines
Quoted 1 line

That’s definitely worth looking into. This isn’t the solution, assuming you’re not disabling recommendations in your image recipe.

Core-image-ptest works so hmm I don’t know what’s wrong with my image

I think the issue seems with any image using opkg backend and adding

IMAGE_FEATURES += "ptest-pkgs"

in local.conf

DISTRO_FEATURES += "ptest"

It does not even bring ptest-runner which is in RRECOMMENDS of every ptest package.

The core-image-ptest work perhaps because they explicitly specify certain ptest packages and they bring in the needed deps

Quoted 11 lines
Quoted 11 lines

Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#171349): https://lists.openembedded.org/g/openembedded-core/message/171349
Mute This Topic: https://lists.openembedded.org/mt/94010252/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#13 lore raw
In reply to Khem Raj

Hello,

This caused many issues on the autobuilders, similar to those:

https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/5982/steps/11/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/3796/steps/11/logs/stdio

Quoted 40 lines · Khem Raj
---
 meta/recipes-connectivity/openssl/openssl_3.0.5.bb | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
meta/recipes-connectivity/openssl/openssl_3.0.5.bb +10 -1
index 04aff04fab..119e58ed24 100644
@@ -243,7 +243,16 @@ CONFFILES:openssl-conf = "${sysconfdir}/ssl/openssl.cnf"
 
 RRECOMMENDS:libcrypto += "openssl-conf ${PN}-ossl-module-legacy"
 RDEPENDS:${PN}-misc = "perl"
-RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules bash sed"
+RDEPENDS:${PN}-ptest += "bash sed openssl-bin \
+                         perl perl-modules \
+                         perl-module-file-spec-functions \
+                         perl-module-findbin perl-module-harness perl-module-tap-base \
+                         perl-module-tap-object perl-module-tap-parser-sourcehandler-executable \
+                         perl-module-tap-formatter-file perl-module-tap-formatter-session \
+                         perl-module-tap-formatter-base perl-module-tap-parser \
+                         perl-module-tap-parser-scheduler perl-module-test-more \
+                         perl-module-pod-text perl-module-encode-encoding \
+                         "
 
 RDEPENDS:${PN}-bin += "openssl-conf"
 
Signature · 11 lines
2.37.3



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#171204): https://lists.openembedded.org/g/openembedded-core/message/171204
Mute This Topic: https://lists.openembedded.org/mt/94010252/3617179
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#14 lore raw

Thanks Alex, I will rework it.

Quoted 55 lines · Alexandre Belloni

Hello,

This caused many issues on the autobuilders, similar to those:

https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/5982/steps/11/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/3796/steps/11/logs/stdio

Quoted 32 lines · Khem Raj
---
 meta/recipes-connectivity/openssl/openssl_3.0.5.bb | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
meta/recipes-connectivity/openssl/openssl_3.0.5.bb +10 -2
index 04aff04fab..119e58ed24 100644
@@ -243,7 +243,16 @@ CONFFILES:openssl-conf = "${sysconfdir}/ssl/openssl.cnf"
 
 RRECOMMENDS:libcrypto += "openssl-conf ${PN}-ossl-module-legacy"
 RDEPENDS:${PN}-misc = "perl"
-RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules bash sed"
+RDEPENDS:${PN}-ptest += "bash sed openssl-bin \
+                         perl perl-modules \
+                         perl-module-file-spec-functions \
+                         perl-module-findbin perl-module-harness perl-module-tap-base \
+                         perl-module-tap-object perl-module-tap-parser-sourcehandler-executable \
+                         perl-module-tap-formatter-file perl-module-tap-formatter-session \
+                         perl-module-tap-formatter-base perl-module-tap-parser \
+                         perl-module-tap-parser-scheduler perl-module-test-more \
+                         perl-module-pod-text perl-module-encode-encoding \
+                         "
 
 RDEPENDS:${PN}-bin += "openssl-conf"
 
--

2.37.3

Quoted 8 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#171204): https://lists.openembedded.org/g/openembedded-core/message/171204
Mute This Topic: https://lists.openembedded.org/mt/94010252/3617179
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com