Skip to contentSkip to conversation

ublk: don't suggest CONFIG_BLK_DEV_UBLK=Y

PATCH Applied Caleb Sander Mateos 4 participants 4 messages Apr 16, 2025 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ublk: don't suggest CONFIG_BLK_DEV_UBLK=Y

The CONFIG_BLK_DEV_UBLK help text suggests setting the config option to Y so task_work_add() can be used to dispatch I/O, improving performance. However, this mechanism was removed in commit 29dc5d06613f2 ("ublk: kill queuing request by task_work_add"). So remove this paragraph from the config help text.

---
 drivers/block/Kconfig | 6 ------
 1 file changed, 6 deletions(-)
drivers/block/Kconfig +0 -6
index 2551ebf88dda..e48b24be45ee 100644
@@ -386,16 +386,10 @@ config BLK_DEV_UBLK
 	  io_uring based userspace block driver. Together with ublk server, ublk
 	  has been working well, but interface with userspace or command data
 	  definition isn't finalized yet, and might change according to future
 	  requirement, so mark is as experimental now.
 
-	  Say Y if you want to get better performance because task_work_add()
-	  can be used in IO path for replacing io_uring cmd, which will become
-	  shared between IO tasks and ubq daemon, meantime task_work_add() can
-	  can handle batch more effectively, but task_work_add() isn't exported
-	  for module, so ublk has to be built to kernel.
-
 config BLKDEV_UBLK_LEGACY_OPCODES
 	bool "Support legacy command opcode"
 	depends on BLK_DEV_UBLK
 	default y
 	help
Signature · 1 line
2.45.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Caleb Sander Mateos

The CONFIG_BLK_DEV_UBLK help text suggests setting the config option to Y so task_work_add() can be used to dispatch I/O, improving performance. However, this mechanism was removed in commit 29dc5d06613f2 ("ublk: kill queuing request by task_work_add"). So remove this paragraph from the config help text.

Quoted 28 lines
---
 drivers/block/Kconfig | 6 ------
 1 file changed, 6 deletions(-)
drivers/block/Kconfig +0 -6
index 2551ebf88dda..e48b24be45ee 100644
@@ -386,16 +386,10 @@ config BLK_DEV_UBLK
 	  io_uring based userspace block driver. Together with ublk server, ublk
 	  has been working well, but interface with userspace or command data
 	  definition isn't finalized yet, and might change according to future
 	  requirement, so mark is as experimental now.
 
-	  Say Y if you want to get better performance because task_work_add()
-	  can be used in IO path for replacing io_uring cmd, which will become
-	  shared between IO tasks and ubq daemon, meantime task_work_add() can
-	  can handle batch more effectively, but task_work_add() isn't exported
-	  for module, so ublk has to be built to kernel.
-
 config BLKDEV_UBLK_LEGACY_OPCODES
 	bool "Support legacy command opcode"
 	depends on BLK_DEV_UBLK
 	default y
 	help
Signature · 1 line
2.45.2
maintainer Applied
#2 lore raw
In reply to Caleb Sander Mateos
Quoted 8 lines · Caleb Sander Mateos

The CONFIG_BLK_DEV_UBLK help text suggests setting the config option to Y so task_work_add() can be used to dispatch I/O, improving performance. However, this mechanism was removed in commit 29dc5d06613f2 ("ublk: kill queuing request by task_work_add"). So remove this paragraph from the config help text.

[...]

Applied, thanks!

[1/1] ublk: don't suggest CONFIG_BLK_DEV_UBLK=Y

      commit: 0b7a4817756c7906d0a8112c953ce88d7cd8d4c6

Best regards,

Signature · 1 line
Jens Axboe
Reviewed-by on v1 1/1
#3 lore raw
In reply to Caleb Sander Mateos
Quoted 7 lines · Caleb Sander Mateos

The CONFIG_BLK_DEV_UBLK help text suggests setting the config option to Y so task_work_add() can be used to dispatch I/O, improving performance. However, this mechanism was removed in commit 29dc5d06613f2 ("ublk: kill queuing request by task_work_add"). So remove this paragraph from the config help text.

Thanks,
Ming