staging: rtl8723bs: Use % 4096 instead of & 0xfff
PATCH 1/1 staging: rtl8723bs: Use % 4096 instead of & 0xfff
Replace the bitwise AND operator & with a modulo operator % and decimal number to make the upper limit visible and clear what the semantic of it is.
Also add white spaces around binary operators for improved readabiity and adherence to Linux kernel coding style.
Suggested-by Andy Shevchenko <[email protected]>
--- drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_xmit.c +3 -3
@@ -943,7 +943,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrif (psta) { psta->sta_xmitpriv.txseq_tid[pattrib->priority]++; - psta->sta_xmitpriv.txseq_tid[pattrib->priority] &=0xFFF ; + psta->sta_xmitpriv.txseq_tid[pattrib->priority] %=4096 ; pattrib->seqnum = psta->sta_xmitpriv.txseq_tid[pattrib->priority];SetSeqNum (hdr, pattrib->seqnum);
@@ -963,11 +963,11 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrif (SN_LESS (pattrib->seqnum, tx_seq)) { pattrib->ampdu_en = false;/* AGG BK */ }else if (SN_EQUAL (pattrib->seqnum, tx_seq)) { - psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (tx_seq+1 )&0xfff ; + psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (tx_seq +1 ) %4096 ; pattrib->ampdu_en = true;/* AGG EN */ }else { - psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (pattrib->seqnum+1 )&0xfff ; + psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (pattrib->seqnum +1 ) %4096 ; pattrib->ampdu_en = true;/* AGG EN */ } }
Signature · 1 line
2.34.1
Quoted 3 lines · On Fri, 4 Apr 2025 23:33:16 +0000 Abraham Samuel Adekunle…
Replace the bitwise AND operator
&with a modulo operator%and decimal number to make the upper limit visible and clear what the semantic of it is.
Use 4096u to make absolutely certain an unsigned module is used.
David
Quoted 38 lines
Also add white spaces around binary operators for improved readabiity and adherence to Linux kernel coding style.
Suggested-by Andy Shevchenko <[email protected]>
Signed-off-by Abraham Samuel Adekunle <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/rtl8723bs/core/rtw_xmit.c +3
-3@@ -943,7 +943,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrif (psta) { psta->sta_xmitpriv.txseq_tid[pattrib->priority]++; - psta->sta_xmitpriv.txseq_tid[pattrib->priority] &=0xFFF ; + psta->sta_xmitpriv.txseq_tid[pattrib->priority] %=4096 ; pattrib->seqnum = psta->sta_xmitpriv.txseq_tid[pattrib->priority];SetSeqNum (hdr, pattrib->seqnum);@@ -963,11 +963,11 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrif (SN_LESS (pattrib->seqnum, tx_seq)) { pattrib->ampdu_en = false;/* AGG BK */ }else if (SN_EQUAL (pattrib->seqnum, tx_seq)) { - psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (tx_seq+1 )&0xfff ; + psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (tx_seq +1 ) %4096 ; pattrib->ampdu_en = true;/* AGG EN */ }else { - psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (pattrib->seqnum+1 )&0xfff ; + psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (pattrib->seqnum +1 ) %4096 ; pattrib->ampdu_en = true;/* AGG EN */ } }
Quoted 9 lines · David Laight
Quoted 3 lines · On Fri, 4 Apr 2025 23:33:16 +0000 Abraham Samuel Adekunle…
Replace the bitwise AND operator
&with a modulo operator%and decimal number to make the upper limit visible and clear what the semantic of it is.Use 4096u to make absolutely certain an unsigned module is used.
Hello David,
Thank you very much for this suggestion.
Adekunle.