staging: rtl8723bs: simplify if-else block by removing unnecessary braces
PATCH 1/1 staging: rtl8723bs: simplify if-else block by removing unnecessary braces
The if-else block contained braces around single statements, which are unnecessary according to the Linux kernel coding style.
Remove the redundant braces to improve code readability and maintain consistency with the rest of the codebase.
Reported by checkpatch:
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by Abraham Samuel Adekunle <[email protected]>
--- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +2 -3
@@ -988,11 +988,10 @@ void rtw_macaddr_cfg(struct device *dev, u8 *mac_addr)if (is_broadcast_ether_addr (mac) ||is_zero_ether_addr (mac)) { addr =of_get_property (np,"local-mac-address" , &len); -if (addr && len ==ETH_ALEN ) { +if (addr && len ==ETH_ALEN )ether_addr_copy (mac_addr, addr); - }else { +else eth_random_addr (mac_addr); - } } }
Signature · 1 line
2.34.1
Quoted 11 lines · Abraham Samuel Adekunle
The if-else block contained braces around single statements, which are unnecessary according to the Linux kernel coding style.
Remove the redundant braces to improve code readability and maintain consistency with the rest of the codebase.
Reported by checkpatch:
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by Abraham Samuel Adekunle <[email protected]>
Reviewed-by Julia Lawall <[email protected]>
Quoted 26 lines
--- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/staging/rtl8723bs/core/rtw_ieee80211.c +2
-4@@ -988,11 +988,10 @@ void rtw_macaddr_cfg(struct device *dev, u8 *mac_addr)if (is_broadcast_ether_addr (mac) ||is_zero_ether_addr (mac)) { addr =of_get_property (np,"local-mac-address" , &len); -if (addr && len ==ETH_ALEN ) { +if (addr && len ==ETH_ALEN )ether_addr_copy (mac_addr, addr); - }else { +else eth_random_addr (mac_addr); - } } } --2.34.1