staging: rtl8723bs: remove braces around single statements
PATCH v2 1/1 staging: rtl8723bs: remove braces around single statements
The code contains braces around single statements in the if blocks which are unnecessary according to the Linux kernel coding style.
Remove the braces to improve readability and maintain consistency.
Reported by checkpatch:
WARNING: braces {} are not necessary for single statement blocks
---
Changes in v2:
- Remove extra blank line
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +2 -4
@@ -56,9 +56,8 @@ int _ips_leave(struct adapter *padapter) pwrpriv->ips_leave_cnts++; result =rtw_ips_pwr_up (padapter); -if (result == _SUCCESS) { +if (result == _SUCCESS) pwrpriv->rf_pwrstate = rf_on; - } pwrpriv->bips_processing = false; pwrpriv->bkeepfwalive = false;
@@ -549,9 +548,8 @@ void LeaveAllPowerSaveMode(struct adapter *Adapter)LPS_Leave_check (Adapter); }else { -if (adapter_to_pwrctl (Adapter)->rf_pwrstate == rf_off) { +if (adapter_to_pwrctl (Adapter)->rf_pwrstate == rf_off)ips_leave (Adapter); - } } }
--
2.34.1
Quoted 8 lines · Abraham Samuel Adekunle
The code contains braces around single statements in the if blocks which are unnecessary according to the Linux kernel coding style.
Remove the braces to improve readability and maintain consistency.
Reported by checkpatch:
WARNING: braces {} are not necessary for single statement blocks
Are there no other email addresses that shoudl receive this patch?
julia
Quoted 40 lines
Signed-off-by Abraham Samuel Adekunle <[email protected]>---
Changes in v2:
- Remove extra blank linedrivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +2
-5@@ -56,9 +56,8 @@ int _ips_leave(struct adapter *padapter) pwrpriv->ips_leave_cnts++; result =rtw_ips_pwr_up (padapter); -if (result == _SUCCESS) { +if (result == _SUCCESS) pwrpriv->rf_pwrstate = rf_on; - } pwrpriv->bips_processing = false; pwrpriv->bkeepfwalive = false;@@ -549,9 +548,8 @@ void LeaveAllPowerSaveMode(struct adapter *Adapter)LPS_Leave_check (Adapter); }else { -if (adapter_to_pwrctl (Adapter)->rf_pwrstate == rf_off) { +if (adapter_to_pwrctl (Adapter)->rf_pwrstate == rf_off)ips_leave (Adapter); - } } } --2.34.1
Quoted 10 lines · Julia Lawall
Quoted 5 lines · Abraham Samuel Adekunle
The code contains braces around single statements in the if blocks which are unnecessary according to the Linux kernel coding style.
Remove the braces to improve readability and maintain consistency.
Quoted 9 lines
Quoted 3 lines
Reported by checkpatch:
WARNING: braces {} are not necessary for single statement blocks
Are there no other email addresses that shoudl receive this patch?
julia
Yes I mistakenly omitted the Outreachy mailing list in the first v2 patch I sent. I will update and add all
recipients in a patch v3. Thank you
Adekunle