Skip to contentSkip to conversation

staging: rtl8723bs: remove braces around single statements

PATCH Superseded Abraham Samuel Adekunle 2 participants 3 messages Mar 26, 2025 Staging

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: rtl8723bs: remove braces around single statements

The code contains braces around single statements in the if blocks which are unnecessary according to the Linux kernel coding style.

Remove the braces to improve readability and maintain consistency.

Reported by checkpatch:

WARNING: braces {} are not necessary for single statement blocks

---
Changes in v2:
- Remove extra blank line

 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +2 -4
index c60e179bb2e1..74a8fcf18e84 100644
@@ -56,9 +56,8 @@ int _ips_leave(struct adapter *padapter)
 		pwrpriv->ips_leave_cnts++;
 
 		result = rtw_ips_pwr_up(padapter);
-		if (result == _SUCCESS) {
+		if (result == _SUCCESS)
 			pwrpriv->rf_pwrstate = rf_on;
-		}
 		pwrpriv->bips_processing = false;
 
 		pwrpriv->bkeepfwalive = false;
@@ -549,9 +548,8 @@ void LeaveAllPowerSaveMode(struct adapter *Adapter)
 
 		LPS_Leave_check(Adapter);
 	} else {
-		if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off) {
+		if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off)
 			ips_leave(Adapter);
-		}
 	}
 }
 

--
2.34.1

#1 lore raw
Quoted 8 lines · Abraham Samuel Adekunle

The code contains braces around single statements in the if blocks which are unnecessary according to the Linux kernel coding style.

Remove the braces to improve readability and maintain consistency.

Reported by checkpatch:

WARNING: braces {} are not necessary for single statement blocks

Are there no other email addresses that shoudl receive this patch?

julia

Quoted 40 lines

---
Changes in v2:
- Remove extra blank line

 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +2 -5
index c60e179bb2e1..74a8fcf18e84 100644
@@ -56,9 +56,8 @@ int _ips_leave(struct adapter *padapter)
 		pwrpriv->ips_leave_cnts++;
 
 		result = rtw_ips_pwr_up(padapter);
-		if (result == _SUCCESS) {
+		if (result == _SUCCESS)
 			pwrpriv->rf_pwrstate = rf_on;
-		}
 		pwrpriv->bips_processing = false;
 
 		pwrpriv->bkeepfwalive = false;
@@ -549,9 +548,8 @@ void LeaveAllPowerSaveMode(struct adapter *Adapter)
 
 		LPS_Leave_check(Adapter);
 	} else {
-		if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off) {
+		if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off)
 			ips_leave(Adapter);
-		}
 	}
 }
 
--

2.34.1

#2 lore raw
Quoted 10 lines · Julia Lawall
Quoted 5 lines · Abraham Samuel Adekunle

The code contains braces around single statements in the if blocks which are unnecessary according to the Linux kernel coding style.

Remove the braces to improve readability and maintain consistency.

Quoted 9 lines
Quoted 3 lines

Reported by checkpatch:

WARNING: braces {} are not necessary for single statement blocks

Are there no other email addresses that shoudl receive this patch?

julia

Yes I mistakenly omitted the Outreachy mailing list in the first v2 patch I sent. I will update and add all
recipients in a patch v3. Thank you

Adekunle