Skip to contentSkip to conversation

PCI: rockchip-ep: Fix error code in rockchip_pcie_ep_init_ob_mem()

PATCH Applied Dan Carpenter 4 participants 4 messages Dec 2, 2024 – Jan 15, 2025

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 PCI: rockchip-ep: Fix error code in rockchip_pcie_ep_init_ob_mem()

Return -ENOMEM if pci_epc_mem_alloc_addr() fails. Don't return success.

Fixes 945648019466 ("PCI: rockchip-ep: Refactor rockchip_pcie_ep_probe() memory allocations")

---
v2: Update the git hash for the Fixes tag because the tree was rebased I guess.

 drivers/pci/controller/pcie-rockchip-ep.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/controller/pcie-rockchip-ep.c +1 -0
index 1064b7b06cef..34162ca14093 100644
@@ -784,6 +784,7 @@ static int rockchip_pcie_ep_init_ob_mem(struct rockchip_pcie_ep *ep)
 						  SZ_1M);
 	if (!ep->irq_cpu_addr) {
 		dev_err(dev, "failed to reserve memory space for MSI\n");
+		err = -ENOMEM;
 		goto err_epc_mem_exit;
 	}
 
Signature · 1 line
2.45.2
Reviewed-by on v2 1/1
#1 lore raw
Quoted 4 lines · Dan Carpenter

Return -ENOMEM if pci_epc_mem_alloc_addr() fails. Don't return success.

Fixes 945648019466 ("PCI: rockchip-ep: Refactor rockchip_pcie_ep_probe() memory allocations")

- Mani

Quoted 22 lines

---
v2: Update the git hash for the Fixes tag because the tree was rebased I guess.

 drivers/pci/controller/pcie-rockchip-ep.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/controller/pcie-rockchip-ep.c +1 -0
index 1064b7b06cef..34162ca14093 100644
@@ -784,6 +784,7 @@ static int rockchip_pcie_ep_init_ob_mem(struct rockchip_pcie_ep *ep)
 						  SZ_1M);
 	if (!ep->irq_cpu_addr) {
 		dev_err(dev, "failed to reserve memory space for MSI\n");
+		err = -ENOMEM;
 		goto err_epc_mem_exit;
 	}
 
Signature · 1 line
2.45.2
Signature · 1 line
மணிவண்ணன் சதாசிவம்
Reviewed-by on v2 1/1
#2 lore raw
In reply to Dan Carpenter
Quoted 26 lines · Dan Carpenter

Return -ENOMEM if pci_epc_mem_alloc_addr() fails. Don't return success.

Fixes 945648019466 ("PCI: rockchip-ep: Refactor rockchip_pcie_ep_probe() memory allocations")

---
v2: Update the git hash for the Fixes tag because the tree was rebased I guess.

 drivers/pci/controller/pcie-rockchip-ep.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/controller/pcie-rockchip-ep.c +1 -0
index 1064b7b06cef..34162ca14093 100644
@@ -784,6 +784,7 @@ static int rockchip_pcie_ep_init_ob_mem(struct rockchip_pcie_ep *ep)
 						  SZ_1M);
 	if (!ep->irq_cpu_addr) {
 		dev_err(dev, "failed to reserve memory space for MSI\n");
+		err = -ENOMEM;
 		goto err_epc_mem_exit;
 	}
 
Signature · 1 line
2.45.2