crypto: lib/gf128mul - Remove some bbe deadcode
Subsystems (2)
PATCH 1/1 crypto: lib/gf128mul - Remove some bbe deadcode
From: "Dr. David Alan Gilbert" <[email protected]>
gf128mul_4k_bbe(), gf128mul_bbe() and gf128mul_init_4k_bbe() are part of the library originally added in 2006 by commit c494e0705d67 ("[CRYPTO] lib: table driven multiplications in GF(2^128)")
but have never been used.
Remove them.
(BBE is Big endian Byte/Big endian bits
Note the 64k table version is used and I've left that in)
--- include/crypto/gf128mul.h | 6 +--- lib/crypto/gf128mul.c | 75 --------------------------------------- 2 files changed, 1 insertion(+), 80 deletions(-)
include/crypto/gf128mul.h +1 -5
@@ -158,12 +158,10 @@64...71 72...79 80...87 88...95 96..103 104.111 112.119 120.127 */ -/* A slow generic version of gf_mul, implemented for lle and bbe +/* A slow generic version of gf_mul, implemented for lle * It multiplies a and b and puts the result in a */ void gf128mul_lle (be128 *a,const be128 *b); -void gf128mul_bbe (be128 *a,const be128 *b); -/* * The following functions multiply a field element by x in * the polynomial field representation. They use 64-bit word operations
@@ -224,9 +222,7 @@ struct gf128mul_4k { };struct gf128mul_4k *gf128mul_init_4k_lle (const be128 *g); -struct gf128mul_4k *gf128mul_init_4k_bbe (const be128 *g);void gf128mul_4k_lle (be128 *a,const struct gf128mul_4k *t); -void gf128mul_4k_bbe (be128 *a,const struct gf128mul_4k *t);void gf128mul_x8_ble (le128 *r,const le128 *x);static inline void gf128mul_free_4k (struct gf128mul_4k *t) {
lib/crypto/gf128mul.c +0 -75
92 lines not on this page · raw message
Signature · 1 line
2.47.1
Herbert Xu
maintainerQuoted 13 lines · On Wed, Dec 11, 2024 at 10:02:18PM +0000, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
gf128mul_4k_bbe(),gf128mul_bbe()andgf128mul_init_4k_bbe()are part of the library originally added in 2006 by commitc494e0705d67("[CRYPTO] lib: table driven multiplications in GF(2^128)")but have never been used.
Remove them.
(BBE is Big endian Byte/Big endian bits
Note the 64k table version is used and I've left that in)
Quoted 5 lines
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- include/crypto/gf128mul.h | 6 +--- lib/crypto/gf128mul.c | 75 --------------------------------------- 2 files changed, 1 insertion(+), 80 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Quoted 14 lines · * Herbert Xu ([email protected]) wrote:
Quoted 13 lines · On Wed, Dec 11, 2024 at 10:02:18PM +0000, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
gf128mul_4k_bbe(),gf128mul_bbe()andgf128mul_init_4k_bbe()are part of the library originally added in 2006 by commitc494e0705d67("[CRYPTO] lib: table driven multiplications in GF(2^128)")but have never been used.
Remove them.
(BBE is Big endian Byte/Big endian bits
Note the 64k table version is used and I've left that in)
Quoted 7 lines
Quoted 5 lines
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- include/crypto/gf128mul.h | 6 +--- lib/crypto/gf128mul.c | 75 --------------------------------------- 2 files changed, 1 insertion(+), 80 deletions(-)Patch applied. Thanks.
Thanks! I'd appreciate if you could also look back at one from September:
async_xor: Remove unused 'async_xor_val' Message ID: [email protected]
Thanks again,
Dave
Quoted 5 lines
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
Herbert Xu
maintainerQuoted 5 lines · Dr. David Alan Gilbert
Thanks! I'd appreciate if you could also look back at one from September:
async_xor: Remove unused 'async_xor_val' Message ID: [email protected]
The MAINTAINERS entry for that file is:
ASYNCHRONOUS TRANSFERS/TRANSFORMS (IOAT) API
R: Dan Williams <[email protected]> S: Odd fixes W: http://sourceforge.net/projects/xscaleiop F: Documentation/crypto/async-tx-api.rst F: crypto/async_tx/ F: include/linux/async_tx.h
Cheers,
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Quoted 9 lines · * Herbert Xu ([email protected]) wrote:
Quoted 5 lines · Dr. David Alan Gilbert
Thanks! I'd appreciate if you could also look back at one from September:
async_xor: Remove unused 'async_xor_val' Message ID: [email protected]The
MAINTAINERSentry for that file is:
Quoted 7 lines
ASYNCHRONOUS TRANSFERS/TRANSFORMS (IOAT) API
R: Dan Williams <[email protected]> S: Odd fixes W: http://sourceforge.net/projects/xscaleiop F: Documentation/crypto/async-tx-api.rst F: crypto/async_tx/ F: include/linux/async_tx.h
That is who I mailed at the time but it didn't go anywhere.
Thanks again,
Dave
Quoted 5 lines
Cheers,
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/