Skip to contentSkip to conversation

net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities

PATCH Applied Daniel Golle 2 participants 2 messages Jan 2, 2025 – Jan 4, 2025

Subsystems (5)
lore
Share & tools
lore

Daniel Golle

author maintainer
#0 lore raw

PATCH 1/1 net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities

Neither does the LynxI PCS support QSGMII, nor is in-band-status supported in 2500Base-X mode. Fix the pcs_inband_caps() method accordingly.

Fixes 520d29bdda86 ("net: pcs: pcs-mtk-lynxi: implement pcs_inband_caps() method")

---
drivers/net/pcs/pcs-mtk-lynxi.c | 5 +++--

 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/pcs/pcs-mtk-lynxi.c +3 -2
index 7de804535229..ed91cd7a406a 100644
@@ -93,11 +93,12 @@ static unsigned int mtk_pcs_lynxi_inband_caps(struct phylink_pcs *pcs,
 {
 	switch (interface) {
 	case PHY_INTERFACE_MODE_1000BASEX:
-	case PHY_INTERFACE_MODE_2500BASEX:
 	case PHY_INTERFACE_MODE_SGMII:
-	case PHY_INTERFACE_MODE_QSGMII:
 		return LINK_INBAND_DISABLE | LINK_INBAND_ENABLE;
 
+	case PHY_INTERFACE_MODE_2500BASEX:
+		return LINK_INBAND_DISABLE;
+
 	default:
 		return 0;
 	}
Signature · 1 line
2.47.1
#1 lore raw
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Thu, 2 Jan 2025 12:41:21 +0000 you wrote:

Neither does the LynxI PCS support QSGMII, nor is in-band-status supported in 2500Base-X mode. Fix the pcs_inband_caps() method accordingly.

Fixes 520d29bdda86 ("net: pcs: pcs-mtk-lynxi: implement pcs_inband_caps() method")

---
drivers/net/pcs/pcs-mtk-lynxi.c | 5 +++--

 1 file changed, 3 insertions(+), 2 deletions(-)

Here is the summary with links:
- [net-next] net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities

    https://git.kernel.org/netdev/net-next/c/a003c38d9bbb

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html