perf top: Don't complain about lack of vmlinux when not resolving some kernel samples
Arnaldo Carvalho de Melo
maintainerPATCH 1/1 perf top: Don't complain about lack of vmlinux when not resolving some kernel samples
Recently we got a case where a kernel sample wasn't being resolved due to a bug that was not setting the end address on kernel functions implemented in assembly (see Link: tag), and then those were not being found by machine__resolve() -> map__find_symbol().
So we ended up with:
# perf top --stdio PerfTop: 0 irqs/s kernel: 0% exact: 0% lost: 0/0 drop: 0/0 [cycles/P] -----------------------------------------------------------------------
Warning:
A vmlinux file was not found.
Kernel samples will not be resolved.
^Z
[1]+ Stopped perf top --stdio
#
But then resolving all other kernel symbols.
So just fixup the logic to only print that warning when there are no symbols in the kernel map.
--- tools/perf/builtin-top.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-top.c +1 -1
@@ -809,7 +809,7 @@ static void perf_event__process_sample(const struct perf_tool *tool,* invalid --vmlinux ;-) */ if (!machine->kptr_restrict_warned && !top->vmlinux_warned && -__map__is_kernel (al.map) &&map__has_symbols (al.map)) { +__map__is_kernel (al.map) && !map__has_symbols (al.map)) {if (symbol_conf.vmlinux_name) {char serr[256 ];
Signature · 1 line
2.47.0
Hi Arnaldo,
Quoted 23 lines · Arnaldo Carvalho de Melo
Recently we got a case where a kernel sample wasn't being resolved due to a bug that was not setting the end address on kernel functions implemented in assembly (see Link: tag), and then those were not being found by
machine__resolve()->map__find_symbol().So we ended up with:
# perf top --stdio PerfTop: 0 irqs/s kernel: 0% exact: 0% lost: 0/0 drop: 0/0 [cycles/P] -----------------------------------------------------------------------Warning:
A vmlinux file was not found.
Kernel samples will not be resolved.
^Z
[1]+ Stopped perf top --stdio
#But then resolving all other kernel symbols.
So just fixup the logic to only print that warning when there are no symbols in the kernel map.
Quoted 8 lines
Cc Adrian Hunter <[email protected]>Cc Ian Rogers <[email protected]>Cc Christophe Leroy <[email protected]>Cc James Clark <[email protected]>Cc Jiri Olsa <[email protected]>Cc Kan Liang <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Looks like an old bug since d88205db9caa0e9d ("perf dso: Add dso__has_symbols() method"). :)
Thanks,
Namhyung
Quoted 20 lines
--- tools/perf/builtin-top.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/builtin-top.c +1
-1@@ -809,7 +809,7 @@ static void perf_event__process_sample(const struct perf_tool *tool,* invalid --vmlinux ;-) */ if (!machine->kptr_restrict_warned && !top->vmlinux_warned && -__map__is_kernel (al.map) &&map__has_symbols (al.map)) { +__map__is_kernel (al.map) && !map__has_symbols (al.map)) {if (symbol_conf.vmlinux_name) {char serr[256 ];Signature · 1 line
2.47.0
Arnaldo Carvalho de Melo
maintainerQuoted 35 lines · Namhyung Kim
Hi Arnaldo,
Quoted 23 lines · Arnaldo Carvalho de Melo
Recently we got a case where a kernel sample wasn't being resolved due to a bug that was not setting the end address on kernel functions implemented in assembly (see Link: tag), and then those were not being found by
machine__resolve()->map__find_symbol().So we ended up with:
# perf top --stdio PerfTop: 0 irqs/s kernel: 0% exact: 0% lost: 0/0 drop: 0/0 [cycles/P] -----------------------------------------------------------------------Warning:
A vmlinux file was not found.
Kernel samples will not be resolved.
^Z
[1]+ Stopped perf top --stdio
#But then resolving all other kernel symbols.
So just fixup the logic to only print that warning when there are no symbols in the kernel map.
Quoted 8 lines
Cc Adrian Hunter <[email protected]>Cc Ian Rogers <[email protected]>Cc Christophe Leroy <[email protected]>Cc James Clark <[email protected]>Cc Jiri Olsa <[email protected]>Cc Kan Liang <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Quoted 4 lines
Reviewed-by Namhyung Kim <[email protected]>Looks like an old bug since
d88205db9caa0e9d("perf dso: Adddso__has_symbols()method"). :)
Agreed, logic inversion, I'm adding the Fixes tag, thanks for finding it!
- Arnaldo