Disabling link power-management on Samsung SSD 870 QVO drives to make them work.
PATCH 1/1 Disabling link power-management on Samsung SSD 870 QVO drives to make them work.
Hi,
since the kernel enabled LPM by default, Samsung 870 QVO SATA SSDs don't work anymore. Disabling LPM for them solves it, please consider applying the attached patch.
I've added a new case for 870 QVO specifically as regular 870 don't have the issue.
[I'm not subscribed to the list, please CC on replies]
Regards,
Daniel
From 55e2cb12faa48cf429ad4a299ea4e4a3a9ba25f5 Mon Sep 17 00:00:00 2001
From: Daniel Baumann <[email protected]>
Date: Sat, 18 Jan 2025 06:36:43 +0100
Subject: [PATCH] Disabling link power-management on Samsung SSD 870 QVO drives
to make them work.
--- drivers/ata/libata-core.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/ata/libata-core.c +4 -0
@@ -4143,6 +4143,10 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = { {"Samsung SSD 860*" ,NULL ,ATA_QUIRK_NO_NCQ_TRIM |ATA_QUIRK_ZERO_AFTER_TRIM | ATA_QUIRK_NO_NCQ_ON_ATI }, + { "Samsung SSD 870 QVO*", NULL, ATA_QUIRK_NO_NCQ_TRIM | +ATA_QUIRK_ZERO_AFTER_TRIM | +ATA_QUIRK_NO_NCQ_ON_ATI | + ATA_QUIRK_NOLPM }, { "Samsung SSD 870*", NULL, ATA_QUIRK_NO_NCQ_TRIM |ATA_QUIRK_ZERO_AFTER_TRIM | ATA_QUIRK_NO_NCQ_ON_ATI },
Signature · 1 line
2.45.2
Niklas Cassel
maintainerHello Daniel,
Quoted 8 lines · Daniel Baumann
Hi,
since the kernel enabled LPM by default, Samsung 870 QVO SATA SSDs don't work anymore. Disabling LPM for them solves it, please consider applying the attached patch.
I've added a new case for 870 QVO specifically as regular 870 don't have the issue.
This should have been in the commit message.
Out of curiosity, did you test on regular 870, so you know they are not broken as well?
Quoted 11 lines
[I'm not subscribed to the list, please CC on replies]
Regards,
DanielFrom
55e2cb12faa48cf429ad4a299ea4e4a3a9ba25f5Mon Sep 17 00:00:00 2001
From: Daniel Baumann <[email protected]>
Date: Sat, 18 Jan 2025 06:36:43 +0100
Subject: [PATCH] Disabling link power-management on Samsung SSD 870 QVO drives
to make them work.
The subject should be something like:
ata: libata-core: Add ATA_QUIRK_NOLPM for Samsung SSD 870 QVO drives
Quoted 2 lines
Signed-off-by Daniel Baumann <[email protected]>
You probably also want to add:
Quoted 22 lines
--- drivers/ata/libata-core.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/ata/libata-core.c +4
-0@@ -4143,6 +4143,10 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = { {"Samsung SSD 860*" ,NULL ,ATA_QUIRK_NO_NCQ_TRIM |ATA_QUIRK_ZERO_AFTER_TRIM | ATA_QUIRK_NO_NCQ_ON_ATI }, + { "Samsung SSD 870 QVO*", NULL, ATA_QUIRK_NO_NCQ_TRIM | +ATA_QUIRK_ZERO_AFTER_TRIM | +ATA_QUIRK_NO_NCQ_ON_ATI | + ATA_QUIRK_NOLPM }, { "Samsung SSD 870*", NULL, ATA_QUIRK_NO_NCQ_TRIM |ATA_QUIRK_ZERO_AFTER_TRIM | ATA_QUIRK_NO_NCQ_ON_ATI },Signature · 1 line
2.45.2
Hi Niklas,
Quoted 4 lines · Niklas Cassel
Quoted 2 lines
I've added a new case for 870 QVO specifically as regular 870 don't have the issue.
This should have been in the commit message.
thanks for the pointer, I have now adjusted the commit message.
Quoted 2 lines
Out of curiosity, did you test on regular 870, so you know they are not broken as well?
we don't have many of non-QVO variants, but so far none of them has needed it. I've added that to the commit message as well.
Quoted 3 lines
You probably also want to add:
Fixes 7627a0edef54 ("ata: ahci: Drop low power policy board type")
added, thanks!
Updated patch attached.
Regards,
Daniel
From f2b44baf60d11882696a99445bf217d6ee409903 Mon Sep 17 00:00:00 2001
From: Daniel Baumann <[email protected]>
Date: Sat, 18 Jan 2025 06:36:43 +0100
Subject: [PATCH] ata: libata-core: Add ATA_QUIRK_NOLPM for Samsung SSD 870 QVO
drives
Disabling link power management on Samsung SSD 870 QVO drives to make them work again after the switch of the default LPM policy to low.
Testing so far has shown that regular Samsung SSD 870 (the non QVO variants) do not need it and work fine with the default LPM policy.
--- drivers/ata/libata-core.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/ata/libata-core.c +4 -0
@@ -4143,6 +4143,10 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = { {"Samsung SSD 860*" ,NULL ,ATA_QUIRK_NO_NCQ_TRIM |ATA_QUIRK_ZERO_AFTER_TRIM | ATA_QUIRK_NO_NCQ_ON_ATI }, + { "Samsung SSD 870 QVO*", NULL, ATA_QUIRK_NO_NCQ_TRIM | +ATA_QUIRK_ZERO_AFTER_TRIM | +ATA_QUIRK_NO_NCQ_ON_ATI | + ATA_QUIRK_NOLPM }, { "Samsung SSD 870*", NULL, ATA_QUIRK_NO_NCQ_TRIM |ATA_QUIRK_ZERO_AFTER_TRIM | ATA_QUIRK_NO_NCQ_ON_ATI },
Signature · 1 line
2.45.2
Damien Le Moal
maintainerQuoted 16 lines · Daniel Baumann
Hi Niklas,
Quoted 4 lines · Niklas Cassel
Quoted 2 lines
I've added a new case for 870 QVO specifically as regular 870 don't have the issue.
This should have been in the commit message.
thanks for the pointer, I have now adjusted the commit message.
Quoted 2 lines
Out of curiosity, did you test on regular 870, so you know they are not broken as well?
we don't have many of non-QVO variants, but so far none of them has needed it. I've added that to the commit message as well.
Quoted 7 lines
Quoted 3 lines
You probably also want to add:
Fixes 7627a0edef54 ("ata: ahci: Drop low power policy board type")added, thanks!
Updated patch attached.
For reference for future patches: please use "git send-email" to send patches. Also please make sure to version the patches (git format-patch -vX ...) and add changelog notes after the "---" at the end of the commit message and before the first line of the patch content (in your case, the line "drivers/ata/libata-core.c | 4 ++++")
Thank you.
Signature · 2 lines
Damien Le Moal Western Digital Research
Quoted 1 line · Damien Le Moal
For reference for future patches:
sorry, I wasn't aware.
I'll make sure of it for next time, thank you for the help.
Regards,
Daniel
Quoted 66 lines · Daniel Baumann
Hi Niklas,
Quoted 4 lines · Niklas Cassel
Quoted 2 lines
I've added a new case for 870 QVO specifically as regular 870 don't have the issue.
This should have been in the commit message.
thanks for the pointer, I have now adjusted the commit message.
Quoted 2 lines
Out of curiosity, did you test on regular 870, so you know they are not broken as well?
we don't have many of non-QVO variants, but so far none of them has needed it. I've added that to the commit message as well.
Quoted 3 lines
You probably also want to add:
Fixes 7627a0edef54 ("ata: ahci: Drop low power policy board type")added, thanks!
Updated patch attached.
Regards,
DanielFrom
f2b44baf60d11882696a99445bf217d6ee409903Mon Sep 17 00:00:00 2001
From: Daniel Baumann <[email protected]>
Date: Sat, 18 Jan 2025 06:36:43 +0100
Subject: [PATCH] ata: libata-core: AddATA_QUIRK_NOLPMfor Samsung SSD 870 QVO
drivesDisabling link power management on Samsung SSD 870 QVO drives to make them work again after the switch of the default LPM policy to low.
Testing so far has shown that regular Samsung SSD 870 (the non QVO variants) do not need it and work fine with the default LPM policy.
Fixes 7627a0edef54 ("ata: ahci: Drop low power policy board type")Signed-off-by Daniel Baumann <[email protected]>--- drivers/ata/libata-core.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/ata/libata-core.c +4
-0@@ -4143,6 +4143,10 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = { {"Samsung SSD 860*" ,NULL ,ATA_QUIRK_NO_NCQ_TRIM |ATA_QUIRK_ZERO_AFTER_TRIM | ATA_QUIRK_NO_NCQ_ON_ATI }, + { "Samsung SSD 870 QVO*", NULL, ATA_QUIRK_NO_NCQ_TRIM | +ATA_QUIRK_ZERO_AFTER_TRIM | +ATA_QUIRK_NO_NCQ_ON_ATI | + ATA_QUIRK_NOLPM }, { "Samsung SSD 870*", NULL, ATA_QUIRK_NO_NCQ_TRIM |ATA_QUIRK_ZERO_AFTER_TRIM | ATA_QUIRK_NO_NCQ_ON_ATI },Signature · 1 line
2.45.2
Applied to libata/linux.git (for-6.14), thanks!
[1/1] ata: libata-core: Add ATA_QUIRK_NOLPM for Samsung SSD 870 QVO drives
https://git.kernel.org/libata/linux/c/cc77e2ce
Kind regards,
Niklas