usb: typec: thunderbolt: Fix loops that iterate TYPEC_PLUG_SOP_P and TYPEC_PLUG_SOP_PP
Subsystems (3)
PATCH 1/2 usb: typec: thunderbolt: Fix loops that iterate TYPEC_PLUG_SOP_P and TYPEC_PLUG_SOP_PP
Fixes these Smatch static checker warnings:drivers/usb/typec/altmodes/thunderbolt.c:116 tbt_altmode_work() warn: why is zero skipped 'i' drivers/usb/typec/altmodes/thunderbolt.c:147 tbt_enter_modes_ordered() warn: why is zero skipped 'i' drivers/usb/typec/altmodes/thunderbolt.c:328 tbt_altmode_remove() warn: why is zero skipped 'i'
--- drivers/usb/typec/altmodes/thunderbolt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/usb/typec/altmodes/thunderbolt.c +3 -3
@@ -112,7 +112,7 @@ static void tbt_altmode_work(struct work_struct *work)return ; disable_plugs: -for (int i =TYPEC_PLUG_SOP_PP ; i >0 ; --i) { +for (int i =TYPEC_PLUG_SOP_PP ; i >=0 ; --i) {if (tbt->plug[i])typec_altmode_put_plug (tbt->plug[i]);
@@ -143,7 +143,7 @@ static int tbt_enter_modes_ordered(struct typec_altmode *alt)if (tbt->plug[TYPEC_PLUG_SOP_P ]) { ret =typec_cable_altmode_enter (alt,TYPEC_PLUG_SOP_P ,NULL );if (ret <0 ) { -for (int i =TYPEC_PLUG_SOP_PP ; i >0 ; --i) { +for (int i =TYPEC_PLUG_SOP_PP ; i >=0 ; --i) {if (tbt->plug[i])typec_altmode_put_plug (tbt->plug[i]);
@@ -324,7 +324,7 @@ static void tbt_altmode_remove(struct typec_altmode *alt) {struct tbt_altmode *tbt =typec_altmode_get_drvdata (alt); -for (int i =TYPEC_PLUG_SOP_PP ; i >0 ; --i) { +for (int i =TYPEC_PLUG_SOP_PP ; i >=0 ; --i) {if (tbt->plug[i])typec_altmode_put_plug (tbt->plug[i]); }
Signature · 1 line
2.48.1.262.g85cc9f2d1e-goog
Quoted 9 lines · Benson Leung
Fixes these Smatch static checker warnings:
drivers/usb/typec/altmodes/thunderbolt.c:116tbt_altmode_work()warn: why is zero skipped 'i'drivers/usb/typec/altmodes/thunderbolt.c:147tbt_enter_modes_ordered()warn: why is zero skipped 'i'drivers/usb/typec/altmodes/thunderbolt.c:328tbt_altmode_remove()warn: why is zero skipped 'i'Fixes 100e25738659 ("usb: typec: Add driver for Thunderbolt 3 Alternate Mode")Signed-off-by Benson Leung <[email protected]>Reported-by Dan Carpenter <[email protected]>
Quoted 37 lines
--- drivers/usb/typec/altmodes/thunderbolt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/usb/typec/altmodes/thunderbolt.c +3
-3@@ -112,7 +112,7 @@ static void tbt_altmode_work(struct work_struct *work)return ; disable_plugs: -for (int i =TYPEC_PLUG_SOP_PP ; i >0 ; --i) { +for (int i =TYPEC_PLUG_SOP_PP ; i >=0 ; --i) {if (tbt->plug[i])typec_altmode_put_plug (tbt->plug[i]);@@ -143,7 +143,7 @@ static int tbt_enter_modes_ordered(struct typec_altmode *alt)if (tbt->plug[TYPEC_PLUG_SOP_P ]) { ret =typec_cable_altmode_enter (alt,TYPEC_PLUG_SOP_P ,NULL );if (ret <0 ) { -for (int i =TYPEC_PLUG_SOP_PP ; i >0 ; --i) { +for (int i =TYPEC_PLUG_SOP_PP ; i >=0 ; --i) {if (tbt->plug[i])typec_altmode_put_plug (tbt->plug[i]);@@ -324,7 +324,7 @@ static void tbt_altmode_remove(struct typec_altmode *alt) {struct tbt_altmode *tbt =typec_altmode_get_drvdata (alt); -for (int i =TYPEC_PLUG_SOP_PP ; i >0 ; --i) { +for (int i =TYPEC_PLUG_SOP_PP ; i >=0 ; --i) {if (tbt->plug[i])typec_altmode_put_plug (tbt->plug[i]); }Signature · 1 line
2.48.1.262.g85cc9f2d1e-goog
Signature · 1 line
heikki
Greg KH
maintainerQuoted 5 lines · Benson Leung
Fixes these Smatch static checker warnings:
drivers/usb/typec/altmodes/thunderbolt.c:116tbt_altmode_work()warn: why is zero skipped 'i'drivers/usb/typec/altmodes/thunderbolt.c:147tbt_enter_modes_ordered()warn: why is zero skipped 'i'drivers/usb/typec/altmodes/thunderbolt.c:328tbt_altmode_remove()warn: why is zero skipped 'i'
Quoted 7 lines
Fixes 100e25738659 ("usb: typec: Add driver for Thunderbolt 3 Alternate Mode")Signed-off-by Benson Leung <[email protected]>Reported-by Dan Carpenter <[email protected]>--- drivers/usb/typec/altmodes/thunderbolt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Please always use 'git send-email' or if not, manually thread your patches so they all show up together as a series. These are both individual and as such, don't play nice with tools.
I'll try to manually handle them, but you owe me...
thanks,
greg k-h
Hi Greg,
Quoted 14 lines · Greg KH
Quoted 5 lines · Benson Leung
Fixes these Smatch static checker warnings:
drivers/usb/typec/altmodes/thunderbolt.c:116tbt_altmode_work()warn: why is zero skipped 'i'drivers/usb/typec/altmodes/thunderbolt.c:147tbt_enter_modes_ordered()warn: why is zero skipped 'i'drivers/usb/typec/altmodes/thunderbolt.c:328tbt_altmode_remove()warn: why is zero skipped 'i'Quoted 7 lines
Fixes 100e25738659 ("usb: typec: Add driver for Thunderbolt 3 Alternate Mode")Signed-off-by Benson Leung <[email protected]>Reported-by Dan Carpenter <[email protected]>--- drivers/usb/typec/altmodes/thunderbolt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 3 lines
Please always use 'git send-email' or if not, manually thread your patches so they all show up together as a series. These are both individual and as such, don't play nice with tools.
Sorry about that. I still need to set up my git-send-email workflow on this new cloud workstation, and I'll get that rectified for next time.
Quoted 2 lines
I'll try to manually handle them, but you owe me...
Thanks! I'll definitely owe you one.
Quoted 4 lines
thanks,
greg k-h
Benson