selftests: livepatch: handle PRINTK_CALLER in check_result()
Subsystems (2)
PATCH v2 1/1 selftests: livepatch: handle PRINTK_CALLER in check_result()
Some arch configs (like ppc64) enable CONFIG_PRINTK_CALLER, which adds the caller id as part of the dmesg. With recent util-linux's update 467a5b3192f16 ('dmesg: add caller_id support') the standard "dmesg" has been enhanced to print PRINTK_CALLER fields.
Due to this, even though the expected vs observed are same, end testcase results are failed.
-% insmod test_modules/test_klp_livepatch.ko
-livepatch: enabling patch 'test_klp_livepatch' -livepatch: 'test_klp_livepatch': initializing patching transition -livepatch: 'test_klp_livepatch': starting patching transition -livepatch: 'test_klp_livepatch': completing patching transition -livepatch: 'test_klp_livepatch': patching complete
-% echo 0 > /sys/kernel/livepatch/test_klp_livepatch/enabled -livepatch: 'test_klp_livepatch': initializing unpatching transition -livepatch: 'test_klp_livepatch': starting unpatching transition -livepatch: 'test_klp_livepatch': completing unpatching transition -livepatch: 'test_klp_livepatch': unpatching complete
-% rmmod test_klp_livepatch
+[ T3659] % insmod test_modules/test_klp_livepatch.ko +[ T3682] livepatch: enabling patch 'test_klp_livepatch' +[ T3682] livepatch: 'test_klp_livepatch': initializing patching transition +[ T3682] livepatch: 'test_klp_livepatch': starting patching transition +[ T826] livepatch: 'test_klp_livepatch': completing patching transition +[ T826] livepatch: 'test_klp_livepatch': patching complete +[ T3659] % echo 0 > /sys/kernel/livepatch/test_klp_livepatch/enabled +[ T3659] livepatch: 'test_klp_livepatch': initializing unpatching transition +[ T3659] livepatch: 'test_klp_livepatch': starting unpatching transition
+[ T789] livepatch: 'test_klp_livepatch': completing unpatching transition
+[ T789] livepatch: 'test_klp_livepatch': unpatching complete
+[ T3659] % rmmod test_klp_livepatch
ERROR: livepatch kselftest(s) failed
not ok 1 selftests: livepatch: test-livepatch.sh # exit=1
Currently the check_result() handles the "[time]" removal from the dmesg. Enhance the check to also handle removal of "[Thread Id]" or "[CPU Id]".
---
Changelog v1:
- Modified commit message to include util-linux commit that updated dmesg to support printing of PRINTK_CALLER fields.
- Updated the check to include "CPU Id" along with "Thread Id"
tools/testing/selftests/livepatch/functions.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/testing/selftests/livepatch/functions.sh +2 -1
@@ -306,7 +306,8 @@ function check_result { result=$(dmesg | awk -v last_dmesg="$LAST_DMESG" 'p; $0 == last_dmesg { p=1 }' | \ grep -e 'livepatch:' -e 'test_klp' | \ grep -v '\(tainting\|taints\) kernel' | \ - sed 's/^\[[ 0-9.]*\] //') + sed 's/^\[[ 0-9.]*\] //' | \ + sed 's/^\[[ ]*[CT][0-9]*\] //') if [[ "$expect" == "$result" ]] ; then echo "ok"
Signature · 1 line
2.47.0
Quoted 33 lines · Madhavan Srinivasan
Some arch configs (like ppc64) enable
CONFIG_PRINTK_CALLER, which adds the caller id as part of the dmesg. With recent util-linux's update467a5b3192f16('dmesg: addcaller_idsupport') the standard "dmesg" has been enhanced to printPRINTK_CALLERfields.Due to this, even though the expected vs observed are same, end testcase results are failed.
-% insmod
test_modules/test_klp_livepatch.ko
-livepatch: enabling patch 'test_klp_livepatch' -livepatch: 'test_klp_livepatch': initializing patching transition -livepatch: 'test_klp_livepatch': starting patching transition -livepatch: 'test_klp_livepatch': completing patching transition -livepatch: 'test_klp_livepatch': patching complete
-% echo 0 >/sys/kernel/livepatch/test_klp_livepatch/enabled-livepatch: 'test_klp_livepatch': initializing unpatching transition -livepatch: 'test_klp_livepatch': starting unpatching transition -livepatch: 'test_klp_livepatch': completing unpatching transition -livepatch: 'test_klp_livepatch': unpatching complete
-% rmmodtest_klp_livepatch+[ T3659] % insmod test_modules/test_klp_livepatch.ko +[ T3682] livepatch: enabling patch 'test_klp_livepatch' +[ T3682] livepatch: 'test_klp_livepatch': initializing patching transition +[ T3682] livepatch: 'test_klp_livepatch': starting patching transition +[ T826] livepatch: 'test_klp_livepatch': completing patching transition +[ T826] livepatch: 'test_klp_livepatch': patching complete +[ T3659] % echo 0 > /sys/kernel/livepatch/test_klp_livepatch/enabled +[ T3659] livepatch: 'test_klp_livepatch': initializing unpatching transition +[ T3659] livepatch: 'test_klp_livepatch': starting unpatching transition+[ T789] livepatch: '
test_klp_livepatch': completing unpatching transition
+[ T789] livepatch: 'test_klp_livepatch': unpatching complete
+[ T3659] % rmmodtest_klp_livepatch
Quoted 8 lines
ERROR: livepatch kselftest(s) failed
not ok 1 selftests: livepatch:test-livepatch.sh# exit=1Currently the
check_result()handles the "[time]" removal from the dmesg. Enhance the check to also handle removal of "[Thread Id]" or "[CPU Id]".Signed-off-by Madhavan Srinivasan <[email protected]>
M
Quoted 33 lines · Madhavan Srinivasan
Some arch configs (like ppc64) enable
CONFIG_PRINTK_CALLER, which adds the caller id as part of the dmesg. With recent util-linux's update467a5b3192f16('dmesg: addcaller_idsupport') the standard "dmesg" has been enhanced to printPRINTK_CALLERfields.Due to this, even though the expected vs observed are same, end testcase results are failed.
-% insmod
test_modules/test_klp_livepatch.ko
-livepatch: enabling patch 'test_klp_livepatch' -livepatch: 'test_klp_livepatch': initializing patching transition -livepatch: 'test_klp_livepatch': starting patching transition -livepatch: 'test_klp_livepatch': completing patching transition -livepatch: 'test_klp_livepatch': patching complete
-% echo 0 >/sys/kernel/livepatch/test_klp_livepatch/enabled-livepatch: 'test_klp_livepatch': initializing unpatching transition -livepatch: 'test_klp_livepatch': starting unpatching transition -livepatch: 'test_klp_livepatch': completing unpatching transition -livepatch: 'test_klp_livepatch': unpatching complete
-% rmmodtest_klp_livepatch+[ T3659] % insmod test_modules/test_klp_livepatch.ko +[ T3682] livepatch: enabling patch 'test_klp_livepatch' +[ T3682] livepatch: 'test_klp_livepatch': initializing patching transition +[ T3682] livepatch: 'test_klp_livepatch': starting patching transition +[ T826] livepatch: 'test_klp_livepatch': completing patching transition +[ T826] livepatch: 'test_klp_livepatch': patching complete +[ T3659] % echo 0 > /sys/kernel/livepatch/test_klp_livepatch/enabled +[ T3659] livepatch: 'test_klp_livepatch': initializing unpatching transition +[ T3659] livepatch: 'test_klp_livepatch': starting unpatching transition+[ T789] livepatch: '
test_klp_livepatch': completing unpatching transition
+[ T789] livepatch: 'test_klp_livepatch': unpatching complete
+[ T3659] % rmmodtest_klp_livepatch
Quoted 8 lines
ERROR: livepatch kselftest(s) failed
not ok 1 selftests: livepatch:test-livepatch.sh# exit=1Currently the
check_result()handles the "[time]" removal from the dmesg. Enhance the check to also handle removal of "[Thread Id]" or "[CPU Id]".Signed-off-by Madhavan Srinivasan <[email protected]>
Looks and works well:
Best Regards,
Petr
PS: The merge window for 6.14 has started yesterday. Every change
should spend at least few days in linux-next and I have already sent a pull request so it is kind of late for 6.14.
If there is a demand, I could still queue it for 6.14 in the 2nd half of the merge window or for rc2. There is only small group of people interested into the livepatch selftests anyway.
Quoted 51 lines · Petr Mladek
Quoted 33 lines · Madhavan Srinivasan
Some arch configs (like ppc64) enable
CONFIG_PRINTK_CALLER, which adds the caller id as part of the dmesg. With recent util-linux's update467a5b3192f16('dmesg: addcaller_idsupport') the standard "dmesg" has been enhanced to printPRINTK_CALLERfields.Due to this, even though the expected vs observed are same, end testcase results are failed.
-% insmod
test_modules/test_klp_livepatch.ko
-livepatch: enabling patch 'test_klp_livepatch' -livepatch: 'test_klp_livepatch': initializing patching transition -livepatch: 'test_klp_livepatch': starting patching transition -livepatch: 'test_klp_livepatch': completing patching transition -livepatch: 'test_klp_livepatch': patching complete
-% echo 0 >/sys/kernel/livepatch/test_klp_livepatch/enabled-livepatch: 'test_klp_livepatch': initializing unpatching transition -livepatch: 'test_klp_livepatch': starting unpatching transition -livepatch: 'test_klp_livepatch': completing unpatching transition -livepatch: 'test_klp_livepatch': unpatching complete
-% rmmodtest_klp_livepatch+[ T3659] % insmod test_modules/test_klp_livepatch.ko +[ T3682] livepatch: enabling patch 'test_klp_livepatch' +[ T3682] livepatch: 'test_klp_livepatch': initializing patching transition +[ T3682] livepatch: 'test_klp_livepatch': starting patching transition +[ T826] livepatch: 'test_klp_livepatch': completing patching transition +[ T826] livepatch: 'test_klp_livepatch': patching complete +[ T3659] % echo 0 > /sys/kernel/livepatch/test_klp_livepatch/enabled +[ T3659] livepatch: 'test_klp_livepatch': initializing unpatching transition +[ T3659] livepatch: 'test_klp_livepatch': starting unpatching transition+[ T789] livepatch: '
test_klp_livepatch': completing unpatching transition
+[ T789] livepatch: 'test_klp_livepatch': unpatching complete
+[ T3659] % rmmodtest_klp_livepatchQuoted 8 lines
ERROR: livepatch kselftest(s) failed
not ok 1 selftests: livepatch:test-livepatch.sh# exit=1Currently the
check_result()handles the "[time]" removal from the dmesg. Enhance the check to also handle removal of "[Thread Id]" or "[CPU Id]".Signed-off-by Madhavan Srinivasan <[email protected]>Looks and works well:
Reviewed-by Petr Mladek <[email protected]>Tested-by Petr Mladek <[email protected]>Best Regards,
Petr
Quoted 7 lines
PS: The merge window for 6.14 has started yesterday. Every change
should spend at least few days in linux-next and I have already sent a pull request so it is kind of late for 6.14.If there is a demand, I could still queue it for 6.14 in the 2nd half of the merge window or for rc2. There is only small group of people interested into the livepatch selftests anyway.
Thanks. No urgency from my end.
Petr Mladek
maintainerQuoted 33 lines · Madhavan Srinivasan
Some arch configs (like ppc64) enable
CONFIG_PRINTK_CALLER, which adds the caller id as part of the dmesg. With recent util-linux's update467a5b3192f16('dmesg: addcaller_idsupport') the standard "dmesg" has been enhanced to printPRINTK_CALLERfields.Due to this, even though the expected vs observed are same, end testcase results are failed.
-% insmod
test_modules/test_klp_livepatch.ko
-livepatch: enabling patch 'test_klp_livepatch' -livepatch: 'test_klp_livepatch': initializing patching transition -livepatch: 'test_klp_livepatch': starting patching transition -livepatch: 'test_klp_livepatch': completing patching transition -livepatch: 'test_klp_livepatch': patching complete
-% echo 0 >/sys/kernel/livepatch/test_klp_livepatch/enabled-livepatch: 'test_klp_livepatch': initializing unpatching transition -livepatch: 'test_klp_livepatch': starting unpatching transition -livepatch: 'test_klp_livepatch': completing unpatching transition -livepatch: 'test_klp_livepatch': unpatching complete
-% rmmodtest_klp_livepatch+[ T3659] % insmod test_modules/test_klp_livepatch.ko +[ T3682] livepatch: enabling patch 'test_klp_livepatch' +[ T3682] livepatch: 'test_klp_livepatch': initializing patching transition +[ T3682] livepatch: 'test_klp_livepatch': starting patching transition +[ T826] livepatch: 'test_klp_livepatch': completing patching transition +[ T826] livepatch: 'test_klp_livepatch': patching complete +[ T3659] % echo 0 > /sys/kernel/livepatch/test_klp_livepatch/enabled +[ T3659] livepatch: 'test_klp_livepatch': initializing unpatching transition +[ T3659] livepatch: 'test_klp_livepatch': starting unpatching transition+[ T789] livepatch: '
test_klp_livepatch': completing unpatching transition
+[ T789] livepatch: 'test_klp_livepatch': unpatching complete
+[ T3659] % rmmodtest_klp_livepatch
Quoted 8 lines
ERROR: livepatch kselftest(s) failed
not ok 1 selftests: livepatch:test-livepatch.sh# exit=1Currently the
check_result()handles the "[time]" removal from the dmesg. Enhance the check to also handle removal of "[Thread Id]" or "[CPU Id]".Signed-off-by Madhavan Srinivasan <[email protected]>
JFYI, the patch has been committed into livepatch.git, branch for-6.14/selftests-dmesg.
I am going to create a pull request for Linus' master by the end of the week or next week.
Best Regards,
Petr