Skip to contentSkip to conversation

PCI: tegra194: Add support for PCIe RC & EP in Tegra234 Platforms

PATCH In review Vidya Sagar 5 participants 15 messages Jan 28, 2025 – Apr 16, 2025 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: tegra194: Add support for PCIe RC & EP in Tegra234 Platforms

Add PCIe RC & EP support for Tegra234 Platforms.

---
 drivers/pci/controller/dwc/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/controller/dwc/Kconfig +2 -2
index b6d6778b0698..6dd232cf8064 100644
@@ -205,7 +205,7 @@ config PCIE_TEGRA194
 
 config PCIE_TEGRA194_HOST
 	tristate "NVIDIA Tegra194 (and later) PCIe controller (host mode)"
-	depends on ARCH_TEGRA_194_SOC || COMPILE_TEST
+	depends on ARCH_TEGRA_194_SOC || ARCH_TEGRA_234_SOC || COMPILE_TEST
 	depends on PCI_MSI
 	select PCIE_DW_HOST
 	select PHY_TEGRA194_P2U
@@ -220,7 +220,7 @@ config PCIE_TEGRA194_HOST
 
 config PCIE_TEGRA194_EP
 	tristate "NVIDIA Tegra194 (and later) PCIe controller (endpoint mode)"
-	depends on ARCH_TEGRA_194_SOC || COMPILE_TEST
+	depends on ARCH_TEGRA_194_SOC || ARCH_TEGRA_234_SOC || COMPILE_TEST
 	depends on PCI_ENDPOINT
 	select PCIE_DW_EP
 	select PHY_TEGRA194_P2U
Signature · 1 line
2.25.1
#1 lore raw

Hello Vidya,

Quoted 1 line · Vidya Sagar

Add PCIe RC & EP support for Tegra234 Platforms.

The commit log does leave quite a few questions unanswered.

Since you are just updating the Kconfig and nothing else:
Does the DT binding already have support for the Tegra234 SoC? Does the driver already have support for the Tegra234 SoC?

Looking at the DT binding and driver, the answer to both questions is yes. (This should have been in the commit message IMO.)

But that leads me to the question, since there is support for Tegra234 SoC in the driver, does this means that this fixes a regression, e.g. the Kconfig ARCH_TEGRA_234_SOC was added after the driver support in this driver was added. In this case, you should have a Fixes: tag that points to the commit that added ARCH_TEGRA_234_SOC.

Or has the the driver support for Tegra234 been "dead-code" since it was originally added? (Because without this patch, no one can have tested it, at least not without COMPILE_TEST.)
In this case, you should add:

Fixes a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")

Kind regards,
Niklas

#2 lore raw
Quoted 21 lines · Niklas Cassel

Hello Vidya,

Quoted 1 line · Vidya Sagar

Add PCIe RC & EP support for Tegra234 Platforms.

The commit log does leave quite a few questions unanswered.

Since you are just updating the Kconfig and nothing else:
Does the DT binding already have support for the Tegra234 SoC? Does the driver already have support for the Tegra234 SoC?

Looking at the DT binding and driver, the answer to both questions is yes. (This should have been in the commit message IMO.)

But that leads me to the question, since there is support for Tegra234 SoC in the driver, does this means that this fixes a regression, e.g. the Kconfig ARCH_TEGRA_234_SOC was added after the driver support in this driver was added. In this case, you should have a Fixes: tag that points to the commit that added ARCH_TEGRA_234_SOC.

Quoted 6 lines

Or has the the driver support for Tegra234 been "dead-code" since it was originally added? (Because without this patch, no one can have tested it, at least not without COMPILE_TEST.)
In this case, you should add:

Fixes a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")

TBH, I don't like muddling with Kconfig like this. Ideally, the driver should just depend on ARCH_TEGRA || COMPILE_TEST and the driver should be selected by the relevant defconfig.

And this is what all other rest of the platforms are doing. Why should Nvidia be different? It makes me feel that this Kconfig dependency is used as a workaround for defconfig updates.

- Mani

Signature · 1 line
மணிவண்ணன் சதாசிவம்
#3 lore raw
Quoted 29 lines · Manivannan Sadhasivam
Quoted 21 lines · Niklas Cassel

Hello Vidya,

Quoted 1 line · Vidya Sagar

Add PCIe RC & EP support for Tegra234 Platforms.

The commit log does leave quite a few questions unanswered.

Since you are just updating the Kconfig and nothing else:
Does the DT binding already have support for the Tegra234 SoC? Does the driver already have support for the Tegra234 SoC?

Looking at the DT binding and driver, the answer to both questions is yes. (This should have been in the commit message IMO.)

But that leads me to the question, since there is support for Tegra234 SoC in the driver, does this means that this fixes a regression, e.g. the Kconfig ARCH_TEGRA_234_SOC was added after the driver support in this driver was added. In this case, you should have a Fixes: tag that points to the commit that added ARCH_TEGRA_234_SOC.

Quoted 6 lines

Or has the the driver support for Tegra234 been "dead-code" since it was originally added? (Because without this patch, no one can have tested it, at least not without COMPILE_TEST.)
In this case, you should add:

Fixes a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")
Quoted 3 lines

TBH, I don't like muddling with Kconfig like this. Ideally, the driver should just depend on ARCH_TEGRA || COMPILE_TEST and the driver should be selected by the relevant defconfig.

ARCH_TEGRA is a symbol that exists both on 32-bit and 64-bit ARM. This driver is completely useless on 32-bit ARM and only used on a very small subset of 64-bit ARM devices. It doesn't make sense to be able to enable this if you want to build a kernel for say Tegra210.

The relevant defconfig in this case would be the arm64 defconfig, which isn't very authoritative.

Quoted 3 lines

And this is what all other rest of the platforms are doing. Why should Nvidia be different? It makes me feel that this Kconfig dependency is used as a workaround for defconfig updates.

Well, it's certainly not used as a workaround for defconfig updates because the change itself doesn't enable this symbol. You'd still need a defconfig change to do that.

Also, we do this primarily because we've always done things this way on Tegra. As I said, for a lot of drivers it doesn't make sense to include them in a 32-bit build or 64-bit build because the hardware simply doesn't exist. Having per-SoC generation Kconfig symbols allows this to be modelled more accurately and if desired to build compact images.

Thierry

#4 lore raw
Quoted 30 lines · Thierry Reding
Quoted 29 lines · Manivannan Sadhasivam
Quoted 27 lines · Niklas Cassel

Hello Vidya,

Quoted 1 line · Vidya Sagar

Add PCIe RC & EP support for Tegra234 Platforms.

The commit log does leave quite a few questions unanswered.

Since you are just updating the Kconfig and nothing else:
Does the DT binding already have support for the Tegra234 SoC? Does the driver already have support for the Tegra234 SoC?

Looking at the DT binding and driver, the answer to both questions is yes. (This should have been in the commit message IMO.)

But that leads me to the question, since there is support for Tegra234 SoC in the driver, does this means that this fixes a regression, e.g. the Kconfig ARCH_TEGRA_234_SOC was added after the driver support in this driver was added. In this case, you should have a Fixes: tag that points to the commit that added ARCH_TEGRA_234_SOC.

Or has the the driver support for Tegra234 been "dead-code" since it was originally added? (Because without this patch, no one can have tested it, at least not without COMPILE_TEST.)
In this case, you should add:

Fixes a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")
Quoted 8 lines
Quoted 3 lines

TBH, I don't like muddling with Kconfig like this. Ideally, the driver should just depend on ARCH_TEGRA || COMPILE_TEST and the driver should be selected by the relevant defconfig.

ARCH_TEGRA is a symbol that exists both on 32-bit and 64-bit ARM. This driver is completely useless on 32-bit ARM and only used on a very small subset of 64-bit ARM devices. It doesn't make sense to be able to enable this if you want to build a kernel for say Tegra210.

Well, if you look in drivers/pci/controller/dwc/Kconfig there are quite a few drivers that does:

depends on ARM64 or ARM and then a ARCH_ something.

I don't see why you can't do
depends on (ARCH_TEGRA && ARM64) || COMPILE_TEST

Kind regards,
Niklas

#5 lore raw
In reply to Thierry Reding
Quoted 30 lines · Thierry Reding
Quoted 29 lines · Manivannan Sadhasivam
Quoted 27 lines · Niklas Cassel

Hello Vidya,

Quoted 1 line · Vidya Sagar

Add PCIe RC & EP support for Tegra234 Platforms.

The commit log does leave quite a few questions unanswered.

Since you are just updating the Kconfig and nothing else:
Does the DT binding already have support for the Tegra234 SoC? Does the driver already have support for the Tegra234 SoC?

Looking at the DT binding and driver, the answer to both questions is yes. (This should have been in the commit message IMO.)

But that leads me to the question, since there is support for Tegra234 SoC in the driver, does this means that this fixes a regression, e.g. the Kconfig ARCH_TEGRA_234_SOC was added after the driver support in this driver was added. In this case, you should have a Fixes: tag that points to the commit that added ARCH_TEGRA_234_SOC.

Or has the the driver support for Tegra234 been "dead-code" since it was originally added? (Because without this patch, no one can have tested it, at least not without COMPILE_TEST.)
In this case, you should add:

Fixes a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")
Quoted 9 lines
Quoted 3 lines

TBH, I don't like muddling with Kconfig like this. Ideally, the driver should just depend on ARCH_TEGRA || COMPILE_TEST and the driver should be selected by the relevant defconfig.

ARCH_TEGRA is a symbol that exists both on 32-bit and 64-bit ARM. This driver is completely useless on 32-bit ARM and only used on a very small subset of 64-bit ARM devices. It doesn't make sense to be able to enable this if you want to build a kernel for say Tegra210.

As Niklas pointed out, why can't you have (ARCH_TEGRA && ARM) in Kconfig?

Quoted 11 lines

The relevant defconfig in this case would be the arm64 defconfig, which isn't very authoritative.

Quoted 3 lines

And this is what all other rest of the platforms are doing. Why should Nvidia be different? It makes me feel that this Kconfig dependency is used as a workaround for defconfig updates.

Well, it's certainly not used as a workaround for defconfig updates because the change itself doesn't enable this symbol. You'd still need a defconfig change to do that.

Quoted 6 lines

Also, we do this primarily because we've always done things this way on Tegra. As I said, for a lot of drivers it doesn't make sense to include them in a 32-bit build or 64-bit build because the hardware simply doesn't exist. Having per-SoC generation Kconfig symbols allows this to be modelled more accurately and if desired to build compact images.

Well, certainly other SoC architectures are not following what Tegra does and I don't see why Tegra should be different than others.

- Mani

Signature · 1 line
மணிவண்ணன் சதாசிவம்
#6 lore raw
In reply to Niklas Cassel
Quoted 21 lines · Niklas Cassel

Hello Vidya,

Quoted 1 line · Vidya Sagar

Add PCIe RC & EP support for Tegra234 Platforms.

The commit log does leave quite a few questions unanswered.

Since you are just updating the Kconfig and nothing else:
Does the DT binding already have support for the Tegra234 SoC? Does the driver already have support for the Tegra234 SoC?

Looking at the DT binding and driver, the answer to both questions is yes. (This should have been in the commit message IMO.)

But that leads me to the question, since there is support for Tegra234 SoC in the driver, does this means that this fixes a regression, e.g. the Kconfig ARCH_TEGRA_234_SOC was added after the driver support in this driver was added. In this case, you should have a Fixes: tag that points to the commit that added ARCH_TEGRA_234_SOC.

Quoted 5 lines

Or has the the driver support for Tegra234 been "dead-code" since it was originally added? (Because without this patch, no one can have tested it, at least not without COMPILE_TEST.)
In this case, you should add:

Fixes a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")

Typically we build the default configuration with some custom options (like everyone else, I assume) and usually in those configurations both Tegra194 and Tegra234 support will be enabled, so the code ends up enabled in most cases. I guess the commit message doesn't do a very good job of making this clear. Really what this commit does is enable the PCI controller driver for Tegra234-only configurations (i.e. no other Tegra generations are built-in).

Not sure about the Fixes: tag since this is fairly harmless. Worst case you'll need to enable Tegra194 support along with Tegra234 in order to be able to enable this driver, but that's almost always the case anyway.

Thierry

#7 lore raw
Quoted 28 lines · Thierry Reding
Quoted 21 lines · Niklas Cassel

Hello Vidya,

Quoted 1 line · Vidya Sagar

Add PCIe RC & EP support for Tegra234 Platforms.

The commit log does leave quite a few questions unanswered.

Since you are just updating the Kconfig and nothing else:
Does the DT binding already have support for the Tegra234 SoC? Does the driver already have support for the Tegra234 SoC?

Looking at the DT binding and driver, the answer to both questions is yes. (This should have been in the commit message IMO.)

But that leads me to the question, since there is support for Tegra234 SoC in the driver, does this means that this fixes a regression, e.g. the Kconfig ARCH_TEGRA_234_SOC was added after the driver support in this driver was added. In this case, you should have a Fixes: tag that points to the commit that added ARCH_TEGRA_234_SOC.

Quoted 5 lines

Or has the the driver support for Tegra234 been "dead-code" since it was originally added? (Because without this patch, no one can have tested it, at least not without COMPILE_TEST.)
In this case, you should add:

Fixes a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")
Quoted 7 lines

Typically we build the default configuration with some custom options (like everyone else, I assume) and usually in those configurations both Tegra194 and Tegra234 support will be enabled, so the code ends up enabled in most cases. I guess the commit message doesn't do a very good job of making this clear. Really what this commit does is enable the PCI controller driver for Tegra234-only configurations (i.e. no other Tegra generations are built-in).

Ok, fine by me.

Quoted 4 lines

Not sure about the Fixes: tag since this is fairly harmless. Worst case you'll need to enable Tegra194 support along with Tegra234 in order to be able to enable this driver, but that's almost always the case anyway.

I think it is quite a fundamental mistake that the commit that added support for Tegra234, actually requires you to enabled support for a completely different SoC to actually make use of that driver, so IMO the Fixes tag is absolutely warrented.

Kind regards,
Niklas

A message that is not in the archive (sent off-list or not yet received): BN9PR12MB5323E59E530FA1F87DE3C7FCB8F22@BN9PR12MB5323.namprd12.prod.outlook.com

#9 lore raw
Quoted 4 lines · Vidya Sagar

Thanks Niklas for the review.
I'll rewrite the commit message add the following line

Fixes a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")

No, please. Try to use the generic ARCH symbol dependency as suggested.

- Mani

Quoted 43 lines

Thanks
Vidya Sagar

________________________________
From: Niklas Cassel <[email protected]>
Sent: Tuesday, January 28, 2025 17:34
To: Vidya Sagar <[email protected]>
Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; Thierry Reding <[email protected]>; Jon Hunter <[email protected]>; Krishna Thota <[email protected]>; Manikanta Maddireddy <[email protected]>; [email protected] <[email protected]>
Subject: Re: [PATCH V1] PCI: tegra194: Add support for PCIe RC & EP in Tegra234 Platforms

External email: Use caution opening links or attachments

Hello Vidya,

Quoted 1 line · Vidya Sagar

Add PCIe RC & EP support for Tegra234 Platforms.

The commit log does leave quite a few questions unanswered.

Since you are just updating the Kconfig and nothing else:
Does the DT binding already have support for the Tegra234 SoC? Does the driver already have support for the Tegra234 SoC?

Looking at the DT binding and driver, the answer to both questions is yes. (This should have been in the commit message IMO.)

But that leads me to the question, since there is support for Tegra234 SoC in the driver, does this means that this fixes a regression, e.g. the Kconfig ARCH_TEGRA_234_SOC was added after the driver support in this driver was added. In this case, you should have a Fixes: tag that points to the commit that added ARCH_TEGRA_234_SOC.

Or has the the driver support for Tegra234 been "dead-code" since it was originally added? (Because without this patch, no one can have tested it, at least not without COMPILE_TEST.)
In this case, you should add:

Fixes a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")

Kind regards,
Niklas

Signature · 1 line
மணிவண்ணன் சதாசிவம்
#10 lore raw
Quoted 18 lines

-----Original Message-----
From: [email protected] <[email protected]>
Sent: 10 February 2025 23:21
To: Vidya Sagar <[email protected]>
Cc: Niklas Cassel <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Thierry Reding <[email protected]>; Jon Hunter <[email protected]>; Krishna Thota <[email protected]>; Manikanta Maddireddy <[email protected]>; [email protected]
Subject: Re: [PATCH V1] PCI: tegra194: Add support for PCIe RC & EP in Tegra234 Platforms

External email: Use caution opening links or attachments

Quoted 7 lines
Quoted 4 lines · Vidya Sagar

Thanks Niklas for the review.
I'll rewrite the commit message add the following line

Fixes a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")

No, please. Try to use the generic ARCH symbol dependency as suggested.

We wanted to have more granularity in terms of enabling the driver for only those SoCs where the respective hardware is available. But, if the community has strong preference towards enabling the drivers at a higher level, I'll modify and send next version of the patch accordingly.

- Vidya Sagar

Quoted 60 lines

- Mani

Quoted 49 lines

Thanks
Vidya Sagar

________________________________
From: Niklas Cassel <[email protected]>
Sent: Tuesday, January 28, 2025 17:34
To: Vidya Sagar <[email protected]>
Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; Thierry Reding <[email protected]>; Jon Hunter <[email protected]>; Krishna Thota <[email protected]>; Manikanta Maddireddy <[email protected]>; [email protected] <[email protected]>
Subject: Re: [PATCH V1] PCI: tegra194: Add support for PCIe RC & EP in Tegra234 Platforms

External email: Use caution opening links or attachments

Hello Vidya,

Quoted 1 line · Vidya Sagar

Add PCIe RC & EP support for Tegra234 Platforms.

The commit log does leave quite a few questions unanswered.

Since you are just updating the Kconfig and nothing else:
Does the DT binding already have support for the Tegra234 SoC? Does the driver already have support for the Tegra234 SoC?

Looking at the DT binding and driver, the answer to both questions is yes. (This should have been in the commit message IMO.)

But that leads me to the question, since there is support for Tegra234 SoC in the driver, does this means that this fixes a regression, e.g. the Kconfig ARCH_TEGRA_234_SOC was added after the driver support in this driver was added. In this case, you should have a Fixes: tag that points to the commit that added ARCH_TEGRA_234_SOC.

Or has the the driver support for Tegra234 been "dead-code" since it was originally added? (Because without this patch, no one can have tested it, at least not without COMPILE_TEST.) In this case, you should add:

Quoted 5 lines
Fixes a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")

Kind regards,
Niklas

--
மணிவண்ணன் சதாசிவம்

#11 lore raw

PATCH v2 1/1 PCI: dwc: tegra194: Broaden architecture dependency

In reply to Vidya Sagar

Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA check, allowing the PCIe controller to be built on Tegra platforms beyond Tegra194. Additionally, ensure compatibility by requiring ARM64 or COMPILE_TEST.

---
v2:
* Addressed review comments from Niklas Cassel and Manivannan Sadhasivam

 drivers/pci/controller/dwc/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/controller/dwc/Kconfig +2 -2
index d9f0386396ed..815b6e0d6a0c 100644
@@ -226,7 +226,7 @@ config PCIE_TEGRA194
 
 config PCIE_TEGRA194_HOST
 	tristate "NVIDIA Tegra194 (and later) PCIe controller (host mode)"
-	depends on ARCH_TEGRA_194_SOC || COMPILE_TEST
+	depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST)
 	depends on PCI_MSI
 	select PCIE_DW_HOST
 	select PHY_TEGRA194_P2U
@@ -241,7 +241,7 @@ config PCIE_TEGRA194_HOST
 
 config PCIE_TEGRA194_EP
 	tristate "NVIDIA Tegra194 (and later) PCIe controller (endpoint mode)"
-	depends on ARCH_TEGRA_194_SOC || COMPILE_TEST
+	depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST)
 	depends on PCI_ENDPOINT
 	select PCIE_DW_EP
 	select PHY_TEGRA194_P2U
Signature · 1 line
2.25.1
Reviewed-by on v2 1/1
#12 lore raw

Re: [PATCH V2] PCI: dwc: tegra194: Broaden architecture dependency

Quoted 39 lines · Vidya Sagar

Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA check, allowing the PCIe controller to be built on Tegra platforms beyond Tegra194. Additionally, ensure compatibility by requiring ARM64 or COMPILE_TEST.

---
v2:
* Addressed review comments from Niklas Cassel and Manivannan Sadhasivam

 drivers/pci/controller/dwc/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/controller/dwc/Kconfig +2 -2
index d9f0386396ed..815b6e0d6a0c 100644
@@ -226,7 +226,7 @@ config PCIE_TEGRA194
 
 config PCIE_TEGRA194_HOST
 	tristate "NVIDIA Tegra194 (and later) PCIe controller (host mode)"
-	depends on ARCH_TEGRA_194_SOC || COMPILE_TEST
+	depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST)
 	depends on PCI_MSI
 	select PCIE_DW_HOST
 	select PHY_TEGRA194_P2U
@@ -241,7 +241,7 @@ config PCIE_TEGRA194_HOST
 
 config PCIE_TEGRA194_EP
 	tristate "NVIDIA Tegra194 (and later) PCIe controller (endpoint mode)"
-	depends on ARCH_TEGRA_194_SOC || COMPILE_TEST
+	depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST)
 	depends on PCI_ENDPOINT
 	select PCIE_DW_EP
 	select PHY_TEGRA194_P2U
Signature · 1 line
2.25.1
#13 lore raw

Re: [PATCH V2] PCI: dwc: tegra194: Broaden architecture dependency

In reply to Vidya Sagar
kernel test robot noticed the following build warnings:

Hi Vidya,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.15-rc2 next-20250416] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vidya-Sagar/PCI-dwc-tegra194-Broaden-architecture-dependency/20250411-035134
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20250410194552.944818-1-vidyas%40nvidia.com
patch subject: [PATCH V2] PCI: dwc: tegra194: Broaden architecture dependency
config: arm64-kismet-CONFIG_PHY_TEGRA194_P2U-CONFIG_PCIE_TEGRA194_EP-0-0 (https://download.01.org/0day-ci/archive/20250416/[email protected]/config)
reproduce: (https://download.01.org/0day-ci/archive/20250416/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

kismet warnings: (new ones prefixed by >>)

>> kismet: WARNING: unmet direct dependencies detected for PHY_TEGRA194_P2U when selected by PCIE_TEGRA194_EP

WARNING: unmet direct dependencies detected for PHY_TEGRA194_P2U
Depends on [n]: ARCH_TEGRA_194_SOC [=n] || ARCH_TEGRA_234_SOC [=n] || COMPILE_TEST [=n] Selected by [y]:
- PCIE_TEGRA194_EP [=y] && PCI [=y] && ARCH_TEGRA [=y] && (ARM64 [=y] || COMPILE_TEST [=n]) && PCI_ENDPOINT [=y]

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#14 lore raw

Re: [PATCH V2] PCI: dwc: tegra194: Broaden architecture dependency

Quoted 22 lines · kernel test robot

Hi Vidya,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.15-rc2 next-20250416] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vidya-Sagar/PCI-dwc-tegra194-Broaden-architecture-dependency/20250411-035134
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20250410194552.944818-1-vidyas%40nvidia.com
patch subject: [PATCH V2] PCI: dwc: tegra194: Broaden architecture dependency
config: arm64-kismet-CONFIG_PHY_TEGRA194_P2U-CONFIG_PCIE_TEGRA194_EP-0-0 (https://download.01.org/0day-ci/archive/20250416/[email protected]/config)
reproduce: (https://download.01.org/0day-ci/archive/20250416/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

Quoted 10 lines

kismet warnings: (new ones prefixed by >>)

Quoted 1 line
Quoted 1 line

kismet: WARNING: unmet direct dependencies detected for PHY_TEGRA194_P2U when selected by PCIE_TEGRA194_EP

WARNING: unmet direct dependencies detected for PHY_TEGRA194_P2U
Depends on [n]: ARCH_TEGRA_194_SOC [=n] || ARCH_TEGRA_234_SOC [=n] || COMPILE_TEST [=n] Selected by [y]:
- PCIE_TEGRA194_EP [=y] && PCI [=y] && ARCH_TEGRA [=y] && (ARM64 [=y] || COMPILE_TEST [=n]) && PCI_ENDPOINT [=y]

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

My guess is that the easiest fix is to change
drivers/phy/tegra/Kconfig

config PHY_TEGRA194_P2U
to
depends on ARCH_TEGRA || COMPILE_TEST

Kind regards,
Niklas

#15 lore raw

Re: [PATCH V2] PCI: dwc: tegra194: Broaden architecture dependency

In reply to Vidya Sagar
kernel test robot noticed the following build warnings:

Hi Vidya,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.15-rc2 next-20250416] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vidya-Sagar/PCI-dwc-tegra194-Broaden-architecture-dependency/20250411-035134
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20250410194552.944818-1-vidyas%40nvidia.com
patch subject: [PATCH V2] PCI: dwc: tegra194: Broaden architecture dependency
config: arm64-kismet-CONFIG_PHY_TEGRA194_P2U-CONFIG_PCIE_TEGRA194_HOST-0-0 (https://download.01.org/0day-ci/archive/20250417/[email protected]/config)
reproduce: (https://download.01.org/0day-ci/archive/20250417/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

kismet warnings: (new ones prefixed by >>)

>> kismet: WARNING: unmet direct dependencies detected for PHY_TEGRA194_P2U when selected by PCIE_TEGRA194_HOST

WARNING: unmet direct dependencies detected for PHY_TEGRA194_P2U
Depends on [n]: ARCH_TEGRA_194_SOC [=n] || ARCH_TEGRA_234_SOC [=n] || COMPILE_TEST [=n] Selected by [y]:
- PCIE_TEGRA194_HOST [=y] && PCI [=y] && ARCH_TEGRA [=y] && (ARM64 [=y] || COMPILE_TEST [=n]) && PCI_MSI [=y]

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki