x86: Make set/clear_bit() atomic
PATCH 1/1 x86: Make set/clear_bit() atomic
x86 is the only architecture that defines set/clear_bit() as non-atomic. This makes it incompatible with arch-agnostic code that might implicitly require atomicity. And it was observed to corrupt the 'online_cpus' bitmap, as non BSP CPUs perform RmWs on the bitmap concurrently during bring up. See:
ap_start64()
save_id()
set_bit(apic_id(), online_cpus)
Address this by making set/clear_bit() atomic.
--- lib/x86/processor.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/x86/processor.h +2 -2
@@ -843,13 +843,13 @@ static inline bool is_canonical(u64 addr)static inline void clear_bit (int bit,u8 *addr) { - __asm__ __volatile__("btr %1, %0" + __asm__ __volatile__("lock; btr %1, %0" :"+m" (*addr) :"Ir" (bit) :"cc" ,"memory" ); }static inline void set_bit (int bit,u8 *addr) { - __asm__ __volatile__("bts %1, %0" + __asm__ __volatile__("lock; bts %1, %0" :"+m" (*addr) :"Ir" (bit) :"cc" ,"memory" ); }
Signature · 1 line
2.47.1
Sean Christopherson
reviewerQuoted 11 lines · Nicolas Saenz Julienne
x86 is the only architecture that defines set/clear_bit() as non-atomic. This makes it incompatible with arch-agnostic code that might implicitly require atomicity. And it was observed to corrupt the '
online_cpus' bitmap, as non BSP CPUs perform RmWs on the bitmap concurrently during bring up. See:
ap_start64()
save_id()set_bit(apic_id(), online_cpus)Address this by making set/clear_bit() atomic.
OMG, this is arguaby worse than the per-CPU stack/data mess. *sigh*
I'll grab this, I'm putting together a pull request for a few things.
Quoted 11 lines · Nicolas Saenz Julienne
x86 is the only architecture that defines set/clear_bit() as non-atomic. This makes it incompatible with arch-agnostic code that might implicitly require atomicity. And it was observed to corrupt the '
online_cpus' bitmap, as non BSP CPUs perform RmWs on the bitmap concurrently during bring up. See:
ap_start64()
save_id()set_bit(apic_id(), online_cpus)[...]
Applied to kvm-x86 next (and now pulled by Paolo), thanks!
[1/1] x86: Make set/clear_bit() atomic
https://github.com/kvm-x86/kvm-unit-tests/commit/2f3c02862e03