staging: gpib: Fix typo in TTY_LOG message
Subsystems (2)
PATCH 1/1 staging: gpib: Fix typo in TTY_LOG message
There is a typo in TTY_LOG message:
- sucesfully -> successfully
Fix it via codespell.
--- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +1 -1
@@ -542,7 +542,7 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confireturn -EIO ;SHOW_STATUS (board); -TTY_LOG ("Module '%s' has been sucesfully configured\n" ,NAME ); +TTY_LOG ("Module '%s' has been successfully configured\n" ,NAME );return 0 ; }
Signature · 1 line
2.48.1.268.g9520f7d998
Quoted 15 lines · Andrew Kreimer
There is a typo in
TTY_LOGmessage:
- sucesfully -> successfullyFix it via codespell.
Signed-off-by Andrew Kreimer <[email protected]>--- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +0
-0
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confi · line 545
Quoted 5 lines
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +1
-1@@ -542,7 +542,7 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confireturn -EIO ;SHOW_STATUS (board); -TTY_LOG ("Module '%s' has been sucesfully configured\n" ,NAME ); +TTY_LOG ("Module '%s' has been successfully configured\n" ,NAME );
When drivers are successful, they should be quiet, this line should just be removed.
thanks,
greg k-h
PATCH v2 1/1 staging: gpib: Remove unnecessary TTY_LOG expansion
In reply to Andrew KreimerWhen drivers are successful, they should be quiet.
Remove the unnecessary TTY_LOG expansion.
---
v2:
- Change commit message/body.
- Remove the TTY_LOG line as suggested.
v1:
- Fix a typo in TTY_LOG message.
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +0 -1
@@ -542,7 +542,6 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confireturn -EIO ;SHOW_STATUS (board); -TTY_LOG ("Module '%s' has been sucesfully configured\n" ,NAME );return 0 ; }
Interdiff against v1:
diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index 1c3e5dfcc9ec..b2c4d1d26f12 100644
--- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -542,7 +542,6 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confi
return -EIO;
SHOW_STATUS(board);
- TTY_LOG("Module '%s' has been successfully configured\n", NAME);
return 0;
}Range-diff against v1:
1: 779e59d74722 ! 1: 463e7000d1a7 staging: gpib: Fix typo in TTY_LOG message
@@ Metadata
Author: Andrew Kreimer <[email protected]>
## Commit message ##
- staging: gpib: Fix typo in TTY_LOG message
+ staging: gpib: Remove unnecessary TTY_LOG expansion
- There is a typo in TTY_LOG message:
- - sucesfully -> successfully
+ When drivers are successful, they should be quiet.
- Fix it via codespell.
+ Remove the unnecessary TTY_LOG expansion.
+ Suggested-by: Greg KH <[email protected]>
## drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c ##
@@ drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c: static int usb_gpib_attach(g
SHOW_STATUS(board);
- TTY_LOG("Module '%s' has been sucesfully configured\n", NAME);
-+ TTY_LOG("Module '%s' has been successfully configured\n", NAME);
return 0;
}
Signature · 1 line
2.48.1.268.g9520f7d998
Greg KH
maintainerRe: [PATCH v2] staging: gpib: Remove unnecessary TTY_LOG expansion
Quoted 63 lines · Andrew Kreimer
When drivers are successful, they should be quiet.
Remove the unnecessary
TTY_LOGexpansion.Suggested-by Greg KH <[email protected]>Signed-off-by Andrew Kreimer <[email protected]>---
v2:
- Change commit message/body.
- Remove theTTY_LOGline as suggested.v1:
- Fix a typo inTTY_LOGmessage.drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 1 - 1 file changed, 1 deletion(-)drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +0
-1@@ -542,7 +542,6 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confireturn -EIO ;SHOW_STATUS (board); -TTY_LOG ("Module '%s' has been sucesfully configured\n" ,NAME );return 0 ; }Interdiff against v1:
diff --gita/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.cb/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.cindex1c3e5dfcc9ec..b2c4d1d26f12100644
---a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+++b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -542,7 +542,6 @@ static int usb_gpib_attach(gpib_board_t *board, constgpib_board_config_t*confireturn -EIO; SHOW_STATUS(board); - TTY_LOG("Module '%s' has been successfully configured\n", NAME); return 0; }Range-diff against v1:
1:779e59d74722! 1:463e7000d1a7staging: gpib: Fix typo inTTY_LOGmessage
@@ Metadata
Author: Andrew Kreimer <[email protected]>## Commit message ##
- staging: gpib: Fix typo inTTY_LOGmessage
+ staging: gpib: Remove unnecessaryTTY_LOGexpansion- There is a typo in
TTY_LOGmessage:
- - sucesfully -> successfully
+ When drivers are successful, they should be quiet.- Fix it via codespell.
+ Remove the unnecessaryTTY_LOGexpansion.+ Suggested-by: Greg KH <[email protected]>
Signed-off-by Andrew Kreimer <[email protected]>
Quoted 12 lines
##
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c##
@@drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c: static int usb_gpib_attach(g
SHOW_STATUS(board);
-TTY_LOG("Module '%s' has been sucesfully configured\n", NAME);
-+TTY_LOG("Module '%s' has been successfully configured\n", NAME);
return 0;
}Signature · 1 line
2.48.1.268.g9520f7d998
What is the interdiff at the bottom here for?
thanks,
greg k-h
Re: [PATCH v2] staging: gpib: Remove unnecessary TTY_LOG expansion
Quoted 1 line
What is the interdiff at the bottom here for?
Indeed, it is pointless here.
Should have sent as a separate patch as well.