Skip to contentSkip to conversation

dt-bindings: input: matrix_keypad - add wakeup-source property

PATCH In review Dmitry Torokhov 3 participants 3 messages Feb 28, 2025

Subsystems (3)
Device tree bindings HID Input drivers
lore
Share & tools
lore

Dmitry Torokhov

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: input: matrix_keypad - add wakeup-source property

The driver recognizes standard "wakeup-source" property and there are DTS files using it. Add the property to the binding.

Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here
Signed-off-by Dmitry Torokhov <[email protected]>
---
 .../devicetree/bindings/input/gpio-matrix-keypad.yaml         | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml +4 -0
index 73bb153ed241..ebfff9e42a36 100644
@@ -68,6 +68,8 @@ properties:
       Drive inactive columns during scan,
       default is to turn inactive columns into inputs.
 
+  wakeup-source: true
+
 required:
   - compatible
   - row-gpios

@@ -96,4 +98,6 @@ examples:
                         0x0001006A
                         0x0101001C
                         0x0201006C>;
+
+        wakeup-source;
     };
Signature · 5 lines
2.48.1.711.g2feabab25a-goog


-- 
Dmitry
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Dmitry Torokhov

The driver recognizes standard "wakeup-source" property and there are DTS files using it. Add the property to the binding.

Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here
Signed-off-by Dmitry Torokhov <[email protected]>
Reviewed-by Manuel Traut <[email protected]>
Quoted 30 lines
---
 .../devicetree/bindings/input/gpio-matrix-keypad.yaml         | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml +4 -0
index 73bb153ed241..ebfff9e42a36 100644
@@ -68,6 +68,8 @@ properties:
       Drive inactive columns during scan,
       default is to turn inactive columns into inputs.
 
+  wakeup-source: true
+
 required:
   - compatible
   - row-gpios

@@ -96,4 +98,6 @@ examples:
                         0x0001006A
                         0x0101001C
                         0x0201006C>;
+
+        wakeup-source;
     };
Signature · 5 lines
2.48.1.711.g2feabab25a-goog


-- 
Dmitry
Acked-by on v1 1/1
#2 lore raw
In reply to Dmitry Torokhov
Quoted 6 lines · Dmitry Torokhov

The driver recognizes standard "wakeup-source" property and there are DTS files using it. Add the property to the binding.

Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here
Signed-off-by Dmitry Torokhov <[email protected]>
Acked-by Conor Dooley <[email protected]>
Quoted 30 lines
---
 .../devicetree/bindings/input/gpio-matrix-keypad.yaml         | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml +4 -0
index 73bb153ed241..ebfff9e42a36 100644
@@ -68,6 +68,8 @@ properties:
       Drive inactive columns during scan,
       default is to turn inactive columns into inputs.
 
+  wakeup-source: true
+
 required:
   - compatible
   - row-gpios

@@ -96,4 +98,6 @@ examples:
                         0x0001006A
                         0x0101001C
                         0x0201006C>;
+
+        wakeup-source;
     };
Signature · 5 lines
2.48.1.711.g2feabab25a-goog


-- 
Dmitry