Skip to contentSkip to conversation

gpu: host1x: Remove unused host1x_debug_dump_syncpts

PATCH Applied [email protected] 3 participants 5 messages Dec 15, 2024 – Feb 28, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu: host1x: Remove unused host1x_debug_dump_syncpts

From: "Dr. David Alan Gilbert" <[email protected]>

host1x_debug_dump_syncpts() has been unused since
commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA fences")

Remove it.

---
 drivers/gpu/host1x/debug.c | 9 ---------
 drivers/gpu/host1x/debug.h | 1 -
 2 files changed, 10 deletions(-)
drivers/gpu/host1x/debug.c +0 -9
index a18cc8d8caf5..6433c00d5d7e 100644
@@ -216,12 +216,3 @@ void host1x_debug_dump(struct host1x *host1x)
 
 	show_all(host1x, &o, true);
 }
-
-void host1x_debug_dump_syncpts(struct host1x *host1x)
-{
-	struct output o = {
-		.fn = write_to_printk
-	};
-
-	show_syncpts(host1x, &o, false);
-}
drivers/gpu/host1x/debug.h +0 -1
index 62bd8a091fa7..c43c61d876a9 100644
@@ -41,6 +41,5 @@ extern unsigned int host1x_debug_trace_cmdbuf;
 void host1x_debug_init(struct host1x *host1x);
 void host1x_debug_deinit(struct host1x *host1x);
 void host1x_debug_dump(struct host1x *host1x);
-void host1x_debug_dump_syncpts(struct host1x *host1x);
 
 #endif
Signature · 1 line
2.47.1
Acked-by on v1 1/1
#1 lore raw
Quoted 36 lines · On 12/16/24 6:47 AM, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

host1x_debug_dump_syncpts() has been unused since
commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA fences")

Remove it.

---
  drivers/gpu/host1x/debug.c | 9 ---------
  drivers/gpu/host1x/debug.h | 1 -
  2 files changed, 10 deletions(-)
drivers/gpu/host1x/debug.c +0 -9
index a18cc8d8caf5..6433c00d5d7e 100644
@@ -216,12 +216,3 @@ void host1x_debug_dump(struct host1x *host1x)
 
  	show_all(host1x, &o, true);
  }
-
-void host1x_debug_dump_syncpts(struct host1x *host1x)
-{
-	struct output o = {
-		.fn = write_to_printk
-	};
-
-	show_syncpts(host1x, &o, false);
-}
drivers/gpu/host1x/debug.h +0 -0
index 62bd8a091fa7..c43c61d876a9 100644

drivers/gpu/host1x/debug.h extern unsigned int host1x_debug_trace_cmdbuf; · line 45

Quoted 6 lines
drivers/gpu/host1x/debug.h +0 -1
@@ -41,6 +41,5 @@ extern unsigned int host1x_debug_trace_cmdbuf;
  void host1x_debug_init(struct host1x *host1x);
  void host1x_debug_deinit(struct host1x *host1x);
  void host1x_debug_dump(struct host1x *host1x);
-void host1x_debug_dump_syncpts(struct host1x *host1x);
 
  #endif
#2 lore raw

Hi,

Quoted 35 lines · * Mikko Perttunen ([email protected]) wrote:
Quoted 34 lines · On 12/16/24 6:47 AM, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

host1x_debug_dump_syncpts() has been unused since
commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA fences")

Remove it.

---
  drivers/gpu/host1x/debug.c | 9 ---------
  drivers/gpu/host1x/debug.h | 1 -
  2 files changed, 10 deletions(-)
drivers/gpu/host1x/debug.c +0 -9
index a18cc8d8caf5..6433c00d5d7e 100644
@@ -216,12 +216,3 @@ void host1x_debug_dump(struct host1x *host1x)
  	show_all(host1x, &o, true);
  }
-
-void host1x_debug_dump_syncpts(struct host1x *host1x)
-{
-	struct output o = {
-		.fn = write_to_printk
-	};
-
-	show_syncpts(host1x, &o, false);
-}
drivers/gpu/host1x/debug.h +0 -0
index 62bd8a091fa7..c43c61d876a9 100644
Quoted 8 lines

drivers/gpu/host1x/debug.h extern unsigned int host1x_debug_trace_cmdbuf; · line 44

Quoted 6 lines
drivers/gpu/host1x/debug.h +0 -1
@@ -41,6 +41,5 @@ extern unsigned int host1x_debug_trace_cmdbuf;
  void host1x_debug_init(struct host1x *host1x);
  void host1x_debug_deinit(struct host1x *host1x);
  void host1x_debug_dump(struct host1x *host1x);
-void host1x_debug_dump_syncpts(struct host1x *host1x);
  #endif

Can this find it's way into drm please.

Thanks,

Dave

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#3 lore raw
In reply to [email protected]
Quoted 6 lines · On Sun, Dec 15, 2024 at 09:47:50PM +0000, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

host1x_debug_dump_syncpts() has been unused since
commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA fences")

Quoted 7 lines

Remove it.

---
 drivers/gpu/host1x/debug.c | 9 ---------
 drivers/gpu/host1x/debug.h | 1 -
 2 files changed, 10 deletions(-)

Applied to drm-misc-next, thanks.

Thierry

#4 lore raw
Quoted 9 lines · * Thierry Reding ([email protected]) wrote:
Quoted 8 lines · On Sun, Dec 15, 2024 at 09:47:50PM +0000, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

host1x_debug_dump_syncpts() has been unused since
commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA fences")

Remove it.

Quoted 7 lines
Quoted 5 lines
---
 drivers/gpu/host1x/debug.c | 9 ---------
 drivers/gpu/host1x/debug.h | 1 -
 2 files changed, 10 deletions(-)

Applied to drm-misc-next, thanks.

Thanks

Quoted 1 line

Thierry

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/