override audit silence norule for fs cases
cover override audit silence norule for fs cases
The audit subsystem normally suppresses output when there are no rules present to avoid overwhelming the user with unwanted messages. It could be argued that another security subsystem would generally want to override that default. Allow them through for fsnotify and filesystem security violations.
Richard Guy Briggs (2):
audit: record fanotify event regardless of presence of rules
audit: record AUDIT_ANOM_* events regardless of presence of rules
include/linux/audit.h | 8 +------- kernel/audit.c | 2 +- kernel/auditsc.c | 2 +- 3 files changed, 3 insertions(+), 9 deletions(-)
Signature · 1 line
2.43.5
PATCH 1/2 audit: record fanotify event regardless of presence of rules
When no audit rules are in place, fanotify event results are unconditionally dropped due to an explicit check for the existence of any audit rules. Given this is a report from another security sub-system, allow it to be recorded regardless of the existence of any audit rules.
To test, install and run the fapolicyd daemon with default config. Then as an unprivileged user, create and run a very simple binary that should be denied. Then check for an event with
ausearch -m FANOTIFY -ts recent
--- include/linux/audit.h | 8 +------- kernel/auditsc.c | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-)
include/linux/audit.h +1 -7
@@ -418,7 +418,7 @@ extern void __audit_log_capset(const struct cred *new, const struct cred *old);extern void __audit_mmap_fd (int fd,int flags);extern void __audit_openat2_how (struct open_how *how);extern void __audit_log_kern_module (char *name); -extern void __audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar); +extern void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar);extern void __audit_tk_injoffset (struct timespec64 offset);extern void __audit_ntp_log (const struct audit_ntp_data *ad); extern void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries,
@@ -525,12 +525,6 @@ static inline void audit_log_kern_module(char *name)__audit_log_kern_module (name); } -static inline void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar) -{ -if (!audit_dummy_context ()) -__audit_fanotify (response, friar); -} -static inline void audit_tk_injoffset (struct timespec64 offset) {/* ignore no-op events */
kernel/auditsc.c +1 -1
@@ -2880,7 +2880,7 @@ void __audit_log_kern_module(char *name) context->type =AUDIT_KERN_MODULE ; } -void __audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar) +void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar) {/* {subj,obj}_trust values are {0,1,2}: no,yes,unknown */ switch (friar->hdr.type) {
Signature · 1 line
2.43.5
Jan Kara
reviewerRe: [PATCH v1 1/2] audit: record fanotify event regardless of presence of rules
Quoted 6 lines · Richard Guy Briggs
When no audit rules are in place, fanotify event results are unconditionally dropped due to an explicit check for the existence of any audit rules. Given this is a report from another security sub-system, allow it to be recorded regardless of the existence of any audit rules.
Quoted 7 lines
To test, install and run the fapolicyd daemon with default config. Then as an unprivileged user, create and run a very simple binary that should be denied. Then check for an event with
ausearch -m FANOTIFY -ts recent
I don't know enough about security modules to tell whether this is what admins want or not so that's up to you but:
include/linux/audit.h static inline void audit_log_kern_module(char *name) · line 533
Quoted 6 lines
include/linux/audit.h +0
-6-static inline void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar) -{ -if (!audit_dummy_context ()) -__audit_fanotify (response, friar); -} -
I think this is going to break compilation with !CONFIG_AUDITSYSCALL && CONFIG_FANOTIFY?
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Re: [PATCH v1 1/2] audit: record fanotify event regardless of presence of rules
Quoted 18 lines · Jan Kara
Quoted 6 lines · Richard Guy Briggs
When no audit rules are in place, fanotify event results are unconditionally dropped due to an explicit check for the existence of any audit rules. Given this is a report from another security sub-system, allow it to be recorded regardless of the existence of any audit rules.
Quoted 7 lines
To test, install and run the fapolicyd daemon with default config. Then as an unprivileged user, create and run a very simple binary that should be denied. Then check for an event with
ausearch -m FANOTIFY -ts recentI don't know enough about security modules to tell whether this is what admins want or not so that's up to you but:
Quoted 9 lines
Review
Quoted 6 lines
(quoted diff) +0
-6-static inline void audit_fanotify(u32 response, struct fanotify_response_info_audit_rule *friar) -{ - if (!audit_dummy_context()) - __audit_fanotify(response, friar); -} -I think this is going to break compilation with !CONFIG_AUDITSYSCALL &&
CONFIG_FANOTIFY?
Why would that break it? The part of the patch you (prematurely) deleted takes care of that.
include/linux/audit.h +1 -1
@@ -418,7 +418,7 @@ extern void __audit_log_capset(const struct cred *new, const struct cred *old);extern void __audit_mmap_fd (int fd,int flags);extern void __audit_openat2_how (struct open_how *how);extern void __audit_log_kern_module (char *name); -extern void __audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar); +extern void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar);extern void __audit_tk_injoffset (struct timespec64 offset);extern void __audit_ntp_log (const struct audit_ntp_data *ad); extern void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries,
Quoted 4 lines
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
- RGB
--
Richard Guy Briggs <[email protected]>
Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada
Upstream IRC: SunRaycer
Voice: +1.613.860 2354 SMS: +1.613.518.6570
Jan Kara
reviewerRe: [PATCH v1 1/2] audit: record fanotify event regardless of presence of rules
Quoted 29 lines · Richard Guy Briggs
Quoted 18 lines · Jan Kara
Quoted 6 lines · Richard Guy Briggs
When no audit rules are in place, fanotify event results are unconditionally dropped due to an explicit check for the existence of any audit rules. Given this is a report from another security sub-system, allow it to be recorded regardless of the existence of any audit rules.
Quoted 7 lines
To test, install and run the fapolicyd daemon with default config. Then as an unprivileged user, create and run a very simple binary that should be denied. Then check for an event with
ausearch -m FANOTIFY -ts recentI don't know enough about security modules to tell whether this is what admins want or not so that's up to you but:
Quoted 9 lines
Review
Quoted 6 lines
(quoted diff) +0
-6-static inline void audit_fanotify(u32 response, struct fanotify_response_info_audit_rule *friar) -{ - if (!audit_dummy_context()) - __audit_fanotify(response, friar); -} -I think this is going to break compilation with !CONFIG_AUDITSYSCALL &&
CONFIG_FANOTIFY?
Quoted 2 lines
Why would that break it? The part of the patch you (prematurely) deleted takes care of that.
So I'm failing to see how it takes care of that when with !CONFIG_AUDITSYSCALL kernel/auditsc.c does not get compiled into the kernel. So what does provide the implementation of audit_fanotify() in that case? I think you need to provide empty audit_fanotify() inline wrapper for that case...
Honza
Quoted 28 lines
include/linux/audit.h +1
-1@@ -418,7 +418,7 @@ extern void __audit_log_capset(const struct cred *new, const struct cred *old);extern void __audit_mmap_fd (int fd,int flags);extern void __audit_openat2_how (struct open_how *how);extern void __audit_log_kern_module (char *name); -extern void __audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar); +extern void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar);extern void __audit_tk_injoffset (struct timespec64 offset);extern void __audit_ntp_log (const struct audit_ntp_data *ad); extern void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries,Quoted 5 lines
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR- RGB
--
Richard Guy Briggs <[email protected]>
Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada
Upstream IRC: SunRaycer
Voice: +1.613.860 2354 SMS: +1.613.518.6570
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Re: [PATCH v1 1/2] audit: record fanotify event regardless of presence of rules
Quoted 30 lines · Jan Kara
Quoted 29 lines · Richard Guy Briggs
Quoted 27 lines · Jan Kara
Quoted 6 lines · Richard Guy Briggs
When no audit rules are in place, fanotify event results are unconditionally dropped due to an explicit check for the existence of any audit rules. Given this is a report from another security sub-system, allow it to be recorded regardless of the existence of any audit rules.
Quoted 7 lines
To test, install and run the fapolicyd daemon with default config. Then as an unprivileged user, create and run a very simple binary that should be denied. Then check for an event with
ausearch -m FANOTIFY -ts recentI don't know enough about security modules to tell whether this is what admins want or not so that's up to you but:
Review
Quoted 6 lines
(quoted diff) +0
-6-static inline void audit_fanotify(u32 response, struct fanotify_response_info_audit_rule *friar) -{ - if (!audit_dummy_context()) - __audit_fanotify(response, friar); -} -I think this is going to break compilation with !CONFIG_AUDITSYSCALL &&
CONFIG_FANOTIFY?
Quoted 8 lines
Quoted 2 lines
Why would that break it? The part of the patch you (prematurely) deleted takes care of that.
So I'm failing to see how it takes care of that when with !CONFIG_AUDITSYSCALL
kernel/auditsc.cdoes not get compiled into the kernel. So what does provide the implementation ofaudit_fanotify()in that case? I think you need to provide emptyaudit_fanotify()inline wrapper for that case...
I'm sorry, I responded too quickly without thinking about your question, my mistake. It isn't the prototype that was changed in the CONFIG_SYSCALL case that is relevant in that case.
There was already in existance in the !CONFIG_AUDITSYSCALL case the inline wrapper to do that job:
static inline void audit_fanotify(u32 response, struct fanotify_response_info_audit_rule *friar)
{ }Did I understand correctly this time and does this answer your question?
But you do cause me to notice the case that these notifications will be dropped when CONFIG_AUDIT && !CONFIG_AUDITSYSCALL.
Thanks for persisting.
Quoted 16 lines
Honza
Quoted 14 lines
include/linux/audit.h +1
-1@@ -418,7 +418,7 @@ extern void __audit_log_capset(const struct cred *new, const struct cred *old);extern void __audit_mmap_fd (int fd,int flags);extern void __audit_openat2_how (struct open_how *how);extern void __audit_log_kern_module (char *name); -extern void __audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar); +extern void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar);extern void __audit_tk_injoffset (struct timespec64 offset);extern void __audit_ntp_log (const struct audit_ntp_data *ad); extern void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries,
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR- RGB
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
- RGB
--
Richard Guy Briggs <[email protected]>
Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada
Upstream IRC: SunRaycer
Voice: +1.613.860 2354 SMS: +1.613.518.6570
Re: [PATCH v1 1/2] audit: record fanotify event regardless of presence of rules
Quoted 44 lines · Richard Guy Briggs
Quoted 30 lines · Jan Kara
Quoted 29 lines · Richard Guy Briggs
Quoted 27 lines · Jan Kara
Quoted 6 lines · Richard Guy Briggs
When no audit rules are in place, fanotify event results are unconditionally dropped due to an explicit check for the existence of any audit rules. Given this is a report from another security sub-system, allow it to be recorded regardless of the existence of any audit rules.
Quoted 7 lines
To test, install and run the fapolicyd daemon with default config. Then as an unprivileged user, create and run a very simple binary that should be denied. Then check for an event with
ausearch -m FANOTIFY -ts recentI don't know enough about security modules to tell whether this is what admins want or not so that's up to you but:
Review
Quoted 6 lines
(quoted diff) +0
-6-static inline void audit_fanotify(u32 response, struct fanotify_response_info_audit_rule *friar) -{ - if (!audit_dummy_context()) - __audit_fanotify(response, friar); -} -I think this is going to break compilation with !CONFIG_AUDITSYSCALL &&
CONFIG_FANOTIFY?Quoted 8 lines
Quoted 2 lines
Why would that break it? The part of the patch you (prematurely) deleted takes care of that.
So I'm failing to see how it takes care of that when with !CONFIG_AUDITSYSCALL
kernel/auditsc.cdoes not get compiled into the kernel. So what does provide the implementation ofaudit_fanotify()in that case? I think you need to provide emptyaudit_fanotify()inline wrapper for that case...I'm sorry, I responded too quickly without thinking about your question, my mistake. It isn't the prototype that was changed in the
CONFIG_SYSCALLcase that is relevant in that case.
Quoted 7 lines
There was already in existance in the !CONFIG_AUDITSYSCALL case the inline wrapper to do that job:
static inline void audit_fanotify(u32 response, struct fanotify_response_info_audit_rule *friar) { }Did I understand correctly this time and does this answer your question?
Yes, thanks for explanation and sorry for not noticing the second audit_fanotify() implementation. Somehow I've hasted to a conclusion (based on customs of parts of kernel I maintain ;)) that you rely on audit_dummy_context() being constant 0 for !CONFIG_AUDITSYSCALL and thus __audit_fanotify() call getting compiled out (which would not be the case after your changes).
Anyway, for the patch feel free to add:
Quoted 2 lines
But you do cause me to notice the case that these notifications will be dropped when
CONFIG_AUDIT&& !CONFIG_AUDITSYSCALL.
Glad my blindness helped something ;)
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Paul Moore
maintainerRe: [PATCH v1 1/2] audit: record fanotify event regardless of presence of rules
In reply to Richard Guy BriggsQuoted 34 lines · On Mar 5, 2025 Richard Guy Briggs <[email protected]> wrote:
When no audit rules are in place, fanotify event results are unconditionally dropped due to an explicit check for the existence of any audit rules. Given this is a report from another security sub-system, allow it to be recorded regardless of the existence of any audit rules.
To test, install and run the fapolicyd daemon with default config. Then as an unprivileged user, create and run a very simple binary that should be denied. Then check for an event with
ausearch -m FANOTIFY -ts recentSigned-off-by Richard Guy Briggs <[email protected]>Acked-by Jan Kara <[email protected]>--- include/linux/audit.h | 8 +------- kernel/auditsc.c | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-)include/linux/audit.h +1
-1@@ -418,7 +418,7 @@ extern void __audit_log_capset(const struct cred *new, const struct cred *old);extern void __audit_mmap_fd (int fd,int flags);extern void __audit_openat2_how (struct open_how *how);extern void __audit_log_kern_module (char *name); -extern void __audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar); +extern void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar);extern void __audit_tk_injoffset (struct timespec64 offset);extern void __audit_ntp_log (const struct audit_ntp_data *ad); extern void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries,
include/linux/audit.h static inline void audit_log_kern_module(char *name) · line 532
Quoted 8 lines
include/linux/audit.h +0
-5@@ -525,12 +525,6 @@ static inline void audit_log_kern_module(char *name)__audit_log_kern_module (name); } -static inline void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar) -{ -if (!audit_dummy_context ()) -__audit_fanotify (response, friar); -}
It seems like we should at least have an audit_enabled() check, yes? We've had people complain about audit events being generated when audit is disabled, any while we don't currently have such a check in place here, I believe the dummy context check is doing that for us.
static inline void audit_fanotify(...)
{
if (!audit_enabled)
return;
__audit_fanotify(...);
}Quoted 18 lines
include/linux/audit.h +0
-0static inline void audit_tk_injoffset (struct timespec64 offset) {/* ignore no-op events */ kernel/auditsc.c +1
-1@@ -2880,7 +2880,7 @@ void __audit_log_kern_module(char *name) context->type =AUDIT_KERN_MODULE ; } -void __audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar) +void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar) {/* {subj,obj}_trust values are {0,1,2}: no,yes,unknown */ switch (friar->hdr.type) {Signature · 1 line
2.43.5
--
paul-moore.com
Re: [PATCH v1 1/2] audit: record fanotify event regardless of presence of rules
Quoted 49 lines · Paul Moore
Quoted 34 lines · On Mar 5, 2025 Richard Guy Briggs <[email protected]> wrote:
When no audit rules are in place, fanotify event results are unconditionally dropped due to an explicit check for the existence of any audit rules. Given this is a report from another security sub-system, allow it to be recorded regardless of the existence of any audit rules.
To test, install and run the fapolicyd daemon with default config. Then as an unprivileged user, create and run a very simple binary that should be denied. Then check for an event with
ausearch -m FANOTIFY -ts recentSigned-off-by Richard Guy Briggs <[email protected]>Acked-by Jan Kara <[email protected]>--- include/linux/audit.h | 8 +------- kernel/auditsc.c | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-)include/linux/audit.h +1
-1@@ -418,7 +418,7 @@ extern void __audit_log_capset(const struct cred *new, const struct cred *old);extern void __audit_mmap_fd (int fd,int flags);extern void __audit_openat2_how (struct open_how *how);extern void __audit_log_kern_module (char *name); -extern void __audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar); +extern void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar);extern void __audit_tk_injoffset (struct timespec64 offset);extern void __audit_ntp_log (const struct audit_ntp_data *ad); extern void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries,include/linux/audit.h static inline void audit_log_kern_module(char *name) · line 532
Quoted 8 lines
include/linux/audit.h +0
-5@@ -525,12 +525,6 @@ static inline void audit_log_kern_module(char *name)__audit_log_kern_module (name); } -static inline void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar) -{ -if (!audit_dummy_context ()) -__audit_fanotify (response, friar); -}It seems like we should at least have an
audit_enabled()check, yes? We've had people complain about audit events being generated when audit is disabled, any while we don't currently have such a check in place here, I believe the dummy context check is doing that for us.
Quoted 6 lines
static inline void audit_fanotify(...)
{
if (!audit_enabled)
return;
__audit_fanotify(...);
}That would be consistent with other security events messages. I was going through the selinux code to see what it does and I am missing it if selinux checks with audit_enabled(). Are selinux messages somehow exempt from audit_enabled()?
Quoted 11 lines
Quoted 11 lines
include/linux/audit.h +0
-0static inline void audit_tk_injoffset (struct timespec64 offset) {/* ignore no-op events */ kernel/auditsc.c +0
-0@@ -2880,7 +2880,7 @@ void __audit_log_kern_module(char *name) context->type =AUDIT_KERN_MODULE ; }
Quoted 11 lines
Quoted 7 lines
kernel/auditsc.c +1
-1-void __audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar) +void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar) {/* {subj,obj}_trust values are {0,1,2}: no,yes,unknown */ switch (friar->hdr.type) {Signature · 1 line
2.43.5--
paul-moore.com
- RGB
--
Richard Guy Briggs <[email protected]>
Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada
Upstream IRC: SunRaycer
Voice: +1.613.860 2354 SMS: +1.613.518.6570
Paul Moore
maintainerRe: [PATCH v1 1/2] audit: record fanotify event regardless of presence of rules
Quoted 57 lines · Richard Guy Briggs
Quoted 49 lines · Paul Moore
Quoted 34 lines · On Mar 5, 2025 Richard Guy Briggs <[email protected]> wrote:
When no audit rules are in place, fanotify event results are unconditionally dropped due to an explicit check for the existence of any audit rules. Given this is a report from another security sub-system, allow it to be recorded regardless of the existence of any audit rules.
To test, install and run the fapolicyd daemon with default config. Then as an unprivileged user, create and run a very simple binary that should be denied. Then check for an event with
ausearch -m FANOTIFY -ts recentSigned-off-by Richard Guy Briggs <[email protected]>Acked-by Jan Kara <[email protected]>--- include/linux/audit.h | 8 +------- kernel/auditsc.c | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-)include/linux/audit.h +1
-1@@ -418,7 +418,7 @@ extern void __audit_log_capset(const struct cred *new, const struct cred *old);extern void __audit_mmap_fd (int fd,int flags);extern void __audit_openat2_how (struct open_how *how);extern void __audit_log_kern_module (char *name); -extern void __audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar); +extern void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar);extern void __audit_tk_injoffset (struct timespec64 offset);extern void __audit_ntp_log (const struct audit_ntp_data *ad); extern void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries,include/linux/audit.h static inline void audit_log_kern_module(char *name) · line 532
Quoted 8 lines
include/linux/audit.h +0
-5@@ -525,12 +525,6 @@ static inline void audit_log_kern_module(char *name)__audit_log_kern_module (name); } -static inline void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar) -{ -if (!audit_dummy_context ()) -__audit_fanotify (response, friar); -}It seems like we should at least have an
audit_enabled()check, yes? We've had people complain about audit events being generated when audit is disabled, any while we don't currently have such a check in place here, I believe the dummy context check is doing that for us.Quoted 6 lines
static inline void audit_fanotify(...) { if (!audit_enabled) return; __audit_fanotify(...); }
Quoted 4 lines
That would be consistent with other security events messages. I was going through the selinux code to see what it does and I am missing it if selinux checks with
audit_enabled(). Are selinux messages somehow exempt fromaudit_enabled()?
There are likely a number of callers in the kernel that don't have audit_enabled() checks, some are probably bugs, others probably intentional; I wouldn't worry too much about what one subsystem does when deciding what to do for another. In the case of fanotify, I suspect the right thing to do is add an audit_enabled() check since it is already doing an audit_dummy_context() check. To be clear, there may be some cases where we do an audit_dummy_context() check and doing an audit_enabled() check would be wrong, but I don't believe that is the case with fanotify.
Signature · 1 line
paul-moore.com
Re: [PATCH v1 1/2] audit: record fanotify event regardless of presence of rules
Quoted 63 lines · Paul Moore
Quoted 57 lines · Richard Guy Briggs
Quoted 49 lines · Paul Moore
Quoted 34 lines · On Mar 5, 2025 Richard Guy Briggs <[email protected]> wrote:
When no audit rules are in place, fanotify event results are unconditionally dropped due to an explicit check for the existence of any audit rules. Given this is a report from another security sub-system, allow it to be recorded regardless of the existence of any audit rules.
To test, install and run the fapolicyd daemon with default config. Then as an unprivileged user, create and run a very simple binary that should be denied. Then check for an event with
ausearch -m FANOTIFY -ts recentSigned-off-by Richard Guy Briggs <[email protected]>Acked-by Jan Kara <[email protected]>--- include/linux/audit.h | 8 +------- kernel/auditsc.c | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-)include/linux/audit.h +1
-1@@ -418,7 +418,7 @@ extern void __audit_log_capset(const struct cred *new, const struct cred *old);extern void __audit_mmap_fd (int fd,int flags);extern void __audit_openat2_how (struct open_how *how);extern void __audit_log_kern_module (char *name); -extern void __audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar); +extern void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar);extern void __audit_tk_injoffset (struct timespec64 offset);extern void __audit_ntp_log (const struct audit_ntp_data *ad); extern void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries,include/linux/audit.h static inline void audit_log_kern_module(char *name) · line 532
Quoted 8 lines
include/linux/audit.h +0
-5@@ -525,12 +525,6 @@ static inline void audit_log_kern_module(char *name)__audit_log_kern_module (name); } -static inline void audit_fanotify (u32 response,struct fanotify_response_info_audit_rule *friar) -{ -if (!audit_dummy_context ()) -__audit_fanotify (response, friar); -}It seems like we should at least have an
audit_enabled()check, yes? We've had people complain about audit events being generated when audit is disabled, any while we don't currently have such a check in place here, I believe the dummy context check is doing that for us.Quoted 6 lines
static inline void audit_fanotify(...) { if (!audit_enabled) return; __audit_fanotify(...); }Quoted 4 lines
That would be consistent with other security events messages. I was going through the selinux code to see what it does and I am missing it if selinux checks with
audit_enabled(). Are selinux messages somehow exempt fromaudit_enabled()?
Quoted 9 lines
There are likely a number of callers in the kernel that don't have
audit_enabled()checks, some are probably bugs, others probably intentional; I wouldn't worry too much about what one subsystem does when deciding what to do for another. In the case of fanotify, I suspect the right thing to do is add anaudit_enabled()check since it is already doing anaudit_dummy_context()check. To be clear, there may be some cases where we do anaudit_dummy_context()check and doing anaudit_enabled()check would be wrong, but I don't believe that is the case with fanotify.
I totally dropped the ball on this. I had it respun, tested and documented, ready to go May 28th and had a note that I'd sent it complete with Message-ID and I find no evidence it was ever sent. Re-based, re-tested, sending.
Quoted 1 line
paul-moore.com
- RGB
--
Richard Guy Briggs <[email protected]>
Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada
Upstream IRC: SunRaycer
Voice: +1.613.860 2354 SMS: +1.613.518.6570
PATCH 2/2 audit: record AUDIT_ANOM_* events regardless of presence of rules
In reply to Richard Guy BriggsWhen no audit rules are in place, AUDIT_ANOM_{LINK,CREAT} events reported in audit_log_path_denied() are unconditionally dropped due to an explicit check for the existence of any audit rules. Given this is a report of a security violation, allow it to be recorded regardless of the existence of any audit rules.
To test,
mkdir -p /root/tmp
chmod 1777 /root/tmp
touch /root/tmp/test.txt
useradd test
chown test /root/tmp/test.txt
{echo C0644 12 test.txt; printf 'hello\ntest1\n'; printf \\000;} | \
scp -t /root/tmp
Check with
ausearch -m ANOM_CREAT -ts recent
--- kernel/audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/audit.c +1 -1
@@ -2285,7 +2285,7 @@ void audit_log_path_denied(int type, const char *operation) {struct audit_buffer *ab; -if (!audit_enabled ||audit_dummy_context ()) +if (!audit_enabled)return ;/* Generate log with subject, operation, outcome. */
Signature · 1 line
2.43.5
Paul Moore
maintainerRe: [PATCH v1 2/2] audit: record AUDIT_ANOM_* events regardless of presence of rules
Quoted 18 lines · On Mar 5, 2025 Richard Guy Briggs <[email protected]> wrote:
When no audit rules are in place, AUDIT_ANOM_{LINK,CREAT} events reported in
audit_log_path_denied()are unconditionally dropped due to an explicit check for the existence of any audit rules. Given this is a report of a security violation, allow it to be recorded regardless of the existence of any audit rules.To test,
mkdir -p/root/tmp
chmod 1777/root/tmp
touch/root/tmp/test.txt
useradd test
chown test/root/tmp/test.txt
{echo C0644 12 test.txt; printf 'hello\ntest1\n'; printf \\000;} | \
scp -t/root/tmp
Check with
ausearch -mANOM_CREAT-ts recent
Quoted 5 lines
--- kernel/audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Looks okay to me, merged into audit/dev, thanks!
Quoted 15 lines
kernel/audit.c +1
-1@@ -2285,7 +2285,7 @@ void audit_log_path_denied(int type, const char *operation) {struct audit_buffer *ab; -if (!audit_enabled ||audit_dummy_context ()) +if (!audit_enabled)return ;/* Generate log with subject, operation, outcome. */ Signature · 1 line
2.43.5
--
paul-moore.com