staging: bcm2835-camera: Modify function call formatting
Subsystems (3)
PATCH 1/1 staging: bcm2835-camera: Modify function call formatting
The line is a function call which ends with an opening parenthesis thereby not adhering to the Linux kernel coding style.
Modify the function call to include parameters on the same line as the opening parenthesis to improve readability and consistency while adhering to Linux coding styles.
Reported by checkpatch:
CHECK: Lines should not end with '('
--- .../vc04_services/bcm2835-camera/controls.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
drivers/staging/vc04_services/bcm2835-camera/controls.c +6 -8
@@ -533,17 +533,15 @@ static int ctrl_set_image_effect(struct bcm2835_mmal_dev *dev, control = &dev->component[COMP_CAMERA ]->control; - ret =vchiq_mmal_port_parameter_set ( - dev->instance, control, -MMAL_PARAMETER_IMAGE_EFFECT_PARAMETERS , - &imagefx,sizeof (imagefx)); + ret =vchiq_mmal_port_parameter_set (dev->instance, control, +MMAL_PARAMETER_IMAGE_EFFECT_PARAMETERS , + &imagefx,sizeof (imagefx));if (ret) goto exit; - ret =vchiq_mmal_port_parameter_set ( - dev->instance, control, -MMAL_PARAMETER_COLOUR_EFFECT , - &dev->colourfx,sizeof (dev->colourfx)); + ret =vchiq_mmal_port_parameter_set (dev->instance, control, +MMAL_PARAMETER_COLOUR_EFFECT , + &dev->colourfx,sizeof (dev->colourfx)); } exit:
Signature · 1 line
2.34.1
Quoted 10 lines · Abraham Samuel Adekunle
The line is a function call which ends with an opening parenthesis thereby not adhering to the Linux kernel coding style.
Modify the function call to include parameters on the same line as the opening parenthesis to improve readability and consistency while adhering to Linux coding styles.
Reported by checkpatch:
CHECK: Lines should not end with '('
Please check the get_maintainer script (see tutorial). It looks like there are some other people who should receive patches on this driver.
julia
Quoted 38 lines
Signed-off-by Abraham Samuel Adekunle <[email protected]>--- .../vc04_services/bcm2835-camera/controls.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)drivers/staging/vc04_services/bcm2835-camera/controls.c +6
-9@@ -533,17 +533,15 @@ static int ctrl_set_image_effect(struct bcm2835_mmal_dev *dev, control = &dev->component[COMP_CAMERA ]->control; - ret =vchiq_mmal_port_parameter_set ( - dev->instance, control, -MMAL_PARAMETER_IMAGE_EFFECT_PARAMETERS , - &imagefx,sizeof (imagefx)); + ret =vchiq_mmal_port_parameter_set (dev->instance, control, +MMAL_PARAMETER_IMAGE_EFFECT_PARAMETERS , + &imagefx,sizeof (imagefx));if (ret) goto exit; - ret =vchiq_mmal_port_parameter_set ( - dev->instance, control, -MMAL_PARAMETER_COLOUR_EFFECT , - &dev->colourfx,sizeof (dev->colourfx)); + ret =vchiq_mmal_port_parameter_set (dev->instance, control, +MMAL_PARAMETER_COLOUR_EFFECT , + &dev->colourfx,sizeof (dev->colourfx)); } exit: --2.34.1
Quoted 12 lines · Julia Lawall
Quoted 7 lines · Abraham Samuel Adekunle
The line is a function call which ends with an opening parenthesis thereby not adhering to the Linux kernel coding style.
Modify the function call to include parameters on the same line as the opening parenthesis to improve readability and consistency while adhering to Linux coding styles.
Quoted 9 lines
Quoted 3 lines
Reported by checkpatch:
CHECK: Lines should not end with '('
Please check the
get_maintainerscript (see tutorial). It looks like there are some other people who should receive patches on this driver.julia
Thank you very much for your review.
Please just to be sure, do I include the emails of the people I initially sent the patch to or
I should only send the patch again to the other people I did not include initially?
Adekunle.
Quoted 20 lines · Samuel Abraham
Quoted 19 lines · Julia Lawall
Quoted 10 lines · Abraham Samuel Adekunle
The line is a function call which ends with an opening parenthesis thereby not adhering to the Linux kernel coding style.
Modify the function call to include parameters on the same line as the opening parenthesis to improve readability and consistency while adhering to Linux coding styles.
Reported by checkpatch:
CHECK: Lines should not end with '('
Please check the
get_maintainerscript (see tutorial). It looks like there are some other people who should receive patches on this driver.
Quoted 8 lines
Quoted 2 lines
julia
Thank you very much for your review.
Please just to be sure, do I include the emails of the people I initially sent the patch to or
I should only send the patch again to the other people I did not include initially?
Send it toeveryone (ald recipients and new ones). You should write [PATCH v2] instead of [PATCH]. Below the --- you can write v2: and an explanation of what has changed, ie adding more recipients.
julia