arm64: dts: qcom: x1e001de-devkit: fix USB retimer reset polarity
PATCH 1/1 arm64: dts: qcom: x1e001de-devkit: fix USB retimer reset polarity
The ps8830 retimer reset is active low.
Fix up the retimer nodes which were based on an early version of the driver which inverted the polarity.
--- arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/qcom/x1e001de-devkit.dts +3 -3
@@ -788,7 +788,7 @@ typec-mux@8 { vddat-supply = <&vreg_rtmr2_1p15>; vddio-supply = <&vreg_rtmr2_1p8>; - reset-gpios = <&tlmm 185 GPIO_ACTIVE_HIGH>; + reset-gpios = <&tlmm 185 GPIO_ACTIVE_LOW>; orientation-switch; retimer-switch;
@@ -843,7 +843,7 @@ typec-mux@8 { vddat-supply = <&vreg_rtmr0_1p15>; vddio-supply = <&vreg_rtmr0_1p8>; - reset-gpios = <&pm8550_gpios 10 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pm8550_gpios 10 GPIO_ACTIVE_LOW>; retimer-switch; orientation-switch;
@@ -898,7 +898,7 @@ typec-mux@8 { vddat-supply = <&vreg_rtmr1_1p15>; vddio-supply = <&vreg_rtmr1_1p8>; - reset-gpios = <&tlmm 176 GPIO_ACTIVE_HIGH>; + reset-gpios = <&tlmm 176 GPIO_ACTIVE_LOW>; retimer-switch; orientation-switch;
Signature · 1 line
2.48.1
Quoted 9 lines · Johan Hovold
The ps8830 retimer reset is active low.
Fix up the retimer nodes which were based on an early version of the driver which inverted the polarity.
Fixes 019e1ee32fec ("arm64: dts: qcom: x1e001de-devkit: Enable external DP support")Cc Sibi Sankar <[email protected]>Signed-off-by Johan Hovold <[email protected]>---
Konrad
Quoted 8 lines · Johan Hovold
The ps8830 retimer reset is active low.
Fix up the retimer nodes which were based on an early version of the driver which inverted the polarity.
Fixes 019e1ee32fec ("arm64: dts: qcom: x1e001de-devkit: Enable external DP support")Cc Sibi Sankar <[email protected]>Signed-off-by Johan Hovold <[email protected]>
Quoted 38 lines
--- arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm64/boot/dts/qcom/x1e001de-devkit.dts +3
-3@@ -788,7 +788,7 @@ typec-mux@8 { vddat-supply = <&vreg_rtmr2_1p15>; vddio-supply = <&vreg_rtmr2_1p8>; - reset-gpios = <&tlmm 185 GPIO_ACTIVE_HIGH>; + reset-gpios = <&tlmm 185 GPIO_ACTIVE_LOW>; orientation-switch; retimer-switch;@@ -843,7 +843,7 @@ typec-mux@8 { vddat-supply = <&vreg_rtmr0_1p15>; vddio-supply = <&vreg_rtmr0_1p8>; - reset-gpios = <&pm8550_gpios 10 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pm8550_gpios 10 GPIO_ACTIVE_LOW>; retimer-switch; orientation-switch;@@ -898,7 +898,7 @@ typec-mux@8 { vddat-supply = <&vreg_rtmr1_1p15>; vddio-supply = <&vreg_rtmr1_1p8>; - reset-gpios = <&tlmm 176 GPIO_ACTIVE_HIGH>; + reset-gpios = <&tlmm 176 GPIO_ACTIVE_LOW>; retimer-switch; orientation-switch;Signature · 1 line
2.48.1
Quoted 6 lines · Johan Hovold
The ps8830 retimer reset is active low.
Fix up the retimer nodes which were based on an early version of the driver which inverted the polarity.
Applied, thanks!
[1/1] arm64: dts: qcom: x1e001de-devkit: fix USB retimer reset polarity
commit: 1a7646d784513dcf0e8b16c1d9124ef54b4ec5e0
Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>