Skip to contentSkip to conversation

staging: r8188eu: delete driver

PATCH In review Greg Kroah-Hartman 10 participants 12 messages Mar 8, 2023 – Mar 20, 2023 Staging

lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

PATCH 1/1 staging: r8188eu: delete driver

Now that the same hardware that the r8188eu driver supported is supported by the real wireless driver rtl8xxxu, the r8188eu driver can be deleted.

Also the rtl8xxxu driver supports way more devices, and is a fraction of the overall size, making this a much better overall solution.

Thanks to the r8188eu developers and maintainers and reviewers over the years, your work allowed Linux users to use their hardware before the real driver was implemented properly.

Cc Martin Kaiser <[email protected]>
Cc Larry Finger <[email protected]>
Cc Phillip Potter <[email protected]>
Cc Pavel Skripkin <[email protected]>
---
 MAINTAINERS                                   |    7 -
 drivers/staging/Kconfig                       |    2 -
 drivers/staging/Makefile                      |    1 -
 drivers/staging/r8188eu/Kconfig               |   16 -
 drivers/staging/r8188eu/Makefile              |   48 -
 drivers/staging/r8188eu/TODO                  |   16 -
 drivers/staging/r8188eu/core/rtw_ap.c         | 1181 ---
 drivers/staging/r8188eu/core/rtw_br_ext.c     |  658 --
 drivers/staging/r8188eu/core/rtw_cmd.c        | 1529 ----
 drivers/staging/r8188eu/core/rtw_efuse.c      |   74 -
 drivers/staging/r8188eu/core/rtw_fw.c         |  335 -
 drivers/staging/r8188eu/core/rtw_ieee80211.c  | 1150 ---
 drivers/staging/r8188eu/core/rtw_ioctl_set.c  |  479 -
 drivers/staging/r8188eu/core/rtw_iol.c        |  160 -
 drivers/staging/r8188eu/core/rtw_led.c        |  255 -
 drivers/staging/r8188eu/core/rtw_mlme.c       | 2067 -----
 drivers/staging/r8188eu/core/rtw_mlme_ext.c   | 7817 -----------------
 drivers/staging/r8188eu/core/rtw_p2p.c        | 1918 ----
 drivers/staging/r8188eu/core/rtw_pwrctrl.c    |  445 -
 drivers/staging/r8188eu/core/rtw_recv.c       | 2010 -----
 drivers/staging/r8188eu/core/rtw_rf.c         |   29 -
 drivers/staging/r8188eu/core/rtw_security.c   | 1374 ---
 drivers/staging/r8188eu/core/rtw_sta_mgt.c    |  490 --
 drivers/staging/r8188eu/core/rtw_wlan_util.c  | 1551 ----
 drivers/staging/r8188eu/core/rtw_xmit.c       | 2179 -----
 .../r8188eu/hal/Hal8188ERateAdaptive.c        |  654 --
 .../staging/r8188eu/hal/HalHWImg8188E_BB.c    |  733 --
 .../staging/r8188eu/hal/HalHWImg8188E_MAC.c   |  212 -
 .../staging/r8188eu/hal/HalHWImg8188E_RF.c    |  269 -
 drivers/staging/r8188eu/hal/HalPhyRf_8188e.c  |  900 --
 drivers/staging/r8188eu/hal/HalPwrSeqCmd.c    |  149 -
 drivers/staging/r8188eu/hal/hal_com.c         |  139 -
 drivers/staging/r8188eu/hal/hal_intf.c        |   50 -
 drivers/staging/r8188eu/hal/odm.c             |  821 --
 drivers/staging/r8188eu/hal/odm_HWConfig.c    |  349 -
 drivers/staging/r8188eu/hal/odm_RTL8188E.c    |  264 -
 drivers/staging/r8188eu/hal/rtl8188e_cmd.c    |  694 --
 drivers/staging/r8188eu/hal/rtl8188e_dm.c     |  146 -
 .../staging/r8188eu/hal/rtl8188e_hal_init.c   |  922 --
 drivers/staging/r8188eu/hal/rtl8188e_phycfg.c |  705 --
 drivers/staging/r8188eu/hal/rtl8188e_rf6052.c |  405 -
 drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c |  161 -
 drivers/staging/r8188eu/hal/rtl8188eu_xmit.c  |  627 --
 drivers/staging/r8188eu/hal/usb_halinit.c     | 1069 ---
 drivers/staging/r8188eu/hal/usb_ops_linux.c   |  476 -
 .../staging/r8188eu/include/Hal8188EPhyCfg.h  |   97 -
 .../staging/r8188eu/include/Hal8188EPhyReg.h  | 1072 ---
 .../r8188eu/include/Hal8188ERateAdaptive.h    |   49 -
 .../r8188eu/include/HalHWImg8188E_BB.h        |   27 -
 .../r8188eu/include/HalHWImg8188E_MAC.h       |   12 -
 .../r8188eu/include/HalHWImg8188E_RF.h        |   13 -
 .../staging/r8188eu/include/HalPhyRf_8188e.h  |   36 -
 .../staging/r8188eu/include/HalPwrSeqCmd.h    |   18 -
 drivers/staging/r8188eu/include/HalVerDef.h   |   42 -
 drivers/staging/r8188eu/include/drv_types.h   |  224 -
 drivers/staging/r8188eu/include/hal_com.h     |  146 -
 drivers/staging/r8188eu/include/hal_intf.h    |   44 -
 drivers/staging/r8188eu/include/ieee80211.h   |  817 --
 drivers/staging/r8188eu/include/odm.h         |  416 -
 .../staging/r8188eu/include/odm_HWConfig.h    |   69 -
 .../staging/r8188eu/include/odm_RTL8188E.h    |   35 -
 .../r8188eu/include/odm_RegDefine11N.h        |   47 -
 drivers/staging/r8188eu/include/osdep_intf.h  |   30 -
 .../staging/r8188eu/include/osdep_service.h   |  153 -
 .../staging/r8188eu/include/rtl8188e_cmd.h    |   90 -
 drivers/staging/r8188eu/include/rtl8188e_dm.h |   28 -
 .../staging/r8188eu/include/rtl8188e_hal.h    |  181 -
 .../staging/r8188eu/include/rtl8188e_recv.h   |   40 -
 drivers/staging/r8188eu/include/rtl8188e_rf.h |   18 -
 .../staging/r8188eu/include/rtl8188e_spec.h   | 1142 ---
 .../staging/r8188eu/include/rtl8188e_xmit.h   |  130 -
 drivers/staging/r8188eu/include/rtw_ap.h      |   34 -
 drivers/staging/r8188eu/include/rtw_br_ext.h  |   43 -
 drivers/staging/r8188eu/include/rtw_cmd.h     |  925 --
 drivers/staging/r8188eu/include/rtw_eeprom.h  |   15 -
 drivers/staging/r8188eu/include/rtw_efuse.h   |   11 -
 drivers/staging/r8188eu/include/rtw_event.h   |   97 -
 drivers/staging/r8188eu/include/rtw_fw.h      |   17 -
 drivers/staging/r8188eu/include/rtw_ht.h      |   28 -
 drivers/staging/r8188eu/include/rtw_io.h      |   33 -
 drivers/staging/r8188eu/include/rtw_ioctl.h   |   13 -
 .../staging/r8188eu/include/rtw_ioctl_set.h   |   25 -
 drivers/staging/r8188eu/include/rtw_iol.h     |   55 -
 drivers/staging/r8188eu/include/rtw_led.h     |   57 -
 drivers/staging/r8188eu/include/rtw_mlme.h    |  574 --
 .../staging/r8188eu/include/rtw_mlme_ext.h    |  753 --
 drivers/staging/r8188eu/include/rtw_p2p.h     |  118 -
 drivers/staging/r8188eu/include/rtw_pwrctrl.h |  111 -
 drivers/staging/r8188eu/include/rtw_recv.h    |  347 -
 drivers/staging/r8188eu/include/rtw_rf.h      |   80 -
 .../staging/r8188eu/include/rtw_security.h    |  231 -
 drivers/staging/r8188eu/include/rtw_xmit.h    |  334 -
 drivers/staging/r8188eu/include/sta_info.h    |  313 -
 drivers/staging/r8188eu/include/usb_ops.h     |   57 -
 drivers/staging/r8188eu/include/usb_osintf.h  |   21 -
 drivers/staging/r8188eu/include/wifi.h        |  773 --
 drivers/staging/r8188eu/include/wlan_bssdef.h |  272 -
 drivers/staging/r8188eu/os_dep/ioctl_linux.c  | 3775 --------
 drivers/staging/r8188eu/os_dep/os_intfs.c     |  807 --
 .../staging/r8188eu/os_dep/osdep_service.c    |  227 -
 drivers/staging/r8188eu/os_dep/usb_intf.c     |  445 -
 .../staging/r8188eu/os_dep/usb_ops_linux.c    |  136 -
 102 files changed, 51239 deletions(-)
 delete mode 100644 drivers/staging/r8188eu/Kconfig
 delete mode 100644 drivers/staging/r8188eu/Makefile
 delete mode 100644 drivers/staging/r8188eu/TODO
 delete mode 100644 drivers/staging/r8188eu/core/rtw_ap.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_br_ext.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_cmd.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_efuse.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_fw.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_ieee80211.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_ioctl_set.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_iol.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_led.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_mlme.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_mlme_ext.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_p2p.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_pwrctrl.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_recv.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_rf.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_security.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_sta_mgt.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_wlan_util.c
 delete mode 100644 drivers/staging/r8188eu/core/rtw_xmit.c
 delete mode 100644 drivers/staging/r8188eu/hal/Hal8188ERateAdaptive.c
 delete mode 100644 drivers/staging/r8188eu/hal/HalHWImg8188E_BB.c
 delete mode 100644 drivers/staging/r8188eu/hal/HalHWImg8188E_MAC.c
 delete mode 100644 drivers/staging/r8188eu/hal/HalHWImg8188E_RF.c
 delete mode 100644 drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
 delete mode 100644 drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
 delete mode 100644 drivers/staging/r8188eu/hal/hal_com.c
 delete mode 100644 drivers/staging/r8188eu/hal/hal_intf.c
 delete mode 100644 drivers/staging/r8188eu/hal/odm.c
 delete mode 100644 drivers/staging/r8188eu/hal/odm_HWConfig.c
 delete mode 100644 drivers/staging/r8188eu/hal/odm_RTL8188E.c
 delete mode 100644 drivers/staging/r8188eu/hal/rtl8188e_cmd.c
 delete mode 100644 drivers/staging/r8188eu/hal/rtl8188e_dm.c
 delete mode 100644 drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
 delete mode 100644 drivers/staging/r8188eu/hal/rtl8188e_phycfg.c
 delete mode 100644 drivers/staging/r8188eu/hal/rtl8188e_rf6052.c
 delete mode 100644 drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c
 delete mode 100644 drivers/staging/r8188eu/hal/rtl8188eu_xmit.c
 delete mode 100644 drivers/staging/r8188eu/hal/usb_halinit.c
 delete mode 100644 drivers/staging/r8188eu/hal/usb_ops_linux.c
 delete mode 100644 drivers/staging/r8188eu/include/Hal8188EPhyCfg.h
 delete mode 100644 drivers/staging/r8188eu/include/Hal8188EPhyReg.h
 delete mode 100644 drivers/staging/r8188eu/include/Hal8188ERateAdaptive.h
 delete mode 100644 drivers/staging/r8188eu/include/HalHWImg8188E_BB.h
 delete mode 100644 drivers/staging/r8188eu/include/HalHWImg8188E_MAC.h
 delete mode 100644 drivers/staging/r8188eu/include/HalHWImg8188E_RF.h
 delete mode 100644 drivers/staging/r8188eu/include/HalPhyRf_8188e.h
 delete mode 100644 drivers/staging/r8188eu/include/HalPwrSeqCmd.h
 delete mode 100644 drivers/staging/r8188eu/include/HalVerDef.h
 delete mode 100644 drivers/staging/r8188eu/include/drv_types.h
 delete mode 100644 drivers/staging/r8188eu/include/hal_com.h
 delete mode 100644 drivers/staging/r8188eu/include/hal_intf.h
 delete mode 100644 drivers/staging/r8188eu/include/ieee80211.h
 delete mode 100644 drivers/staging/r8188eu/include/odm.h
 delete mode 100644 drivers/staging/r8188eu/include/odm_HWConfig.h
 delete mode 100644 drivers/staging/r8188eu/include/odm_RTL8188E.h
 delete mode 100644 drivers/staging/r8188eu/include/odm_RegDefine11N.h
 delete mode 100644 drivers/staging/r8188eu/include/osdep_intf.h
 delete mode 100644 drivers/staging/r8188eu/include/osdep_service.h
 delete mode 100644 drivers/staging/r8188eu/include/rtl8188e_cmd.h
 delete mode 100644 drivers/staging/r8188eu/include/rtl8188e_dm.h
 delete mode 100644 drivers/staging/r8188eu/include/rtl8188e_hal.h
 delete mode 100644 drivers/staging/r8188eu/include/rtl8188e_recv.h
 delete mode 100644 drivers/staging/r8188eu/include/rtl8188e_rf.h
 delete mode 100644 drivers/staging/r8188eu/include/rtl8188e_spec.h
 delete mode 100644 drivers/staging/r8188eu/include/rtl8188e_xmit.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_ap.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_br_ext.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_cmd.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_eeprom.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_efuse.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_event.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_fw.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_ht.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_io.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_ioctl.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_ioctl_set.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_iol.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_led.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_mlme.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_mlme_ext.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_p2p.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_pwrctrl.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_recv.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_rf.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_security.h
 delete mode 100644 drivers/staging/r8188eu/include/rtw_xmit.h
 delete mode 100644 drivers/staging/r8188eu/include/sta_info.h
 delete mode 100644 drivers/staging/r8188eu/include/usb_ops.h
 delete mode 100644 drivers/staging/r8188eu/include/usb_osintf.h
 delete mode 100644 drivers/staging/r8188eu/include/wifi.h
 delete mode 100644 drivers/staging/r8188eu/include/wlan_bssdef.h
 delete mode 100644 drivers/staging/r8188eu/os_dep/ioctl_linux.c
 delete mode 100644 drivers/staging/r8188eu/os_dep/os_intfs.c
 delete mode 100644 drivers/staging/r8188eu/os_dep/osdep_service.c
 delete mode 100644 drivers/staging/r8188eu/os_dep/usb_intf.c
 delete mode 100644 drivers/staging/r8188eu/os_dep/usb_ops_linux.c
MAINTAINERS +0 -7
index 8d5bc223f305..93c5fa40c772 100644
@@ -19863,13 +19863,6 @@ S:	Maintained
 W:	http://wiki.laptop.org/go/DCON
 F:	drivers/staging/olpc_dcon/
 
-STAGING - REALTEK RTL8188EU DRIVERS
-M:	Larry Finger <[email protected]>
-M:	Phillip Potter <[email protected]>
-R:	Pavel Skripkin <[email protected]>
-S:	Supported
-F:	drivers/staging/r8188eu/
-
 STAGING - REALTEK RTL8712U DRIVERS
 M:	Larry Finger <[email protected]>
 M:	Florian Schilhabel <[email protected]>.
drivers/staging/Kconfig +0 -2
index 5cfabd5376cc..f9aef39cac2e 100644
@@ -36,8 +36,6 @@ source "drivers/staging/rtl8723bs/Kconfig"
 
 source "drivers/staging/rtl8712/Kconfig"
 
-source "drivers/staging/r8188eu/Kconfig"
-
 source "drivers/staging/rts5208/Kconfig"
 
 source "drivers/staging/octeon/Kconfig"
drivers/staging/Makefile +0 -1
index f8c3aa9c2418..ffa70dda481d 100644
@@ -8,7 +8,6 @@ obj-$(CONFIG_RTL8192U)		+= rtl8192u/
 obj-$(CONFIG_RTL8192E)		+= rtl8192e/
 obj-$(CONFIG_RTL8723BS)		+= rtl8723bs/
 obj-$(CONFIG_R8712U)		+= rtl8712/
-obj-$(CONFIG_R8188EU)		+= r8188eu/
 obj-$(CONFIG_RTS5208)		+= rts5208/
 obj-$(CONFIG_OCTEON_ETHERNET)	+= octeon/
 obj-$(CONFIG_VT6655)		+= vt6655/
drivers/staging/r8188eu/Kconfig deleted +0 -16
deleted file mode 100644
index f5fe423530f0..000000000000
@@ -1,16 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-config R8188EU
-	tristate "Realtek RTL8188EU Wireless LAN NIC driver"
-	depends on WLAN && USB && CFG80211
-	depends on m
-	select WIRELESS_EXT
-	select WEXT_PRIV
-	select LIB80211
-	select LIB80211_CRYPT_WEP
-	select LIB80211_CRYPT_CCMP
-	help
-	This option adds support for the Realtek RTL8188EU chipset, used in USB
-	devices such as the ASUS USB-N10 Nano. This newer driver is based on GitHub
-	sources for version v4.1.4_6773.20130222, and contains modifications for
-	newer kernel features. If built as a module, it will be called r8188eu.
-
drivers/staging/r8188eu/Makefile deleted +0 -48

48 lines not on this page · raw message

drivers/staging/r8188eu/TODO deleted +0 -16
deleted file mode 100644
index ab9d5d145b3b..000000000000
@@ -1,16 +0,0 @@
-To-do list:
-
-* Correct the coding style according to Linux guidelines; please read the document
-  at https://www.kernel.org/doc/html/latest/process/coding-style.html.
-* Remove unnecessary debugging/printing macros; for those that are still needed
-  use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()).
-* Remove dead code such as unusued functions, variables, fields, etc..
-* Use in-kernel API and remove unnecessary wrappers where possible.
-* Fix bugs due to code that sleeps in atomic context.
-* Remove the HAL layer and migrate its functionality into the relevant parts of
-  the driver.
-* Switch to use LIB80211.
-* Switch to use MAC80211.
-* Switch to use CFG80211.
-* Improve the error handling of various functions, particularly those that use
-  existing kernel APIs.
drivers/staging/r8188eu/core/rtw_ap.c deleted +0 -1181

1,181 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_br_ext.c deleted +0 -658

658 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_cmd.c deleted +0 -1529

1,053 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_efuse.c deleted +0 -74

74 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_fw.c deleted +0 -335

335 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_ieee80211.c deleted +0 -1150

1,150 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_ioctl_set.c deleted +0 -479

479 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_iol.c deleted +0 -160

160 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_led.c deleted +0 -255

255 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_mlme.c deleted +0 -2067

2,067 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_mlme_ext.c deleted +0 -7817

7,817 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_p2p.c deleted +0 -1918

1,918 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_pwrctrl.c deleted +0 -445

445 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_recv.c deleted +0 -2010

2,010 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_rf.c deleted +0 -29
deleted file mode 100644
index 2d2f0fc4c942..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/core/rtw_security.c deleted +0 -1374

1,374 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_sta_mgt.c deleted +0 -490

490 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_wlan_util.c deleted +0 -1551

1,551 lines not on this page · raw message

drivers/staging/r8188eu/core/rtw_xmit.c deleted +0 -2179

2,179 lines not on this page · raw message

drivers/staging/r8188eu/hal/Hal8188ERateAdaptive.c deleted +0 -654

654 lines not on this page · raw message

drivers/staging/r8188eu/hal/HalHWImg8188E_BB.c deleted +0 -733

733 lines not on this page · raw message

drivers/staging/r8188eu/hal/HalHWImg8188E_MAC.c deleted +0 -212

212 lines not on this page · raw message

drivers/staging/r8188eu/hal/HalHWImg8188E_RF.c deleted +0 -269

269 lines not on this page · raw message

drivers/staging/r8188eu/hal/HalPhyRf_8188e.c deleted +0 -900

900 lines not on this page · raw message

drivers/staging/r8188eu/hal/HalPwrSeqCmd.c deleted +0 -149

149 lines not on this page · raw message

drivers/staging/r8188eu/hal/hal_com.c deleted +0 -139

139 lines not on this page · raw message

drivers/staging/r8188eu/hal/hal_intf.c deleted +0 -50

50 lines not on this page · raw message

drivers/staging/r8188eu/hal/odm.c deleted +0 -821

821 lines not on this page · raw message

drivers/staging/r8188eu/hal/odm_HWConfig.c deleted +0 -349

349 lines not on this page · raw message

drivers/staging/r8188eu/hal/odm_RTL8188E.c deleted +0 -264

264 lines not on this page · raw message

drivers/staging/r8188eu/hal/rtl8188e_cmd.c deleted +0 -694

694 lines not on this page · raw message

drivers/staging/r8188eu/hal/rtl8188e_dm.c deleted +0 -146

146 lines not on this page · raw message

drivers/staging/r8188eu/hal/rtl8188e_hal_init.c deleted +0 -922

922 lines not on this page · raw message

drivers/staging/r8188eu/hal/rtl8188e_phycfg.c deleted +0 -705

705 lines not on this page · raw message

drivers/staging/r8188eu/hal/rtl8188e_rf6052.c deleted +0 -405

405 lines not on this page · raw message

drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c deleted +0 -161

161 lines not on this page · raw message

drivers/staging/r8188eu/hal/rtl8188eu_xmit.c deleted +0 -627

627 lines not on this page · raw message

drivers/staging/r8188eu/hal/usb_halinit.c deleted +0 -1069

1,069 lines not on this page · raw message

drivers/staging/r8188eu/hal/usb_ops_linux.c deleted +0 -476

476 lines not on this page · raw message

drivers/staging/r8188eu/include/Hal8188EPhyCfg.h deleted +0 -97

97 lines not on this page · raw message

drivers/staging/r8188eu/include/Hal8188EPhyReg.h deleted +0 -1072

1,072 lines not on this page · raw message

drivers/staging/r8188eu/include/Hal8188ERateAdaptive.h deleted +0 -49

49 lines not on this page · raw message

drivers/staging/r8188eu/include/HalHWImg8188E_BB.h deleted +0 -27
deleted file mode 100644
index 0a290bc31c4d..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/HalHWImg8188E_MAC.h deleted +0 -12
deleted file mode 100644
index b3d67c1a8050..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/HalHWImg8188E_RF.h deleted +0 -13
deleted file mode 100644
index 880feadb4340..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/HalPhyRf_8188e.h deleted +0 -36
deleted file mode 100644
index b75a5d869c56..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/HalPwrSeqCmd.h deleted +0 -18
deleted file mode 100644
index 0886300d26bf..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/HalVerDef.h deleted +0 -42

42 lines not on this page · raw message

drivers/staging/r8188eu/include/drv_types.h deleted +0 -224

224 lines not on this page · raw message

drivers/staging/r8188eu/include/hal_com.h deleted +0 -146

146 lines not on this page · raw message

drivers/staging/r8188eu/include/hal_intf.h deleted +0 -44

44 lines not on this page · raw message

drivers/staging/r8188eu/include/ieee80211.h deleted +0 -817

817 lines not on this page · raw message

drivers/staging/r8188eu/include/odm.h deleted +0 -416

416 lines not on this page · raw message

drivers/staging/r8188eu/include/odm_HWConfig.h deleted +0 -69

69 lines not on this page · raw message

drivers/staging/r8188eu/include/odm_RTL8188E.h deleted +0 -35
deleted file mode 100644
index 4f16af248591..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/odm_RegDefine11N.h deleted +0 -47

47 lines not on this page · raw message

drivers/staging/r8188eu/include/osdep_intf.h deleted +0 -30
deleted file mode 100644
index 457fb3852a19..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/osdep_service.h deleted +0 -153

153 lines not on this page · raw message

drivers/staging/r8188eu/include/rtl8188e_cmd.h deleted +0 -90

90 lines not on this page · raw message

drivers/staging/r8188eu/include/rtl8188e_dm.h deleted +0 -28
deleted file mode 100644
index d62cdfc2db20..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/rtl8188e_hal.h deleted +0 -181

181 lines not on this page · raw message

drivers/staging/r8188eu/include/rtl8188e_recv.h deleted +0 -40
deleted file mode 100644
index dc4f358f646d..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/rtl8188e_rf.h deleted +0 -18
deleted file mode 100644
index 63ac0acc68fd..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/rtl8188e_spec.h deleted +0 -1142

1,142 lines not on this page · raw message

drivers/staging/r8188eu/include/rtl8188e_xmit.h deleted +0 -130

130 lines not on this page · raw message

drivers/staging/r8188eu/include/rtw_ap.h deleted +0 -34
deleted file mode 100644
index 89b02c97e041..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/rtw_br_ext.h deleted +0 -43

43 lines not on this page · raw message

drivers/staging/r8188eu/include/rtw_cmd.h deleted +0 -925

925 lines not on this page · raw message

drivers/staging/r8188eu/include/rtw_eeprom.h deleted +0 -15
deleted file mode 100644
index 94d735b1d0db..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/rtw_efuse.h deleted +0 -11
deleted file mode 100644
index 3d688a0e6dfb..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/rtw_event.h deleted +0 -97

97 lines not on this page · raw message

drivers/staging/r8188eu/include/rtw_fw.h deleted +0 -17
deleted file mode 100644
index 8f74157ee9ac..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/rtw_ht.h deleted +0 -28
deleted file mode 100644
index 2b56b7c38c86..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/rtw_io.h deleted +0 -33
deleted file mode 100644
index e1718f739cc9..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/rtw_ioctl.h deleted +0 -13
deleted file mode 100644
index c704f3040ac8..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/rtw_ioctl_set.h deleted +0 -25
deleted file mode 100644
index c3eb2479f27b..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/rtw_iol.h deleted +0 -55

55 lines not on this page · raw message

drivers/staging/r8188eu/include/rtw_led.h deleted +0 -57

57 lines not on this page · raw message

drivers/staging/r8188eu/include/rtw_mlme.h deleted +0 -574

574 lines not on this page · raw message

drivers/staging/r8188eu/include/rtw_mlme_ext.h deleted +0 -753

753 lines not on this page · raw message

drivers/staging/r8188eu/include/rtw_p2p.h deleted +0 -118

118 lines not on this page · raw message

drivers/staging/r8188eu/include/rtw_pwrctrl.h deleted +0 -111

111 lines not on this page · raw message

drivers/staging/r8188eu/include/rtw_recv.h deleted +0 -347

347 lines not on this page · raw message

drivers/staging/r8188eu/include/rtw_rf.h deleted +0 -80

80 lines not on this page · raw message

drivers/staging/r8188eu/include/rtw_security.h deleted +0 -231

231 lines not on this page · raw message

drivers/staging/r8188eu/include/rtw_xmit.h deleted +0 -334

334 lines not on this page · raw message

drivers/staging/r8188eu/include/sta_info.h deleted +0 -313

313 lines not on this page · raw message

drivers/staging/r8188eu/include/usb_ops.h deleted +0 -57

57 lines not on this page · raw message

drivers/staging/r8188eu/include/usb_osintf.h deleted +0 -21
deleted file mode 100644
index f271e93e9ab9..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/r8188eu/include/wifi.h deleted +0 -773

773 lines not on this page · raw message

drivers/staging/r8188eu/include/wlan_bssdef.h deleted +0 -272

272 lines not on this page · raw message

drivers/staging/r8188eu/os_dep/ioctl_linux.c deleted +0 -3775

3,775 lines not on this page · raw message

drivers/staging/r8188eu/os_dep/os_intfs.c deleted +0 -807

807 lines not on this page · raw message

drivers/staging/r8188eu/os_dep/osdep_service.c deleted +0 -227

227 lines not on this page · raw message

drivers/staging/r8188eu/os_dep/usb_intf.c deleted +0 -445

445 lines not on this page · raw message

drivers/staging/r8188eu/os_dep/usb_ops_linux.c deleted +0 -136

136 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.39.2

Part of the diff is not shown here. View the raw message.

Acked-by on v1 1/1
#1 lore raw

Hi All,

Quoted 11 lines

Now that the same hardware that the r8188eu driver supported is supported by the real wireless driver rtl8xxxu, the r8188eu driver can be deleted.

Also the rtl8xxxu driver supports way more devices, and is a fraction of the overall size, making this a much better overall solution.

Thanks to the r8188eu developers and maintainers and reviewers over the years, your work allowed Linux users to use their hardware before the real driver was implemented properly.

Quoted 6 lines
Cc Martin Kaiser <[email protected]>
Cc Larry Finger <[email protected]>
Cc Phillip Potter <[email protected]>
Cc Pavel Skripkin <[email protected]>

Thank you for doing this, I agree that this is the best solution moving forward:

Regards,

Hans

author maintainer
#2 lore raw
Quoted 20 lines · Hans de Goede

Hi All,

Quoted 11 lines

Now that the same hardware that the r8188eu driver supported is supported by the real wireless driver rtl8xxxu, the r8188eu driver can be deleted.

Also the rtl8xxxu driver supports way more devices, and is a fraction of the overall size, making this a much better overall solution.

Thanks to the r8188eu developers and maintainers and reviewers over the years, your work allowed Linux users to use their hardware before the real driver was implemented properly.

Quoted 6 lines
Cc Martin Kaiser <[email protected]>
Cc Larry Finger <[email protected]>
Cc Phillip Potter <[email protected]>
Cc Pavel Skripkin <[email protected]>
Quoted 4 lines

Thank you for doing this, I agree that this is the best solution moving forward:

Great!

Also, to verify the "these devices are supported", I compared the list of module aliases exported by both drivers. The r8188eu is a tiny subset of the rtl8xxxu driver, with no devices listed in the r8188eu that are not in the rtl8xxxu driver.

Attached are the lists of the vendor/product USB ids for each driver as proof.

thanks,

greg k-h

v056Ep4008
v07B8p8179
v0B05p18F0
v0BDAp0179
v0BDAp8179
v0BDApFFEF
v0DF6p0076
v2001p330F
v2001p3310
v2001p3311
v2001p331B
v2357p010C
v2357p0111
v2C4Ep0102
v7392pB811

v04BBp094C
v04BBp0950
v04F2pAFF7
v04F2pAFF8
v04F2pAFF9
v04F2pAFFA
v04F2pAFFB
v04F2pAFFC
v050Dp1004
v050Dp1102
v050Dp2102
v050Dp2103
v056Ep4008
v0586p341F
v06F8pE033
v06F8pE035
v0789p016D
v07AAp0056
v07B8p8178
v07B8p8179
v07B8p8189
v0846p9021
v0846p9041
v0846pF001
v0B05p17AB
v0B05p17BA
v0B05p18F0
v0BDAp0179
v0BDAp018A
v0BDAp0724
v0BDAp1724
v0BDAp1E1E
v0BDAp2E2E
v0BDAp317F
v0BDAp5088
v0BDAp8170
v0BDAp8176
v0BDAp8177
v0BDAp8178
v0BDAp8179
v0BDAp817A
v0BDAp817B
v0BDAp817D
v0BDAp817E
v0BDAp817F
v0BDAp818A
v0BDAp818B
v0BDAp818C
v0BDAp8191
v0BDAp8724
v0BDApB720
v0BDApF179
v0BDApFFEF
v0DF6p0052
v0DF6p005C
v0DF6p0061
v0DF6p0070
v0DF6p0076
v0E66p0019
v0E66p0020
v0EB0p9071
v103Cp1629
v1058p0631
v13D3p3357
v2001p3307
v2001p3308
v2001p3309
v2001p330A
v2001p330B
v2001p330F
v2001p3310
v2001p3311
v2001p3319
v2001p331B
v2019p1201
v2019p4902
v2019pAB2A
v2019pAB2B
v2019pAB2E
v2019pAB33
v2019pED17
v20F4p624D
v20F4p648B
v2357p0100
v2357p0107
v2357p0108
v2357p0109
v2357p010C
v2357p0111
v2C4Ep0102
v4855p0090
v4855p0091
v4856p0091
v7392p7811
v7392p7822
v7392pA611
v7392pB811
vCDABp8010

Acked-by on v1 1/1
#3 lore raw
In reply to Greg Kroah-Hartman

Hi Greg,

Thus wrote Greg Kroah-Hartman ([email protected]):

Quoted 11 lines

Now that the same hardware that the r8188eu driver supported is supported by the real wireless driver rtl8xxxu, the r8188eu driver can be deleted.

Also the rtl8xxxu driver supports way more devices, and is a fraction of the overall size, making this a much better overall solution.

Thanks to the r8188eu developers and maintainers and reviewers over the years, your work allowed Linux users to use their hardware before the real driver was implemented properly.

Quoted 6 lines
Cc Martin Kaiser <[email protected]>
Cc Larry Finger <[email protected]>
Cc Phillip Potter <[email protected]>
Cc Pavel Skripkin <[email protected]>

thanks for your time and patience reviewing all the cleanups we submitted.

Best regards,

Martin

Acked-by on v1 1/1
#4 lore raw
In reply to Greg Kroah-Hartman
Quoted 11 lines · Greg Kroah-Hartman

Now that the same hardware that the r8188eu driver supported is supported by the real wireless driver rtl8xxxu, the r8188eu driver can be deleted.

Also the rtl8xxxu driver supports way more devices, and is a fraction of the overall size, making this a much better overall solution.

Thanks to the r8188eu developers and maintainers and reviewers over the years, your work allowed Linux users to use their hardware before the real driver was implemented properly.

Quoted 6 lines
Cc Martin Kaiser<[email protected]>
Cc Larry Finger<[email protected]>
Cc Phillip Potter<[email protected]>
Cc Pavel Skripkin<[email protected]>

This staging driver satisfied a need at the time it was first added to the kernel, but that time is over!

Larry

Tested-by on v1 1/1
#5 lore raw
In reply to Greg Kroah-Hartman
Quoted 11 lines · Greg Kroah-Hartman

Now that the same hardware that the r8188eu driver supported is supported by the real wireless driver rtl8xxxu, the r8188eu driver can be deleted.

Also the rtl8xxxu driver supports way more devices, and is a fraction of the overall size, making this a much better overall solution.

Thanks to the r8188eu developers and maintainers and reviewers over the years, your work allowed Linux users to use their hardware before the real driver was implemented properly.

Quoted 6 lines
Cc Martin Kaiser<[email protected]>
Cc Larry Finger<[email protected]>
Cc Phillip Potter<[email protected]>
Cc Pavel Skripkin<[email protected]>

New driver rtl8xxxu is working fine for me.
r8188eu is gone.

Thanks for your support.

Acked-by on v1 1/1
#6 lore raw
In reply to Greg Kroah-Hartman
Quoted 11 lines · Greg Kroah-Hartman

Now that the same hardware that the r8188eu driver supported is supported by the real wireless driver rtl8xxxu, the r8188eu driver can be deleted.

Also the rtl8xxxu driver supports way more devices, and is a fraction of the overall size, making this a much better overall solution.

Thanks to the r8188eu developers and maintainers and reviewers over the years, your work allowed Linux users to use their hardware before the real driver was implemented properly.

Quoted 7 lines
Cc Martin Kaiser <[email protected]>
Cc Larry Finger <[email protected]>
Cc Phillip Potter <[email protected]>
Cc Pavel Skripkin <[email protected]>

---

The rtl8xxxu driver works well for me.

Acked-by on v1 1/1
#7 lore raw
In reply to Greg Kroah-Hartman

Hi Greg,

Greg Kroah-Hartman <[email protected]> says:

Quoted 11 lines

Now that the same hardware that the r8188eu driver supported is supported by the real wireless driver rtl8xxxu, the r8188eu driver can be deleted.

Also the rtl8xxxu driver supports way more devices, and is a fraction of the overall size, making this a much better overall solution.

Thanks to the r8188eu developers and maintainers and reviewers over the years, your work allowed Linux users to use their hardware before the real driver was implemented properly.

Quoted 7 lines
Cc Martin Kaiser <[email protected]>
Cc Larry Finger <[email protected]>
Cc Phillip Potter <[email protected]>
Cc Pavel Skripkin <[email protected]>

---

I guess, I am late to the party, but if it matters

With regards,
Pavel Skripkin

#8 lore raw
Quoted 24 lines · Pavel Skripkin

Hi Greg,

Greg Kroah-Hartman <[email protected]> says:

Quoted 11 lines

Now that the same hardware that the r8188eu driver supported is supported by the real wireless driver rtl8xxxu, the r8188eu driver can be deleted.

Also the rtl8xxxu driver supports way more devices, and is a fraction of the overall size, making this a much better overall solution.

Thanks to the r8188eu developers and maintainers and reviewers over the years, your work allowed Linux users to use their hardware before the real driver was implemented properly.

Quoted 7 lines
Cc Martin Kaiser <[email protected]>
Cc Larry Finger <[email protected]>
Cc Phillip Potter <[email protected]>
Cc Pavel Skripkin <[email protected]>

---

I guess, I am late to the party, but if it matters

Quoted 7 lines

With regards,
Pavel Skripkin

Same here, won't make it into the deletion commit log entry, but:

Regards,
Phil

author maintainer
#9 lore raw
Quoted 30 lines · Phillip Potter
Quoted 29 lines · Pavel Skripkin

Hi Greg,

Greg Kroah-Hartman <[email protected]> says:

Quoted 11 lines

Now that the same hardware that the r8188eu driver supported is supported by the real wireless driver rtl8xxxu, the r8188eu driver can be deleted.

Also the rtl8xxxu driver supports way more devices, and is a fraction of the overall size, making this a much better overall solution.

Thanks to the r8188eu developers and maintainers and reviewers over the years, your work allowed Linux users to use their hardware before the real driver was implemented properly.

Quoted 7 lines
Cc Martin Kaiser <[email protected]>
Cc Larry Finger <[email protected]>
Cc Phillip Potter <[email protected]>
Cc Pavel Skripkin <[email protected]>

---

I guess, I am late to the party, but if it matters

Quoted 6 lines
Quoted 2 lines

With regards,
Pavel Skripkin

Same here, won't make it into the deletion commit log entry, but:

Thanks, the link in the commit will point to this thread for the archives, so it still does matter :)

greg k-h

#10 lore raw
Quoted 6 lines · Greg Kroah-Hartman
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Also the rtl8xxxu driver supports way more devices, and is a fraction of the overall size, making this a much better overall solution.

Thanks to the r8188eu developers and maintainers and reviewers over the years, your work allowed Linux users to use their hardware before the real driver was implemented properly.

Both r8188eu and rtl8188eu had support for access point mode but rtl8xxxu has none AFAICT.
Is there something in the pipes to have AP mode supported?

#11 lore raw
Quoted 5 lines · Richard Weinberger
Quoted 3 lines · Greg Kroah-Hartman
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Also the rtl8xxxu driver supports way more devices, and is a fraction of the overall size, making this a much better overall solution.

Quoted 7 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Thanks to the r8188eu developers and maintainers and reviewers over the years, your work allowed Linux users to use their hardware before the real driver was implemented properly.

Both r8188eu and rtl8188eu had support for access point mode but rtl8xxxu has none AFAICT.
Is there something in the pipes to have AP mode supported?

Indeed, rtl8xxxu only supports station mode. I have been thinking about adding support for AP mode at some point.