Skip to contentSkip to conversation

docs: Correct FW_JUMP_FDT_ADDR calculation example

PATCH Superseded Gabriel Somlo 2 participants 5 messages Mar 24, 2023

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 docs: Correct FW_JUMP_FDT_ADDR calculation example

When using PLATFORM=generic defaults, the kernel is loaded at FW_JUMP_ADDR, and the FDT is loaded at `FW_JUMP_FDT_ADDR.

Therefore, the maximum kernel size before FW_JUMP_FDT_ADDR must be increased is $(( FW_JUMP_FDT_ADDR - FW_JUMP_ADDR )).

The example calculation assumes rv64, and is wrong to boot (off by 0x200000). Fix it and update it for the general case.

---
 docs/firmware/fw_jump.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
docs/firmware/fw_jump.md +4 -4
index 956897e..03ddf96 100644
@@ -48,13 +48,13 @@ follows:
   ```
   ${CROSS_COMPILE}objdump -h $KERNEL_ELF | sort -k 5,5 | awk -n '/^ +[0-9]+ /\
   {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}' \
-  | (( `tail -1` > 0x2200000 )) && echo fdt overlaps kernel,\
-  increase FW_JUMP_FDT_ADDR
+  | (( `tail -1` > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) && \
+  echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR
 
   ${LLVM}objdump -h --show-lma $KERNEL_ELF | sort -k 5,5 | \
   awk -n '/^ +[0-9]+ / {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}'\
-  | (( `tail -1` > 0x2200000 )) && echo fdt overlaps kernel,\
-  increase FW_JUMP_FDT_ADDR
+  | (( `tail -1` > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) && \
+  echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR
   ```
 
 *FW_JUMP* Example
Signature · 1 line
2.39.2
#1 lore raw

PATCH v2 1/1 docs: Correct FW_JUMP_FDT_ADDR calculation example

Quoted 24 lines · Gabriel Somlo

When using PLATFORM=generic defaults, the kernel is loaded at FW_JUMP_ADDR, and the FDT is loaded at `FW_JUMP_FDT_ADDR.

Therefore, the maximum kernel size before FW_JUMP_FDT_ADDR must be increased is $(( FW_JUMP_FDT_ADDR - FW_JUMP_ADDR )).

The example calculation assumes rv64, and is wrong to boot (off by 0x200000). Fix it and update it for the general case.

---
 docs/firmware/fw_jump.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
docs/firmware/fw_jump.md +0 -2
index 956897e..03ddf96 100644
@@ -48,13 +48,13 @@ follows:
   ```
   ${CROSS_COMPILE}objdump -h $KERNEL_ELF | sort -k 5,5 | awk -n '/^ +[0-9]+ /\
   {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}' \
-  | (( `tail -1` > 0x2200000 )) && echo fdt overlaps kernel,\
-  increase FW_JUMP_FDT_ADDR

docs/firmware/fw_jump.md follows: · line 58

Quoted 10 lines
docs/firmware/fw_jump.md +4 -2
+  | (( `tail -1` > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) && \
+  echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR
 
   ${LLVM}objdump -h --show-lma $KERNEL_ELF | sort -k 5,5 | \
   awk -n '/^ +[0-9]+ / {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}'\
-  | (( `tail -1` > 0x2200000 )) && echo fdt overlaps kernel,\
-  increase FW_JUMP_FDT_ADDR
+  | (( `tail -1` > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) && \
+  echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR
   ```

nit: We can put a bit of lipstick on this pig by rewriting as

${CROSS_COMPILE}objdump -h $KERNEL_ELF | sort -k 5,5 | awk -n ' /^ +[0-9]+ / {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}' | (( tail -1 > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) &&
echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR

${LLVM}objdump -h --show-lma $KERNEL_ELF | sort -k 5,5 | awk -n ' /^ +[0-9]+ / {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}' | (( tail -1 > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) &&
echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR

which drops the unnecessary '\'s and makes the gcc and llvm versions more consistent.

Quoted 5 lines
docs/firmware/fw_jump.md +0 -0
 *FW_JUMP* Example
Signature · 1 line
2.39.2

Anyway,

Thanks,
drew

#2 lore raw

PATCH v2 1/1 docs: Correct FW_JUMP_FDT_ADDR calculation example

Quoted 43 lines · Andrew Jones
Quoted 24 lines · Gabriel Somlo

When using PLATFORM=generic defaults, the kernel is loaded at FW_JUMP_ADDR, and the FDT is loaded at `FW_JUMP_FDT_ADDR.

Therefore, the maximum kernel size before FW_JUMP_FDT_ADDR must be increased is $(( FW_JUMP_FDT_ADDR - FW_JUMP_ADDR )).

The example calculation assumes rv64, and is wrong to boot (off by 0x200000). Fix it and update it for the general case.

---
 docs/firmware/fw_jump.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
docs/firmware/fw_jump.md +0 -2
index 956897e..03ddf96 100644
@@ -48,13 +48,13 @@ follows:
   ```
   ${CROSS_COMPILE}objdump -h $KERNEL_ELF | sort -k 5,5 | awk -n '/^ +[0-9]+ /\
   {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}' \
-  | (( `tail -1` > 0x2200000 )) && echo fdt overlaps kernel,\
-  increase FW_JUMP_FDT_ADDR

docs/firmware/fw_jump.md follows: · line 58

Quoted 10 lines
docs/firmware/fw_jump.md +4 -2
+  | (( `tail -1` > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) && \
+  echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR
 
   ${LLVM}objdump -h --show-lma $KERNEL_ELF | sort -k 5,5 | \
   awk -n '/^ +[0-9]+ / {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}'\
-  | (( `tail -1` > 0x2200000 )) && echo fdt overlaps kernel,\
-  increase FW_JUMP_FDT_ADDR
+  | (( `tail -1` > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) && \
+  echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR
   ```

nit: We can put a bit of lipstick on this pig by rewriting as

${CROSS_COMPILE}objdump -h $KERNEL_ELF | sort -k 5,5 | awk -n ' /^ +[0-9]+ / {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}' | (( tail -1 > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) &&
echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR

Quoted 7 lines

${LLVM}objdump -h --show-lma $KERNEL_ELF | sort -k 5,5 | awk -n ' /^ +[0-9]+ / {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}' | (( tail -1 > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) &&
echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR

which drops the unnecessary '\'s and makes the gcc and llvm versions more consistent.

Sounds good to me -- you wanna just do that directly while applying, or should I send a v3? :)

Quoted 9 lines
Quoted 5 lines
docs/firmware/fw_jump.md +0 -0
 *FW_JUMP* Example
Signature · 1 line
2.39.2

Anyway,

Thanks,
--Gabriel

#3 lore raw

PATCH v2 1/1 docs: Correct FW_JUMP_FDT_ADDR calculation example

Quoted 49 lines · Gabriel L. Somlo
Quoted 48 lines · Andrew Jones
Quoted 24 lines · Gabriel Somlo

When using PLATFORM=generic defaults, the kernel is loaded at FW_JUMP_ADDR, and the FDT is loaded at `FW_JUMP_FDT_ADDR.

Therefore, the maximum kernel size before FW_JUMP_FDT_ADDR must be increased is $(( FW_JUMP_FDT_ADDR - FW_JUMP_ADDR )).

The example calculation assumes rv64, and is wrong to boot (off by 0x200000). Fix it and update it for the general case.

---
 docs/firmware/fw_jump.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
docs/firmware/fw_jump.md +0 -2
index 956897e..03ddf96 100644
@@ -48,13 +48,13 @@ follows:
   ```
   ${CROSS_COMPILE}objdump -h $KERNEL_ELF | sort -k 5,5 | awk -n '/^ +[0-9]+ /\
   {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}' \
-  | (( `tail -1` > 0x2200000 )) && echo fdt overlaps kernel,\
-  increase FW_JUMP_FDT_ADDR

docs/firmware/fw_jump.md follows: · line 58

Quoted 10 lines
docs/firmware/fw_jump.md +4 -2
+  | (( `tail -1` > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) && \
+  echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR
 
   ${LLVM}objdump -h --show-lma $KERNEL_ELF | sort -k 5,5 | \
   awk -n '/^ +[0-9]+ / {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}'\
-  | (( `tail -1` > 0x2200000 )) && echo fdt overlaps kernel,\
-  increase FW_JUMP_FDT_ADDR
+  | (( `tail -1` > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) && \
+  echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR
   ```

nit: We can put a bit of lipstick on this pig by rewriting as

${CROSS_COMPILE}objdump -h $KERNEL_ELF | sort -k 5,5 | awk -n ' /^ +[0-9]+ / {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}' | (( tail -1 > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) &&
echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR

${LLVM}objdump -h --show-lma $KERNEL_ELF | sort -k 5,5 | awk -n ' /^ +[0-9]+ / {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}' | (( tail -1 > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) &&
echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR

Quoted 5 lines
Quoted 2 lines

which drops the unnecessary '\'s and makes the gcc and llvm versions more consistent.

Sounds good to me -- you wanna just do that directly while applying, or should I send a v3? :)

It sounds reasonable to do while applying to me, but that's up to a maintainer, like Anup.

Thanks,
drew

Quoted 13 lines
Quoted 10 lines
Quoted 6 lines
docs/firmware/fw_jump.md +0 -0
 *FW_JUMP* Example
Signature · 1 line
2.39.2

Anyway,

Thanks,
--Gabriel

#4 lore raw

PATCH v2 1/1 docs: Correct FW_JUMP_FDT_ADDR calculation example

Quoted 50 lines · Andrew Jones
Quoted 49 lines · Gabriel L. Somlo
Quoted 48 lines · Andrew Jones
Quoted 24 lines · Gabriel Somlo

When using PLATFORM=generic defaults, the kernel is loaded at FW_JUMP_ADDR, and the FDT is loaded at `FW_JUMP_FDT_ADDR.

Therefore, the maximum kernel size before FW_JUMP_FDT_ADDR must be increased is $(( FW_JUMP_FDT_ADDR - FW_JUMP_ADDR )).

The example calculation assumes rv64, and is wrong to boot (off by 0x200000). Fix it and update it for the general case.

---
 docs/firmware/fw_jump.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
docs/firmware/fw_jump.md +0 -2
index 956897e..03ddf96 100644
@@ -48,13 +48,13 @@ follows:
   ```
   ${CROSS_COMPILE}objdump -h $KERNEL_ELF | sort -k 5,5 | awk -n '/^ +[0-9]+ /\
   {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}' \
-  | (( `tail -1` > 0x2200000 )) && echo fdt overlaps kernel,\
-  increase FW_JUMP_FDT_ADDR

docs/firmware/fw_jump.md follows: · line 58

Quoted 10 lines
docs/firmware/fw_jump.md +4 -2
+  | (( `tail -1` > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) && \
+  echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR
 
   ${LLVM}objdump -h --show-lma $KERNEL_ELF | sort -k 5,5 | \
   awk -n '/^ +[0-9]+ / {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}'\
-  | (( `tail -1` > 0x2200000 )) && echo fdt overlaps kernel,\
-  increase FW_JUMP_FDT_ADDR
+  | (( `tail -1` > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) && \
+  echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR
   ```

nit: We can put a bit of lipstick on this pig by rewriting as

${CROSS_COMPILE}objdump -h $KERNEL_ELF | sort -k 5,5 | awk -n ' /^ +[0-9]+ / {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}' | (( tail -1 > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) &&
echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR

${LLVM}objdump -h --show-lma $KERNEL_ELF | sort -k 5,5 | awk -n ' /^ +[0-9]+ / {addr="0x"$3; size="0x"$5; printf "0x""%x\n",addr+size}' | (( tail -1 > (FW_JUMP_FDT_ADDR - FW_JUMP_ADDR) )) &&
echo fdt overlaps kernel, increase FW_JUMP_FDT_ADDR

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

which drops the unnecessary '\'s and makes the gcc and llvm versions more consistent.

Sounds good to me -- you wanna just do that directly while applying, or should I send a v3? :)

It sounds reasonable to do while applying to me, but that's up to a maintainer, like Anup.

OK, I'll send a v3 to make that easy and painless... :)

Quoted 13 lines
Quoted 13 lines
Quoted 10 lines
Quoted 6 lines
docs/firmware/fw_jump.md +0 -0
 *FW_JUMP* Example
Signature · 1 line
2.39.2

Anyway,

Thanks,
--Gabriel