staging: greybus: fix line ending with '('
Subsystems (3)
PATCH 1/1 staging: greybus: fix line ending with '('
Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl
Move the first parameter right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.
--- drivers/staging/greybus/audio_topology.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/greybus/audio_topology.c +2 -3
@@ -24,9 +24,8 @@ struct gbaudio_ctl_pvt {struct gb_audio_ctl_elem_info *info; }; -static struct gbaudio_module_info *find_gb_module ( -struct gbaudio_codec_info *codec, -char const *name) +static struct gbaudio_module_info *find_gb_module (struct gbaudio_codec_info *codec, +char const *name) {int dev_id;char begin[NAME_SIZE ];
--
2.34.1
Quoted 29 lines · Khadija Kamran
Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl
Move the first parameter right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.
Signed-off-by Khadija Kamran <[email protected]>--- drivers/staging/greybus/audio_topology.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/staging/greybus/audio_topology.c +2
-4@@ -24,9 +24,8 @@ struct gbaudio_ctl_pvt {struct gb_audio_ctl_elem_info *info; }; -static struct gbaudio_module_info *find_gb_module ( -struct gbaudio_codec_info *codec, -char const *name) +static struct gbaudio_module_info *find_gb_module (struct gbaudio_codec_info *codec, +char const *name) {int dev_id;char begin[NAME_SIZE ]; --
Quoted 2 lines
2.34.1
Hey Outreachy Mentors,
Kindly take a look at this patch and let me know if I should wait for the response on this patch or submit another patch.
Thank you for your time.
Regards,
Khadija
Greg Kroah-Hartman
maintainerOn Tue, Mar 21, 2023 at 09:19:27PM +0500, Khadija Kamran wrote:
<snip>
Quoted 4 lines
Hey Outreachy Mentors,
Kindly take a look at this patch and let me know if I should wait for the response on this patch or submit another patch.
Less than 1 day later?
Please relax and always keep working on new things, don't let my response time be the gateway for you doing work, otherwise you are not going to get very much done at all.
You normally have to wait about 2 weeks to get a patch reviewed, sometimes I go much faster, sometimes slower. Either way, it's uncertian...
thanks,
greg k-h
Quoted 15 lines · Greg Kroah-Hartman
On Tue, Mar 21, 2023 at 09:19:27PM +0500, Khadija Kamran wrote:
<snip>
Quoted 4 lines
Hey Outreachy Mentors,
Kindly take a look at this patch and let me know if I should wait for the response on this patch or submit another patch.
Less than 1 day later?
Please relax and always keep working on new things, don't let my response time be the gateway for you doing work, otherwise you are not going to get very much done at all.
Quoted 7 lines
You normally have to wait about 2 weeks to get a patch reviewed, sometimes I go much faster, sometimes slower. Either way, it's uncertian...
thanks,
greg k-h
Okay understood.
Really sorry about this message.
Regards,
Khadija