Skip to contentSkip to conversation

edits in greybus driver

PATCH Superseded Menna Mahmoud 4 participants 18 messages Mar 20, 2023 – Mar 21, 2023

Subsystems (4)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

cover edits in greybus driver

This patchset includes change happened in greybus driver in three different files two of them patch one and three related to checkpatch issue and in second patch convert two container_of macros into inline functions.

Menna Mahmoud (3):
staging: greybus: remove unnecessary blank line
staging: greybus: use inline function for macros
staging: greybus: remove unnecessary blank line

 drivers/staging/greybus/gbphy.h                  | 10 ++++++++--
 drivers/staging/greybus/greybus_authentication.h |  1 -
 drivers/staging/greybus/pwm.c                    |  1 -
 3 files changed, 8 insertions(+), 4 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/3 staging: greybus: remove unnecessary blank line

Remove unnecessary blank line before struct as reported by checkpatch:

" CHECK: Please don't use multiple blank lines "

---
 drivers/staging/greybus/greybus_authentication.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/greybus/greybus_authentication.h +0 -1
index 7edc7295b7ab..48b4a9794d3c 100644
@@ -41,7 +41,6 @@
 #define CAP_AUTH_RESULT_CR_NO_KEY	0x03
 #define CAP_AUTH_RESULT_CR_SIG_FAIL	0x04
 
-
 /* IOCTL support */
 struct cap_ioc_get_endpoint_uid {
 	__u8			uid[8];
Signature · 1 line
2.34.1
#2 lore raw

PATCH 2/3 staging: greybus: use inline function for macros

In reply to Menna Mahmoud

Convert to_gbphy_dev and to_gbphy_driver macros into a static inline function.

it is not great to have macro that use container_of macro, because from looking at the definition one cannot tell what type it applies to.

One can get the same benefit from an efficiency point of view by making an inline function.

---
 drivers/staging/greybus/gbphy.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/staging/greybus/gbphy.h +8 -2
index d4a225b76338..03a977056637 100644
@@ -15,7 +15,10 @@ struct gbphy_device {
 	struct list_head list;
 	struct device dev;
 };
-#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
+static inline struct gbphy_device *to_gbphy_dev(const struct device *d)
+{
+	return container_of(d, struct gbphy_device, dev);
+}
 
 static inline void *gb_gbphy_get_data(struct gbphy_device *gdev)
 {
@@ -43,7 +46,10 @@ struct gbphy_driver {
 
 	struct device_driver driver;
 };
-#define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver)
+static inline struct gbphy_driver *to_gbphy_driver(struct device_driver *d)
+{
+	return container_of(d, struct gbphy_driver, driver);
+}
 
 int gb_gbphy_register_driver(struct gbphy_driver *driver,
 			     struct module *owner, const char *mod_name);
Signature · 1 line
2.34.1
#3 lore raw

Re: [PATCH 2/3] staging: greybus: use inline function for macros

Hello,

just some nitpicks:

Quoted 4 lines · Menna Mahmoud

Convert to_gbphy_dev and to_gbphy_driver macros into a static inline function.

it is not great to have macro that use container_of macro,

s/it/It/; s/macro/macros/; s/use/use the/;

drivers/staging/greybus/gbphy.h struct gbphy_device { · line 18

Quoted 5 lines

because from looking at the definition one cannot tell what type it applies to.
[...]

drivers/staging/greybus/gbphy.h +1 -1
-#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
+static inline struct gbphy_device *to_gbphy_dev(const struct device *d)

drivers/staging/greybus/gbphy.c always passes a variable named "dev" to this macro. So I'd call the parameter "dev", too, instead of "d". This is also a more typical name for variables of that type.

drivers/staging/greybus/gbphy.h struct gbphy_driver { · line 52

Quoted 10 lines
drivers/staging/greybus/gbphy.h +7 -1
+{
+	return container_of(d, struct gbphy_device, dev);
+}
[...]
 };
-#define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver)
+static inline struct gbphy_driver *to_gbphy_driver(struct device_driver *d)
+{
+	return container_of(d, struct gbphy_driver, driver);
+}

With a similar reasoning (and also to not have "d"s that are either device or device_driver) I'd recommend "drv" here.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
#4 lore raw

Re: [PATCH 2/3] staging: greybus: use inline function for macros

Quoted 12 lines · Uwe Kleine-König

Hello,

just some nitpicks:

Quoted 4 lines · Menna Mahmoud

Convert to_gbphy_dev and to_gbphy_driver macros into a static inline function.

it is not great to have macro that use container_of macro,

s/it/It/; s/macro/macros/; s/use/use the/;

Quoted 9 lines

drivers/staging/greybus/gbphy.h struct gbphy_device { · line 18

Quoted 5 lines

because from looking at the definition one cannot tell what type it applies to.
[...]

drivers/staging/greybus/gbphy.h +1 -1
-#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
+static inline struct gbphy_device *to_gbphy_dev(const struct device *d)

drivers/staging/greybus/gbphy.c always passes a variable named "dev" to this macro. So I'd call the parameter "dev", too, instead of "d". This is also a more typical name for variables of that type.

I argued against that. Because then there are two uses of dev in the argument of container_of, and they refer to completely different things. It's true that by the way container_of works, it's fine, but it may be misleading.

julia

Quoted 22 lines

drivers/staging/greybus/gbphy.h struct gbphy_driver { · line 52

Quoted 11 lines
drivers/staging/greybus/gbphy.h +7 -1
+{
+	return container_of(d, struct gbphy_device, dev);
+}
[...]
 };
-#define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver)
+static inline struct gbphy_driver *to_gbphy_driver(struct device_driver *d)
+{
+	return container_of(d, struct gbphy_driver, driver);
+}

With a similar reasoning (and also to not have "d"s that are either device or device_driver) I'd recommend "drv" here.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

#5 lore raw

Re: [PATCH 2/3] staging: greybus: use inline function for macros

Quoted 26 lines · Julia Lawall
Quoted 12 lines · Uwe Kleine-König

Hello,

just some nitpicks:

Quoted 4 lines · Menna Mahmoud

Convert to_gbphy_dev and to_gbphy_driver macros into a static inline function.

it is not great to have macro that use container_of macro,

s/it/It/; s/macro/macros/; s/use/use the/;

Quoted 9 lines

drivers/staging/greybus/gbphy.h struct gbphy_device { · line 18

Quoted 5 lines

because from looking at the definition one cannot tell what type it applies to.
[...]

drivers/staging/greybus/gbphy.h +1 -1
-#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
+static inline struct gbphy_device *to_gbphy_dev(const struct device *d)

drivers/staging/greybus/gbphy.c always passes a variable named "dev" to this macro. So I'd call the parameter "dev", too, instead of "d". This is also a more typical name for variables of that type.

Quoted 4 lines

I argued against that. Because then there are two uses of dev in the argument of container_of, and they refer to completely different things. It's true that by the way container_of works, it's fine, but it may be misleading.

Hmm, that seems to be subjective, but I have less problems with that than with using "d" for a struct device (or a struct device_driver). I'd even go so far as to consider it nice if they are identical.

Maybe that's because having the first and third argument identical is quite common:

	$ git grep -P 'container_of\((?<ident>[A-Za-z_0-9-]*)\s*,[^,]*,\s*\g{ident}\s*\)' | wc -l
	5940

which is >44% of all the usages

	$ git grep -P 'container_of\((?<ident>[A-Za-z_0-9-]*)\s*,[^,]*,\s*(?&ident)\s*\)' | wc -l
	13362

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
#6 lore raw

Re: [PATCH 2/3] staging: greybus: use inline function for macros

Quoted 39 lines · Uwe Kleine-König
Quoted 26 lines · Julia Lawall
Quoted 12 lines · Uwe Kleine-König

Hello,

just some nitpicks:

Quoted 4 lines · Menna Mahmoud

Convert to_gbphy_dev and to_gbphy_driver macros into a static inline function.

it is not great to have macro that use container_of macro,

s/it/It/; s/macro/macros/; s/use/use the/;

Quoted 9 lines

drivers/staging/greybus/gbphy.h struct gbphy_device { · line 18

Quoted 5 lines

because from looking at the definition one cannot tell what type it applies to.
[...]

drivers/staging/greybus/gbphy.h +1 -1
-#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
+static inline struct gbphy_device *to_gbphy_dev(const struct device *d)

drivers/staging/greybus/gbphy.c always passes a variable named "dev" to this macro. So I'd call the parameter "dev", too, instead of "d". This is also a more typical name for variables of that type.

Quoted 4 lines

I argued against that. Because then there are two uses of dev in the argument of container_of, and they refer to completely different things. It's true that by the way container_of works, it's fine, but it may be misleading.

Hmm, that seems to be subjective, but I have less problems with that than with using "d" for a struct device (or a struct device_driver). I'd even go so far as to consider it nice if they are identical.

Maybe that's because having the first and third argument identical is quite common:

Quoted 7 lines
	$ git grep -P 'container_of\((?<ident>[A-Za-z_0-9-]*)\s*,[^,]*,\s*\g{ident}\s*\)' | wc -l
	5940

which is >44% of all the usages

	$ git grep -P 'container_of\((?<ident>[A-Za-z_0-9-]*)\s*,[^,]*,\s*(?&ident)\s*\)' | wc -l
	13362

OK, if people like that, then why not. But it's dangerous if the call to container_of is in a macro, rather than in a function.

julia

maintainer
#7 lore raw

Re: [PATCH 2/3] staging: greybus: use inline function for macros

Quoted 46 lines · Julia Lawall
Quoted 42 lines · Uwe Kleine-König
Quoted 26 lines · Julia Lawall
Quoted 12 lines · Uwe Kleine-König

Hello,

just some nitpicks:

Quoted 4 lines · Menna Mahmoud

Convert to_gbphy_dev and to_gbphy_driver macros into a static inline function.

it is not great to have macro that use container_of macro,

s/it/It/; s/macro/macros/; s/use/use the/;

Quoted 9 lines

drivers/staging/greybus/gbphy.h struct gbphy_device { · line 18

Quoted 5 lines

because from looking at the definition one cannot tell what type it applies to.
[...]

drivers/staging/greybus/gbphy.h +1 -1
-#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
+static inline struct gbphy_device *to_gbphy_dev(const struct device *d)

drivers/staging/greybus/gbphy.c always passes a variable named "dev" to this macro. So I'd call the parameter "dev", too, instead of "d". This is also a more typical name for variables of that type.

Quoted 4 lines

I argued against that. Because then there are two uses of dev in the argument of container_of, and they refer to completely different things. It's true that by the way container_of works, it's fine, but it may be misleading.

Hmm, that seems to be subjective, but I have less problems with that than with using "d" for a struct device (or a struct device_driver). I'd even go so far as to consider it nice if they are identical.

Maybe that's because having the first and third argument identical is quite common:

	$ git grep -P 'container_of\((?<ident>[A-Za-z_0-9-]*)\s*,[^,]*,\s*\g{ident}\s*\)' | wc -l
	5940
Quoted 7 lines
Quoted 4 lines

which is >44% of all the usages

	$ git grep -P 'container_of\((?<ident>[A-Za-z_0-9-]*)\s*,[^,]*,\s*(?&ident)\s*\)' | wc -l
	13362

OK, if people like that, then why not. But it's dangerous if the call to container_of is in a macro, rather than in a function.

It's not "dangerous" at all, as the macro will enforce type-safety, you can't get it wrong when using it.

Ideally this is best as a macro as it's just doing pointer math, worst case, the compiler turns a function like this into a real function and you have a call/subtract/return for every time you make this call.

So this conversion to functions feels odd to me, as you potentially are making all of this worse overall.

Wait until people realize that when we eventually turn these into container_of_const() you HAVE to go back to using it as a macro instead of in a function call wrapper like this...

thanks,

greg k-h

#8 lore raw

Re: [PATCH 2/3] staging: greybus: use inline function for macros

In reply to Uwe Kleine-König
Quoted 10 lines · Uwe Kleine-König

Hello,

just some nitpicks:

Quoted 4 lines · Menna Mahmoud

Convert to_gbphy_dev and to_gbphy_driver macros into a static inline function.

it is not great to have macro that use container_of macro,

s/it/It/; s/macro/macros/; s/use/use the/;

Okay, I will fix it.

Quoted 10 lines

drivers/staging/greybus/gbphy.h struct gbphy_device { · line 18

Quoted 6 lines

because from looking at the definition one cannot tell what type it applies to.
[...]

drivers/staging/greybus/gbphy.h +1 -1
-#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
+static inline struct gbphy_device *to_gbphy_dev(const struct device *d)

drivers/staging/greybus/gbphy.c always passes a variable named "dev" to this macro. So I'd call the parameter "dev", too, instead of "d". This is also a more typical name for variables of that type.

Quoted 12 lines

drivers/staging/greybus/gbphy.h struct gbphy_driver { · line 52

Quoted 10 lines
drivers/staging/greybus/gbphy.h +7 -1
+{
+	return container_of(d, struct gbphy_device, dev);
+}
[...]
  };
-#define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver)
+static inline struct gbphy_driver *to_gbphy_driver(struct device_driver *d)
+{
+	return container_of(d, struct gbphy_driver, driver);
+}

With a similar reasoning (and also to not have "d"s that are either device or device_driver) I'd recommend "drv" here.

please check this with Julia, because she said they should different.

Thanks,

Menna

Quoted 4 lines

Best regards
Uwe

#9 lore raw

Re: [PATCH 2/3] staging: greybus: use inline function for macros

Quoted 37 lines · Menna Mahmoud
Quoted 10 lines · Uwe Kleine-König

Hello,

just some nitpicks:

Quoted 4 lines · Menna Mahmoud

Convert to_gbphy_dev and to_gbphy_driver macros into a static inline function.

it is not great to have macro that use container_of macro,

s/it/It/; s/macro/macros/; s/use/use the/;

Okay, I will fix it.

Quoted 10 lines

drivers/staging/greybus/gbphy.h struct gbphy_device { · line 18

Quoted 6 lines

because from looking at the definition one cannot tell what type it applies to.
[...]

drivers/staging/greybus/gbphy.h +1 -1
-#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
+static inline struct gbphy_device *to_gbphy_dev(const struct device *d)

drivers/staging/greybus/gbphy.c always passes a variable named "dev" to this macro. So I'd call the parameter "dev", too, instead of "d". This is also a more typical name for variables of that type.

Quoted 12 lines

drivers/staging/greybus/gbphy.h struct gbphy_driver { · line 52

Quoted 10 lines
drivers/staging/greybus/gbphy.h +7 -1
+{
+	return container_of(d, struct gbphy_device, dev);
+}
[...]
  };
-#define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver)
+static inline struct gbphy_driver *to_gbphy_driver(struct device_driver *d)
+{
+	return container_of(d, struct gbphy_driver, driver);
+}

With a similar reasoning (and also to not have "d"s that are either device or device_driver) I'd recommend "drv" here.

Quoted 1 line

please check this with Julia, because she said they should different.

At least use "_dev" instead of "d" which seems to be a common idiom, too:

	$ git grep -P 'container_of\(_(?<ident>[A-Za-z_0-9-]*)\s*,[^,]*,\s*\g{ident}\s*\)' | wc -l
	570

("drv" should be fine, because the third argument is "driver" there.)

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
#10 lore raw

Re: [PATCH 2/3] staging: greybus: use inline function for macros

Quoted 35 lines · Uwe Kleine-König
Quoted 34 lines · Menna Mahmoud
Quoted 10 lines · Uwe Kleine-König

Hello,

just some nitpicks:

Quoted 4 lines · Menna Mahmoud

Convert to_gbphy_dev and to_gbphy_driver macros into a static inline function.

it is not great to have macro that use container_of macro,

s/it/It/; s/macro/macros/; s/use/use the/;

Okay, I will fix it.

Quoted 21 lines

drivers/staging/greybus/gbphy.h struct gbphy_device { · line 18

Quoted 5 lines

because from looking at the definition one cannot tell what type it applies to.
[...]

drivers/staging/greybus/gbphy.h +1 -1
-#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
+static inline struct gbphy_device *to_gbphy_dev(const struct device *d)

drivers/staging/greybus/gbphy.c always passes a variable named "dev" to this macro. So I'd call the parameter "dev", too, instead of "d". This is also a more typical name for variables of that type.

drivers/staging/greybus/gbphy.h struct gbphy_driver { · line 52

Quoted 10 lines
drivers/staging/greybus/gbphy.h +7 -1
+{
+	return container_of(d, struct gbphy_device, dev);
+}
[...]
   };
-#define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver)
+static inline struct gbphy_driver *to_gbphy_driver(struct device_driver *d)
+{
+	return container_of(d, struct gbphy_driver, driver);
+}

With a similar reasoning (and also to not have "d"s that are either device or device_driver) I'd recommend "drv" here.

Quoted 8 lines
Quoted 1 line

please check this with Julia, because she said they should different.

At least use "_dev" instead of "d" which seems to be a common idiom, too:

	$ git grep -P 'container_of\(_(?<ident>[A-Za-z_0-9-]*)\s*,[^,]*,\s*\g{ident}\s*\)' | wc -l
	570

("drv" should be fine, because the third argument is "driver" there.)

Okay, I will do that.

Thanks,

Menna

Quoted 4 lines

Best regards
Uwe

#11 lore raw

PATCH 3/3 staging: greybus: remove unnecessary blank line

In reply to Menna Mahmoud

Remove unnecessary blank line before struct as reported by checkpatch:

" CHECK: Please don't use multiple blank lines "

---
 drivers/staging/greybus/pwm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/greybus/pwm.c +0 -1
index 3fda172239d2..26d39e08c3b6 100644
@@ -24,7 +24,6 @@ struct gb_pwm_chip {
 #define pwm_chip_to_gb_pwm_chip(chip) \
 	container_of(chip, struct gb_pwm_chip, chip)
 
-
 static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
 {
 	struct gb_pwm_count_response response;
Signature · 1 line
2.34.1
#12 lore raw
In reply to Menna Mahmoud
Quoted 9 lines · Menna Mahmoud

This patchset includes change happened in greybus driver in three different files two of them patch one and three related to checkpatch issue and in second patch convert two container_of macros into inline functions.

Menna Mahmoud (3):
staging: greybus: remove unnecessary blank line
staging: greybus: use inline function for macros
staging: greybus: remove unnecessary blank line

Different patches should have different subject lines. You need to either be more specific about the file affected or merge the two patches with the same subject into one.

julia

Quoted 11 lines
 drivers/staging/greybus/gbphy.h                  | 10 ++++++++--
 drivers/staging/greybus/greybus_authentication.h |  1 -
 drivers/staging/greybus/pwm.c                    |  1 -
 3 files changed, 8 insertions(+), 4 deletions(-)

--
2.34.1

#13 lore raw
Quoted 8 lines · Julia Lawall
Quoted 5 lines · Menna Mahmoud

This patchset includes change happened in greybus driver in three different files two of them patch one and three related to checkpatch issue and in second patch convert two container_of macros into inline functions.

Quoted 5 lines
Quoted 4 lines

Menna Mahmoud (3):
staging: greybus: remove unnecessary blank line
staging: greybus: use inline function for macros
staging: greybus: remove unnecessary blank line

Different patches should have different subject lines.

But I have already the same edit in both file, so should I re-write the subject for one of them?

Quoted 3 lines

You need to either
be more specific about the file affected or merge the two patches with the same subject into one.

each patch related to different file. So, Can I to merge two commits for different files but have the same edit in one patch?

but in this case no need to create patchset for all changes in greybus driver, right?

If okay with that, should I versioning the patches to resend them again, or should add "RESEND" subject prefix?

please tell me the best way to resend these patches, appreciate your help.

Menna

Quoted 13 lines

julia

Quoted 10 lines
  drivers/staging/greybus/gbphy.h                  | 10 ++++++++--
  drivers/staging/greybus/greybus_authentication.h |  1 -
  drivers/staging/greybus/pwm.c                    |  1 -
  3 files changed, 8 insertions(+), 4 deletions(-)

--
2.34.1

maintainer
#14 lore raw
Quoted 15 lines · Menna Mahmoud
Quoted 8 lines · Julia Lawall
Quoted 5 lines · Menna Mahmoud

This patchset includes change happened in greybus driver in three different files two of them patch one and three related to checkpatch issue and in second patch convert two container_of macros into inline functions.

Quoted 5 lines
Quoted 4 lines

Menna Mahmoud (3):
staging: greybus: remove unnecessary blank line
staging: greybus: use inline function for macros
staging: greybus: remove unnecessary blank line

Different patches should have different subject lines.

Quoted 8 lines

But I have already the same edit in both file, so should I re-write the subject for one of them?

Quoted 3 lines

You need to either
be more specific about the file affected or merge the two patches with the same subject into one.

each patch related to different file. So, Can I to merge two commits for different files but have the same edit in one patch?

Yes, or make 2 different patches with 2 different subject lines as they are obviously doing different things.

Quoted 7 lines

but in this case no need to create patchset for all changes in greybus driver, right?

If okay with that, should I versioning the patches to resend them again, or should add "RESEND" subject prefix?

please tell me the best way to resend these patches, appreciate your help.

What would you want to see if you had to review and apply loads of patches like this?

(hint, it's not a resend, but a new version...)

thanks,

greg k-h

#15 lore raw
Quoted 16 lines · Greg KH
Quoted 15 lines · Menna Mahmoud
Quoted 7 lines · Julia Lawall
Quoted 5 lines · Menna Mahmoud

This patchset includes change happened in greybus driver in three different files two of them patch one and three related to checkpatch issue and in second patch convert two container_of macros into inline functions.

Quoted 5 lines
Quoted 4 lines

Menna Mahmoud (3):
staging: greybus: remove unnecessary blank line
staging: greybus: use inline function for macros
staging: greybus: remove unnecessary blank line

Different patches should have different subject lines.

But I have already the same edit in both file, so should I re-write the subject for one of them?

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

You need to either
be more specific about the file affected or merge the two patches with the same subject into one.

each patch related to different file. So, Can I to merge two commits for different files but have the same edit in one patch?

Yes, or make 2 different patches with 2 different subject lines as they are obviously doing different things.

okay, I will fix it.

Quoted 10 lines
Quoted 8 lines

but in this case no need to create patchset for all changes in greybus driver, right?

If okay with that, should I versioning the patches to resend them again, or should add "RESEND" subject prefix?

please tell me the best way to resend these patches, appreciate your help.

What would you want to see if you had to review and apply loads of patches like this?

sure add version number will be easy to review.

Quoted 5 lines

(hint, it's not a resend, but a new version...)

thanks,

greg k-h

Thanks,

Menna

#16 lore raw
In reply to Menna Mahmoud
Quoted 15 lines · Menna Mahmoud
Quoted 8 lines · Julia Lawall
Quoted 5 lines · Menna Mahmoud

This patchset includes change happened in greybus driver in three different files two of them patch one and three related to checkpatch issue and in second patch convert two container_of macros into inline functions.

Quoted 5 lines
Quoted 4 lines

Menna Mahmoud (3):
staging: greybus: remove unnecessary blank line
staging: greybus: use inline function for macros
staging: greybus: remove unnecessary blank line

Different patches should have different subject lines.

Quoted 8 lines

But I have already the same edit in both file, so should I re-write the subject for one of them?

Quoted 3 lines

You need to either
be more specific about the file affected or merge the two patches with the same subject into one.

each patch related to different file. So, Can I to merge two commits for different files but have the same edit in one patch?

They are both for greybus, which is what you advertise in the subject line. And the sense of the changes is the same, and the changes are quite simple. So I think you could just put them in one patch. If you find other occurrences of the problem in greybus you could make one patch that fixes all of them.

Quoted 2 lines

but in this case no need to create patchset for all changes in greybus driver, right?

A patchset is needed if the changes affect the same file, because there might be complications if the patches are applied in the wrong order.

Quoted 3 lines

If okay with that, should I versioning the patches to resend them again, or should add "RESEND" subject prefix?

RESEND would be if you send exactly the same thing, because some time has passed and you are worried that the patch has been lost. Now that you have put these in a series, it is perhaps best to leave them in a series and increase the version number, to avoid confusion on the part of people reading the patches.

julia

Quoted 20 lines

please tell me the best way to resend these patches, appreciate your help.

Menna

Quoted 13 lines

julia

Quoted 10 lines
  drivers/staging/greybus/gbphy.h                  | 10 ++++++++--
  drivers/staging/greybus/greybus_authentication.h |  1 -
  drivers/staging/greybus/pwm.c                    |  1 -
  3 files changed, 8 insertions(+), 4 deletions(-)

--
2.34.1

#17 lore raw
Quoted 36 lines · Julia Lawall
Quoted 12 lines · Menna Mahmoud
Quoted 11 lines · Julia Lawall
Quoted 9 lines · Menna Mahmoud

This patchset includes change happened in greybus driver in three different files two of them patch one and three related to checkpatch issue and in second patch convert two container_of macros into inline functions.

Menna Mahmoud (3):
staging: greybus: remove unnecessary blank line
staging: greybus: use inline function for macros
staging: greybus: remove unnecessary blank line

Quoted 8 lines
Quoted 1 line

Different patches should have different subject lines.

But I have already the same edit in both file, so should I re-write the subject for one of them?

Quoted 3 lines

You need to either
be more specific about the file affected or merge the two patches with the same subject into one.

each patch related to different file. So, Can I to merge two commits for different files but have the same edit in one patch?

They are both for greybus, which is what you advertise in the subject line. And the sense of the changes is the same, and the changes are quite simple. So I think you could just put them in one patch. If you find other occurrences of the problem in greybus you could make one patch that fixes all of them.

Quoted 2 lines

but in this case no need to create patchset for all changes in greybus driver, right?

A patchset is needed if the changes affect the same file, because there might be complications if the patches are applied in the wrong order.

Quoted 2 lines

If okay with that, should I versioning the patches to resend them again, or should add "RESEND" subject prefix?

Quoted 7 lines

RESEND would be if you send exactly the same thing, because some time has passed and you are worried that the patch has been lost. Now that you have put these in a series, it is perhaps best to leave them in a series and increase the version number, to avoid confusion on the part of people reading the patches.

julia

understood, thanks Julia.

Menna

Quoted 20 lines
Quoted 20 lines

please tell me the best way to resend these patches, appreciate your help.

Menna

Quoted 12 lines

julia

Quoted 10 lines
   drivers/staging/greybus/gbphy.h                  | 10 ++++++++--
   drivers/staging/greybus/greybus_authentication.h |  1 -
   drivers/staging/greybus/pwm.c                    |  1 -
   3 files changed, 8 insertions(+), 4 deletions(-)

--
2.34.1