Skip to contentSkip to conversation

staging: most: fix line ending with '('

PATCH In review Khadija Kamran 2 participants 6 messages Mar 22, 2023 – Mar 23, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: most: fix line ending with '('

Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl

Move the first parameter right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.

---
 drivers/staging/most/dim2/hal.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/most/dim2/hal.c +2 -3
index a5d40b5b138a..6abe3ab2b2cf 100644
@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
 		dim2_clear_ctr(ctr_addr);
 }
 
-static void dim2_configure_channel(
-	u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
-	u16 packet_length)
+static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
+				   u16 hw_buffer_size, u16 packet_length)
 {
 	dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
 	dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);

--
2.34.1

#1 lore raw
Quoted 11 lines · Khadija Kamran

Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl

Move the first parameter right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.

---
 drivers/staging/most/dim2/hal.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

You have 2 patches here with identical subject lines, yet they do different things :(

I've dropped all of your pending patches now for the most driver as I'm totally confused. Please resend them all as a proper patch series with updated subject lines.

thanks,

greg k-h

#2 lore raw
Quoted 13 lines · Greg Kroah-Hartman
Quoted 11 lines · Khadija Kamran

Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl

Move the first parameter right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.

---
 drivers/staging/most/dim2/hal.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Quoted 7 lines

You have 2 patches here with identical subject lines, yet they do different things :(

I've dropped all of your pending patches now for the most driver as I'm totally confused. Please resend them all as a proper patch series with updated subject lines.

Hey Greg,

Okay understood. Sorry for the inconvenience.

Regards,
Khadija

Quoted 3 lines

thanks,

greg k-h

#3 lore raw
In reply to Greg Kroah-Hartman
Quoted 13 lines · Greg Kroah-Hartman
Quoted 11 lines · Khadija Kamran

Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl

Move the first parameter right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.

---
 drivers/staging/most/dim2/hal.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Quoted 7 lines

You have 2 patches here with identical subject lines, yet they do different things :(

I've dropped all of your pending patches now for the most driver as I'm totally confused. Please resend them all as a proper patch series with updated subject lines.

Hey Greg!

I took your message literally and sent a RESEND PATCH. I should've sent a new version of the patch instead.

Would it be okay if I send patch revisions with changed subjects now?

My apologies for the inconvenience.

Regards,
Khadija

Quoted 3 lines

thanks,

greg k-h

#4 lore raw
Quoted 22 lines · Khadija Kamran
Quoted 13 lines · Greg Kroah-Hartman
Quoted 11 lines · Khadija Kamran

Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl

Move the first parameter right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.

---
 drivers/staging/most/dim2/hal.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Quoted 7 lines

You have 2 patches here with identical subject lines, yet they do different things :(

I've dropped all of your pending patches now for the most driver as I'm totally confused. Please resend them all as a proper patch series with updated subject lines.

Quoted 4 lines

Hey Greg!

I took your message literally and sent a RESEND PATCH. I should've sent a new version of the patch instead.

What message?

Remember, we get hundreds of patches a day to review and have a short term memory of a squirrel.. make it obvious what is happening when resending or sending a new version, otherwise we are confused.

Quoted 1 line

Would it be okay if I send patch revisions with changed subjects now?

What would you want to see if you were on the recieving end of this patch to know what to do with it?

thanks,

greg k-h

#5 lore raw
Quoted 25 lines · Greg Kroah-Hartman
Quoted 24 lines · Khadija Kamran
Quoted 13 lines · Greg Kroah-Hartman
Quoted 11 lines · Khadija Kamran

Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl

Move the first parameter right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.

---
 drivers/staging/most/dim2/hal.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Quoted 7 lines

You have 2 patches here with identical subject lines, yet they do different things :(

I've dropped all of your pending patches now for the most driver as I'm totally confused. Please resend them all as a proper patch series with updated subject lines.

Hey Greg!

Quoted 9 lines
Quoted 2 lines

I took your message literally and sent a RESEND PATCH. I should've sent a new version of the patch instead.

What message?

Remember, we get hundreds of patches a day to review and have a short term memory of a squirrel.. make it obvious what is happening when resending or sending a new version, otherwise we are confused.

Okay noted. I apologize for my mistakes.

Thank you for your time.

Quoted 5 lines
Quoted 1 line

Would it be okay if I send patch revisions with changed subjects now?

What would you want to see if you were on the recieving end of this patch to know what to do with it?

I have sent revisions with an explanation about why the patches are being sent again and what changes are made.

I hope I am not making any mistakes.

Regards,
Khadija

Quoted 3 lines

thanks,

greg k-h