Tegra234 Memory interconnect support
Subsystems (6)
v5 cover Tegra234 Memory interconnect support
Hi All,
Thank you for the review. Have incorporated the changes suggested in v4. Requesting for ACK on the remaining patches if all fine.
The patches are divided into below groups:
- Patch [7] : Memory Interconnect support in PCI (MC client) -- Need ACK.
- Patch [3-6, 8]: Memory Interconnect support in CPUFREQ (MC client) -- 'Patch 3, 4 & 5': have ACK from Krzysztof.
-- 'Patch 6 & 8': Need ACK.
- Patch [1-2]: Memory Interconnect base support
-- 'Patch 2': has ACK from Krzysztof.
-- 'Patch 1': Need ACK.
Both the MC client patches are dependent on the 'Patch [1-2]'.
Thank you,
Sumit Gupta
============
This patch series adds memory interconnect support for Tegra234 SoC. It is used to dynamically scale DRAM Frequency as per the bandwidth requests from different Memory Controller (MC) clients.
MC Clients use ICC Framework's icc_set_bw() api to dynamically request for the DRAM bandwidth (BW). As per path, the request will be routed from MC to the EMC driver. MC driver passes the request info like the Client ID, type, and frequency request info to the BPMP-FW which will set the final DRAM freq considering all exisiting requests.
MC and EMC are the ICC providers. Nodes in path for a request will be:
Client[1-n] -> MC -> EMC -> EMEM/DRAM
The patch series also adds interconnect support in below clients:
1) CPUFREQ driver for scaling bandwidth with CPU frequency. For that, add per cluster OPP table which will be used in the CPUFREQ driver by requesting the minimum BW respective to the given CPU frequency in the OPP table of it's cluster.
2) PCIE driver to request BW required for different modes.
---
v4[4] -> v5:
- dropped 'patch 1 & 2' from v4 which added "nvidia,bpmp" in MC node.
- save BPMP ref from EMC node into 'mc->bpmp' and use it in MC driver.
- added check for array bounds violation in pci suggested by Bjorn.
- moved DT patch having OPP table to the last 'Patch 8'.
- did multiple small changes and cleanup suggested by Krzysztof in v4.
v3[3] -> v4:
- dropped 'patch 1' from v3 which returns 'struct tegra_bpmp *'.
- added 'patch 1 & 2' to get bpmp ref using 'nvidia,bpmp' property.
- dropped 'patch 10 & 11' from v3 and added those changes in 'patch 3'.
- added static to prototype of 'tegra_cpufreq_init_cpufreq_table()' to fix the warning reported by 'kernel test robot'.
v2[2] -> v3:
- in 'patch 7', set 'icc_dram_bw_scaling' to false if set_opp call failed to avoid flooding of uart with 'Failed to set bw' messages.
- added 'patch 10' to handle if the bpmp-fw is old and not support bwmgr mrq.
- added 'patch 11' to fix interconnect registration in tegra186-emc. ref patch link in linux next:
[https://lore.kernel.org/all/[email protected]/]
v1[1] -> v2:
- moved BW setting to tegra234_mc_icc_set() from EMC driver.
- moved sw clients to the 'tegra_mc_clients' table.
- point 'node->data' to the entry within 'tegra_mc_clients'.
- removed 'struct tegra_icc_node' and get client info using 'node->data'.
- changed error handling in and around tegra_emc_interconnect_init().
- moved 'tegra-icc.h' from 'include/soc/tegra' to 'include/linux'.
- added interconnect support to PCIE driver in 'Patch 9'.
- merged 'Patch 9 & 10' from [1] to get num_channels and use.
- merged 'Patch 2 & 3' from [1] to add ISO and NISO clients.
- added 'Acked-by' of Krzysztof from 'Patch 05/10' of [1].
- Removed 'Patch 7' from [1] as that is merged now.
Sumit Gupta (8):
memory: tegra: add interconnect support for DRAM scaling in Tegra234
memory: tegra: add mc clients for Tegra234
memory: tegra: add software mc clients in Tegra234
dt-bindings: tegra: add icc ids for dummy MC clients
memory: tegra: make cpu cluster bw request a multiple of mc channels
cpufreq: tegra194: add OPP support and set bandwidth
PCI: tegra194: add interconnect support in Tegra234
arm64: tegra: Add cpu OPP tables and interconnects property
arch/arm64/boot/dts/nvidia/tegra234.dtsi | 276 ++++++++++ drivers/cpufreq/tegra194-cpufreq.c | 156 +++++- drivers/memory/tegra/mc.c | 24 + drivers/memory/tegra/mc.h | 1 + drivers/memory/tegra/tegra186-emc.c | 130 +++++ drivers/memory/tegra/tegra234.c | 595 ++++++++++++++++++++- drivers/pci/controller/dwc/pcie-tegra194.c | 44 +- include/dt-bindings/memory/tegra234-mc.h | 5 + include/linux/tegra-icc.h | 65 +++ include/soc/tegra/mc.h | 8 + 10 files changed, 1282 insertions(+), 22 deletions(-) create mode 100644 include/linux/tegra-icc.h
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/
[3] https://lore.kernel.org/lkml/[email protected]/
[4] https://lore.kernel.org/lkml/[email protected]/
Signature · 1 line
2.17.1
PATCH v5 1/8 memory: tegra: add interconnect support for DRAM scaling in Tegra234
Add Interconnect framework support to dynamically set the DRAM bandwidth from different clients. Both the MC and EMC drivers are added as ICC providers. The path for any request is:
MC-Client[1-n] -> MC -> EMC -> EMEM/DRAM
MC client's request for bandwidth will go to the MC driver which passes the client request info like BPMP Client ID, Client type and the Bandwidth to the BPMP-FW. The final DRAM freq to achieve the requested bandwidth is set by the BPMP-FW based on the passed parameters.
--- drivers/memory/tegra/mc.c | 5 + drivers/memory/tegra/tegra186-emc.c | 130 ++++++++++++++++++++++++++ drivers/memory/tegra/tegra234.c | 138 +++++++++++++++++++++++++++- include/linux/tegra-icc.h | 65 +++++++++++++ include/soc/tegra/mc.h | 7 ++ 5 files changed, 344 insertions(+), 1 deletion(-) create mode 100644 include/linux/tegra-icc.h
drivers/memory/tegra/mc.c +5 -0
@@ -15,6 +15,7 @@#include <linux/platform_device.h> #include <linux/slab.h> #include <linux/sort.h> +#include <linux/tegra-icc.h> #include <soc/tegra/fuse.h>
@@ -792,6 +793,8 @@ static int tegra_mc_interconnect_setup(struct tegra_mc *mc) mc->provider.data = &mc->provider; mc->provider.set = mc->soc->icc_ops->set; mc->provider.aggregate = mc->soc->icc_ops->aggregate; + mc->provider.get_bw = mc->soc->icc_ops->get_bw; + mc->provider.xlate = mc->soc->icc_ops->xlate; mc->provider.xlate_extended = mc->soc->icc_ops->xlate_extended;icc_provider_init (&mc->provider);
@@ -824,6 +827,8 @@ static int tegra_mc_interconnect_setup(struct tegra_mc *mc) err =icc_link_create (node,TEGRA_ICC_MC );if (err) goto remove_nodes; + + node->data = (struct tegra_mc_client *)&(mc->soc->clients[i]); } err =icc_provider_register (&mc->provider);
drivers/memory/tegra/tegra186-emc.c +130 -0
176 lines not on this page · raw message
drivers/memory/tegra/tegra234.c +137 -1
233 lines not on this page · raw message
include/linux/tegra-icc.h new file +65 -0
65 lines not on this page · raw message
include/soc/tegra/mc.h +7 -0
@@ -13,6 +13,7 @@#include <linux/irq.h> #include <linux/reset-controller.h> #include <linux/types.h> +#include <linux/tegra-icc.h> struct clk ;struct device ;
@@ -26,6 +27,8 @@ struct tegra_mc_timing {struct tegra_mc_client {unsigned int id; +unsigned int bpmp_id; +enum tegra_icc_client_type type;const char *name;/* * For Tegra210 and earlier, this is the SWGROUP ID used for IOVA translations in the
@@ -166,8 +169,10 @@ struct tegra_mc_icc_ops {int (*set)(struct icc_node *src,struct icc_node *dst);int (*aggregate)(struct icc_node *node,u32 tag,u32 avg_bw,u32 peak_bw,u32 *agg_avg,u32 *agg_peak); +struct icc_node * (*xlate)(struct of_phandle_args *spec,void *data);struct icc_node_data *(*xlate_extended)(struct of_phandle_args *spec,void *data); +int (*get_bw)(struct icc_node *node,u32 *avg,u32 *peak); };struct tegra_mc_ops {
@@ -214,6 +219,7 @@ struct tegra_mc_soc { };struct tegra_mc { +struct tegra_bpmp *bpmp;struct device *dev;struct tegra_smmu *smmu;struct gart_device *gart;
@@ -229,6 +235,7 @@ struct tegra_mc {struct tegra_mc_timing *timings;unsigned int num_timings; +bool bwmgr_mrq_supported;struct reset_controller_dev reset;struct icc_provider provider;
Signature · 1 line
2.17.1
PATCH v5 2/8 memory: tegra: add mc clients for Tegra234
In reply to Sumit GuptaAdd few Isochronous (ISO) and Non-ISO MC clients. ISO clients have guaranteed bandwidth requirement. PCIE clients added to the mc_clients table represent each controller in Tegra234.
--- drivers/memory/tegra/tegra234.c | 420 ++++++++++++++++++++++++++++++++ 1 file changed, 420 insertions(+)
drivers/memory/tegra/tegra234.c +420 -0
@@ -14,6 +14,30 @@static const struct tegra_mc_client tegra234_mc_clients[] = { { + .id =TEGRA234_MEMORY_CLIENT_HDAR , + .name ="hdar" , + .bpmp_id =TEGRA_ICC_BPMP_HDA , + .type =TEGRA_ICC_ISO_AUDIO , + .sid =TEGRA234_SID_HDA , + .regs = { + .sid = { + .override =0xa8 , + .security =0xac , + }, + }, + }, { + .id =TEGRA234_MEMORY_CLIENT_HDAW , + .name ="hdaw" , + .bpmp_id =TEGRA_ICC_BPMP_HDA , + .type =TEGRA_ICC_ISO_AUDIO , + .sid =TEGRA234_SID_HDA , + .regs = { + .sid = { + .override =0x1a8 , + .security =0x1ac , + }, + }, + }, { .id =TEGRA234_MEMORY_CLIENT_MGBEARD , .name ="mgbeard" , .bpmp_id =TEGRA_ICC_BPMP_EQOS ,
@@ -133,6 +157,90 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { .security = 0x33c, }, }, + }, { + .id = TEGRA234_MEMORY_CLIENT_VI2W, + .name = "vi2w", + .bpmp_id = TEGRA_ICC_BPMP_VI2, + .type = TEGRA_ICC_ISO_VI, + .sid = TEGRA234_SID_ISO_VI2, + .regs = { + .sid = { + .override = 0x380, + .security = 0x384, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_VI2FALR, + .name = "vi2falr", + .bpmp_id = TEGRA_ICC_BPMP_VI2FAL, + .type = TEGRA_ICC_ISO_VIFAL, + .sid = TEGRA234_SID_ISO_VI2FALC, + .regs = { + .sid = { + .override = 0x388, + .security = 0x38c, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_VI2FALW, + .name = "vi2falw", + .bpmp_id = TEGRA_ICC_BPMP_VI2FAL, + .type = TEGRA_ICC_ISO_VIFAL, + .sid = TEGRA234_SID_ISO_VI2FALC, + .regs = { + .sid = { + .override = 0x3e0, + .security = 0x3e4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_APER, + .name = "aper", + .bpmp_id = TEGRA_ICC_BPMP_APE, + .type = TEGRA_ICC_ISO_AUDIO, + .sid = TEGRA234_SID_APE, + .regs = { + .sid = { + .override = 0x3d0, + .security = 0x3d4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_APEW, + .name = "apew", + .bpmp_id = TEGRA_ICC_BPMP_APE, + .type = TEGRA_ICC_ISO_AUDIO, + .sid = TEGRA234_SID_APE, + .regs = { + .sid = { + .override = 0x3d8, + .security = 0x3dc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_NVDISPLAYR, + .name = "nvdisplayr", + .bpmp_id = TEGRA_ICC_BPMP_DISPLAY, + .type = TEGRA_ICC_ISO_DISPLAY, + .sid = TEGRA234_SID_ISO_NVDISPLAY, + .regs = { + .sid = { + .override = 0x490, + .security = 0x494, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_NVDISPLAYR1, + .name = "nvdisplayr1", + .bpmp_id = TEGRA_ICC_BPMP_DISPLAY, + .type = TEGRA_ICC_ISO_DISPLAY, + .sid = TEGRA234_SID_ISO_NVDISPLAY, + .regs = { + .sid = { + .override = 0x508, + .security = 0x50c, + }, + }, }, { .id = TEGRA234_MEMORY_CLIENT_BPMPR, .name = "bpmpr",
@@ -357,6 +465,318 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { .security = 0x37c, }, }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE0R, + .name = "pcie0r", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_0, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE0, + .regs = { + .sid = { + .override = 0x6c0, + .security = 0x6c4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE0W, + .name = "pcie0w", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_0, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE0, + .regs = { + .sid = { + .override = 0x6c8, + .security = 0x6cc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE1R, + .name = "pcie1r", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_1, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE1, + .regs = { + .sid = { + .override = 0x6d0, + .security = 0x6d4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE1W, + .name = "pcie1w", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_1, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE1, + .regs = { + .sid = { + .override = 0x6d8, + .security = 0x6dc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE2AR, + .name = "pcie2ar", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_2, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE2, + .regs = { + .sid = { + .override = 0x6e0, + .security = 0x6e4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE2AW, + .name = "pcie2aw", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_2, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE2, + .regs = { + .sid = { + .override = 0x6e8, + .security = 0x6ec, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE3R, + .name = "pcie3r", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_3, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE3, + .regs = { + .sid = { + .override = 0x6f0, + .security = 0x6f4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE3W, + .name = "pcie3w", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_3, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE3, + .regs = { + .sid = { + .override = 0x6f8, + .security = 0x6fc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE4R, + .name = "pcie4r", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_4, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE4, + .regs = { + .sid = { + .override = 0x700, + .security = 0x704, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE4W, + .name = "pcie4w", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_4, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE4, + .regs = { + .sid = { + .override = 0x708, + .security = 0x70c, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE5R, + .name = "pcie5r", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_5, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE5, + .regs = { + .sid = { + .override = 0x710, + .security = 0x714, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE5W, + .name = "pcie5w", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_5, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE5, + .regs = { + .sid = { + .override = 0x718, + .security = 0x71c, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE5R1, + .name = "pcie5r1", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_5, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE5, + .regs = { + .sid = { + .override = 0x778, + .security = 0x77c, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE6AR, + .name = "pcie6ar", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_6, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE6, + .regs = { + .sid = { + .override = 0x140, + .security = 0x144, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE6AW, + .name = "pcie6aw", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_6, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE6, + .regs = { + .sid = { + .override = 0x148, + .security = 0x14c, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE6AR1, + .name = "pcie6ar1", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_6, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE6, + .regs = { + .sid = { + .override = 0x1e8, + .security = 0x1ec, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE7AR, + .name = "pcie7ar", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_7, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE7, + .regs = { + .sid = { + .override = 0x150, + .security = 0x154, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE7AW, + .name = "pcie7aw", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_7, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE7, + .regs = { + .sid = { + .override = 0x180, + .security = 0x184, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE7AR1, + .name = "pcie7ar1", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_7, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE7, + .regs = { + .sid = { + .override = 0x248, + .security = 0x24c, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE8AR, + .name = "pcie8ar", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_8, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE8, + .regs = { + .sid = { + .override = 0x190, + .security = 0x194, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE8AW, + .name = "pcie8aw", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_8, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE8, + .regs = { + .sid = { + .override = 0x1d8, + .security = 0x1dc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE9AR, + .name = "pcie9ar", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_9, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE9, + .regs = { + .sid = { + .override = 0x1e0, + .security = 0x1e4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE9AW, + .name = "pcie9aw", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_9, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE9, + .regs = { + .sid = { + .override = 0x1f0, + .security = 0x1f4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE10AR, + .name = "pcie10ar", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_10, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE10, + .regs = { + .sid = { + .override = 0x1f8, + .security = 0x1fc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE10AW, + .name = "pcie10aw", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_10, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE10, + .regs = { + .sid = { + .override = 0x200, + .security = 0x204, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE10AR1, + .name = "pcie10ar1", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_10, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE10, + .regs = { + .sid = { + .override = 0x240, + .security = 0x244, + }, + }, }, };
Signature · 1 line
2.17.1
PATCH v5 3/8 memory: tegra: add software mc clients in Tegra234
In reply to Sumit GuptaAdd dummy Memory Controller clients to represent CPU clusters. They will be used by the CPUFREQ driver to scale DRAM FREQ with the CPU FREQ.
--- drivers/memory/tegra/tegra234.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
drivers/memory/tegra/tegra234.c +15 -0
@@ -777,6 +777,21 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { .security = 0x244, }, }, + }, { + .id = TEGRA_ICC_MC_CPU_CLUSTER0, + .name = "sw_cluster0", + .bpmp_id = TEGRA_ICC_BPMP_CPU_CLUSTER0, + .type = TEGRA_ICC_NISO, + }, { + .id = TEGRA_ICC_MC_CPU_CLUSTER1, + .name = "sw_cluster1", + .bpmp_id = TEGRA_ICC_BPMP_CPU_CLUSTER1, + .type = TEGRA_ICC_NISO, + }, { + .id = TEGRA_ICC_MC_CPU_CLUSTER2, + .name = "sw_cluster2", + .bpmp_id = TEGRA_ICC_BPMP_CPU_CLUSTER2, + .type = TEGRA_ICC_NISO, }, };
Signature · 1 line
2.17.1
PATCH v5 4/8 dt-bindings: tegra: add icc ids for dummy MC clients
In reply to Sumit GuptaAdd ICC id's for dummy software clients representing CCPLEX clusters.
--- include/dt-bindings/memory/tegra234-mc.h | 5 +++++ 1 file changed, 5 insertions(+)
include/dt-bindings/memory/tegra234-mc.h +5 -0
@@ -536,4 +536,9 @@#define TEGRA234_MEMORY_CLIENT_NVJPG1SRD 0x123#define TEGRA234_MEMORY_CLIENT_NVJPG1SWR 0x124 +/* ICC ID's for dummy MC clients used to represent CPU Clusters */ +#define TEGRA_ICC_MC_CPU_CLUSTER0 1003 +#define TEGRA_ICC_MC_CPU_CLUSTER1 1004 +#define TEGRA_ICC_MC_CPU_CLUSTER2 1005 +#endif
Signature · 1 line
2.17.1
PATCH v5 5/8 memory: tegra: make cpu cluster bw request a multiple of mc channels
In reply to Sumit GuptaMake CPU cluster's bandwidth (BW) request a multiple of MC channels. CPU OPP tables have BW info per MC channel. But, the actual BW depends on the number of MC channels which can change as per the boot config. Get the number of MC channels which are actually enabled in current boot configuration and multiply the BW request from a CPU cluster with the number of enabled MC channels. This is not required to be done for other MC clients.
--- drivers/memory/tegra/mc.c | 19 +++++++++++++++++++ drivers/memory/tegra/mc.h | 1 + drivers/memory/tegra/tegra234.c | 24 +++++++++++++++++++++++- include/soc/tegra/mc.h | 1 + 4 files changed, 44 insertions(+), 1 deletion(-)
drivers/memory/tegra/mc.c +19 -0
@@ -843,6 +843,23 @@ static int tegra_mc_interconnect_setup(struct tegra_mc *mc)return err; } +static void tegra_mc_num_channel_enabled (struct tegra_mc *mc) +{ +unsigned int i; +u32 value; + + value =mc_ch_readl (mc,0 ,MC_EMEM_ADR_CFG_CHANNEL_ENABLE ); +if (value <=0 ) { + mc->num_channels = mc->soc->num_channels; +return ; + } + +for (i =0 ; i <32 ; i++) { +if (value &BIT (i)) + mc->num_channels++; + } +} +static int tegra_mc_probe (struct platform_device *pdev) {struct tegra_mc *mc;
@@ -881,6 +898,8 @@ static int tegra_mc_probe(struct platform_device *pdev)return err; } +tegra_mc_num_channel_enabled (mc); +if (mc->soc->ops && mc->soc->ops->handle_irq) { mc->irq =platform_get_irq (pdev,0 );if (mc->irq <0 )
drivers/memory/tegra/mc.h +1 -0
@@ -53,6 +53,7 @@#define MC_ERR_ROUTE_SANITY_ADR 0x9c4#define MC_ERR_GENERALIZED_CARVEOUT_STATUS 0xc00#define MC_ERR_GENERALIZED_CARVEOUT_ADR 0xc04 +#define MC_EMEM_ADR_CFG_CHANNEL_ENABLE 0xdf8#define MC_GLOBAL_INTSTATUS 0xf24#define MC_ERR_ADR_HI 0x11fc
drivers/memory/tegra/tegra234.c +23 -1
@@ -867,6 +867,28 @@ static int tegra234_mc_icc_set(struct icc_node *src, struct icc_node *dst)return ret; } +static int tegra234_mc_icc_aggregate (struct icc_node *node,u32 tag,u32 avg_bw, +u32 peak_bw,u32 *agg_avg,u32 *agg_peak) +{ +struct icc_provider *p = node->provider; +struct tegra_mc *mc =icc_provider_to_tegra_mc (p); + +if (!mc->bwmgr_mrq_supported) +return -EINVAL ; + +if (node->id ==TEGRA_ICC_MC_CPU_CLUSTER0 || + node->id ==TEGRA_ICC_MC_CPU_CLUSTER1 || + node->id ==TEGRA_ICC_MC_CPU_CLUSTER2 ) { +if (mc) + peak_bw = peak_bw * mc->num_channels; + } + + *agg_avg += avg_bw; + *agg_peak =max (*agg_peak, peak_bw); + +return 0 ; +} +static struct icc_node *tegra234_mc_of_icc_xlate (struct of_phandle_args *spec,void *data) {
@@ -898,7 +920,7 @@ static int tegra234_mc_icc_get_init_bw(struct icc_node *node, u32 *avg, u32 *peastatic const struct tegra_mc_icc_ops tegra234_mc_icc_ops = { .xlate = tegra234_mc_of_icc_xlate, - .aggregate = icc_std_aggregate, + .aggregate = tegra234_mc_icc_aggregate, .get_bw = tegra234_mc_icc_get_init_bw, .set = tegra234_mc_icc_set, };
include/soc/tegra/mc.h +1 -0
@@ -234,6 +234,7 @@ struct tegra_mc {struct tegra_mc_timing *timings;unsigned int num_timings; +unsigned int num_channels;bool bwmgr_mrq_supported;struct reset_controller_dev reset;
Signature · 1 line
2.17.1
PATCH v5 6/8 cpufreq: tegra194: add OPP support and set bandwidth
In reply to Sumit GuptaAdd support to use OPP table from DT in Tegra194 cpufreq driver. Tegra SoC's receive the frequency lookup table (LUT) from BPMP-FW. Cross check the OPP's present in DT against the LUT from BPMP-FW and enable only those DT OPP's which are present in LUT also.
The OPP table in DT has CPU Frequency to bandwidth mapping where the bandwidth value is per MC channel. DRAM bandwidth depends on the number of MC channels which can vary as per the boot configuration. This per channel bandwidth from OPP table will be later converted by MC driver to final bandwidth value by multiplying with number of channels before sending the request to BPMP-FW.
If OPP table is not present in DT, then use the LUT from BPMP-FW directy as the CPU frequency table and not do the DRAM frequency scaling which is same as the current behavior.
Now, as the CPU Frequency table is being controlling through OPP table in DT. Keeping fewer entries in the table will create less frequency steps and can help to scale fast to high frequencies when required.
--- drivers/cpufreq/tegra194-cpufreq.c | 156 ++++++++++++++++++++++++++--- 1 file changed, 143 insertions(+), 13 deletions(-)
drivers/cpufreq/tegra194-cpufreq.c +143 -13
@@ -12,6 +12,7 @@#include <linux/of_platform.h> #include <linux/platform_device.h> #include <linux/slab.h> +#include <linux/units.h> #include <asm/smp_plat.h>
@@ -65,12 +66,36 @@ struct tegra_cpufreq_soc {struct tegra194_cpufreq_data {void __iomem *regs; -struct cpufreq_frequency_table **tables; +struct cpufreq_frequency_table **bpmp_luts;const struct tegra_cpufreq_soc *soc; +bool icc_dram_bw_scaling; };static struct workqueue_struct *read_counters_wq; +static int tegra_cpufreq_set_bw (struct cpufreq_policy *policy,unsigned long freq_khz) +{ +struct tegra194_cpufreq_data *data =cpufreq_get_driver_data (); +struct dev_pm_opp *opp; +struct device *dev; +int ret; + + dev =get_cpu_device (policy->cpu); +if (!dev) +return -ENODEV ; + + opp =dev_pm_opp_find_freq_exact (dev, freq_khz *KHZ , true); +if (IS_ERR (opp)) +return PTR_ERR (opp); + + ret =dev_pm_opp_set_opp (dev, opp); +if (ret) + data->icc_dram_bw_scaling = false; + +dev_pm_opp_put (opp); +return ret; +} +static void tegra_get_cpu_mpidr (void *mpidr) { *((u64 *)mpidr) =read_cpuid_mpidr () &MPIDR_HWID_BITMASK ;
@@ -354,7 +379,7 @@ static unsigned int tegra194_get_speed(u32 cpu)* to the last written ndiv value from freq_table. This is * done to return consistent value. */ -cpufreq_for_each_valid_entry (pos, data->tables[clusterid]) { +cpufreq_for_each_valid_entry (pos, data->bpmp_luts[clusterid]) {if (pos->driver_data != ndiv)continue ;
@@ -369,16 +394,93 @@ static unsigned int tegra194_get_speed(u32 cpu)return rate; } +static int tegra_cpufreq_init_cpufreq_table (struct cpufreq_policy *policy, +struct cpufreq_frequency_table *bpmp_lut, +struct cpufreq_frequency_table **opp_table) +{ +struct tegra194_cpufreq_data *data =cpufreq_get_driver_data (); +struct cpufreq_frequency_table *freq_table =NULL ; +struct cpufreq_frequency_table *pos; +struct device *cpu_dev; +struct dev_pm_opp *opp; +unsigned long rate; +int ret, max_opps; +int j =0 ; + + cpu_dev =get_cpu_device (policy->cpu); +if (!cpu_dev) { +pr_err ("%s: failed to get cpu%d device\n" , __func__, policy->cpu); +return -ENODEV ; + } + +/* Initialize OPP table mentioned in operating-points-v2 property in DT */ + ret =dev_pm_opp_of_add_table_indexed (cpu_dev,0 ); +if (!ret) { + max_opps =dev_pm_opp_get_opp_count (cpu_dev); +if (max_opps <=0 ) { +dev_err (cpu_dev,"Failed to add OPPs\n" ); +return max_opps; + } + +/* Disable all opps and cross-validate against LUT later */ +for (rate =0 ; ; rate++) { + opp =dev_pm_opp_find_freq_ceil (cpu_dev, &rate); +if (IS_ERR (opp)) +break ; + +dev_pm_opp_put (opp); +dev_pm_opp_disable (cpu_dev, rate); + } + }else { +dev_err (cpu_dev,"Invalid or empty opp table in device tree\n" ); + data->icc_dram_bw_scaling = false; +return ret; + } + + freq_table =kcalloc ((max_opps +1 ),sizeof (*freq_table),GFP_KERNEL ); +if (!freq_table) +return -ENOMEM ; + +/* +* Cross check the frequencies from BPMP-FW LUT against the OPP's present in DT. +* Enable only those DT OPP's which are present in LUT also. +*/ +cpufreq_for_each_valid_entry (pos, bpmp_lut) { + opp =dev_pm_opp_find_freq_exact (cpu_dev, pos->frequency *KHZ , false); +if (IS_ERR (opp)) +continue ; + + ret =dev_pm_opp_enable (cpu_dev, pos->frequency *KHZ ); +if (ret <0 ) +return ret; + + freq_table[j].driver_data = pos->driver_data; + freq_table[j].frequency = pos->frequency; + j++; + } + + freq_table[j].driver_data = pos->driver_data; + freq_table[j].frequency =CPUFREQ_TABLE_END ; + + *opp_table = &freq_table[0 ]; + +dev_pm_opp_set_sharing_cpus (cpu_dev, policy->cpus); + +return ret; +} +static int tegra194_cpufreq_init (struct cpufreq_policy *policy) {struct tegra194_cpufreq_data *data =cpufreq_get_driver_data ();int maxcpus_per_cluster = data->soc->maxcpus_per_cluster; +struct cpufreq_frequency_table *freq_table; +struct cpufreq_frequency_table *bpmp_lut;u32 start_cpu, cpu;u32 clusterid; +int ret; data->soc->ops->get_cpu_cluster_id (policy->cpu,NULL , &clusterid); - -if (clusterid >= data->soc->num_clusters || !data->tables[clusterid]) +if (clusterid >= data->soc->num_clusters || !data->bpmp_luts[clusterid])return -EINVAL ; start_cpu =rounddown (policy->cpu, maxcpus_per_cluster);
@@ -387,9 +489,22 @@ static int tegra194_cpufreq_init(struct cpufreq_policy *policy)if (cpu_possible (cpu))cpumask_set_cpu (cpu, policy->cpus); } - policy->freq_table = data->tables[clusterid]; policy->cpuinfo.transition_latency =TEGRA_CPUFREQ_TRANSITION_LATENCY ; + bpmp_lut = data->bpmp_luts[clusterid]; + +if (data->icc_dram_bw_scaling) { + ret =tegra_cpufreq_init_cpufreq_table (policy, bpmp_lut, &freq_table); +if (!ret) { + policy->freq_table = freq_table; +return 0 ; + } + } + + data->icc_dram_bw_scaling = false; + policy->freq_table = bpmp_lut; +pr_info ("OPP tables missing from DT, EMC frequency scaling disabled\n" ); +return 0 ; }
@@ -406,6 +521,9 @@ static int tegra194_cpufreq_set_target(struct cpufreq_policy *policy,*/ data->soc->ops->set_cpu_ndiv (policy, (u64 )tbl->driver_data); +if (data->icc_dram_bw_scaling) +tegra_cpufreq_set_bw (policy, tbl->frequency); +return 0 ; }
@@ -439,8 +557,8 @@ static void tegra194_cpufreq_free_resources(void) }static struct cpufreq_frequency_table * -init_freq_table (struct platform_device *pdev,struct tegra_bpmp *bpmp, -unsigned int cluster_id) +tegra_cpufreq_bpmp_read_lut (struct platform_device *pdev,struct tegra_bpmp *bpmp, +unsigned int cluster_id) {struct cpufreq_frequency_table *freq_table;struct mrq_cpu_ndiv_limits_response resp;
@@ -515,6 +633,7 @@ static int tegra194_cpufreq_probe(struct platform_device *pdev)const struct tegra_cpufreq_soc *soc;struct tegra194_cpufreq_data *data;struct tegra_bpmp *bpmp; +struct device *cpu_dev;int err, i; data =devm_kzalloc (&pdev->dev,sizeof (*data),GFP_KERNEL );
@@ -530,9 +649,9 @@ static int tegra194_cpufreq_probe(struct platform_device *pdev)return -EINVAL ; } - data->tables =devm_kcalloc (&pdev->dev, data->soc->num_clusters, -sizeof (*data->tables),GFP_KERNEL ); -if (!data->tables) + data->bpmp_luts =devm_kcalloc (&pdev->dev, data->soc->num_clusters, +sizeof (*data->bpmp_luts),GFP_KERNEL ); +if (!data->bpmp_luts)return -ENOMEM ;if (soc->actmon_cntr_base) {
@@ -556,15 +675,26 @@ static int tegra194_cpufreq_probe(struct platform_device *pdev) }for (i =0 ; i < data->soc->num_clusters; i++) { - data->tables[i] =init_freq_table (pdev, bpmp, i); -if (IS_ERR (data->tables[i])) { - err =PTR_ERR (data->tables[i]); + data->bpmp_luts[i] =tegra_cpufreq_bpmp_read_lut (pdev, bpmp, i); +if (IS_ERR (data->bpmp_luts[i])) { + err =PTR_ERR (data->bpmp_luts[i]); goto err_free_res; } } tegra194_cpufreq_driver.driver_data = data; +/* Check for optional OPPv2 and interconnect paths on CPU0 to enable ICC scaling */ + cpu_dev =get_cpu_device (0 ); +if (!cpu_dev) +return -EPROBE_DEFER ; + +if (dev_pm_opp_of_get_opp_desc_node (cpu_dev)) { + err =dev_pm_opp_of_find_icc_paths (cpu_dev,NULL ); +if (!err) + data->icc_dram_bw_scaling = true; + } + err =cpufreq_register_driver (&tegra194_cpufreq_driver);if (!err) goto put_bpmp;
Signature · 1 line
2.17.1
PATCH v5 7/8 PCI: tegra194: add interconnect support in Tegra234
In reply to Sumit GuptaAdd support to request DRAM bandwidth with Memory Interconnect in Tegra234 SoC. The DRAM BW required for different modes depends on speed (Gen-1/2/3/4) and width/lanes (x1/x2/x4/x8).
--- drivers/pci/controller/dwc/pcie-tegra194.c | 44 ++++++++++++++++++---- 1 file changed, 36 insertions(+), 8 deletions(-)
drivers/pci/controller/dwc/pcie-tegra194.c +36 -8
@@ -14,6 +14,7 @@#include <linux/delay.h> #include <linux/gpio.h> #include <linux/gpio/consumer.h> +#include <linux/interconnect.h> #include <linux/interrupt.h> #include <linux/iopoll.h> #include <linux/kernel.h>
@@ -223,6 +224,7 @@#define EP_STATE_ENABLED 1static const unsigned int pcie_gen_freq[] = { +GEN1_CORE_CLK_FREQ ,/* PCI_EXP_LNKSTA_CLS == 0; undefined */ GEN1_CORE_CLK_FREQ ,GEN2_CORE_CLK_FREQ ,GEN3_CORE_CLK_FREQ ,
@@ -287,6 +289,7 @@ struct tegra_pcie_dw {unsigned int pex_rst_irq;int ep_state;long link_status; +struct icc_path *icc_path; };static inline struct tegra_pcie_dw *to_tegra_pcie (struct dw_pcie *pci)
@@ -309,6 +312,27 @@ struct tegra_pcie_soc {enum dw_pcie_device_mode mode; }; +static void tegra_pcie_icc_set (struct tegra_pcie_dw *pcie) +{ +struct dw_pcie *pci = &pcie->pci; +u32 val, speed, width; + + val =dw_pcie_readw_dbi (pci, pcie->pcie_cap_base +PCI_EXP_LNKSTA ); + + speed =FIELD_GET (PCI_EXP_LNKSTA_CLS , val); + width =FIELD_GET (PCI_EXP_LNKSTA_NLW , val); + + val = width * (PCIE_SPEED2MBS_ENC (pcie_link_speed[speed]) /BITS_PER_BYTE ); + +if (icc_set_bw (pcie->icc_path,MBps_to_icc (val),0 )) +dev_err (pcie->dev,"can't set bw[%u]\n" , val); + +if (speed >=ARRAY_SIZE (pcie_gen_freq)) + speed =0 ; + +clk_set_rate (pcie->core_clk, pcie_gen_freq[speed]); +} +static void apply_bad_link_workaround (struct dw_pcie_rp *pp) {struct dw_pcie *pci =to_dw_pcie_from_pp (pp);
@@ -452,14 +476,12 @@ static irqreturn_t tegra_pcie_ep_irq_thread(int irq, void *arg)struct tegra_pcie_dw *pcie = arg;struct dw_pcie_ep *ep = &pcie->pci.ep;struct dw_pcie *pci = &pcie->pci; -u32 val, speed; +u32 val;if (test_and_clear_bit (0 , &pcie->link_status))dw_pcie_ep_linkup (ep); - speed =dw_pcie_readw_dbi (pci, pcie->pcie_cap_base +PCI_EXP_LNKSTA ) & -PCI_EXP_LNKSTA_CLS ; -clk_set_rate (pcie->core_clk, pcie_gen_freq[speed -1 ]); +tegra_pcie_icc_set (pcie);if (pcie->of_data->has_ltr_req_fix)return IRQ_HANDLED ;
@@ -945,9 +967,9 @@ static int tegra_pcie_dw_host_init(struct dw_pcie_rp *pp)static int tegra_pcie_dw_start_link (struct dw_pcie *pci) { -u32 val, offset, speed, tmp;struct tegra_pcie_dw *pcie =to_tegra_pcie (pci);struct dw_pcie_rp *pp = &pci->pp; +u32 val, offset, tmp;bool retry = true;if (pcie->of_data->mode ==DW_PCIE_EP_TYPE ) {
@@ -1018,9 +1040,7 @@ static int tegra_pcie_dw_start_link(struct dw_pcie *pci) goto retry_link; } - speed =dw_pcie_readw_dbi (pci, pcie->pcie_cap_base +PCI_EXP_LNKSTA ) & -PCI_EXP_LNKSTA_CLS ; -clk_set_rate (pcie->core_clk, pcie_gen_freq[speed -1 ]); +tegra_pcie_icc_set (pcie);tegra_pcie_enable_interrupts (pp);
@@ -2224,6 +2244,14 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)platform_set_drvdata (pdev, pcie); + pcie->icc_path =devm_of_icc_get (&pdev->dev,"write" ); + ret =PTR_ERR_OR_ZERO (pcie->icc_path); +if (ret) { +tegra_bpmp_put (pcie->bpmp); +dev_err_probe (&pdev->dev, ret,"failed to get write interconnect\n" ); +return ret; + } +switch (pcie->of_data->mode) {case DW_PCIE_RC_TYPE : ret = devm_request_irq(dev, pp->irq, tegra_pcie_rp_irq_handler,
Signature · 1 line
2.17.1
Lorenzo Pieralisi
maintainerRe: [Patch v5 7/8] PCI: tegra194: add interconnect support in Tegra234
You should still capitalize the subject.
"PCI: tegra194: Add interconnect.."
Quoted 5 lines · Sumit Gupta
Add support to request DRAM bandwidth with Memory Interconnect in Tegra234 SoC. The DRAM BW required for different modes depends on speed (Gen-1/2/3/4) and width/lanes (x1/x2/x4/x8).
Suggested-by Manikanta Maddireddy <[email protected]>
You should add a Link to the relevant lore archive, I am pretty sure Bjorn chimed in too.
This patch does too many things at once; more importantly it does *not* explain why we request memory bandwidth and why it is required and *safe* given that the current code works so far.
So:
patch 1: fix the array overflow issues with the current code patch 2: add memory bandwidth interconnect support
Thanks,
Lorenzo
Quoted 118 lines
Signed-off-by Sumit Gupta <[email protected]>--- drivers/pci/controller/dwc/pcie-tegra194.c | 44 ++++++++++++++++++---- 1 file changed, 36 insertions(+), 8 deletions(-)drivers/pci/controller/dwc/pcie-tegra194.c +36
-8@@ -14,6 +14,7 @@#include <linux/delay.h> #include <linux/gpio.h> #include <linux/gpio/consumer.h> +#include <linux/interconnect.h> #include <linux/interrupt.h> #include <linux/iopoll.h> #include <linux/kernel.h> @@ -223,6 +224,7 @@#define EP_STATE_ENABLED 1static const unsigned int pcie_gen_freq[] = { +GEN1_CORE_CLK_FREQ ,/* PCI_EXP_LNKSTA_CLS == 0; undefined */ GEN1_CORE_CLK_FREQ ,GEN2_CORE_CLK_FREQ ,GEN3_CORE_CLK_FREQ ,@@ -287,6 +289,7 @@ struct tegra_pcie_dw {unsigned int pex_rst_irq;int ep_state;long link_status; +struct icc_path *icc_path; };static inline struct tegra_pcie_dw *to_tegra_pcie (struct dw_pcie *pci)@@ -309,6 +312,27 @@ struct tegra_pcie_soc {enum dw_pcie_device_mode mode; }; +static void tegra_pcie_icc_set (struct tegra_pcie_dw *pcie) +{ +struct dw_pcie *pci = &pcie->pci; +u32 val, speed, width; + + val =dw_pcie_readw_dbi (pci, pcie->pcie_cap_base +PCI_EXP_LNKSTA ); + + speed =FIELD_GET (PCI_EXP_LNKSTA_CLS , val); + width =FIELD_GET (PCI_EXP_LNKSTA_NLW , val); + + val = width * (PCIE_SPEED2MBS_ENC (pcie_link_speed[speed]) /BITS_PER_BYTE ); + +if (icc_set_bw (pcie->icc_path,MBps_to_icc (val),0 )) +dev_err (pcie->dev,"can't set bw[%u]\n" , val); + +if (speed >=ARRAY_SIZE (pcie_gen_freq)) + speed =0 ; + +clk_set_rate (pcie->core_clk, pcie_gen_freq[speed]); +} +static void apply_bad_link_workaround (struct dw_pcie_rp *pp) {struct dw_pcie *pci =to_dw_pcie_from_pp (pp);@@ -452,14 +476,12 @@ static irqreturn_t tegra_pcie_ep_irq_thread(int irq, void *arg)struct tegra_pcie_dw *pcie = arg;struct dw_pcie_ep *ep = &pcie->pci.ep;struct dw_pcie *pci = &pcie->pci; -u32 val, speed; +u32 val;if (test_and_clear_bit (0 , &pcie->link_status))dw_pcie_ep_linkup (ep); - speed =dw_pcie_readw_dbi (pci, pcie->pcie_cap_base +PCI_EXP_LNKSTA ) & -PCI_EXP_LNKSTA_CLS ; -clk_set_rate (pcie->core_clk, pcie_gen_freq[speed -1 ]); +tegra_pcie_icc_set (pcie);if (pcie->of_data->has_ltr_req_fix)return IRQ_HANDLED ;@@ -945,9 +967,9 @@ static int tegra_pcie_dw_host_init(struct dw_pcie_rp *pp)static int tegra_pcie_dw_start_link (struct dw_pcie *pci) { -u32 val, offset, speed, tmp;struct tegra_pcie_dw *pcie =to_tegra_pcie (pci);struct dw_pcie_rp *pp = &pci->pp; +u32 val, offset, tmp;bool retry = true;if (pcie->of_data->mode ==DW_PCIE_EP_TYPE ) {@@ -1018,9 +1040,7 @@ static int tegra_pcie_dw_start_link(struct dw_pcie *pci) goto retry_link; } - speed =dw_pcie_readw_dbi (pci, pcie->pcie_cap_base +PCI_EXP_LNKSTA ) & -PCI_EXP_LNKSTA_CLS ; -clk_set_rate (pcie->core_clk, pcie_gen_freq[speed -1 ]); +tegra_pcie_icc_set (pcie);tegra_pcie_enable_interrupts (pp);@@ -2224,6 +2244,14 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)platform_set_drvdata (pdev, pcie); + pcie->icc_path =devm_of_icc_get (&pdev->dev,"write" ); + ret =PTR_ERR_OR_ZERO (pcie->icc_path); +if (ret) { +tegra_bpmp_put (pcie->bpmp); +dev_err_probe (&pdev->dev, ret,"failed to get write interconnect\n" ); +return ret; + } +switch (pcie->of_data->mode) {case DW_PCIE_RC_TYPE : ret = devm_request_irq(dev, pp->irq, tegra_pcie_rp_irq_handler,Signature · 1 line
2.17.1
Re: [Patch v5 7/8] PCI: tegra194: add interconnect support in Tegra234
Quoted 7 lines
You should still capitalize the subject.
"PCI: tegra194: Add interconnect.."
Sure.
Quoted 10 lines · Sumit Gupta
Quoted 5 lines
Add support to request DRAM bandwidth with Memory Interconnect in Tegra234 SoC. The DRAM BW required for different modes depends on speed (Gen-1/2/3/4) and width/lanes (x1/x2/x4/x8).
Suggested-by Manikanta Maddireddy <[email protected]>You should add a Link to the relevant lore archive, I am pretty sure Bjorn chimed in too.
Sure.
Quoted 4 lines
This patch does too many things at once; more importantly it does *not* explain why we request memory bandwidth and why it is required and *safe* given that the current code works so far.
Quoted 8 lines
So:
patch 1: fix the array overflow issues with the current code patch 2: add memory bandwidth interconnect support
Thanks,
Lorenzo
Thank you for the review.
I will split this patch into two and add the info as sugested in v6.
Will spin a v6 soon if there is no further comment.
Thanks,
Sumit
Quoted 118 lines
Quoted 118 lines
Signed-off-by Sumit Gupta <[email protected]>--- drivers/pci/controller/dwc/pcie-tegra194.c | 44 ++++++++++++++++++---- 1 file changed, 36 insertions(+), 8 deletions(-)drivers/pci/controller/dwc/pcie-tegra194.c +36
-9@@ -14,6 +14,7 @@#include <linux/delay.h> #include <linux/gpio.h> #include <linux/gpio/consumer.h> +#include <linux/interconnect.h> #include <linux/interrupt.h> #include <linux/iopoll.h> #include <linux/kernel.h> @@ -223,6 +224,7 @@#define EP_STATE_ENABLED 1static const unsigned int pcie_gen_freq[] = { +GEN1_CORE_CLK_FREQ ,/* PCI_EXP_LNKSTA_CLS == 0; undefined */ GEN1_CORE_CLK_FREQ ,GEN2_CORE_CLK_FREQ ,GEN3_CORE_CLK_FREQ ,@@ -287,6 +289,7 @@ struct tegra_pcie_dw {unsigned int pex_rst_irq;int ep_state;long link_status; +struct icc_path *icc_path; };static inline struct tegra_pcie_dw *to_tegra_pcie (struct dw_pcie *pci)@@ -309,6 +312,27 @@ struct tegra_pcie_soc {enum dw_pcie_device_mode mode; }; +static void tegra_pcie_icc_set (struct tegra_pcie_dw *pcie) +{ +struct dw_pcie *pci = &pcie->pci; +u32 val, speed, width; + + val =dw_pcie_readw_dbi (pci, pcie->pcie_cap_base +PCI_EXP_LNKSTA ); + + speed =FIELD_GET (PCI_EXP_LNKSTA_CLS , val); + width =FIELD_GET (PCI_EXP_LNKSTA_NLW , val); + + val = width * (PCIE_SPEED2MBS_ENC (pcie_link_speed[speed]) /BITS_PER_BYTE ); + +if (icc_set_bw (pcie->icc_path,MBps_to_icc (val),0 )) +dev_err (pcie->dev,"can't set bw[%u]\n" , val); + +if (speed >=ARRAY_SIZE (pcie_gen_freq)) + speed =0 ; + +clk_set_rate (pcie->core_clk, pcie_gen_freq[speed]); +} +static void apply_bad_link_workaround (struct dw_pcie_rp *pp) {struct dw_pcie *pci =to_dw_pcie_from_pp (pp);@@ -452,14 +476,12 @@ static irqreturn_t tegra_pcie_ep_irq_thread(int irq, void *arg)struct tegra_pcie_dw *pcie = arg;struct dw_pcie_ep *ep = &pcie->pci.ep;struct dw_pcie *pci = &pcie->pci; -u32 val, speed; +u32 val;if (test_and_clear_bit (0 , &pcie->link_status))dw_pcie_ep_linkup (ep); - speed =dw_pcie_readw_dbi (pci, pcie->pcie_cap_base +PCI_EXP_LNKSTA ) & -PCI_EXP_LNKSTA_CLS ; -clk_set_rate (pcie->core_clk, pcie_gen_freq[speed -1 ]); +tegra_pcie_icc_set (pcie);if (pcie->of_data->has_ltr_req_fix)return IRQ_HANDLED ;@@ -945,9 +967,9 @@ static int tegra_pcie_dw_host_init(struct dw_pcie_rp *pp)static int tegra_pcie_dw_start_link (struct dw_pcie *pci) { -u32 val, offset, speed, tmp;struct tegra_pcie_dw *pcie =to_tegra_pcie (pci);struct dw_pcie_rp *pp = &pci->pp; +u32 val, offset, tmp;bool retry = true;if (pcie->of_data->mode ==DW_PCIE_EP_TYPE ) {@@ -1018,9 +1040,7 @@ static int tegra_pcie_dw_start_link(struct dw_pcie *pci) goto retry_link; } - speed =dw_pcie_readw_dbi (pci, pcie->pcie_cap_base +PCI_EXP_LNKSTA ) & -PCI_EXP_LNKSTA_CLS ; -clk_set_rate (pcie->core_clk, pcie_gen_freq[speed -1 ]); +tegra_pcie_icc_set (pcie);tegra_pcie_enable_interrupts (pp);@@ -2224,6 +2244,14 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)platform_set_drvdata (pdev, pcie); + pcie->icc_path =devm_of_icc_get (&pdev->dev,"write" ); + ret =PTR_ERR_OR_ZERO (pcie->icc_path); +if (ret) { +tegra_bpmp_put (pcie->bpmp); +dev_err_probe (&pdev->dev, ret,"failed to get write interconnect\n" ); +return ret; + } +switch (pcie->of_data->mode) {case DW_PCIE_RC_TYPE : ret = devm_request_irq(dev, pp->irq, tegra_pcie_rp_irq_handler, --2.17.1
PATCH v5 8/8 arm64: tegra: Add cpu OPP tables and interconnects property
In reply to Sumit GuptaAdd OPP table and interconnects property to scale DDR frequency with CPU frequency for better performance. Each operating point entry of the OPP table has CPU freq to per MC channel bandwidth mapping. One table is added for each cluster even though the table data is same because the bandwidth request is per cluster. This is done because OPP framework creates a single icc path and hence single bandwidth request if the table is marked as 'opp-shared' and shared among all clusters. For us, the OPP table data is same but the MC Client ID argument to interconnects property is different for each cluster. So, having per cluster table makes different icc path for each cluster and helps to make per cluster BW requests.
--- arch/arm64/boot/dts/nvidia/tegra234.dtsi | 276 +++++++++++++++++++++++ 1 file changed, 276 insertions(+)
arch/arm64/boot/dts/nvidia/tegra234.dtsi +276 -0
@@ -3011,6 +3011,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl0_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER0 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3027,6 +3030,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl0_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER0 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3043,6 +3049,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl0_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER0 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3059,6 +3068,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl0_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER0 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3075,6 +3087,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl1_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER1 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3091,6 +3106,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl1_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER1 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3107,6 +3125,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl1_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER1 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3123,6 +3144,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl1_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER1 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3139,6 +3163,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl2_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER2 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3155,6 +3182,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl2_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER2 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3171,6 +3201,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl2_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER2 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3187,6 +3220,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl2_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER2 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3443,4 +3479,244 @@ interrupt-parent = <&gic>; always-on; }; + + cl0_opp_tbl: opp-table-cluster0 { + compatible = "operating-points-v2"; + opp-shared; + + cl0_ch1_opp1: opp-115200000 { + opp-hz = /bits/ 64 <115200000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp2: opp-268800000 { + opp-hz = /bits/ 64 <268800000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp3: opp-422400000 { + opp-hz = /bits/ 64 <422400000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp4: opp-576000000 { + opp-hz = /bits/ 64 <576000000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp5: opp-729600000 { + opp-hz = /bits/ 64 <729600000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp6: opp-883200000 { + opp-hz = /bits/ 64 <883200000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp7: opp-1036800000 { + opp-hz = /bits/ 64 <1036800000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp8: opp-1190400000 { + opp-hz = /bits/ 64 <1190400000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp9: opp-1344000000 { + opp-hz = /bits/ 64 <1344000000>; + opp-peak-kBps = <1632000>; + }; + + cl0_ch1_opp10: opp-1497600000 { + opp-hz = /bits/ 64 <1497600000>; + opp-peak-kBps = <1632000>; + }; + + cl0_ch1_opp11: opp-1651200000 { + opp-hz = /bits/ 64 <1651200000>; + opp-peak-kBps = <2660000>; + }; + + cl0_ch1_opp12: opp-1804800000 { + opp-hz = /bits/ 64 <1804800000>; + opp-peak-kBps = <2660000>; + }; + + cl0_ch1_opp13: opp-1958400000 { + opp-hz = /bits/ 64 <1958400000>; + opp-peak-kBps = <3200000>; + }; + + cl0_ch1_opp14: opp-2112000000 { + opp-hz = /bits/ 64 <2112000000>; + opp-peak-kBps = <6400000>; + }; + + cl0_ch1_opp15: opp-2201600000 { + opp-hz = /bits/ 64 <2201600000>; + opp-peak-kBps = <6400000>; + }; + }; + + cl1_opp_tbl: opp-table-cluster1 { + compatible = "operating-points-v2"; + opp-shared; + + cl1_ch1_opp1: opp-115200000 { + opp-hz = /bits/ 64 <115200000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp2: opp-268800000 { + opp-hz = /bits/ 64 <268800000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp3: opp-422400000 { + opp-hz = /bits/ 64 <422400000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp4: opp-576000000 { + opp-hz = /bits/ 64 <576000000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp5: opp-729600000 { + opp-hz = /bits/ 64 <729600000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp6: opp-883200000 { + opp-hz = /bits/ 64 <883200000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp7: opp-1036800000 { + opp-hz = /bits/ 64 <1036800000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp8: opp-1190400000 { + opp-hz = /bits/ 64 <1190400000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp9: opp-1344000000 { + opp-hz = /bits/ 64 <1344000000>; + opp-peak-kBps = <1632000>; + }; + + cl1_ch1_opp10: opp-1497600000 { + opp-hz = /bits/ 64 <1497600000>; + opp-peak-kBps = <1632000>; + }; + + cl1_ch1_opp11: opp-1651200000 { + opp-hz = /bits/ 64 <1651200000>; + opp-peak-kBps = <2660000>; + }; + + cl1_ch1_opp12: opp-1804800000 { + opp-hz = /bits/ 64 <1804800000>; + opp-peak-kBps = <2660000>; + }; + + cl1_ch1_opp13: opp-1958400000 { + opp-hz = /bits/ 64 <1958400000>; + opp-peak-kBps = <3200000>; + }; + + cl1_ch1_opp14: opp-2112000000 { + opp-hz = /bits/ 64 <2112000000>; + opp-peak-kBps = <6400000>; + }; + + cl1_ch1_opp15: opp-2201600000 { + opp-hz = /bits/ 64 <2201600000>; + opp-peak-kBps = <6400000>; + }; + }; + + cl2_opp_tbl: opp-table-cluster2 { + compatible = "operating-points-v2"; + opp-shared; + + cl2_ch1_opp1: opp-115200000 { + opp-hz = /bits/ 64 <115200000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp2: opp-268800000 { + opp-hz = /bits/ 64 <268800000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp3: opp-422400000 { + opp-hz = /bits/ 64 <422400000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp4: opp-576000000 { + opp-hz = /bits/ 64 <576000000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp5: opp-729600000 { + opp-hz = /bits/ 64 <729600000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp6: opp-883200000 { + opp-hz = /bits/ 64 <883200000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp7: opp-1036800000 { + opp-hz = /bits/ 64 <1036800000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp8: opp-1190400000 { + opp-hz = /bits/ 64 <1190400000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp9: opp-1344000000 { + opp-hz = /bits/ 64 <1344000000>; + opp-peak-kBps = <1632000>; + }; + + cl2_ch1_opp10: opp-1497600000 { + opp-hz = /bits/ 64 <1497600000>; + opp-peak-kBps = <1632000>; + }; + + cl2_ch1_opp11: opp-1651200000 { + opp-hz = /bits/ 64 <1651200000>; + opp-peak-kBps = <2660000>; + }; + + cl2_ch1_opp12: opp-1804800000 { + opp-hz = /bits/ 64 <1804800000>; + opp-peak-kBps = <2660000>; + }; + + cl2_ch1_opp13: opp-1958400000 { + opp-hz = /bits/ 64 <1958400000>; + opp-peak-kBps = <3200000>; + }; + + cl2_ch1_opp14: opp-2112000000 { + opp-hz = /bits/ 64 <2112000000>; + opp-peak-kBps = <6400000>; + }; + + cl2_ch1_opp15: opp-2201600000 { + opp-hz = /bits/ 64 <2201600000>; + opp-peak-kBps = <6400000>; + }; + }; };
Signature · 1 line
2.17.1