Skip to contentSkip to conversation

device property: Remove unused struct net_device forward declaration

PATCH In review Andy Shevchenko 2 participants 4 messages Mar 23, 2023 – Mar 27, 2023

Subsystems (3)
lore
Share & tools
lore

Andy Shevchenko

author reviewer
#0 lore raw

PATCH 1/1 device property: Remove unused struct net_device forward declaration

There is no users in the property.h for the struct net_device. Remove the latter for good.

---
 include/linux/property.h | 1 -
 1 file changed, 1 deletion(-)
include/linux/property.h +0 -1
index ee9cc1710d82..1dff38e930fc 100644
@@ -16,7 +16,6 @@
 #include <linux/types.h>
 
 struct device;
-struct net_device;
 
 enum dev_prop_type {
 	DEV_PROP_U8,
Signature · 1 line
2.40.0.1.gaa8946217a0b
author reviewer
#1 lore raw
Quoted 2 lines · Andy Shevchenko

There is no users in the property.h for the struct net_device. Remove the latter for good.

Oh, this seems unfortunate as it doesn't Cc Greg. Folks, shall we add the header to "DRIVER CORE, KOBJECTS, DEBUGFS AND SYSFS"?

Quoted 17 lines
---
 include/linux/property.h | 1 -
 1 file changed, 1 deletion(-)
include/linux/property.h +0 -1
index ee9cc1710d82..1dff38e930fc 100644
@@ -16,7 +16,6 @@
 #include <linux/types.h>
 
 struct device;
-struct net_device;
 
 enum dev_prop_type {
 	DEV_PROP_U8,
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 6 lines · Andy Shevchenko
Quoted 2 lines · Andy Shevchenko

There is no users in the property.h for the struct net_device. Remove the latter for good.

Oh, this seems unfortunate as it doesn't Cc Greg. Folks, shall we add the header to "DRIVER CORE, KOBJECTS, DEBUGFS AND SYSFS"?

Yes please.

author reviewer
#3 lore raw
Quoted 9 lines · Greg Kroah-Hartman
Quoted 6 lines · Andy Shevchenko
Quoted 2 lines · Andy Shevchenko

There is no users in the property.h for the struct net_device. Remove the latter for good.

Oh, this seems unfortunate as it doesn't Cc Greg. Folks, shall we add the header to "DRIVER CORE, KOBJECTS, DEBUGFS AND SYSFS"?

Yes please.

Done as v2 with this patch also resent there.

Signature · 2 lines
With Best Regards,
Andy Shevchenko