Skip to contentSkip to conversation

tracing: install trace events file only if necessary

PATCH Superseded [email protected] 2 participants 3 messages Mar 27, 2023 – Apr 8, 2023 Arm/Amlogic Meson SoC support

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tracing: install trace events file only if necessary

From: Carlos Santos <[email protected]>

It is not useful when configuring with --enable-trace-backends=nop.

---
Changes v1->v2:
Install based on chosen trace backend, not on chosen emulators.

---
 trace/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
trace/meson.build +1 -1
index 8e80be895c..3d96b4eea0 100644
@@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all',
                                  input: trace_events_files,
                                  command: [ 'cat', '@INPUT@' ],
                                  capture: true,
-                                 install: true,
+                                 install: get_option('trace_backends') != 'nop'
                                  install_dir: qemu_datadir)
 
 if 'ust' in get_option('trace_backends')
Signature · 1 line
2.31.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 6 lines · On Mon, Mar 27, 2023 at 02:30:58PM -0300, [email protected] wrote:

From: Carlos Santos <[email protected]>

It is not useful when configuring with --enable-trace-backends=nop.

---

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#2 lore raw
Quoted 12 lines · Daniel P. Berrangé
Quoted 6 lines · On Mon, Mar 27, 2023 at 02:30:58PM -0300, [email protected] wrote:

From: Carlos Santos <[email protected]>

It is not useful when configuring with --enable-trace-backends=nop.

---

Quoted 7 lines

With regards,
Daniel
--

|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

I updated the patch to fix the array comparison and add a missing comma.

Signature · 4 lines
Carlos Santos
Senior Software Maintenance Engineer
Red Hat
[email protected]    T: +55-11-3534-6186