ACPI _CRS CSI-2 and MIPI DisCo for Imaging support
Subsystems (5)
Sakari Ailus
reviewerv7 cover ACPI _CRS CSI-2 and MIPI DisCo for Imaging support
Hello all,
Here's an implementation of ACPI 6.4 _CRS CSI-2 resource descriptor and MIPI DisCo for Imaging 1.0 [1]. What the two basically provide is an officially sanctioned way to describe CSI-2 connected cameras to operating system software, something DT based systems have enjoyed for quite some time already.
The implementation digs the information from ACPI tables (_CRS descriptors and data + property extensions) and constructs software nodes that are compatible with Documentation/firmware-guide/acpi/dsd/graph.rst and Documentation/devicetree/bindings/media/video-interface-devices.yaml . No specific driver changes are needed.
The first patch of the set also removes the second namespace walk from DSDT root.
[1] https://www.mipi.org/specifications/mipi-disco-imaging
since v6:
- Avoid including an extra patch in the set. Otherwise the set is unchanged.
since v5:
- Add a high level description of the mipi.c file in the heading.
- Add a missing memory allocation check (thanks to Dan Carpenter).
- Prepend a patch to the set that removes the second ACPI namespace walk due _DEP. Instead, the devices that can't be initialised yet are collected to a linked list that is revisited after initialising the rest of the devices.
- Collect information on _CRS CSI2 records during the same, single namespace walk. Effectively since v5, two namespace walks from the namespace root are removed.
- The former requires passing state information between functions during the _DSD property initialisation, among other things, introducing additional function arguments in _DSD parsing functions.
- The order of the patches has changed somewhat, as the parsing process has changed. Also a patch has been added to collect ACPI devices for which software nodes need to be initialised for DisCo for Imaging.
- Elsewhere, acpi_bus_scan() becomes easier to grasp. Comments are also added in acpi_bus_scan() to explain what is being done.
- Change the wrong node type warning from acpi_parse_string_ref() to use debug level.
since v4:
- Add leading dots to comment sentences.
- Use UINT_MAX - 1 to denote an unallocated port instead of ~1U.
- Unwrap a line.
- Get ACPI handle into a local variable in acpi_init_swnodes() for easier use, use acpi_device_handle() to obtain it.
- Rework "rotation" property checking and _PLD object access.
- Also obtain return value of acpi_get_name() into a local variable before testing it.
- Use a local variable for the first element string pointer in acpi_properties_prepare_mipi().
since v3:
- Add comments to data structures and functions, code inside functions.
- Use ACPI_FAILURE() for testing ACPI framework function return values.
- Unwrap a few lines.
- Rename list heads as "head", some were called just "list".
- Count ACPI handles related to _CRS CSI2 resources during tree walk.
- Reshape testing for CSI-2 port allocation in next_csi2_port_index().
- Move allocation of software nodes into a new function, acpi_crs_csi2_alloc_fill_swnodes().
- Comments: acpi_bus_scan_crs_csi2() is to be called on the namespace root.
- Use size_t for this_count variable in acpi_bus_scan_crs_csi2().
- Revert the NEXT_PROPERTY() macro condition to original (the suggested one was different).
- Remove u union in init_port_csi2_common().
- Fix val array size in init_port_csi2_common(). This issue was masked by the presence of a u32 field in the union.
- Use "-" for copyright year range.
since v2:
- Unwrap a few lines.
- Copy CSI-2 resource source string using strscpy() instead of memcpy() in scan_check_crs_csi2_instance.
- Fix GRAPH_PORT_NAME() sanity check bug introduced in v2.
- Fix snprintf() return value check for port node name in get_mipi_port_handle().
- Fix mipi-img-lane-polarities reading.
- Cast bit value to bool instead of using ... ? 1U : 0U.
- Get primary fwnode using acpi_fwnode_handle().
- Don't use MIPI_IMG_PREFIX in the array of renamed properties.
- Use tabs for indenting drivers/acpi/property.c authors.
- Add a comment on assigning ACPI device's secondary fwnode and assign ACPI device's secondary fwnode straight to NULL when unassigning it.
since v1:
- Update copyright notices.
- Include linux/types.h instead of linux/kernel.h in drivers/acpi/mipi.c.
- Use SWNODE_GRAPH_PORT_NAME_FMT instead of plain "port@%u" in GRAPH_PORT_NAME macro.
- Make the condition in NEXT_PROPERTY() macro easier to read.
- Unwrap lines to make them moderately longer than 80 characters.
- Use * BITS_PER_TYPE(u8) instead of << 3 to convert bytes to bits in init_port_csi2_common().
- Test ACPI framework call success using ACPI_SUCCESS() instead of comparing with AE_OK. Likewise for ACPI_FAILURE and != AE_OK.
- Use newly added SOFTWARE_NODE() macro to construct the root software node.
- Use str_has_prefix() to test for a string prefix instead of memcmp().
- Add pr_fmt() macro to drivers/acpi/property.c.
- Move logical or operators to the end of the line in acpi_properties_prepare().
- Improve bad node type error in acpi_parse_string_ref().
Sakari Ailus (10):
ACPI: scan: Remove the second DSDT traversal
ACPI: property: Parse data node string references in properties
ACPI: property: Parse _CRS CSI-2 descriptor
device property: Add SOFTWARE_NODE() macro for defining software nodes
ACPI: property: Prepare generating swnodes for ACPI and DisCo for
Imaging
ACPI: scan: Generate software nodes based on MIPI DisCo for Imaging
ACPI: property: Dig "rotation" property for devices with CSI2 _CRS
ACPI: property: Rename parsed MIPI DisCo for Imaging properties
ACPI: property: Skip MIPI property table without "mipi-img" prefix
ACPI: property: Document _CRS CSI-2 and DisCo for Imaging support
drivers/acpi/Makefile | 2 +- drivers/acpi/internal.h | 41 +- drivers/acpi/mipi.c | 796 +++++++++++++++++++++++++++++++++++++++ drivers/acpi/power.c | 2 +- drivers/acpi/property.c | 180 +++++++-- drivers/acpi/scan.c | 227 +++++++++-- include/acpi/acpi_bus.h | 82 ++++ include/linux/property.h | 7 + 8 files changed, 1252 insertions(+), 85 deletions(-) create mode 100644 drivers/acpi/mipi.c
Signature · 1 line
2.30.2
Sakari Ailus
reviewerPATCH v7 1/10 ACPI: scan: Remove the second DSDT traversal
Collect the devices with _DEP into a list and continue processing them after a full traversal, instead of doing a full second traversal of the tree.
This makes the second DSDT traversal pass unnecessary as we already have the nodes we're interested in in a linked list.
--- drivers/acpi/scan.c | 125 ++++++++++++++++++++++++++++++++------------ 1 file changed, 92 insertions(+), 33 deletions(-)
drivers/acpi/scan.c +92 -33
@@ -2029,10 +2029,52 @@ static u32 acpi_scan_check_dep(acpi_handle handle, bool check_dep)return count; } -static bool acpi_bus_scan_second_pass; +/** +* struct acpi_postponed_handle - A postponed ACPI handle +* @handle: The postponed handle +* @list: Entry in a postponed list +* +* One such entry represents an ACPI handle the scanning of which has been +* postponed. +*/ +struct acpi_postponed_handle { +acpi_handle handle; +struct list_head list; +}; + +/** +* struct acpi_scan_context - Context for scanning ACPI devices +* @device: The first encountered device, typically the root of the scanned tree +* @postponed_head: The list head of the postponed ACPI handles +*/ +struct acpi_scan_context { +struct acpi_device *device; +struct list_head postponed_head; +}; + +/** +* acpi_bus_handle_postpone - Add an ACPI handle to a given postponed list +* @handle: The ACPI handle +* @head: Postponed list head +* +* Add a given ACPI handle to a list of ACPI objects for which the creation +* of the device objects is to be postponed. +*/ +static void acpi_bus_handle_postpone (acpi_handle handle, +struct list_head *head) +{ +struct acpi_postponed_handle *ph; + + ph =kzalloc (sizeof (*ph),GFP_KERNEL ); +if (!ph) +return ; + + ph->handle = handle; +list_add (&ph->list, head); +}static acpi_status acpi_bus_check_add (acpi_handle handle,bool check_dep, -struct acpi_device **adev_p) +struct acpi_scan_context *ctx) {struct acpi_device *device =acpi_fetch_acpi_dev (handle);acpi_object_type acpi_type;
@@ -2051,7 +2093,7 @@ static acpi_status acpi_bus_check_add(acpi_handle handle, bool check_dep,/* Bail out if there are dependencies. */ if (acpi_scan_check_dep (handle, check_dep) >0 ) { - acpi_bus_scan_second_pass = true; +acpi_bus_handle_postpone (handle, &ctx->postponed_head);return AE_CTRL_DEPTH ; }
@@ -2086,22 +2128,22 @@ static acpi_status acpi_bus_check_add(acpi_handle handle, bool check_dep,acpi_scan_init_hotplug (device); out: -if (!*adev_p) - *adev_p = device; +if (!ctx->device) + ctx->device = device;return AE_OK ; }static acpi_status acpi_bus_check_add_1 (acpi_handle handle,u32 lvl_not_used, -void *not_used,void **ret_p) +void *ctx,void **unused) { -return acpi_bus_check_add (handle, true, (struct acpi_device **)ret_p); +return acpi_bus_check_add (handle, true, (struct acpi_scan_context *)ctx); }static acpi_status acpi_bus_check_add_2 (acpi_handle handle,u32 lvl_not_used, -void *not_used,void **ret_p) +void *ctx,void **device) { -return acpi_bus_check_add (handle, false, (struct acpi_device **)ret_p); +return acpi_bus_check_add (handle, false, (struct acpi_scan_context *)ctx); }static void acpi_default_enumeration (struct acpi_device *device)
@@ -2422,37 +2464,54 @@ EXPORT_SYMBOL_GPL(acpi_dev_get_next_consumer_dev);*/ int acpi_bus_scan (acpi_handle handle) { -struct acpi_device *device =NULL ; - - acpi_bus_scan_second_pass = false; - -/* Pass 1: Avoid enumerating devices with missing dependencies. */ +struct acpi_scan_context ctx = { + .postponed_head =LIST_HEAD_INIT (ctx.postponed_head), + }; +struct acpi_postponed_handle *ph, *tmp_ph; +int ret =0 ; -if (ACPI_SUCCESS (acpi_bus_check_add (handle, true, &device))) +if (ACPI_SUCCESS (acpi_bus_check_add (handle, true, &ctx)))acpi_walk_namespace (ACPI_TYPE_ANY , handle,ACPI_UINT32_MAX , - acpi_bus_check_add_1,NULL ,NULL , - (void **)&device); - -if (!device) -return -ENODEV ; - -acpi_bus_attach (device, (void *)true); + acpi_bus_check_add_1,NULL , (void *)&ctx, +NULL ); -if (!acpi_bus_scan_second_pass) -return 0 ; - -/* Pass 2: Enumerate all of the remaining devices. */ +if (!ctx.device) { + ret = -ENODEV ; + goto out_release; + } - device =NULL ; +acpi_bus_attach (ctx.device, (void *)true); -if (ACPI_SUCCESS (acpi_bus_check_add (handle, false, &device))) -acpi_walk_namespace (ACPI_TYPE_ANY , handle,ACPI_UINT32_MAX , - acpi_bus_check_add_2,NULL ,NULL , - (void **)&device); +/* +* Proceed to register ACPI devices that were postponed due to _DEP +* objects during the namespace walk. +*/ +list_for_each_entry_safe (ph, tmp_ph, &ctx.postponed_head, list) { +list_del (&ph->list); +/* Set device NULL here to obtain the root for this sub-tree. */ + ctx.device =NULL ; +/* +* Do this manually, as the namespace walk will only include +* sub-nodes, not the node itself. ctx.device is set to the +* ACPI device corresponding ph->handle. +*/ +acpi_bus_check_add_2 (ph->handle,0 , &ctx,NULL ); +/* Walk the rest of the sub-namespace. */ +acpi_walk_namespace (ACPI_TYPE_ANY , ph->handle,ACPI_UINT32_MAX , + acpi_bus_check_add_2,NULL , (void *)&ctx, +NULL ); +if (ctx.device) +acpi_bus_attach (ctx.device,NULL ); +kfree (ph); + } -acpi_bus_attach (device,NULL ); +out_release: +list_for_each_entry_safe (ph, tmp_ph, &ctx.postponed_head, list) { +list_del (&ph->list); +kfree (ph); + } -return 0 ; +return ret; }EXPORT_SYMBOL (acpi_bus_scan);
Signature · 1 line
2.30.2
Andy Shevchenko
reviewerRe: [PATCH v7 01/10] ACPI: scan: Remove the second DSDT traversal
Quoted 6 lines · Sakari Ailus
Collect the devices with
_DEPinto a list and continue processing them after a full traversal, instead of doing a full second traversal of the tree.This makes the second DSDT traversal pass unnecessary as we already have the nodes we're interested in in a linked list.
...
drivers/acpi/scan.c static u32 acpi_scan_check_dep(acpi_handle handle, bool check_dep) · line 2043
Quoted 12 lines
drivers/acpi/scan.c +12
-0+/** +* struct acpi_postponed_handle - A postponed ACPI handle +* @handle: The postponed handle +* @list: Entry in a postponed list +* +* One such entry represents an ACPI handle the scanning of which has been +* postponed. +*/ +struct acpi_postponed_handle { +acpi_handle handle; +struct list_head list; +};
If you put the list to be the first member, container_of() against it becomes a no-op at compile time. Have you checked the code generation if you swap these members?
drivers/acpi/scan.c static u32 acpi_scan_check_dep(acpi_handle handle, bool check_dep) · line 2053
Quoted 9 lines
drivers/acpi/scan.c +9
-0+/** +* struct acpi_scan_context - Context for scanning ACPI devices +* @device: The first encountered device, typically the root of the scanned tree +* @postponed_head: The list head of the postponed ACPI handles +*/ +struct acpi_scan_context { +struct acpi_device *device; +struct list_head postponed_head; +};
Ditto.
...
Quoted 7 lines
+/**
+ *acpi_bus_handle_postpone- Add an ACPI handle to a given postponed list
+ * @handle: The ACPI handle
+ * @head: Postponed list head
+ *
+ * Add a given ACPI handle to a list of ACPI objects for which the creation
+ * of the device objects is to be postponed.
kernel-doc -v ... complains on the absence of Return section. Is it the same for you?
Quoted 1 line
+ */
Signature · 2 lines
With Best Regards, Andy Shevchenko
Sakari Ailus
reviewerRe: [PATCH v7 01/10] ACPI: scan: Remove the second DSDT traversal
Hi Andy,
Thank you for the review.
Quoted 10 lines · Andy Shevchenko
Quoted 6 lines · Sakari Ailus
Collect the devices with
_DEPinto a list and continue processing them after a full traversal, instead of doing a full second traversal of the tree.This makes the second DSDT traversal pass unnecessary as we already have the nodes we're interested in in a linked list.
...
Quoted 16 lines
drivers/acpi/scan.c static u32 acpi_scan_check_dep(acpi_handle handle, bool check_dep) · line 2043
Quoted 12 lines
drivers/acpi/scan.c +12
-0+/** +* struct acpi_postponed_handle - A postponed ACPI handle +* @handle: The postponed handle +* @list: Entry in a postponed list +* +* One such entry represents an ACPI handle the scanning of which has been +* postponed. +*/ +struct acpi_postponed_handle { +acpi_handle handle; +struct list_head list; +};If you put the list to be the first member,
container_of()against it becomes a no-op at compile time. Have you checked the code generation if you swap these members?
I haven't checked but that would seem like a reasonable thing to do. A pointer to the handle isn't used, unlike it is for the list.
Quoted 23 lines
drivers/acpi/scan.c static u32 acpi_scan_check_dep(acpi_handle handle, bool check_dep) · line 2053
Quoted 10 lines
drivers/acpi/scan.c +9
-0+/** +* struct acpi_scan_context - Context for scanning ACPI devices +* @device: The first encountered device, typically the root of the scanned tree +* @postponed_head: The list head of the postponed ACPI handles +*/ +struct acpi_scan_context { +struct acpi_device *device; +struct list_head postponed_head; +};Ditto.
...
Quoted 7 lines
+/**
+ *acpi_bus_handle_postpone- Add an ACPI handle to a given postponed list
+ * @handle: The ACPI handle
+ * @head: Postponed list head
+ *
+ * Add a given ACPI handle to a list of ACPI objects for which the creation
+ * of the device objects is to be postponed.
Quoted 2 lines
kernel-doc -v ...complains on the absence of Return section. Is it the same for you?
That may well be. These comments wouldn't necessarily even need to be kernel-doc as the rest isn't so documented either. I can of course fix the error while leaving these kernel-doc.
Signature · 3 lines
Kind regards, Sakari Ailus
Sakari Ailus
reviewerRe: [PATCH v7 01/10] ACPI: scan: Remove the second DSDT traversal
Quoted 8 lines · Sakari Ailus
Quoted 8 lines
Quoted 7 lines
+/**
+ *acpi_bus_handle_postpone- Add an ACPI handle to a given postponed list
+ * @handle: The ACPI handle
+ * @head: Postponed list head
+ *
+ * Add a given ACPI handle to a list of ACPI objects for which the creation
+ * of the device objects is to be postponed.
Quoted 6 lines
Quoted 2 lines
kernel-doc -v ...complains on the absence of Return section. Is it the same for you?That may well be. These comments wouldn't necessarily even need to be kernel-doc as the rest isn't so documented either. I can of course fix the error while leaving these kernel-doc.
No warning is produced here. That would seem like a false positive as the function returns void.
Signature · 1 line
Sakari Ailus
Sakari Ailus
reviewerPATCH v7 2/10 ACPI: property: Parse data node string references in properties
In reply to Sakari AilusAdd support for parsing property references using strings, besides reference objects that were previously supported. This allows also referencing data nodes which was not possible with reference objects.
Also add pr_fmt() macro to prefix printouts.
While at it, update copyright.
--- drivers/acpi/property.c | 110 ++++++++++++++++++++++++++++++++++------ 1 file changed, 94 insertions(+), 16 deletions(-)
drivers/acpi/property.c +94 -16
@@ -2,14 +2,17 @@/* * ACPI device specific properties support. * -* Copyright (C) 2014, Intel Corporation +* Copyright (C) 2014-2023, Intel Corporation * All rights reserved. * * Authors: Mika Westerberg <[email protected]> -* Darren Hart <[email protected]> -* Rafael J. Wysocki <[email protected]> +* Darren Hart <[email protected]> +* Rafael J. Wysocki <[email protected]> +* Sakari Ailus <[email protected]> */ +#define pr_fmt (fmt) "ACPI: " fmt +#include <linux/acpi.h> #include <linux/device.h> #include <linux/export.h>
@@ -795,7 +798,8 @@ acpi_fwnode_get_named_child_node(const struct fwnode_handle *fwnode,static int acpi_get_ref_args (struct fwnode_reference_args *args,struct fwnode_handle *ref_fwnode,const union acpi_object **element, -const union acpi_object *end,size_t num_args) +const union acpi_object *end,size_t num_args, +bool subnode_string) {u32 nargs =0 , i;
@@ -803,13 +807,16 @@ static int acpi_get_ref_args(struct fwnode_reference_args *args,* Find the referred data extension node under the * referred device node. */ -for (; *element < end && (*element)->type ==ACPI_TYPE_STRING ; - (*element)++) { -const char *child_name = (*element)->string.pointer; - - ref_fwnode =acpi_fwnode_get_named_child_node (ref_fwnode, child_name); -if (!ref_fwnode) -return -EINVAL ; +if (subnode_string) { +for (; *element < end && (*element)->type ==ACPI_TYPE_STRING ; + (*element)++) { +const char *child_name = (*element)->string.pointer; + + ref_fwnode =acpi_fwnode_get_named_child_node (ref_fwnode, + child_name); +if (!ref_fwnode) +return -EINVAL ; + } }/*
@@ -820,7 +827,8 @@ static int acpi_get_ref_args(struct fwnode_reference_args *args,for (i =0 ; (*element) + i < end && i < num_args; i++) {acpi_object_type type = (*element)[i].type; -if (type ==ACPI_TYPE_LOCAL_REFERENCE ) +if (type ==ACPI_TYPE_LOCAL_REFERENCE || + (!subnode_string && type ==ACPI_TYPE_STRING ))break ;if (type ==ACPI_TYPE_INTEGER )
@@ -844,6 +852,43 @@ static int acpi_get_ref_args(struct fwnode_reference_args *args,return 0 ; } +static struct fwnode_handle * +acpi_parse_string_ref (const struct fwnode_handle *fwnode,const char *refstring) +{ +acpi_handle scope, handle; +struct acpi_data_node *dn; +struct acpi_device *device; +acpi_status status; + +if (is_acpi_device_node (fwnode)) { + scope =to_acpi_device_node (fwnode)->handle; + }else if (is_acpi_data_node (fwnode)) { + scope =to_acpi_data_node (fwnode)->handle; + }else { +pr_debug ("bad node type for node %pfw\n" , fwnode); +return ERR_PTR (-EINVAL ); + } + + status =acpi_get_handle (scope, refstring, &handle); +if (ACPI_FAILURE (status)) { +acpi_handle_debug (scope,"can't get handle for %s" , refstring); +return ERR_PTR (-EINVAL ); + } + + device =acpi_fetch_acpi_dev (handle); +if (device) +return acpi_fwnode_handle (device); + + status =acpi_get_data_full (handle, acpi_nondev_subnode_tag, + (void **)&dn,NULL ); +if (ACPI_FAILURE (status) || !dn) { +acpi_handle_debug (handle,"can't find subnode" ); +return ERR_PTR (-EINVAL ); + } + +return &dn->fwnode; +} +/** * __acpi_node_get_property_reference - returns handle to the referenced object * @fwnode: Firmware node to get the property from
@@ -886,6 +931,7 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode,const union acpi_object *element, *end;const union acpi_object *obj;const struct acpi_device_data *data; +struct fwnode_handle *ref_fwnode;struct acpi_device *device;int ret, idx =0 ;
@@ -909,16 +955,29 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode, args->fwnode =acpi_fwnode_handle (device); args->nargs =0 ; +return 0 ; +case ACPI_TYPE_STRING : +if (index) +return -ENOENT ; + + ref_fwnode =acpi_parse_string_ref (fwnode, obj->string.pointer); +if (IS_ERR (ref_fwnode)) +return PTR_ERR (ref_fwnode); + + args->fwnode = ref_fwnode; + args->nargs =0 ; +return 0 ;case ACPI_TYPE_PACKAGE :/* * If it is not a single reference, then it is a package of -* references followed by number of ints as follows: +* references, followed by number of ints as follows: * * Package () { REF, INT, REF, INT, INT } * -* The index argument is then used to determine which reference -* the caller wants (along with the arguments). +* Here, REF may be either a local reference or a string. The +* index argument is then used to determine which reference the +* caller wants (along with the arguments). */ break ;default :
@@ -942,7 +1001,26 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode, ret =acpi_get_ref_args (idx == index ? args :NULL ,acpi_fwnode_handle (device), - &element, end, num_args); + &element, end, num_args, true); +if (ret <0 ) +return ret; + +if (idx == index) +return 0 ; + +break ; +case ACPI_TYPE_STRING : + ref_fwnode = +acpi_parse_string_ref (fwnode, + element->string.pointer); +if (IS_ERR (ref_fwnode)) +return PTR_ERR (ref_fwnode); + + element++; + + ret =acpi_get_ref_args (idx == index ? args :NULL , + ref_fwnode, &element, end, + num_args, false);if (ret <0 )return ret;
Signature · 1 line
2.30.2
Sakari Ailus
reviewerPATCH v7 3/10 ACPI: property: Parse _CRS CSI-2 descriptor
In reply to Sakari AilusParse newly added ACPI _CRS CSI-2 descriptor for CSI-2 and camera configuration, associate it with appropriate devices and allocate memory for software nodes needed to create a DT-like data structure for drivers.
--- drivers/acpi/Makefile | 2 +- drivers/acpi/internal.h | 26 +++ drivers/acpi/mipi.c | 345 ++++++++++++++++++++++++++++++++++++++++ drivers/acpi/scan.c | 46 ++++-- include/acpi/acpi_bus.h | 11 ++ 5 files changed, 415 insertions(+), 15 deletions(-) create mode 100644 drivers/acpi/mipi.c
drivers/acpi/Makefile +1 -1
@@ -37,7 +37,7 @@ acpi-$(CONFIG_ACPI_SLEEP) += proc.o # ACPI Bus and Device Drivers # acpi-y += bus.o glue.o -acpi-y += scan.o +acpi-y += scan.o mipi.o acpi-y += resource.o acpi-y += acpi_processor.o acpi-y += processor_core.o
drivers/acpi/internal.h +26 -0
@@ -102,6 +102,24 @@ struct acpi_device_bus_id {struct list_head node; }; +/* Context for scanning ACPI device nodes for _CRS CSI2 resource descriptors */ +struct acpi_scan_context_csi2 { +struct list_head crs_csi2_head; +size_t handle_count; +}; + +/** +* struct acpi_scan_context - Context for scanning ACPI devices +* @device: The first encountered device, typically the root of the scanned tree +* @postponed_head: The list head of the postponed ACPI handles +* @csi2: Context for scanning _CRS CSI2 resource descriptors +*/ +struct acpi_scan_context { +struct acpi_device *device; +struct list_head postponed_head; +struct acpi_scan_context_csi2 csi2; +}; +void acpi_init_device_object (struct acpi_device *device,acpi_handle handle,int type,void (*release)(struct device *));int acpi_tie_acpi_dev (struct acpi_device *adev);
@@ -282,4 +300,12 @@ void acpi_init_lpit(void);static inline void acpi_init_lpit (void ) { }#endif +/*-------------------------------------------------------------------------- +ACPI _CRS CSI2 and MIPI DisCo for Imaging conversion +-------------------------------------------------------------------------- */ + +void acpi_crs_csi2_swnodes_del_free (void ); +void acpi_bus_scan_check_crs_csi2 (acpi_handle handle,struct acpi_scan_context *ctx); +void acpi_bus_scan_crs_csi2 (struct acpi_scan_context_csi2 *ctx); +#endif /* _ACPI_INTERNAL_H_ */
drivers/acpi/mipi.c new file +345 -0
345 lines not on this page · raw message
drivers/acpi/scan.c +32 -14
97 lines not on this page · raw message
include/acpi/acpi_bus.h +11 -0
@@ -361,6 +361,17 @@ struct acpi_device_data {struct acpi_gpio_mapping ; +struct acpi_device_software_node_port { +unsigned int port_nr; +}; + +struct acpi_device_software_nodes { +struct acpi_device_software_node_port *ports; +struct software_node *nodes; +const struct software_node **nodeptrs; +unsigned int num_ports; +}; +/* Device */ struct acpi_device {u32 pld_crc;
Signature · 1 line
2.30.2
Andy Shevchenko
reviewerRe: [PATCH v7 03/10] ACPI: property: Parse _CRS CSI-2 descriptor
Quoted 3 lines · Sakari Ailus
Parse newly added ACPI
_CRSCSI-2 descriptor for CSI-2 and camera configuration, associate it with appropriate devices and allocate memory for software nodes needed to create a DT-like data structure for drivers.
...
drivers/acpi/internal.h struct acpi_device_bus_id { · line 119
Quoted 3 lines
drivers/acpi/internal.h +3
-0+struct acpi_scan_context { +struct acpi_device *device; +struct list_head postponed_head;
Make it first?
Quoted 2 lines
drivers/acpi/internal.h +2
-0+struct acpi_scan_context_csi2 csi2; +};
...
Quoted 10 lines
drivers/acpi/mipi.c new file +10
-0+void acpi_bus_scan_check_crs_csi2 (acpi_handle handle,struct acpi_scan_context *ctx) +{ +struct scan_check_crs_csi2_context inst_context = { + .handle = handle, + .res_head =LIST_HEAD_INIT (inst_context.res_head), + }; +struct crs_csi2 *csi2; + +acpi_walk_resources (handle,METHOD_NAME__CRS , + scan_check_crs_csi2_instance, &inst_context);
drivers/acpi/mipi.c line 151
Quoted 10 lines
drivers/acpi/mipi.c new file +10
-0+ +if (list_empty (&inst_context.res_head)) +return ; + +/* +* Found entry, so allocate memory for it, fill it and add it to the +* list. +*/ + csi2 =kmalloc (sizeof (*csi2),GFP_KERNEL ); +if (!csi2)
Who is going to release resources allocated in the callback above?
Quoted 9 lines
drivers/acpi/mipi.c new file +9
-0+return ;/* There's nothing we really can do about this. */ + + csi2->handle = handle; +list_replace (&inst_context.res_head, &csi2->buses); +list_add (&csi2->list, &ctx->csi2.crs_csi2_head); + +/* This handle plus remote handles in _CRS CSI2 resource descriptors */ + ctx->csi2.handle_count +=1 + inst_context.handle_count; +}
...
drivers/acpi/mipi.c line 214
Quoted 5 lines
drivers/acpi/mipi.c new file +5
-0+/* +* Allocate memory for ports, node pointers (number of nodes + +* 1 (guardian), nodes (root + number of ports * 2 (for for +* every port there is an endpoint)). +*/
for for ?
I am a bit lost here. Can you put the above in more mathematical language?
Quoted 14 lines
drivers/acpi/mipi.c new file +14
-0+ overflow =check_mul_overflow (sizeof (*ads->ports) + +sizeof (*ads->nodes) *2 + +sizeof (*ads->nodeptrs) *2 , + ports_count, &alloc_size); + overflow = overflow || +check_add_overflow (sizeof (*ads) +sizeof (*ads->nodes) + +sizeof (*ads->nodeptrs) *2 , + alloc_size, &alloc_size); +if (overflow) { +acpi_handle_warn (handle, +"too many _CRS CSI2 resource handles (%zu)" , + ports_count); +return ; + }
Signature · 2 lines
With Best Regards, Andy Shevchenko
Sakari Ailus
reviewerRe: [PATCH v7 03/10] ACPI: property: Parse _CRS CSI-2 descriptor
Hi Andy,
Thank you for the review.
Quoted 5 lines · Andy Shevchenko
Quoted 3 lines · Sakari Ailus
Parse newly added ACPI
_CRSCSI-2 descriptor for CSI-2 and camera configuration, associate it with appropriate devices and allocate memory for software nodes needed to create a DT-like data structure for drivers.
Quoted 7 lines
...
drivers/acpi/internal.h struct acpi_device_bus_id { · line 119
Quoted 3 lines
drivers/acpi/internal.h +3
-0+struct acpi_scan_context { +struct acpi_device *device; +struct list_head postponed_head;Make it first?
Soon this isn't the only list here, only one of them can be first. But I guess there is some benefit nonetheless.
Quoted 20 lines
Quoted 3 lines
drivers/acpi/internal.h +2
-0+struct acpi_scan_context_csi2 csi2; +};...
Quoted 14 lines
drivers/acpi/mipi.c new file +14
-0+void acpi_bus_scan_check_crs_csi2 (acpi_handle handle,struct acpi_scan_context *ctx) +{ +struct scan_check_crs_csi2_context inst_context = { + .handle = handle, + .res_head =LIST_HEAD_INIT (inst_context.res_head), + }; +struct crs_csi2 *csi2; + +acpi_walk_resources (handle,METHOD_NAME__CRS , + scan_check_crs_csi2_instance, &inst_context); + +if (list_empty (&inst_context.res_head)) +return ; +
Quoted 8 lines
drivers/acpi/mipi.c line 151
Quoted 6 lines
drivers/acpi/mipi.c new file +6
-0+/* +* Found entry, so allocate memory for it, fill it and add it to the +* list. +*/ + csi2 =kmalloc (sizeof (*csi2),GFP_KERNEL ); +if (!csi2)Who is going to release resources allocated in the callback above?
This is done by crs_csi2_release(), called from acpi_bus_scan_crs_csi2().
Quoted 21 lines
Quoted 10 lines
drivers/acpi/mipi.c new file +9
-0+return ;/* There's nothing we really can do about this. */ + + csi2->handle = handle; +list_replace (&inst_context.res_head, &csi2->buses); +list_add (&csi2->list, &ctx->csi2.crs_csi2_head); + +/* This handle plus remote handles in _CRS CSI2 resource descriptors */ + ctx->csi2.handle_count +=1 + inst_context.handle_count; +}...
drivers/acpi/mipi.c line 214
Quoted 5 lines
drivers/acpi/mipi.c new file +5
-0+/* +* Allocate memory for ports, node pointers (number of nodes + +* 1 (guardian), nodes (root + number of ports * 2 (for for +* every port there is an endpoint)). +*/ for for ?
Quoted 1 line
I am a bit lost here. Can you put the above in more mathematical language?
The first "for" is in the sense of "because". I can replace it if you think it'd be clearer that way.
There is simply a single endpoint for every port, as DisCo for Imaging does not support the notion of endpoints (where you could have multiple connections with more endpoints).
Signature · 3 lines
Kind regards, Sakari Ailus
Andy Shevchenko
reviewerRe: [PATCH v7 03/10] ACPI: property: Parse _CRS CSI-2 descriptor
Quoted 2 lines · Sakari Ailus
Quoted 1 line · Andy Shevchenko
On Tue, Mar 28, 2023 at 01:12:56PM +0300, Sakari Ailus wrote:
...
Quoted 21 lines
Quoted 12 lines
Quoted 12 lines
drivers/acpi/mipi.c new file +12
-0+struct scan_check_crs_csi2_context inst_context = { + .handle = handle, + .res_head =LIST_HEAD_INIT (inst_context.res_head), + }; +struct crs_csi2 *csi2; + +acpi_walk_resources (handle,METHOD_NAME__CRS , + scan_check_crs_csi2_instance, &inst_context); + +if (list_empty (&inst_context.res_head)) +return ; +Quoted 8 lines
drivers/acpi/mipi.c line 151
Quoted 6 lines
drivers/acpi/mipi.c new file +6
-0+/* +* Found entry, so allocate memory for it, fill it and add it to the +* list. +*/ + csi2 =kmalloc (sizeof (*csi2),GFP_KERNEL ); +if (!csi2)Who is going to release resources allocated in the callback above?
Quoted 1 line
This is done by
crs_csi2_release(), called fromacpi_bus_scan_crs_csi2().
Isn't it a bit counter intuitive?
Quoted 1 line
Quoted 1 line
Quoted 1 line
drivers/acpi/mipi.c new file +1
-0+return ;/* There's nothing we really can do about this. */
Signature · 2 lines
With Best Regards, Andy Shevchenko
Sakari Ailus
reviewerRe: [PATCH v7 03/10] ACPI: property: Parse _CRS CSI-2 descriptor
Quoted 27 lines · Andy Shevchenko
Quoted 2 lines · Sakari Ailus
Quoted 1 line · Andy Shevchenko
On Tue, Mar 28, 2023 at 01:12:56PM +0300, Sakari Ailus wrote:
...
Quoted 21 lines
Quoted 20 lines
Quoted 8 lines
drivers/acpi/mipi.c new file +8
-0+struct scan_check_crs_csi2_context inst_context = { + .handle = handle, + .res_head =LIST_HEAD_INIT (inst_context.res_head), + }; +struct crs_csi2 *csi2; + +acpi_walk_resources (handle,METHOD_NAME__CRS , + scan_check_crs_csi2_instance, &inst_context);drivers/acpi/mipi.c line 151
Quoted 10 lines
drivers/acpi/mipi.c new file +10
-0+ +if (list_empty (&inst_context.res_head)) +return ; + +/* +* Found entry, so allocate memory for it, fill it and add it to the +* list. +*/ + csi2 =kmalloc (sizeof (*csi2),GFP_KERNEL ); +if (!csi2)Who is going to release resources allocated in the callback above?
Quoted 3 lines
Quoted 1 line
This is done by
crs_csi2_release(), called fromacpi_bus_scan_crs_csi2().Isn't it a bit counter intuitive?
Are you suggesting changing something?
Basically we're gathering the information during an ACPI namespace walk. Once the information has been processed and used, the memory can be released.
Signature · 1 line
Sakari Ailus
Andy Shevchenko
reviewerRe: [PATCH v7 03/10] ACPI: property: Parse _CRS CSI-2 descriptor
Quoted 4 lines · Sakari Ailus
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Sakari Ailus
Quoted 1 line · Andy Shevchenko
On Tue, Mar 28, 2023 at 01:12:56PM +0300, Sakari Ailus wrote:
...
Quoted 23 lines
Quoted 23 lines
Quoted 22 lines
Quoted 12 lines
Quoted 12 lines
drivers/acpi/mipi.c new file +12
-0+struct scan_check_crs_csi2_context inst_context = { + .handle = handle, + .res_head =LIST_HEAD_INIT (inst_context.res_head), + }; +struct crs_csi2 *csi2; + +acpi_walk_resources (handle,METHOD_NAME__CRS , + scan_check_crs_csi2_instance, &inst_context); + +if (list_empty (&inst_context.res_head)) +return ; +Quoted 8 lines
drivers/acpi/mipi.c line 151
Quoted 6 lines
drivers/acpi/mipi.c new file +6
-0+/* +* Found entry, so allocate memory for it, fill it and add it to the +* list. +*/ + csi2 =kmalloc (sizeof (*csi2),GFP_KERNEL ); +if (!csi2)Who is going to release resources allocated in the callback above?
This is done by
crs_csi2_release(), called fromacpi_bus_scan_crs_csi2().
Quoted 7 lines
Quoted 1 line
Isn't it a bit counter intuitive?
Are you suggesting changing something?
Basically we're gathering the information during an ACPI namespace walk. Once the information has been processed and used, the memory can be released.
Release allocated memory in the function which allocates it. Since it's called via callback, the closest one is the one that calls acpi_walk_resources().
Can't we free them here?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Sakari Ailus
reviewerRe: [PATCH v7 03/10] ACPI: property: Parse _CRS CSI-2 descriptor
Quoted 35 lines · Andy Shevchenko
Quoted 4 lines · Sakari Ailus
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Sakari Ailus
Quoted 1 line · Andy Shevchenko
On Tue, Mar 28, 2023 at 01:12:56PM +0300, Sakari Ailus wrote:
...
Quoted 27 lines
Quoted 21 lines
Quoted 21 lines
Quoted 20 lines
Quoted 8 lines
drivers/acpi/mipi.c new file +8
-0+struct scan_check_crs_csi2_context inst_context = { + .handle = handle, + .res_head =LIST_HEAD_INIT (inst_context.res_head), + }; +struct crs_csi2 *csi2; + +acpi_walk_resources (handle,METHOD_NAME__CRS , + scan_check_crs_csi2_instance, &inst_context);drivers/acpi/mipi.c line 151
Quoted 10 lines
drivers/acpi/mipi.c new file +10
-0+ +if (list_empty (&inst_context.res_head)) +return ; + +/* +* Found entry, so allocate memory for it, fill it and add it to the +* list. +*/ + csi2 =kmalloc (sizeof (*csi2),GFP_KERNEL ); +if (!csi2)Who is going to release resources allocated in the callback above?
Quoted 3 lines
Quoted 1 line
This is done by
crs_csi2_release(), called fromacpi_bus_scan_crs_csi2().Isn't it a bit counter intuitive?
Are you suggesting changing something?
Quoted 8 lines
Quoted 3 lines
Basically we're gathering the information during an ACPI namespace walk. Once the information has been processed and used, the memory can be released.
Release allocated memory in the function which allocates it. Since it's called via callback, the closest one is the one that calls
acpi_walk_resources().Can't we free them here?
Ah, I get your point now.
I'll change this for v8.
Signature · 1 line
Sakari Ailus
Sakari Ailus
reviewerPATCH v7 4/10 device property: Add SOFTWARE_NODE() macro for defining software nodes
In reply to Sakari AilusAdd SOFTWARE_NODE() macro in order to make defining software nodes look nicer. This is analogous to different PROPERTY_ENTRY_*() macros for defining properties.
--- include/linux/property.h | 7 +++++++ 1 file changed, 7 insertions(+)
include/linux/property.h +7 -0
@@ -477,6 +477,13 @@ struct software_node {const struct property_entry *properties; }; +#define SOFTWARE_NODE (_name_, _properties_, _parent_) \ + (struct software_node) { \ + .name = _name_, \ + .properties = _properties_, \ + .parent = _parent_, \ + } +bool is_software_node (const struct fwnode_handle *fwnode);const struct software_node *to_software_node (const struct fwnode_handle *fwnode);
Signature · 1 line
2.30.2
Sakari Ailus
reviewerPATCH v7 5/10 ACPI: property: Prepare generating swnodes for ACPI and DisCo for Imaging
In reply to Sakari AilusPrepare generating software nodes for information parsed from ACPI _CRS for CSI-2 as well as MIPI DisCo for Imaging spec. The software nodes are compliant with existing ACPI or DT definitions and are parsed by relevant drivers without changes.
--- drivers/acpi/internal.h | 1 + drivers/acpi/mipi.c | 359 +++++++++++++++++++++++++++++++++++++++- drivers/acpi/scan.c | 18 ++ include/acpi/acpi_bus.h | 70 ++++++++ 4 files changed, 447 insertions(+), 1 deletion(-)
drivers/acpi/internal.h +1 -0
@@ -307,5 +307,6 @@ static inline void acpi_init_lpit(void) { }void acpi_crs_csi2_swnodes_del_free (void );void acpi_bus_scan_check_crs_csi2 (acpi_handle handle,struct acpi_scan_context *ctx);void acpi_bus_scan_crs_csi2 (struct acpi_scan_context_csi2 *ctx); +void acpi_init_swnodes (struct acpi_device *device);#endif /* _ACPI_INTERNAL_H_ */
drivers/acpi/mipi.c +358 -1
402 lines not on this page · raw message
drivers/acpi/scan.c +18 -0
@@ -449,10 +449,28 @@ static void acpi_free_power_resources_lists(struct acpi_device *device) } } +static void acpi_free_swnodes (struct acpi_device *device) +{ +struct acpi_device_software_nodes *ads = device->swnodes; +struct fwnode_handle *primary; + +if (!ads) +return ; + +software_node_unregister_node_group (ads->nodeptrs); + primary =acpi_fwnode_handle (device); + primary->secondary =NULL ; +kfree (ads->nodes[ACPI_DEVICE_SWNODE_ROOT ].name); +kfree (ads); + + device->swnodes =NULL ; +} +static void acpi_device_release (struct device *dev) {struct acpi_device *acpi_dev =to_acpi_device (dev); +acpi_free_swnodes (acpi_dev);acpi_free_properties (acpi_dev);acpi_free_pnp_ids (&acpi_dev->pnp);acpi_free_power_resources_lists (acpi_dev);
include/acpi/acpi_bus.h +70 -0
91 lines not on this page · raw message
Signature · 1 line
2.30.2
Andy Shevchenko
reviewerRe: [PATCH v7 05/10] ACPI: property: Prepare generating swnodes for ACPI and DisCo for Imaging
Quoted 4 lines · Sakari Ailus
Prepare generating software nodes for information parsed from ACPI
_CRSfor CSI-2 as well as MIPI DisCo for Imaging spec. The software nodes are compliant with existing ACPI or DT definitions and are parsed by relevant drivers without changes.
...
Quoted 1 line
#define
NO_CSI2_PORT(UINT_MAX- 1)
Has it been used before this patch?
...
drivers/acpi/mipi.c struct acpi_handle_ref { · line 211
Quoted 4 lines
drivers/acpi/mipi.c +4
-0+/* Print graph port name into a buffer, return non-zero if failed. */ +#define GRAPH_PORT_NAME (var, num) \ + (snprintf((var), sizeof(var), SWNODE_GRAPH_PORT_NAME_FMT, (num)) >= \ + sizeof(var))
This macro evaluates sizeof(var) twice. Is it a problem?
...
drivers/acpi/mipi.c void acpi_bus_scan_crs_csi2(struct acpi_scan_context_csi2 *ctx) · line 489
Quoted 3 lines
drivers/acpi/mipi.c +3
-0+#define NEXT_PROPERTY (index, max) \ + (WARN_ON(++(index) > ACPI_DEVICE_SWNODE_##max + 1) ? \ + ACPI_DEVICE_SWNODE_##max : (index) - 1)
This macro full of interesting effects. On top of that it's written in hard-to-read form.
Why not at least
#define NEXT_PROPERTY(index, max) \ (WARN_ON((index) > ACPI_DEVICE_SWNODE_##max) ? \ ACPI_DEVICE_SWNODE_##max : (index)++)
?
...
Quoted 6 lines
drivers/acpi/mipi.c +6
-0+ ret =fwnode_property_count_u8 (mipi_port_fwnode,"mipi-img-lane-polarities" ); +if (ret >0 ) { + unsigned int bytes = min_t(unsigned int, ret, sizeof(val)); + + fwnode_property_read_u8_array(mipi_port_fwnode, + "mipi-img-lane-polarities",
drivers/acpi/mipi.c void acpi_bus_scan_crs_csi2(struct acpi_scan_context_csi2 *ctx) · line 574
Quoted 10 lines
drivers/acpi/mipi.c +10
-0+ val, bytes); + +/* Total number of lanes here is clock lane + data lanes */ +if (bytes *BITS_PER_TYPE (u8) >=1 + num_lanes) { +unsigned int i; + +/* Move polarity bits to the lane polarity u32 array */ +for (i =0 ; i <1 + num_lanes; i++) + port->lane_polarities[i] = + (bool )(val[i >>3 ] & (1 << (i &7 )));
Casting to bool?!
Can we read the array and convert it to bitmap, then this voodoo-ish code can be simplified to
for_each_set_bit(i, ...) ..._polarities[i] = 1;
(assuming initially they are 0:s)?
Quoted 10 lines
drivers/acpi/mipi.c +10
-0+ port->ep_props[NEXT_PROPERTY (*ep_prop_index,EP_LANE_POLARITIES )] = +PROPERTY_ENTRY_U32_ARRAY_LEN ("lane-polarities" , + port->lane_polarities, +1 + num_lanes); + }else { +acpi_handle_warn (acpi_device_handle (device), +"too few lane polarity bytes (%u)\n" , + bytes); + } + }
Signature · 2 lines
With Best Regards, Andy Shevchenko
Sakari Ailus
reviewerRe: [PATCH v7 05/10] ACPI: property: Prepare generating swnodes for ACPI and DisCo for Imaging
Hi Andy,
Quoted 11 lines · Andy Shevchenko
Quoted 4 lines · Sakari Ailus
Prepare generating software nodes for information parsed from ACPI
_CRSfor CSI-2 as well as MIPI DisCo for Imaging spec. The software nodes are compliant with existing ACPI or DT definitions and are parsed by relevant drivers without changes....
Quoted 1 line
#define
NO_CSI2_PORT(UINT_MAX- 1)Has it been used before this patch?
I don't think so.
It has its current form as you preferred it earlier. :-)
Quoted 9 lines
...
drivers/acpi/mipi.c struct acpi_handle_ref { · line 211
Quoted 4 lines
drivers/acpi/mipi.c +4
-0+/* Print graph port name into a buffer, return non-zero if failed. */ +#define GRAPH_PORT_NAME (var, num) \ + (snprintf((var), sizeof(var), SWNODE_GRAPH_PORT_NAME_FMT, (num)) >= \ + sizeof(var))This macro evaluates sizeof(var) twice. Is it a problem?
I don't think it is.
Quoted 10 lines
...
drivers/acpi/mipi.c void acpi_bus_scan_crs_csi2(struct acpi_scan_context_csi2 *ctx) · line 489
Quoted 3 lines
drivers/acpi/mipi.c +3
-0+#define NEXT_PROPERTY (index, max) \ + (WARN_ON(++(index) > ACPI_DEVICE_SWNODE_##max + 1) ? \ + ACPI_DEVICE_SWNODE_##max : (index) - 1)This macro full of interesting effects. On top of that it's written in hard-to-read form.
Quoted 7 lines
Why not at least
#define NEXT_PROPERTY(index, max) \ (WARN_ON((index) > ACPI_DEVICE_SWNODE_##max) ? \ ACPI_DEVICE_SWNODE_##max : (index)++)?
This appears functionally (almost) equivalent --- it wouldn't overflow. I'll use this in v8.
Quoted 13 lines
...
Quoted 10 lines
drivers/acpi/mipi.c +10
-0+ ret =fwnode_property_count_u8 (mipi_port_fwnode,"mipi-img-lane-polarities" ); +if (ret >0 ) { + unsigned int bytes = min_t(unsigned int, ret, sizeof(val)); + +fwnode_property_read_u8_array (mipi_port_fwnode, +"mipi-img-lane-polarities" , + val, bytes); + +/* Total number of lanes here is clock lane + data lanes */ +if (bytes *BITS_PER_TYPE (u8) >=1 + num_lanes) {
Quoted 8 lines
drivers/acpi/mipi.c void acpi_bus_scan_crs_csi2(struct acpi_scan_context_csi2 *ctx) · line 574
Quoted 6 lines
drivers/acpi/mipi.c +6
-0+unsigned int i; + +/* Move polarity bits to the lane polarity u32 array */ +for (i =0 ; i <1 + num_lanes; i++) + port->lane_polarities[i] = + (bool )(val[i >>3 ] & (1 << (i &7 )));Casting to bool?!
This was the result of our earlier discussion on an earlier version of this set.
Quoted 6 lines
Can we read the array and convert it to bitmap, then this voodoo-ish code can be simplified to
for_each_set_bit(i, ...) ..._polarities[i] = 1;
for_each_set_bit() operates on unsigned longs (usually u32 or u64) but we have u8s here. There's an endianness issue there.
Quoted 2 lines
(assuming initially they are 0:s)?
Signature · 3 lines
Kind regards, Sakari Ailus
Andy Shevchenko
reviewerRe: [PATCH v7 05/10] ACPI: property: Prepare generating swnodes for ACPI and DisCo for Imaging
Quoted 2 lines · Sakari Ailus
Quoted 1 line · Andy Shevchenko
On Tue, Mar 28, 2023 at 01:12:58PM +0300, Sakari Ailus wrote:
...
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
#define
NO_CSI2_PORT(UINT_MAX- 1)Has it been used before this patch?
I don't think so.
It has its current form as you preferred it earlier. :-)
My point is that it needs to be introduced where the first user appears.
Quoted 8 lines
Quoted 5 lines
#define NEXT_PROPERTY(index, max) \ (WARN_ON((index) > ACPI_DEVICE_SWNODE_##max) ? \ ACPI_DEVICE_SWNODE_##max : (index)++)?
This appears functionally (almost) equivalent --- it wouldn't overflow. I'll use this in v8.
In this form it even takes line less
#define NEXT_PROPERTY(i, m) \ (WARN_ON((i) > ACPI_DEVICE_SWNODE_##m) ? ACPI_DEVICE_SWNODE_##m : (i)++)
...
Quoted 22 lines
Quoted 10 lines
Quoted 10 lines
drivers/acpi/mipi.c +10
-0+ ret =fwnode_property_count_u8 (mipi_port_fwnode,"mipi-img-lane-polarities" ); +if (ret >0 ) { + unsigned int bytes = min_t(unsigned int, ret, sizeof(val)); + +fwnode_property_read_u8_array (mipi_port_fwnode, +"mipi-img-lane-polarities" , + val, bytes); + +/* Total number of lanes here is clock lane + data lanes */ +if (bytes *BITS_PER_TYPE (u8) >=1 + num_lanes) {Quoted 8 lines
drivers/acpi/mipi.c void acpi_bus_scan_crs_csi2(struct acpi_scan_context_csi2 *ctx) · line 574
Quoted 6 lines
drivers/acpi/mipi.c +6
-0+unsigned int i; + +/* Move polarity bits to the lane polarity u32 array */ +for (i =0 ; i <1 + num_lanes; i++) + port->lane_polarities[i] = + (bool )(val[i >>3 ] & (1 << (i &7 )));Casting to bool?!
This was the result of our earlier discussion on an earlier version of this set.
Quoted 8 lines
Quoted 5 lines
Can we read the array and convert it to bitmap, then this voodoo-ish code can be simplified to
for_each_set_bit(i, ...) ..._polarities[i] = 1;
for_each_set_bit()operates on unsigned longs (usually u32 or u64) but we have u8s here. There's an endianness issue there.
No issue if you convert it to unsigned long:s first.
Quoted 1 line
Quoted 1 line
(assuming initially they are 0:s)?
I think open coding the bitmap operations here is not a win.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Sakari Ailus
reviewerRe: [PATCH v7 05/10] ACPI: property: Prepare generating swnodes for ACPI and DisCo for Imaging
Hi Andy,
Quoted 8 lines · Andy Shevchenko
Quoted 2 lines · Sakari Ailus
Quoted 1 line · Andy Shevchenko
On Tue, Mar 28, 2023 at 01:12:58PM +0300, Sakari Ailus wrote:
...
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
#define
NO_CSI2_PORT(UINT_MAX- 1)
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Has it been used before this patch?
I don't think so.
It has its current form as you preferred it earlier. :-)
My point is that it needs to be introduced where the first user appears.
Yes, the first use of this macro is in this patch.
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
#define NEXT_PROPERTY(index, max) \ (WARN_ON((index) > ACPI_DEVICE_SWNODE_##max) ? \ ACPI_DEVICE_SWNODE_##max : (index)++)?
Quoted 7 lines
Quoted 2 lines
This appears functionally (almost) equivalent --- it wouldn't overflow. I'll use this in v8.
In this form it even takes line less
#define NEXT_PROPERTY(i, m) \ (WARN_ON((i) > ACPI_DEVICE_SWNODE_##m) ? ACPI_DEVICE_SWNODE_##m : (i)++)
I prefer the previous form as it is easier to grasp what it does --- the names of the variables suggest what they are for.
Quoted 31 lines
...
Quoted 28 lines
Quoted 10 lines
Quoted 10 lines
drivers/acpi/mipi.c +10
-0+ ret =fwnode_property_count_u8 (mipi_port_fwnode,"mipi-img-lane-polarities" ); +if (ret >0 ) { + unsigned int bytes = min_t(unsigned int, ret, sizeof(val)); + +fwnode_property_read_u8_array (mipi_port_fwnode, +"mipi-img-lane-polarities" , + val, bytes); + +/* Total number of lanes here is clock lane + data lanes */ +if (bytes *BITS_PER_TYPE (u8) >=1 + num_lanes) {Quoted 8 lines
drivers/acpi/mipi.c void acpi_bus_scan_crs_csi2(struct acpi_scan_context_csi2 *ctx) · line 574
Quoted 6 lines
drivers/acpi/mipi.c +6
-0+unsigned int i; + +/* Move polarity bits to the lane polarity u32 array */ +for (i =0 ; i <1 + num_lanes; i++) + port->lane_polarities[i] = + (bool )(val[i >>3 ] & (1 << (i &7 )));Casting to bool?!
This was the result of our earlier discussion on an earlier version of this set.
Quoted 5 lines
Can we read the array and convert it to bitmap, then this voodoo-ish code can be simplified to
for_each_set_bit(i, ...) ..._polarities[i] = 1;
Quoted 8 lines
Quoted 2 lines
for_each_set_bit()operates on unsigned longs (usually u32 or u64) but we have u8s here. There's an endianness issue there.No issue if you convert it to unsigned long:s first.
Quoted 1 line
Quoted 1 line
(assuming initially they are 0:s)?
I think open coding the bitmap operations here is not a win.
Sure, this could be converted to a different form and then the bits could be accessed using existing API functions. But I don't think it'd be better that way.
Signature · 3 lines
Kind regards, Sakari Ailus
Sakari Ailus
reviewerPATCH v7 6/10 ACPI: scan: Generate software nodes based on MIPI DisCo for Imaging
In reply to Sakari AilusGenerate software nodes for driver use, based on MIPI DisCo for Imaging definitions.
During the (sub-)namespace walk, ACPI device nodes are created but the drivers aren't probed for the devices yet. A convenient way to determine which ACPI devices this applies to is to find a hierarchical data node that begins with "mipi-img-port-". These devices need software nodes that need to be present before probing, and can only be constructed once the related _CRS CSI2 records have been parsed.
--- drivers/acpi/internal.h | 13 ++++++- drivers/acpi/mipi.c | 5 +-- drivers/acpi/power.c | 2 +- drivers/acpi/property.c | 48 +++++++++++++++-------- drivers/acpi/scan.c | 84 +++++++++++++++++++++++++++++++++-------- 5 files changed, 115 insertions(+), 37 deletions(-)
drivers/acpi/internal.h +11 -2
@@ -112,16 +112,22 @@ struct acpi_scan_context_csi2 {* struct acpi_scan_context - Context for scanning ACPI devices * @device: The first encountered device, typically the root of the scanned tree * @postponed_head: The list head of the postponed ACPI handles +* @mipi_img_head: The list of ACPI devices with MIPI DisCo for Imaging related +* properties * @csi2: Context for scanning _CRS CSI2 resource descriptors */ struct acpi_scan_context {struct acpi_device *device;struct list_head postponed_head; +struct list_head mipi_img_head;struct acpi_scan_context_csi2 csi2; }; +void acpi_bus_device_postpone (struct acpi_device *device, +struct list_head *head);void acpi_init_device_object (struct acpi_device *device,acpi_handle handle, -int type,void (*release)(struct device *)); +int type,void (*release)(struct device *), +struct list_head *mipi_img_head);int acpi_tie_acpi_dev (struct acpi_device *adev);int acpi_device_add (struct acpi_device *device);int acpi_device_setup_files (struct acpi_device *dev);
@@ -275,7 +281,8 @@ static inline bool force_storage_d3(void)-------------------------------------------------------------------------- */ #define ACPI_DT_NAMESPACE_HID "PRP0001" -void acpi_init_properties (struct acpi_device *adev); +void acpi_init_properties (struct acpi_device *adev, +struct list_head *mipi_img_head);void acpi_free_properties (struct acpi_device *adev);#ifdef CONFIG_X86
@@ -304,6 +311,8 @@ static inline void acpi_init_lpit(void) { }ACPI _CRS CSI2 and MIPI DisCo for Imaging conversion -------------------------------------------------------------------------- */ +#define MIPI_IMG_PORT_PREFIX "mipi-img-port-" +void acpi_crs_csi2_swnodes_del_free (void );void acpi_bus_scan_check_crs_csi2 (acpi_handle handle,struct acpi_scan_context *ctx);void acpi_bus_scan_crs_csi2 (struct acpi_scan_context_csi2 *ctx);
drivers/acpi/mipi.c +2 -3
@@ -491,11 +491,10 @@ void acpi_bus_scan_crs_csi2(struct acpi_scan_context_csi2 *ctx)static struct fwnode_handle *get_mipi_port_handle (struct acpi_device *device,unsigned int port) { -static const char mipi_port_prefix[] ="mipi-img-port-" ; -char mipi_port_name[sizeof (mipi_port_prefix) +2 ]; +char mipi_port_name[sizeof (MIPI_IMG_PORT_PREFIX ) +2 ];if (snprintf (mipi_port_name,sizeof (mipi_port_name),"%s%u" , - mipi_port_prefix, port) >=sizeof (mipi_port_name)) { +MIPI_IMG_PORT_PREFIX , port) >=sizeof (mipi_port_name)) {acpi_handle_info (acpi_device_handle (device),"mipi port name too long for port %u\n" , port);return NULL ;
drivers/acpi/power.c +1 -1
@@ -945,7 +945,7 @@ struct acpi_device *acpi_add_power_resource(acpi_handle handle) device = &resource->device;acpi_init_device_object (device, handle,ACPI_BUS_TYPE_POWER , - acpi_release_power_resource); + acpi_release_power_resource,NULL );mutex_init (&resource->resource_lock);INIT_LIST_HEAD (&resource->list_node);INIT_LIST_HEAD (&resource->dependents);
drivers/acpi/property.c +33 -15
104 lines not on this page · raw message
drivers/acpi/scan.c +68 -16
178 lines not on this page · raw message
Signature · 1 line
2.30.2
Andy Shevchenko
reviewerRe: [PATCH v7 06/10] ACPI: scan: Generate software nodes based on MIPI DisCo for Imaging
Quoted 9 lines · Sakari Ailus
Generate software nodes for driver use, based on MIPI DisCo for Imaging definitions.
During the (sub-)namespace walk, ACPI device nodes are created but the drivers aren't probed for the devices yet. A convenient way to determine which ACPI devices this applies to is to find a hierarchical data node that begins with "mipi-img-port-". These devices need software nodes that need to be present before probing, and can only be constructed once the related
_CRSCSI2 records have been parsed.
...
drivers/acpi/mipi.c void acpi_bus_scan_crs_csi2(struct acpi_scan_context_csi2 *ctx) · line 497
Quoted 7 lines
drivers/acpi/mipi.c +2
-3-static const char mipi_port_prefix[] ="mipi-img-port-" ; -char mipi_port_name[sizeof (mipi_port_prefix) +2 ]; +char mipi_port_name[sizeof (MIPI_IMG_PORT_PREFIX ) +2 ];if (snprintf (mipi_port_name,sizeof (mipi_port_name),"%s%u" , - mipi_port_prefix, port) >=sizeof (mipi_port_name)) { +MIPI_IMG_PORT_PREFIX , port) >=sizeof (mipi_port_name)) {
You are modifying lines you just brought by the previous patch. Why this mess?
...
drivers/acpi/scan.c struct acpi_postponed_handle { · line 2079
Quoted 3 lines
drivers/acpi/scan.c +1
-2-static void acpi_bus_handle_postpone (acpi_handle handle, -struct list_head *head) +static void acpi_bus_handle_postpone (acpi_handle handle,struct list_head *head)
Unrelated change?
...
drivers/acpi/scan.c static void acpi_bus_handle_postpone(acpi_handle handle, · line 2100
Quoted 10 lines
drivers/acpi/scan.c +10
-0+/** +* acpi_bus_device_postpone - Add an ACPI device to a given postponed list +* @device: The ACPI device +* @head: Postponed list head +* +* Add a given ACPI device to a list of ACPI objects for which the creation +* of the device objects is to be postponed. +*/ +void acpi_bus_device_postpone (struct acpi_device *device, +struct list_head *head)
Taking into account above indentation, why not to have them on one line to begin with?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Sakari Ailus
reviewerRe: [PATCH v7 06/10] ACPI: scan: Generate software nodes based on MIPI DisCo for Imaging
Hi Adnry,
Quoted 33 lines · Andy Shevchenko
Quoted 9 lines · Sakari Ailus
Generate software nodes for driver use, based on MIPI DisCo for Imaging definitions.
During the (sub-)namespace walk, ACPI device nodes are created but the drivers aren't probed for the devices yet. A convenient way to determine which ACPI devices this applies to is to find a hierarchical data node that begins with "mipi-img-port-". These devices need software nodes that need to be present before probing, and can only be constructed once the related
_CRSCSI2 records have been parsed....
drivers/acpi/mipi.c void acpi_bus_scan_crs_csi2(struct acpi_scan_context_csi2 *ctx) · line 497
Quoted 7 lines
drivers/acpi/mipi.c +2
-3-static const char mipi_port_prefix[] ="mipi-img-port-" ; -char mipi_port_name[sizeof (mipi_port_prefix) +2 ]; +char mipi_port_name[sizeof (MIPI_IMG_PORT_PREFIX ) +2 ];if (snprintf (mipi_port_name,sizeof (mipi_port_name),"%s%u" , - mipi_port_prefix, port) >=sizeof (mipi_port_name)) { +MIPI_IMG_PORT_PREFIX , port) >=sizeof (mipi_port_name)) {You are modifying lines you just brought by the previous patch. Why this mess?
...
drivers/acpi/scan.c struct acpi_postponed_handle { · line 2079
Quoted 3 lines
drivers/acpi/scan.c +1
-2-static void acpi_bus_handle_postpone (acpi_handle handle, -struct list_head *head) +static void acpi_bus_handle_postpone (acpi_handle handle,struct list_head *head)Unrelated change?
...
Quoted 13 lines
drivers/acpi/scan.c static void acpi_bus_handle_postpone(acpi_handle handle, · line 2100
Quoted 10 lines
drivers/acpi/scan.c +10
-0+/** +* acpi_bus_device_postpone - Add an ACPI device to a given postponed list +* @device: The ACPI device +* @head: Postponed list head +* +* Add a given ACPI device to a list of ACPI objects for which the creation +* of the device objects is to be postponed. +*/ +void acpi_bus_device_postpone (struct acpi_device *device, +struct list_head *head)Taking into account above indentation, why not to have them on one line to begin with?
I'll address these for v8.
Signature · 3 lines
Kind regards, Sakari Ailus
Sakari Ailus
reviewerPATCH v7 7/10 ACPI: property: Dig "rotation" property for devices with CSI2 _CRS
In reply to Sakari AilusDig "rotation" property value for devices with _CRS CSI2 resource descriptor. The value comes from _PLD (physical location of device) object, if it exists for the device.
This way camera sensor drivers that know the "rotation" property do not need to care about _PLD on ACPI.
--- drivers/acpi/mipi.c | 17 +++++++++++++++++ include/acpi/acpi_bus.h | 1 + 2 files changed, 18 insertions(+)
drivers/acpi/mipi.c +17 -0
@@ -654,10 +654,12 @@ static void init_port_csi2_remote(struct acpi_device *device,*/ void acpi_init_swnodes (struct acpi_device *device) { +struct fwnode_handle *fwnode =acpi_fwnode_handle (device);struct acpi_device_software_nodes *ads;struct acpi_buffer buffer = { .length =ACPI_ALLOCATE_BUFFER };acpi_handle handle =acpi_device_handle (device);struct fwnode_handle *primary; +unsigned int prop_index =0 ;acpi_status status;unsigned int i;int ret;
@@ -666,6 +668,21 @@ void acpi_init_swnodes(struct acpi_device *device)if (!ads)return ; +/* +* Check if "rotation" property exists and if it doesn't but there's a +* _PLD object, then get the rotation value from there. +*/ +if (!fwnode_property_present (fwnode,"rotation" )) { +struct acpi_pld_info *pld; + + status =acpi_get_physical_device_location (handle, &pld); +if (ACPI_SUCCESS (status)) { + ads->dev_props[NEXT_PROPERTY (prop_index,DEV_ROTATION )] = +PROPERTY_ENTRY_U32 ("rotation" , pld->rotation *45U ); +kfree (pld); + } + } + status =acpi_get_name (handle,ACPI_FULL_PATHNAME , &buffer);if (ACPI_FAILURE (status)) {acpi_handle_warn (handle,"cannot get path name\n" );
include/acpi/acpi_bus.h +1 -0
@@ -362,6 +362,7 @@ struct acpi_device_data {struct acpi_gpio_mapping ;enum acpi_device_swnode_dev_props { +ACPI_DEVICE_SWNODE_DEV_ROTATION ,ACPI_DEVICE_SWNODE_DEV_NUM_OF ,ACPI_DEVICE_SWNODE_DEV_NUM_ENTRIES };
Signature · 1 line
2.30.2
Sakari Ailus
reviewerPATCH v7 8/10 ACPI: property: Rename parsed MIPI DisCo for Imaging properties
In reply to Sakari AilusMIPI DisCo for Imaging defines properties for sensor-adjacent devices such as EEPROM, LED flash or lens VCM as either device or sub-node references. This is compliant with existing DT definitions apart from property names.
Rename parsed MIPI-defined properties so drivers will have a unified view of them as defined in DT and already parsed by drivers. This can be done in-place as the MIPI-defined property strings are always longer than the DT one. This also results in loss of constness in parser function arguments.
Individual bindings to devices could define the references differently between MIPI DisCo for Imaging and DT, in terms of device or sub-node references. This will still need to be handled in the drivers themselves.
--- drivers/acpi/internal.h | 1 + drivers/acpi/mipi.c | 36 ++++++++++++++++++++++++++++++++++++ drivers/acpi/property.c | 22 ++++++++++++---------- 3 files changed, 49 insertions(+), 10 deletions(-)
drivers/acpi/internal.h +1 -0
@@ -317,5 +317,6 @@ void acpi_crs_csi2_swnodes_del_free(void);void acpi_bus_scan_check_crs_csi2 (acpi_handle handle,struct acpi_scan_context *ctx);void acpi_bus_scan_crs_csi2 (struct acpi_scan_context_csi2 *ctx);void acpi_init_swnodes (struct acpi_device *device); +void acpi_properties_prepare_mipi (union acpi_object *elements);#endif /* _ACPI_INTERNAL_H_ */
drivers/acpi/mipi.c +36 -0
@@ -716,3 +716,39 @@ void acpi_init_swnodes(struct acpi_device *device) primary =acpi_fwnode_handle (device); primary->secondary =software_node_fwnode (ads->nodes); } + +static const struct mipi_disco_prop { +const char *mipi_prop; +const char *dt_prop; +} mipi_disco_props[] = { + {"mipi-img-lens-focus" ,"lens-focus" }, + {"mipi-img-flash-leds" ,"flash-leds" }, + {"mipi-img-clock-frequency" ,"clock-frequency" }, + {"mipi-img-led-max-current" ,"led-max-microamp" }, + {"mipi-img-flash-max-current" ,"flash-max-microamp" }, + {"mipi-img-flash-max-timeout" ,"flash-max-timeout-us" }, +}; + +/** +* acpi_properties_prepare_mipi - Rename MIPI properties as commin DT ones +* +* @elements: ACPI object containing _DSD properties for a device node +* +* Renames MIPI-defined properties as common DT ones. The pre-requisite is that +* the names of all such MIPI properties are no longer than the corresponding DT +* ones. +*/ +void acpi_properties_prepare_mipi (union acpi_object *elements) +{ +char *e0 = elements[0 ].string.pointer; +unsigned int i; + +/* Replace MIPI DisCo for Imaging property names with DT equivalents. */ +for (i =0 ; i <ARRAY_SIZE (mipi_disco_props); i++) { +if (!strcmp (mipi_disco_props[i].mipi_prop, e0)) { +WARN_ON (strscpy (e0, mipi_disco_props[i].dt_prop, + elements[0 ].string.length) <0 ); +break ; + } + } +}
drivers/acpi/property.c +12 -10
@@ -127,7 +127,7 @@ static bool acpi_nondev_subnode_extract(union acpi_object *desc, }static bool acpi_nondev_subnode_data_ok (acpi_handle handle, -const union acpi_object *link, +union acpi_object *link,struct list_head *list,struct fwnode_handle *parent) {
@@ -148,7 +148,7 @@ static bool acpi_nondev_subnode_data_ok(acpi_handle handle, }static bool acpi_nondev_subnode_ok (acpi_handle scope, -const union acpi_object *link, +union acpi_object *link,struct list_head *list,struct fwnode_handle *parent) {
@@ -292,22 +292,24 @@ static bool acpi_property_value_ok(const union acpi_object *value)return false; } -static bool acpi_properties_format_valid (const union acpi_object *properties) +static bool acpi_properties_prepare (union acpi_object *properties) { -int i; +unsigned int i;for (i =0 ; i < properties->package.count; i++) { -const union acpi_object *property; +union acpi_object *property = &properties->package.elements[i]; +union acpi_object *elements = property->package.elements; - property = &properties->package.elements[i];/* * Only two elements allowed, the first one must be a string and * the second one has to satisfy certain conditions. */ -if (property->package.count !=2 - || property->package.elements[0 ].type !=ACPI_TYPE_STRING - || !acpi_property_value_ok (&property->package.elements[1 ])) +if (property->package.count !=2 || + elements[0 ].type !=ACPI_TYPE_STRING || + !acpi_property_value_ok (&elements[1 ]))return false; + +acpi_properties_prepare_mipi (elements); }return true; }
@@ -539,7 +541,7 @@ static bool acpi_extract_properties(acpi_handle scope, union acpi_object *desc,* We found the matching GUID. Now validate the format of the * package immediately following it. */ -if (!acpi_properties_format_valid (properties)) +if (!acpi_properties_prepare (properties))continue ; acpi_data_add_props(data, (const guid_t *)guid->buffer.pointer,
Signature · 1 line
2.30.2
Sakari Ailus
reviewerPATCH v7 9/10 ACPI: property: Skip MIPI property table without "mipi-img" prefix
In reply to Sakari AilusFor all _DSD properties, skip going through the MIPI DisCo for Imaging property name substitution table if the property doesn't have "mipi-img-" prefix.
--- drivers/acpi/mipi.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/acpi/mipi.c +5 -0
@@ -717,6 +717,8 @@ void acpi_init_swnodes(struct acpi_device *device) primary->secondary =software_node_fwnode (ads->nodes); } +#define MIPI_IMG_PREFIX "mipi-img-" + static const struct mipi_disco_prop { const char *mipi_prop; const char *dt_prop;
@@ -743,6 +745,9 @@ void acpi_properties_prepare_mipi(union acpi_object *elements)char *e0 = elements[0 ].string.pointer;unsigned int i; +if (!str_has_prefix (elements[0 ].string.pointer,MIPI_IMG_PREFIX )) +return ; +/* Replace MIPI DisCo for Imaging property names with DT equivalents. */ for (i =0 ; i <ARRAY_SIZE (mipi_disco_props); i++) {if (!strcmp (mipi_disco_props[i].mipi_prop, e0)) {
Signature · 1 line
2.30.2
Sakari Ailus
reviewerPATCH v7 10/10 ACPI: property: Document _CRS CSI-2 and DisCo for Imaging support
In reply to Sakari AilusDocument how ACPI _CRS CSI-2 and DisCo for Imaging works. It's non-trivial so such documentation can be useful.
--- drivers/acpi/mipi.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+)
drivers/acpi/mipi.c +37 -0
@@ -9,6 +9,43 @@* Also see <URL:https://www.mipi.org/specifications/mipi-disco-imaging>. * * Copyright (C) 2023 Intel Corporation +* +* _CRS CSI-2 descriptors, as defined starting from ACPI 6.4 [1], contain +* information on cross-device CSI-2 bus configuration. The descriptors are +* located under transmitter devices, and the receiver devices have no direct +* way to access them even if the information in these descriptors is equally +* important for receivers. This information is amended with MIPI DisCo for +* Imaging [2] specification that defines _DSD data nodes and properties. +* +* The support for these is based on two-fold approach, firstly renaming +* properties where semantics matches and secondly gathering information to +* generate properties using information gathered from various sources. The +* former is trivial (see acpi_properties_prepare_mipi() at the end of the +* file) whereas the latter requires a more elaborate explanation. +* +* acpi_bus_scan_crs_csi2() scans an ACPI bus for devices with _CRS CSI-2 +* descriptors and stores them to a linked list. This is done as traversing just +* this list is much smaller task than the entire DSDT. This list is then used +* to figure out how much memory is needed for swnodes related to a given ACPI +* device (handle). Further on, the same function sets the property values for +* the properties the values of which are obtained from the _CRS CSI-2 +* descriptor. The information is stored into another list where the information +* can be looked up based on device's acpi_handle as the struct acpi_device +* isn't available yet at this point (and could not, as cross-device references +* need to be set up before the devices are available for drivers to probe). +* +* For each struct acpi_device, acpi_init_swnodes() further obtains information +* required to find out the values for the rest of the properties needed by +* drivers. This includes all port and endpoint properties as the node +* structures used by DT graphs and DisCo for Imaging are different. Finally the +* function registers software nodes for the device and sets the secondary +* pointer for the ACPI device's fwnode. +* +* Access to data the structures is serialised using acpi_scan_lock in scan.c. +* +* [1] https://uefi.org/sites/default/files/resources/ACPI_Spec_6_4_Jan22.pdf +* +* [2] https://www.mipi.org/specifications/mipi-disco-imaging */ #include <linux/acpi.h>
Signature · 1 line
2.30.2