gpiolib: Split property name from the warning message
PATCH 1/1 gpiolib: Split property name from the warning message
Split property name from the warning message to make object file shorter. The linker will use the single copy of it. It's fine to pass a pointer to the printing function since it's a slow path anyway.
--- drivers/gpio/gpiolib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpiolib.c +2 -2
@@ -403,8 +403,8 @@ static int gpiochip_set_names(struct gpio_chip *chip)* gpiochips. */ if (count <= chip->offset) { -dev_warn (dev,"gpio-line-names too short (length %d), cannot map names for the gpiochip at offset %u\n" , - count, chip->offset); +dev_warn (dev,"%s too short (length %d), cannot map names for the gpiochip at offset %u\n" , +"gpio-line-names" , count, chip->offset);return 0 ; }
Signature · 1 line
2.40.0.1.gaa8946217a0b
Quoted 27 lines · Andy Shevchenko
Split property name from the warning message to make object file shorter. The linker will use the single copy of it. It's fine to pass a pointer to the printing function since it's a slow path anyway.
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/gpio/gpiolib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpio/gpiolib.c +2
-3@@ -403,8 +403,8 @@ static int gpiochip_set_names(struct gpio_chip *chip)* gpiochips. */ if (count <= chip->offset) { -dev_warn (dev,"gpio-line-names too short (length %d), cannot map names for the gpiochip at offset %u\n" , - count, chip->offset); +dev_warn (dev,"%s too short (length %d), cannot map names for the gpiochip at offset %u\n" , +"gpio-line-names" , count, chip->offset);return 0 ; } --
Quoted 2 lines
2.40.0.1.gaa8946217a0b
I'd say being able to grep the code easily for messages is more important than saving a couple bytes here?
Bart
Quoted 2 lines · Bartosz Golaszewski
On Tue, Mar 21, 2023 at 2:52 PM Andy Shevchenko
<[email protected]> wrote:
...
Quoted 9 lines
drivers/gpio/gpiolib.c static int gpiochip_set_names(struct gpio_chip *chip) · line 409
Quoted 6 lines
drivers/gpio/gpiolib.c +2
-2-dev_warn (dev,"gpio-line-names too short (length %d), cannot map names for the gpiochip at offset %u\n" , - count, chip->offset); +dev_warn (dev,"%s too short (length %d), cannot map names for the gpiochip at offset %u\n" , +"gpio-line-names" , count, chip->offset);return 0 ; }I'd say being able to grep the code easily for messages is more important than saving a couple bytes here?
We still grep by the rest of the message. But anyway, up to you, I've no hard feelings to this patch.
Signature · 2 lines
With Best Regards, Andy Shevchenko