9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition]
Eric Van Hensbergen
maintainerPATCH v3 1/1 9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition]
----- Forwarded message from Zheng Wang <[email protected]> -----
Date: Mon, 13 Mar 2023 22:43:25 +0800
From: Zheng Wang <[email protected]>
To: [email protected]
Cc: [email protected], [email protected], Zheng Wang <[email protected]>, [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected],
[email protected], [email protected], [email protected]
Subject: [V9fs-developer] [PATCH net v3] 9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition
X-Mailer: git-send-email 2.25.1
In xen_9pfs_front_probe, it calls xen_9pfs_front_alloc_dataring to init priv->rings and bound &ring->work with p9_xen_response.
When it calls xen_9pfs_front_event_handler to handle IRQ requests, it will finally call schedule_work to start the work.
When we call xen_9pfs_front_remove to remove the driver, there may be a sequence as follows:
Fix it by finishing the work before cleanup in xen_9pfs_front_free.
Note that, this bug is found by static analysis, which might be false positive.
CPU0 CPU1
|p9_xen_response
xen_9pfs_front_remove|
xen_9pfs_front_free|
kfree(priv) |
//free priv |
|p9_tag_lookup
|//use priv->client---
v3:
- remove unnecessary comment and move definition to the for loop suggested by Michal Swiatkowski
v2:
- fix type error of ring found by kernel test robot
--- net/9p/trans_xen.c | 4 ++++ 1 file changed, 4 insertions(+)
net/9p/trans_xen.c +4 -0
@@ -280,6 +280,10 @@ static void xen_9pfs_front_free(struct xen_9pfs_front_priv *priv)write_unlock (&xen_9pfs_lock);for (i =0 ; i < priv->num_rings; i++) { +struct xen_9pfs_dataring *ring = &priv->rings[i]; + +cancel_work_sync (&ring->work); +if (!priv->rings[i].intf)break ;if (priv->rings[i].irq >0 )
Signature · 10 lines
2.25.1 _______________________________________________ V9fs-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/v9fs-developer ----- End forwarded message -----