tracing: install trace events file only if necessary
PATCH v4 1/1 tracing: install trace events file only if necessary
From: Carlos Santos <[email protected]>
It is not useful when configuring with --enable-trace-backends=nop.
---
Changes v1->v2:
Install based on chosen trace backend, not on chosen emulators.
Changes v2->v3:
Add missing comma
Changes v3->v4:
Fix array comparison:
get_option('trace_backends') != [ 'nop' ]
not
get_option('trace_backends') != 'nop'
---
trace/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)trace/meson.build +1 -1
@@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all', input: trace_events_files, command: [ 'cat', '@INPUT@' ], capture: true, - install: true, + install: get_option('trace_backends') != [ 'nop' ], install_dir: qemu_datadir) if 'ust' in get_option('trace_backends')
Signature · 1 line
2.31.1
Copying Stefan as the trace subsystem maintainer
Quoted 36 lines · On Fri, Apr 07, 2023 at 10:04:10PM -0300, [email protected] wrote:
From: Carlos Santos <[email protected]>
It is not useful when configuring with --enable-trace-backends=nop.
Signed-off-by Carlos Santos <[email protected]>---
Changesv1->v2:
Install based on chosen trace backend, not on chosen emulators.
Changesv2->v3:
Add missing comma
Changesv3->v4:
Fix array comparison:get_option('trace_backends') != [ 'nop' ] not get_option('trace_backends') != 'nop' --- trace/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)trace/meson.build +1
-1@@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all', input: trace_events_files, command: [ 'cat', '@INPUT@' ], capture: true, - install: true, + install: get_option('trace_backends') != [ 'nop' ], install_dir: qemu_datadir) if 'ust' in get_option('trace_backends')Signature · 1 line
2.31.1
With regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Stefan Hajnoczi
AppliedQuoted 13 lines · On Fri, 7 Apr 2023 at 21:05, <[email protected]> wrote:
From: Carlos Santos <[email protected]>
It is not useful when configuring with --enable-trace-backends=nop.
Signed-off-by Carlos Santos <[email protected]>---
Changesv1->v2:
Install based on chosen trace backend, not on chosen emulators.
Changesv2->v3:
Add missing comma
Changesv3->v4:
Fix array comparison:
Quoted 6 lines
get_option('trace_backends') != [ 'nop' ]
not
get_option('trace_backends') != 'nop'
---
trace/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)Thanks, applied to my block-next tree:
https://gitlab.com/stefanha/qemu/-/commit/d0380c64b4002e6da3b6e205468030d9e76dcc4a
Stefan