KVM: PPC: BOOK3S: book3s_hv_nested.c: improve branch prediction for k.alloc
Subsystems (2)
PATCH 1/1 KVM: PPC: BOOK3S: book3s_hv_nested.c: improve branch prediction for k.alloc
I used the unlikely() macro on the return values of the k.alloc calls and found that it changes the code generation a bit. Optimize all return paths of k.alloc calls by improving branch prediction on return value of k.alloc.
--- arch/powerpc/kvm/book3s_hv_nested.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/powerpc/kvm/book3s_hv_nested.c +4 -4
@@ -446,7 +446,7 @@ long kvmhv_nested_init(void) ptb_order =12 ; pseries_partition_tb =kmalloc (sizeof (struct patb_entry ) << ptb_order,GFP_KERNEL ); -if (!pseries_partition_tb) { +if (unlikely (!pseries_partition_tb)) {pr_err ("kvm-hv: failed to allocated nested partition table\n" );return -ENOMEM ; }
@@ -575,7 +575,7 @@ long kvmhv_copy_tofrom_guest_nested(struct kvm_vcpu *vcpu)return H_PARAMETER ; buf =kzalloc (n,GFP_KERNEL | __GFP_NOWARN); -if (!buf) +if (unlikely (!buf))return H_NO_MEM ; gp =kvmhv_get_nested (vcpu->kvm, l1_lpid, false);
@@ -689,7 +689,7 @@ static struct kvm_nested_guest *kvmhv_alloc_nested(struct kvm *kvm, unsigned intlong shadow_lpid; gp =kzalloc (sizeof (*gp),GFP_KERNEL ); -if (!gp) +if (unlikely (!gp))return NULL ; gp->l1_host = kvm; gp->l1_lpid = lpid;
@@ -1633,7 +1633,7 @@ static long int __kvmhv_nested_page_fault(struct kvm_vcpu *vcpu,/* 4. Insert the pte into our shadow_pgtable */ n_rmap =kzalloc (sizeof (*n_rmap),GFP_KERNEL ); -if (!n_rmap) +if (unlikely (!n_rmap))return RESUME_GUEST ;/* Let the guest try again */ n_rmap->rmap = (n_gpa &RMAP_NESTED_GPA_MASK ) | (((unsigned long ) gp->l1_lpid) <<RMAP_NESTED_LPID_SHIFT );
Signature · 1 line
2.39.2
Quoted 4 lines · Kautuk Consul
I used the
unlikely()macro on the return values of the k.alloc calls and found that it changes the code generation a bit. Optimize all return paths of k.alloc calls by improving branch prediction on return value of k.alloc.
What about below?
"Improve branch prediction on kmalloc() and kzalloc() call by using unlikely() macro to optimize their return paths."
That is, try to avoid first-person construct (I).
Thanks.
Signature · 1 line
An old man doll... just what I always wanted! - Clara
Quoted 5 lines · Bagas Sanjaya
Quoted 4 lines · Kautuk Consul
I used the
unlikely()macro on the return values of the k.alloc calls and found that it changes the code generation a bit. Optimize all return paths of k.alloc calls by improving branch prediction on return value of k.alloc.
Nit, this is improving code generation, not branch prediction.
Quoted 4 lines
What about below?
"Improve branch prediction on
kmalloc()andkzalloc()call by usingunlikely()macro to optimize their return paths."
Another nit, using unlikely() doesn't necessarily provide a measurable optimization. As above, it does often improve code generation for the happy path, but that doesn't always equate to improved performance, e.g. if the CPU can easily predict the branch and/or there is no impact on the cache footprint.
Quoted 8 lines · Sean Christopherson
Quoted 5 lines · Bagas Sanjaya
Quoted 4 lines · Kautuk Consul
I used the
unlikely()macro on the return values of the k.alloc calls and found that it changes the code generation a bit. Optimize all return paths of k.alloc calls by improving branch prediction on return value of k.alloc.Nit, this is improving code generation, not branch prediction.
Sorry my mistake.
Quoted 10 lines
Quoted 5 lines
What about below?
"Improve branch prediction on
kmalloc()andkzalloc()call by usingunlikely()macro to optimize their return paths."Another nit, using
unlikely()doesn't necessarily provide a measurable optimization. As above, it does often improve code generation for the happy path, but that doesn't always equate to improved performance, e.g. if the CPU can easily predict the branch and/or there is no impact on the cache footprint.
I see. I will submit a v2 of the patch with a better and more accurate description. Does anyone else have any comments before I do so ?
Michael Ellerman
reviewerQuoted 16 lines · Kautuk Consul
Quoted 8 lines · Sean Christopherson
Quoted 5 lines · Bagas Sanjaya
Quoted 4 lines · Kautuk Consul
I used the
unlikely()macro on the return values of the k.alloc calls and found that it changes the code generation a bit. Optimize all return paths of k.alloc calls by improving branch prediction on return value of k.alloc.Nit, this is improving code generation, not branch prediction.
Sorry my mistake.
Quoted 6 lines
Quoted 5 lines
What about below?
"Improve branch prediction on
kmalloc()andkzalloc()call by usingunlikely()macro to optimize their return paths."
Quoted 7 lines
Quoted 4 lines
Another nit, using
unlikely()doesn't necessarily provide a measurable optimization. As above, it does often improve code generation for the happy path, but that doesn't always equate to improved performance, e.g. if the CPU can easily predict the branch and/or there is no impact on the cache footprint.I see. I will submit a v2 of the patch with a better and more accurate description. Does anyone else have any comments before I do so ?
In general I think unlikely should be saved for cases where either the compiler is generating terrible code, or the likelyness of the condition might be surprising to a human reader.
eg. if you had some code that does a NULL check and it's *expected* that the value is NULL, then wrapping that check in likely() actually adds information for a human reader.
Also please don't use unlikely in init paths or other cold paths, it clutters the code (only slightly but a little) and that's not worth the possible tiny benefit for code that only runs once or infrequently.
I would expect the compilers to do the right thing in all these cases without the unlikely. But if you can demonstrate that they meaningfully improve the code generation with a before/after dissassembly then I'd be interested.
cheers
A message that is not in the archive (sent off-list or not yet received): CAKWYkK0hjMiP7yJWWjWX8CqS1Lcqi2z4P1bzj14-AU8SzBkYqw@mail.gmail.com
Sorry, last email rejected by the mailing lists.
Can you please look at the diff file attach ?
Quoted 59 lines · Kautuk Consul
Hi,
Sorry Im replying back using my private gmail ID as I can't figure out how to attach multiple files using mutt.
Quoted 34 lines · Michael Ellerman
Quoted 16 lines · Kautuk Consul
Quoted 8 lines · Sean Christopherson
Quoted 5 lines · Bagas Sanjaya
Quoted 4 lines · Kautuk Consul
I used the
unlikely()macro on the return values of the k.alloc calls and found that it changes the code generation a bit. Optimize all return paths of k.alloc calls by improving branch prediction on return value of k.alloc.Nit, this is improving code generation, not branch prediction.
Sorry my mistake.
Quoted 6 lines
Quoted 5 lines
What about below?
"Improve branch prediction on
kmalloc()andkzalloc()call by usingunlikely()macro to optimize their return paths."Quoted 7 lines
Quoted 4 lines
Another nit, using
unlikely()doesn't necessarily provide a measurable optimization. As above, it does often improve code generation for the happy path, but that doesn't always equate to improved performance, e.g. if the CPU can easily predict the branch and/or there is no impact on the cache footprint.I see. I will submit a v2 of the patch with a better and more accurate description. Does anyone else have any comments before I do so ?
In general I think unlikely should be saved for cases where either the compiler is generating terrible code, or the likelyness of the condition might be surprising to a human reader.
eg. if you had some code that does a NULL check and it's *expected* that the value is NULL, then wrapping that check in
likely()actually adds information for a human reader.Quoted 9 lines
Also please don't use unlikely in init paths or other cold paths, it clutters the code (only slightly but a little) and that's not worth the possible tiny benefit for code that only runs once or infrequently.
I would expect the compilers to do the right thing in all these cases without the unlikely. But if you can demonstrate that they meaningfully improve the code generation with a before/after dissassembly then I'd be interested.
There are surprisingly many changes to code generation before and after using these
instances of the unlikely macro. I couldn't really analyze all of them to be able to state
that they are indeed improving performance in some way. I assumed the compiler would generate optimal code for these unlikely paths.
Please find the before and after file attached to this email.Quoted 1 line
cheers
Hi,
Quoted 33 lines · Michael Ellerman
Quoted 16 lines · Kautuk Consul
Quoted 8 lines · Sean Christopherson
Quoted 5 lines · Bagas Sanjaya
Quoted 4 lines · Kautuk Consul
I used the
unlikely()macro on the return values of the k.alloc calls and found that it changes the code generation a bit. Optimize all return paths of k.alloc calls by improving branch prediction on return value of k.alloc.Nit, this is improving code generation, not branch prediction.
Sorry my mistake.
Quoted 6 lines
Quoted 5 lines
What about below?
"Improve branch prediction on
kmalloc()andkzalloc()call by usingunlikely()macro to optimize their return paths."Quoted 7 lines
Quoted 4 lines
Another nit, using
unlikely()doesn't necessarily provide a measurable optimization. As above, it does often improve code generation for the happy path, but that doesn't always equate to improved performance, e.g. if the CPU can easily predict the branch and/or there is no impact on the cache footprint.I see. I will submit a v2 of the patch with a better and more accurate description. Does anyone else have any comments before I do so ?
In general I think unlikely should be saved for cases where either the compiler is generating terrible code, or the likelyness of the condition might be surprising to a human reader.
eg. if you had some code that does a NULL check and it's *expected* that the value is NULL, then wrapping that check in
likely()actually adds information for a human reader.
Quoted 8 lines
Also please don't use unlikely in init paths or other cold paths, it clutters the code (only slightly but a little) and that's not worth the possible tiny benefit for code that only runs once or infrequently.
I would expect the compilers to do the right thing in all these cases without the unlikely. But if you can demonstrate that they meaningfully improve the code generation with a before/after dissassembly then I'd be interested.
Just FYI, the last email by [email protected] was by me. That last email contains a diff file attachment which compares 2 files:
before my changes and after my changes.
This diff file shows a lot of changes in code generation. Im assuming all those changes are made by the compiler towards optimizing all return paths to k.alloc calls.
Kindly review and comment.
Quoted 1 line
cheers
Quoted 44 lines · Kautuk Consul
Hi,
Quoted 33 lines · Michael Ellerman
Quoted 16 lines · Kautuk Consul
Quoted 8 lines · Sean Christopherson
Quoted 5 lines · Bagas Sanjaya
Quoted 4 lines · Kautuk Consul
I used the
unlikely()macro on the return values of the k.alloc calls and found that it changes the code generation a bit. Optimize all return paths of k.alloc calls by improving branch prediction on return value of k.alloc.Nit, this is improving code generation, not branch prediction.
Sorry my mistake.
Quoted 6 lines
Quoted 5 lines
What about below?
"Improve branch prediction on
kmalloc()andkzalloc()call by usingunlikely()macro to optimize their return paths."Quoted 7 lines
Quoted 4 lines
Another nit, using
unlikely()doesn't necessarily provide a measurable optimization. As above, it does often improve code generation for the happy path, but that doesn't always equate to improved performance, e.g. if the CPU can easily predict the branch and/or there is no impact on the cache footprint.I see. I will submit a v2 of the patch with a better and more accurate description. Does anyone else have any comments before I do so ?
In general I think unlikely should be saved for cases where either the compiler is generating terrible code, or the likelyness of the condition might be surprising to a human reader.
eg. if you had some code that does a NULL check and it's *expected* that the value is NULL, then wrapping that check in
likely()actually adds information for a human reader.Quoted 8 lines
Also please don't use unlikely in init paths or other cold paths, it clutters the code (only slightly but a little) and that's not worth the possible tiny benefit for code that only runs once or infrequently.
I would expect the compilers to do the right thing in all these cases without the unlikely. But if you can demonstrate that they meaningfully improve the code generation with a before/after dissassembly then I'd be interested.
Quoted 7 lines
Just FYI, the last email by [email protected] was by me. That last email contains a diff file attachment which compares 2 files:
before my changes and after my changes.
This diff file shows a lot of changes in code generation. Im assuming all those changes are made by the compiler towards optimizing all return paths to k.alloc calls.
Kindly review and comment.
Any comments on the numerous code generation changes as shown by the files I attached to this mail chain ? Sorry I don't have concrete figures of any type to prove that this leads to any measurable performance improvements. I am just assuming that the compiler's modified code generation (due to the use of the unlikely macro) would be optimal.
Thanks.
Quoted 1 line
Quoted 1 line
cheers