Input: Check sanity of pipe in pegasus_probe()
Subsystems (2)
PATCH 1/1 Input: Check sanity of pipe in pegasus_probe()
Fix WARNING in pegasus_open/usb_submit_urb
Syzbot bug: https://syzkaller.appspot.com/bug?id=bbc107584dcf3262253ce93183e51f3612aaeb13
Warning raised because pegasus_driver submits transfer request for bogus URB(pipe type does not match endpoint type). Add sanity check at probe time for pipe value extracted from endpoint descriptor. Probe will fail if sanity check fails.
--- drivers/input/tablet/pegasus_notetaker.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/input/tablet/pegasus_notetaker.c +6 -0
@@ -296,6 +296,12 @@ static int pegasus_probe(struct usb_interface *intf, pegasus->intf = intf; pipe =usb_rcvintpipe (dev, endpoint->bEndpointAddress); +/* Sanity check that pipe's type matches endpoint's type */ +if (usb_pipe_type_check (dev, pipe)) { + error = -EINVAL ; + goto err_free_mem; + } + pegasus->data_len =usb_maxpacket (dev, pipe); pegasus->data = usb_alloc_coherent(dev, pegasus->data_len, GFP_KERNEL,
Signature · 1 line
2.17.1
Quoted 10 lines · Soumya Negi
Fix WARNING in pegasus_open/usb_submit_urb
Syzbot bug: https://syzkaller.appspot.com/bug?id=bbc107584dcf3262253ce93183e51f3612aaeb13Warning raised because
pegasus_driversubmits transfer request for bogus URB(pipe type does not match endpoint type). Add sanity check at probe time for pipe value extracted from endpoint descriptor. Probe will fail if sanity check fails.Reported-and-tested-by [email protected]Signed-off-by Soumya Negi <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry