Skip to contentSkip to conversation

meson: Disable testplan build by default

PATCH NAK Ville Syrjala 3 participants 9 messages Apr 11, 2023 – Apr 13, 2023 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 meson: Disable testplan build by default

From: Ville Syrjälä <[email protected]>

No real idea what this "testplan" is and why it lives in igt. Seems to be build some xe documentation, and based on the name is maybe some manager level stuff? Surely this is nothing that matters for normal people (esp. those outside Intel).

The main problem here being that it is hideously slow to build, making life miserable for everyone. Flip the default to disabled and let those that need this enable it themselves.

On my HSW:

$ touch tests/kms_color.c # any random file
$ time ninja -Cbuild
- real  0m22,202s
- user  0m20,640s
- sys   0m1,570s
+ real  0m0,241s
+ user  0m0,214s
+ sys   0m0,031s
Cc Kamil Konieczny <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
---
 meson_options.txt | 1 +
 1 file changed, 1 insertion(+)
meson_options.txt +1 -0
index d4e373d6cfc4..0ea1383a4fe8 100644
@@ -22,6 +22,7 @@ option('man',
 
 option('testplan',
        type : 'feature',
+       value : 'disabled',
        description : 'Build testplan documentation pages in ReST and html')
 
 option('sphinx',
Signature · 1 line
2.39.2
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for meson: Disable testplan build by default

== Series Details ==

== Series Details ==

Series: meson: Disable testplan build by default
URL : https://patchwork.freedesktop.org/series/116312/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12987 -> IGTPW_8777
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/index.html

Participating hosts (35 -> 34)
------------------------------

Missing (1): fi-snb-2520m

Known issues
------------

Here are the changes found in IGTPW_8777 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s0@smem:
- bat-dg2-9: [PASS][1] -> [DMESG-WARN][2] ([i915#6704])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/bat-dg2-9/igt@gem_exec_suspend@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/bat-dg2-9/igt@gem_exec_suspend@[email protected]
- bat-rpls-2: [PASS][3] -> [ABORT][4] ([i915#6687])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/bat-rpls-2/igt@gem_exec_suspend@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/bat-rpls-2/igt@gem_exec_suspend@[email protected]

* igt@gem_exec_suspend@basic-s3@smem:
- bat-rpls-1: NOTRUN -> [ABORT][5] ([i915#6687] / [i915#7978])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/bat-rpls-1/igt@gem_exec_suspend@[email protected]

* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-FAIL][6] ([i915#6367])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/bat-rpls-1/igt@i915_selftest@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][7] ([i915#4983]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/bat-rpls-1/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/bat-rpls-1/igt@i915_selftest@[email protected]

#### Warnings ####

* igt@i915_selftest@live@slpc:
- bat-rpls-2: [DMESG-FAIL][9] ([i915#6997] / [i915#7913]) -> [DMESG-FAIL][10] ([i915#6367] / [i915#7913])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/bat-rpls-2/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/bat-rpls-2/igt@i915_selftest@[email protected]

[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6704]: https://gitlab.freedesktop.org/drm/intel/issues/6704
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7249 -> IGTPW_8777

CI-20190529: 20190529
CI_DRM_12987: 603a179375a194085e1462cf1c24f2a0006dd72b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8777: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/index.html
IGT_7249: 44cc06fb6a20c8907f696ca61ba87e152b3dcd11 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

Testlist changes
----------------

-igt@kms_color@ctm-signed

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/index.html

#2 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for meson: Disable testplan build by default

In reply to Ville Syrjala
== Series Details ==

== Series Details ==

Series: meson: Disable testplan build by default
URL : https://patchwork.freedesktop.org/series/116312/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12987_full -> IGTPW_8777_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_8777_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_8777_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/index.html

Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_8777_full:

### IGT changes ###

#### Possible regressions ####

* igt@perf_pmu@faulting-read@uc:
- shard-apl: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-apl2/igt@perf_pmu@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-apl1/igt@perf_pmu@[email protected]

* igt@perf_pmu@faulting-read@wb:
- shard-apl: [PASS][3] -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-apl2/igt@perf_pmu@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-apl1/igt@perf_pmu@[email protected]

Known issues
------------

Here are the changes found in IGTPW_8777_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2842])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-glk9/igt@gem_exec_fair@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-glk7/igt@gem_exec_fair@[email protected]

* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#3886])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-apl2/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

* igt@kms_chamelium_hpd@hdmi-hpd-storm:
- shard-snb: NOTRUN -> [SKIP][8] ([fdo#109271]) +45 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-snb7/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2346])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-glk5/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-glk4/igt@[email protected]

* igt@kms_plane_alpha_blend@constant-alpha-max@pipe-c-dp-1:
- shard-apl: NOTRUN -> [FAIL][11] ([i915#4573]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-apl4/igt@kms_plane_alpha_blend@[email protected]

* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#658])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-apl7/igt@kms_psr2_su@page_flip-xrgb8888.html

* igt@kms_vblank@pipe-d-ts-continuation-dpms-rpm:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271]) +21 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-apl7/igt@[email protected]

* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#2437])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-apl4/igt@[email protected]

#### Possible fixes ####

* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}: [FAIL][15] ([i915#7742]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-rkl-7/igt@drm_fdinfo@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-rkl-7/igt@drm_fdinfo@[email protected]

* igt@gem_barrier_race@remote-request@rcs0:
- shard-apl: [ABORT][17] ([i915#8211] / [i915#8234]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-apl6/igt@gem_barrier_race@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-apl7/igt@gem_barrier_race@[email protected]

* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][19] ([i915#6268]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-tglu-3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-tglu-6/igt@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- {shard-rkl}: [FAIL][21] ([i915#2842]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-rkl-7/igt@gem_exec_fair@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-rkl-3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_suspend@basic-s4-devices@smem:
- {shard-tglu}: [ABORT][23] ([i915#7975]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-tglu-10/igt@gem_exec_suspend@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-tglu-8/igt@gem_exec_suspend@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- {shard-tglu}: [FAIL][25] ([i915#3989] / [i915#454]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-tglu-2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-tglu-10/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- {shard-tglu}: [WARN][27] ([i915#2681]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-tglu-6/igt@i915_pm_rc6_residency@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-tglu-3/igt@i915_pm_rc6_residency@[email protected]

* igt@i915_pm_rpm@dpms-lpsp:
- {shard-rkl}: [SKIP][29] ([i915#1397]) -> [PASS][30] +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-rkl-1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-rkl-7/igt@[email protected]

* igt@i915_pm_rpm@modeset-lpsp:
- {shard-dg1}: [SKIP][31] ([i915#1397]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-dg1-16/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-dg1-14/igt@[email protected]

* igt@i915_suspend@fence-restore-untiled:
- {shard-tglu}: [ABORT][33] ([i915#5122]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-tglu-7/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-tglu-8/igt@[email protected]

* igt@kms_cursor_legacy@forked-bo@pipe-b:
- {shard-rkl}: [INCOMPLETE][35] ([i915#8011]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-rkl-7/igt@kms_cursor_legacy@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-rkl-2/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@dpms-vs-vblank-race-interruptible@b-hdmi-a2:
- shard-glk: [FAIL][37] ([i915#407]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-glk1/igt@kms_flip@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-glk7/igt@kms_flip@[email protected]

* igt@kms_plane_scaling@i915-max-src-size@pipe-a-hdmi-a-1:
- {shard-tglu}: [FAIL][39] ([i915#8292]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12987/shard-tglu-8/igt@kms_plane_scaling@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/shard-tglu-8/igt@kms_plane_scaling@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#407]: https://gitlab.freedesktop.org/drm/intel/issues/407
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5431]: https://gitlab.freedesktop.org/drm/intel/issues/5431
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7249 -> IGTPW_8777
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_12987: 603a179375a194085e1462cf1c24f2a0006dd72b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8777: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/index.html
IGT_7249: 44cc06fb6a20c8907f696ca61ba87e152b3dcd11 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8777/index.html

#3 lore raw
In reply to Ville Syrjala
Quoted 7 lines · On Tue, 11 Apr 2023 14:02:05 +0300 Ville Syrjala…

From: Ville Syrjälä <[email protected]>

No real idea what this "testplan" is and why it lives in igt. Seems to be build some xe documentation, and based on the name is maybe some manager level stuff? Surely this is nothing that matters for normal people (esp. those outside Intel).

No. Basically, testplan contains documentation for the tests. Currently, it contains 100% of the documentation from Xe tests. We may end implementing it for i915 as well.

There is even a plan to generate testlists like xe-fast-feedback.testlist directly from documentation. So, it is important to have the tests properly documented, as otherwise they won't be executed by CI in the future.

Quoted 5 lines

The main problem here being that it is hideously slow to build, making life miserable for everyone. Flip the default to disabled and let those that need this enable it themselves.

Generating documents takes ~150ms. What makes it slow is not the doc generation itself, but a validation logic that checks if the test documentation was updated as tests got added/renamed/removed. It currently uses igt_runner, pointing to the documented tests. As right now just Xe tests uses it, it will call the runner with:

	$ igt_runner -L -t igt@xe ${builddir}/tests

Perhaps the best strategy would be to re-implement the logic there to not use igt_runner, executing

	 ${builddir}/tests/xe_* --list

directly, and in parallel. I'll work on a patch like that.

Anyway, all developers touching documented tests should run (and so CI), as we don't want to have undocumented tests on IGT.

So,

NACK.

Regards,
Mauro

Quoted 30 lines

On my HSW:

$ touch tests/kms_color.c # any random file
$ time ninja -Cbuild
- real  0m22,202s
- user  0m20,640s
- sys   0m1,570s
+ real  0m0,241s
+ user  0m0,214s
+ sys   0m0,031s
Cc Kamil Konieczny <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
---
 meson_options.txt | 1 +
 1 file changed, 1 insertion(+)
meson_options.txt +1 -0
index d4e373d6cfc4..0ea1383a4fe8 100644
@@ -22,6 +22,7 @@ option('man',
 
 option('testplan',
        type : 'feature',
+       value : 'disabled',
        description : 'Build testplan documentation pages in ReST and html')
 
 option('sphinx',
#4 lore raw
Quoted 25 lines · Mauro Carvalho Chehab
Quoted 7 lines · On Tue, 11 Apr 2023 14:02:05 +0300 Ville Syrjala…

From: Ville Syrj�l� <[email protected]>

No real idea what this "testplan" is and why it lives in igt. Seems to be build some xe documentation, and based on the name is maybe some manager level stuff? Surely this is nothing that matters for normal people (esp. those outside Intel).

No. Basically, testplan contains documentation for the tests. Currently, it contains 100% of the documentation from Xe tests. We may end implementing it for i915 as well.

There is even a plan to generate testlists like xe-fast-feedback.testlist directly from documentation. So, it is important to have the tests properly documented, as otherwise they won't be executed by CI in the future.

Quoted 5 lines

The main problem here being that it is hideously slow to build, making life miserable for everyone. Flip the default to disabled and let those that need this enable it themselves.

Quoted 7 lines

Generating documents takes ~150ms. What makes it slow is not the doc generation itself, but a validation logic that checks if the test documentation was updated as tests got added/renamed/removed. It currently uses igt_runner, pointing to the documented tests. As right now just Xe tests uses it, it will call the runner with:

	$ igt_runner -L -t igt@xe ${builddir}/tests

That is not the slow thing. The slow thing is some python stuff.

Quoted 48 lines

Perhaps the best strategy would be to re-implement the logic there to not use igt_runner, executing

	 ${builddir}/tests/xe_* --list

directly, and in parallel. I'll work on a patch like that.

Anyway, all developers touching documented tests should run (and so CI), as we don't want to have undocumented tests on IGT.

So,

NACK.

Regards,
Mauro

Quoted 30 lines

On my HSW:

$ touch tests/kms_color.c # any random file
$ time ninja -Cbuild
- real  0m22,202s
- user  0m20,640s
- sys   0m1,570s
+ real  0m0,241s
+ user  0m0,214s
+ sys   0m0,031s
Cc Kamil Konieczny <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
---
 meson_options.txt | 1 +
 1 file changed, 1 insertion(+)
meson_options.txt +1 -0
index d4e373d6cfc4..0ea1383a4fe8 100644
@@ -22,6 +22,7 @@ option('man',
 
 option('testplan',
        type : 'feature',
+       value : 'disabled',
        description : 'Build testplan documentation pages in ReST and html')
 
 option('sphinx',
Signature · 2 lines
Ville Syrj�l�
Intel
#5 lore raw
Quoted 32 lines · On Wed, 12 Apr 2023 10:33:39 +0300 Ville Syrjälä…
Quoted 31 lines · Mauro Carvalho Chehab
Quoted 7 lines · On Tue, 11 Apr 2023 14:02:05 +0300 Ville Syrjala…

From: Ville Syrjälä <[email protected]>

No real idea what this "testplan" is and why it lives in igt. Seems to be build some xe documentation, and based on the name is maybe some manager level stuff? Surely this is nothing that matters for normal people (esp. those outside Intel).

No. Basically, testplan contains documentation for the tests. Currently, it contains 100% of the documentation from Xe tests. We may end implementing it for i915 as well.

There is even a plan to generate testlists like xe-fast-feedback.testlist directly from documentation. So, it is important to have the tests properly documented, as otherwise they won't be executed by CI in the future.

Quoted 5 lines

The main problem here being that it is hideously slow to build, making life miserable for everyone. Flip the default to disabled and let those that need this enable it themselves.

Generating documents takes ~150ms. What makes it slow is not the doc generation itself, but a validation logic that checks if the test documentation was updated as tests got added/renamed/removed. It currently uses igt_runner, pointing to the documented tests. As right now just Xe tests uses it, it will call the runner with:

Quoted 3 lines
Quoted 1 line
	$ igt_runner -L -t igt@xe ${builddir}/tests

That is not the slow thing. The slow thing is some python stuff.

This was part of the slow logic. The other part is to run regular expressions to check test names. This also needed some optimization.

Just sent a patch series using re.compile() to speed regexes, with a replacement patch for igt_runner.

It could be possible to optimize it even further with multithreading but as it is now taking 500ms to run (against 12 seconds before that on a i7 notebook using python 3.11), it seems good enough to me after the changes.

Patch series sent: https://patchwork.freedesktop.org/series/116379/

Regards,
Mauro

#6 lore raw
Quoted 45 lines · Mauro Carvalho Chehab
Quoted 32 lines · On Wed, 12 Apr 2023 10:33:39 +0300 Ville Syrj�l�…
Quoted 31 lines · Mauro Carvalho Chehab
Quoted 7 lines · On Tue, 11 Apr 2023 14:02:05 +0300 Ville Syrjala…

From: Ville Syrj�l� <[email protected]>

No real idea what this "testplan" is and why it lives in igt. Seems to be build some xe documentation, and based on the name is maybe some manager level stuff? Surely this is nothing that matters for normal people (esp. those outside Intel).

No. Basically, testplan contains documentation for the tests. Currently, it contains 100% of the documentation from Xe tests. We may end implementing it for i915 as well.

There is even a plan to generate testlists like xe-fast-feedback.testlist directly from documentation. So, it is important to have the tests properly documented, as otherwise they won't be executed by CI in the future.

Quoted 5 lines

The main problem here being that it is hideously slow to build, making life miserable for everyone. Flip the default to disabled and let those that need this enable it themselves.

Generating documents takes ~150ms. What makes it slow is not the doc generation itself, but a validation logic that checks if the test documentation was updated as tests got added/renamed/removed. It currently uses igt_runner, pointing to the documented tests. As right now just Xe tests uses it, it will call the runner with:

Quoted 3 lines
Quoted 1 line
	$ igt_runner -L -t igt@xe ${builddir}/tests

That is not the slow thing. The slow thing is some python stuff.

This was part of the slow logic. The other part is to run regular expressions to check test names. This also needed some optimization.

Just sent a patch series using re.compile() to speed regexes, with a replacement patch for igt_runner.

Quoted 6 lines

It could be possible to optimize it even further with multithreading but as it is now taking 500ms to run (against 12 seconds before that on a i7 notebook using python 3.11), it seems good enough to me after the changes.

Patch series sent: https://patchwork.freedesktop.org/series/116379/

That is definitely much improved. Thanks.

Still feels a bit too slow to keep enabled
during normal developement work though.

$ time git rebase -x 'ninja -Cbuild' HEAD~10

-Dtestplan=disabled

real    0m9,699s
user    0m26,422s
sys     0m2,518s

-Dtestplan=auto

real    0m46,020s
user    1m5,102s
sys     0m4,191s

At least for me that that would still exceed
my attention span.

But seems fast enough for a one off test build
before sending out patches/pushing.

Signature · 2 lines
Ville Syrj�l�
Intel
#7 lore raw
Quoted 70 lines · On Wed, 12 Apr 2023 17:18:32 +0300 Ville Syrjälä…
Quoted 45 lines · Mauro Carvalho Chehab
Quoted 32 lines · On Wed, 12 Apr 2023 10:33:39 +0300 Ville Syrjälä…
Quoted 31 lines · Mauro Carvalho Chehab
Quoted 7 lines · On Tue, 11 Apr 2023 14:02:05 +0300 Ville Syrjala…

From: Ville Syrjälä <[email protected]>

No real idea what this "testplan" is and why it lives in igt. Seems to be build some xe documentation, and based on the name is maybe some manager level stuff? Surely this is nothing that matters for normal people (esp. those outside Intel).

No. Basically, testplan contains documentation for the tests. Currently, it contains 100% of the documentation from Xe tests. We may end implementing it for i915 as well.

There is even a plan to generate testlists like xe-fast-feedback.testlist directly from documentation. So, it is important to have the tests properly documented, as otherwise they won't be executed by CI in the future.

Quoted 5 lines

The main problem here being that it is hideously slow to build, making life miserable for everyone. Flip the default to disabled and let those that need this enable it themselves.

Generating documents takes ~150ms. What makes it slow is not the doc generation itself, but a validation logic that checks if the test documentation was updated as tests got added/renamed/removed. It currently uses igt_runner, pointing to the documented tests. As right now just Xe tests uses it, it will call the runner with:

Quoted 3 lines
Quoted 1 line
	$ igt_runner -L -t igt@xe ${builddir}/tests  

That is not the slow thing. The slow thing is some python stuff.

This was part of the slow logic. The other part is to run regular expressions to check test names. This also needed some optimization.

Just sent a patch series using re.compile() to speed regexes, with a replacement patch for igt_runner.

Quoted 6 lines

It could be possible to optimize it even further with multithreading but as it is now taking 500ms to run (against 12 seconds before that on a i7 notebook using python 3.11), it seems good enough to me after the changes.

Patch series sent: https://patchwork.freedesktop.org/series/116379/

That is definitely much improved. Thanks.

Still feels a bit too slow to keep enabled
during normal developement work though.

$ time git rebase -x 'ninja -Cbuild' HEAD~10

-Dtestplan=disabled

real    0m9,699s
user    0m26,422s
sys     0m2,518s

-Dtestplan=auto

real    0m46,020s
user    1m5,102s
sys     0m4,191s
Quoted 5 lines

At least for me that that would still exceed
my attention span.

But seems fast enough for a one off test build
before sending out patches/pushing.

I guess we can set sphinx to disable by default. Still, the time to build from scratch is ~1.30 mins here:

	$ rm -rf build && meson setup build
	$ time ninja -C build
	ninja: Entering directory `build'
	[1330/1330] Generating docs/testplan/xe_tests.html with a custom command
	real	1m33.598s
	user	9m5.730s
	sys	1m10.462s

Re-running it with Sphinx disabled after a single file change is fast:

	$ touch tests/xe/xe_compute.c 
	$ time ninja -C build
	ninja: Entering directory `build'
	[5/5] Generating docs/testplan/xe_tests.html with a custom command
	real	0m1.746s
	user	0m1.574s
	sys	0m0.171s

Re-running it with Sphinx enabled (and with rst2pdf installed) after a single file change takes 9 extra seconds here:

	$ touch tests/xe/xe_compute.c 
	$ time ninja -C build
	...
	[9/9] Generating docs/testplan/xe_tests.pdf with a custom command
	real	0m10.545s
	user	0m13.778s
	sys	0m0.724s

So, I'll add this patch at the end of the series:

meson_options.txt +1 -0
index d4e373d6cfc4..2cb44f20169b 100644
@@ -26,6 +26,7 @@ option('testplan',
 
 option('sphinx',
        type : 'feature',
+       value : 'disabled',
        description : 'Build testplan documentation using Sphinx')
 
 option('docs',

Please reply with your R-B and/or A-B for me to apply it at the revision 3 (I'm about to send it).

Regards,
Mauro

#8 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for meson: Disable testplan build by default (rev2)

In reply to Ville Syrjala
== Series Details ==

== Series Details ==

Series: meson: Disable testplan build by default (rev2)
URL : https://patchwork.freedesktop.org/series/116312/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12999 -> IGTPW_8797
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_8797 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_8797, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8797/index.html

Participating hosts (37 -> 36)
------------------------------

Missing (1): fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_8797:

### IGT changes ###

#### Possible regressions ####

* igt@i915_module_load@load:
- bat-dg1-7: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12999/bat-dg1-7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8797/bat-dg1-7/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_8797 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@migrate:
- bat-adlp-6: [PASS][3] -> [DMESG-FAIL][4] ([i915#7699])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12999/bat-adlp-6/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8797/bat-adlp-6/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- fi-kbl-soraka: [PASS][5] -> [ABORT][6] ([i915#7913])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12999/fi-kbl-soraka/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8797/fi-kbl-soraka/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-2: [PASS][7] -> [ABORT][8] ([i915#7978])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12999/bat-rpls-2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8797/bat-rpls-2/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][9] ([i915#5354])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8797/bat-dg2-11/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [PASS][10] -> [FAIL][11] ([i915#7932])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12999/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8797/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@migrate:
- bat-dg2-11: [DMESG-WARN][12] ([i915#7699]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12999/bat-dg2-11/igt@i915_selftest@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8797/bat-dg2-11/igt@i915_selftest@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
- bat-dg2-8: [FAIL][14] ([i915#7932]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12999/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8797/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]

#### Warnings ####

* igt@i915_selftest@live@slpc:
- bat-rpls-2: [DMESG-FAIL][16] ([i915#6367] / [i915#7913] / [i915#7996]) -> [DMESG-FAIL][17] ([i915#6997] / [i915#7913])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12999/bat-rpls-2/igt@i915_selftest@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8797/bat-rpls-2/igt@i915_selftest@[email protected]

[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7253 -> IGTPW_8797

CI-20190529: 20190529
CI_DRM_12999: 10a071db6707a1aedbfc9fa7aece52f3ef7e31a4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8797: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8797/index.html
IGT_7253: 1a619e8dbc6ca887f2ae24b2d7f1ac536342f58c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

Testlist changes
----------------

-igt@i915_pm_freq_api@freq-basic-api
-igt@i915_pm_freq_api@freq-reset

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8797/index.html