Skip to contentSkip to conversation

iommu/exynos: Use the devm_clk_get_optional() helper

PATCH Applied Christophe JAILLET 3 participants 3 messages Mar 26, 2023 – Apr 13, 2023

Subsystems (4)
Kernel janitors Arm Samsung Exynos IOMMU Exynos sysmmu (IOMMU) driver
lore
Share & tools
lore

Christophe JAILLET

author
#0 lore raw

PATCH 1/1 iommu/exynos: Use the devm_clk_get_optional() helper

Use devm_clk_get_optional() instead of hand writing it. This saves some loC and improves the semantic.

Signed-off-by Christophe JAILLET <[email protected]>
---
 drivers/iommu/exynos-iommu.c | 24 ++++++++----------------
 1 file changed, 8 insertions(+), 16 deletions(-)
drivers/iommu/exynos-iommu.c +8 -16
index 483aaaeb6dae..867f409e0325 100644
@@ -747,22 +747,16 @@ static int exynos_sysmmu_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	data->clk = devm_clk_get(dev, "sysmmu");
-	if (PTR_ERR(data->clk) == -ENOENT)
-		data->clk = NULL;
-	else if (IS_ERR(data->clk))
+	data->clk = devm_clk_get_optional(dev, "sysmmu");
+	if (IS_ERR(data->clk))
 		return PTR_ERR(data->clk);
 
-	data->aclk = devm_clk_get(dev, "aclk");
-	if (PTR_ERR(data->aclk) == -ENOENT)
-		data->aclk = NULL;
-	else if (IS_ERR(data->aclk))
+	data->aclk = devm_clk_get_optional(dev, "aclk");
+	if (IS_ERR(data->aclk))
 		return PTR_ERR(data->aclk);
 
-	data->pclk = devm_clk_get(dev, "pclk");
-	if (PTR_ERR(data->pclk) == -ENOENT)
-		data->pclk = NULL;
-	else if (IS_ERR(data->pclk))
+	data->pclk = devm_clk_get_optional(dev, "pclk");
+	if (IS_ERR(data->pclk))
 		return PTR_ERR(data->pclk);
 
 	if (!data->clk && (!data->aclk || !data->pclk)) {

@@ -770,10 +764,8 @@ static int exynos_sysmmu_probe(struct platform_device *pdev)
 		return -ENOSYS;
 	}
 
-	data->clk_master = devm_clk_get(dev, "master");
-	if (PTR_ERR(data->clk_master) == -ENOENT)
-		data->clk_master = NULL;
-	else if (IS_ERR(data->clk_master))
+	data->clk_master = devm_clk_get_optional(dev, "master");
+	if (IS_ERR(data->clk_master))
 		return PTR_ERR(data->clk_master);
 
 	data->sysmmu = dev;
Signature · 1 line
2.34.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Christophe JAILLET

Use devm_clk_get_optional() instead of hand writing it. This saves some loC and improves the semantic.

Signed-off-by Christophe JAILLET <[email protected]>
Acked-by Marek Szyprowski <[email protected]>
Quoted 40 lines
---
  drivers/iommu/exynos-iommu.c | 24 ++++++++----------------
  1 file changed, 8 insertions(+), 16 deletions(-)
drivers/iommu/exynos-iommu.c +6 -12
index 483aaaeb6dae..867f409e0325 100644
@@ -747,22 +747,16 @@ static int exynos_sysmmu_probe(struct platform_device *pdev)
  		return ret;
  	}
 
-	data->clk = devm_clk_get(dev, "sysmmu");
-	if (PTR_ERR(data->clk) == -ENOENT)
-		data->clk = NULL;
-	else if (IS_ERR(data->clk))
+	data->clk = devm_clk_get_optional(dev, "sysmmu");
+	if (IS_ERR(data->clk))
  		return PTR_ERR(data->clk);
 
-	data->aclk = devm_clk_get(dev, "aclk");
-	if (PTR_ERR(data->aclk) == -ENOENT)
-		data->aclk = NULL;
-	else if (IS_ERR(data->aclk))
+	data->aclk = devm_clk_get_optional(dev, "aclk");
+	if (IS_ERR(data->aclk))
  		return PTR_ERR(data->aclk);
 
-	data->pclk = devm_clk_get(dev, "pclk");
-	if (PTR_ERR(data->pclk) == -ENOENT)
-		data->pclk = NULL;
-	else if (IS_ERR(data->pclk))
+	data->pclk = devm_clk_get_optional(dev, "pclk");
+	if (IS_ERR(data->pclk))
  		return PTR_ERR(data->pclk);
 
  	if (!data->clk && (!data->aclk || !data->pclk)) {

@@ -770,10 +764,8 @@ static int exynos_sysmmu_probe(struct platform_device *pdev)
  		return -ENOSYS;
  	}

drivers/iommu/exynos-iommu.c static int exynos_sysmmu_probe(struct platform_device *pdev) · line 771

Quoted 10 lines
drivers/iommu/exynos-iommu.c +2 -4
 
-	data->clk_master = devm_clk_get(dev, "master");
-	if (PTR_ERR(data->clk_master) == -ENOENT)
-		data->clk_master = NULL;
-	else if (IS_ERR(data->clk_master))
+	data->clk_master = devm_clk_get_optional(dev, "master");
+	if (IS_ERR(data->clk_master))
  		return PTR_ERR(data->clk_master);
 
  	data->sysmmu = dev;

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland