Skip to contentSkip to conversation

Input: cyttsp5 - fix sensing configuration data structure

PATCH Applied hrdl 3 participants 3 messages Apr 11, 2023 – Apr 14, 2023

Subsystems (3)
lore
Share & tools
lore

hrdl

author
#0 lore raw

PATCH 1/1 Input: cyttsp5 - fix sensing configuration data structure

Prior to this patch, the sensing configuration data was not parsed correctly, breaking detection of max_tch. The vendor driver includes this field. This change informs the driver about the correct maximum number of simultaneous touch inputs.

Tested on a Pine64 PineNote with a modified touch screen controller firmware.

---
 drivers/input/touchscreen/cyttsp5.c | 1 +
 1 file changed, 1 insertion(+)
drivers/input/touchscreen/cyttsp5.c +1 -0
index 16caffa35dd9..30102cb80fac 100644
@@ -111,6 +111,7 @@ struct cyttsp5_sensing_conf_data_dev {
 	__le16 max_z;
 	u8 origin_x;
 	u8 origin_y;
+	u8 panel_id;
 	u8 btn;
 	u8 scan_mode;
 	u8 max_num_of_tch_per_refresh_cycle;
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · hrdl

Prior to this patch, the sensing configuration data was not parsed correctly, breaking detection of max_tch. The vendor driver includes this field. This change informs the driver about the correct maximum number of simultaneous touch inputs.

Tested on a Pine64 PineNote with a modified touch screen controller firmware.

Alistair

Quoted 20 lines

---
drivers/input/touchscreen/cyttsp5.c | 1 +

1 file changed, 1 insertion(+)
drivers/input/touchscreen/cyttsp5.c +1 -0
index 16caffa35dd9..30102cb80fac 100644
@@ -111,6 +111,7 @@ struct cyttsp5_sensing_conf_data_dev {
 __le16 max_z;
 u8 origin_x;
 u8 origin_y;
+ u8 panel_id;
 u8 btn;
 u8 scan_mode;
 u8 max_num_of_tch_per_refresh_cycle;
Signature · 1 line
2.39.2
maintainer Applied
#2 lore raw
In reply to hrdl
Quoted 9 lines · hrdl

Prior to this patch, the sensing configuration data was not parsed correctly, breaking detection of max_tch. The vendor driver includes this field. This change informs the driver about the correct maximum number of simultaneous touch inputs.

Tested on a Pine64 PineNote with a modified touch screen controller firmware.

Applied, thank you.

Signature · 1 line
Dmitry