firmware/psci: demote suspend-mode warning to info level
PATCH RESEND v2 1/1 firmware/psci: demote suspend-mode warning to info level
On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this is now logged at warning level:
psci: failed to set PC mode: -3
As there is nothing users can do about the firmware behaving this way, demote the warning to info level and clearly mark it as a firmware bug:
psci: [Firmware Bug]: failed to set PC mode: -3
---
This one fell between the cracks so resending with tags added.
Mark or Lorenzo, is this something you can pick up?
Johan
drivers/firmware/psci/psci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/firmware/psci/psci.c +2 -1
@@ -167,7 +167,8 @@ int psci_set_osi_mode(bool enable) err =invoke_psci_fn (PSCI_1_0_FN_SET_SUSPEND_MODE , suspend_mode,0 ,0 );if (err <0 ) -pr_warn ("failed to set %s mode: %d\n" , enable ?"OSI" :"PC" , err); +pr_info (FW_BUG "failed to set %s mode: %d\n" , + enable ?"OSI" :"PC" , err);return psci_to_linux_errno (err); }
Signature · 1 line
2.39.2
Quoted 11 lines · Johan Hovold
On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode during boot fails with
PSCI_RET_DENIEDand since commit998fcd001feb("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this is now logged at warning level:psci: failed to set PC mode: -3
As there is nothing users can do about the firmware behaving this way, demote the warning to info level and clearly mark it as a firmware bug:
Quoted 7 lines
psci: [Firmware Bug]: failed to set PC mode: -3
Reviewed-by Ulf Hansson <[email protected]>Acked-by Mark Rutland <[email protected]>Acked-by Sudeep Holla <[email protected]>Signed-off-by Johan Hovold <[email protected]>---
For the sake of completeness:
Quoted 7 lines
This one fell between the cracks so resending with tags added.
Mark or Lorenzo, is this something you can pick up?
Johan
Signature · 2 lines
With best wishes Dmitry
Mark Rutland
maintainerQuoted 16 lines · Johan Hovold
On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode during boot fails with
PSCI_RET_DENIEDand since commit998fcd001feb("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this is now logged at warning level:psci: failed to set PC mode: -3
As there is nothing users can do about the firmware behaving this way, demote the warning to info level and clearly mark it as a firmware bug:
psci: [Firmware Bug]: failed to set PC mode: -3
Reviewed-by Ulf Hansson <[email protected]>Acked-by Mark Rutland <[email protected]>Acked-by Sudeep Holla <[email protected]>Signed-off-by Johan Hovold <[email protected]>
Quoted 7 lines
---
This one fell between the cracks so resending with tags added.
Mark or Lorenzo, is this something you can pick up?
Johan
Sorry about this.
I don't think we have anything else in this area, so Arnd, are you happy to pick this via the soc tree?
Thanks,
Mark.
Quoted 22 lines
drivers/firmware/psci/psci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/firmware/psci/psci.c +2
-1@@ -167,7 +167,8 @@ int psci_set_osi_mode(bool enable) err =invoke_psci_fn (PSCI_1_0_FN_SET_SUSPEND_MODE , suspend_mode,0 ,0 );if (err <0 ) -pr_warn ("failed to set %s mode: %d\n" , enable ?"OSI" :"PC" , err); +pr_info (FW_BUG "failed to set %s mode: %d\n" , + enable ?"OSI" :"PC" , err);return psci_to_linux_errno (err); }Signature · 1 line
2.39.2
Quoted 21 lines · Mark Rutland
Quoted 20 lines · Johan Hovold
On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode during boot fails with
PSCI_RET_DENIEDand since commit998fcd001feb("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this is now logged at warning level:psci: failed to set PC mode: -3
As there is nothing users can do about the firmware behaving this way, demote the warning to info level and clearly mark it as a firmware bug:
psci: [Firmware Bug]: failed to set PC mode: -3
Reviewed-by Ulf Hansson <[email protected]>Acked-by Mark Rutland <[email protected]>Acked-by Sudeep Holla <[email protected]>Signed-off-by Johan Hovold <[email protected]>---
This one fell between the cracks so resending with tags added.
Quoted 8 lines
Quoted 3 lines
Mark or Lorenzo, is this something you can pick up?
Johan
Sorry about this.
I don't think we have anything else in this area, so Arnd, are you happy to pick this via the soc tree?
Sure, applied to the fixes branch for 6.3 now.
Arnd