Skip to contentSkip to conversation

fbdev: visfxfb: HP Visualize-FX framebufffer driver

PATCH New Helge Deller 2 participants 2 messages Apr 23, 2023 – Apr 25, 2023

Subsystems (3)
lore
Share & tools
lore

Helge Deller

author maintainer
#0 lore raw

PATCH v3 1/1 fbdev: visfxfb: HP Visualize-FX framebufffer driver

A framebuffer driver for HP's Visualize-FX series of cards. The aim is to support all FX2 - FX10 types but currently only FX5 is tested.

This driver is an updated version of the one which Sven Schnelle originally posted here:
https://lore.kernel.org/all/[email protected]/

Additional changes:
- added support for 32bpp
- added copyarea to bitblt from screen to screen
- allows screen sizes of up to 1920x1600 pixel
- lots of minor fixes (and probably new bugs)

This driver is still under development, nevertheless it would be great if people could test.
This driver will not work on FX-10 cards yet.

arch/parisc/include/asm/fb.h +1 -1
index 55d29c4f716e..a41b257d70c8 100644
@@ -12,7 +12,7 @@ static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma,
 	pgprot_val(vma->vm_page_prot) |= _PAGE_NO_CACHE;
 }
 
-#if defined(CONFIG_FB_STI)
+#if defined(CONFIG_FB_STI) || defined(FB_VISUALIZEFX)
 int fb_is_primary_device(struct fb_info *info);
 #else
 static inline int fb_is_primary_device(struct fb_info *info)
drivers/video/console/sticore.c +1 -1
index db568f67e4dc..562fb7bebd85 100644
@@ -1148,7 +1148,7 @@ int sti_call(const struct sti_struct *sti, unsigned long func,
 	return ret;
 }
 
-#if defined(CONFIG_FB_STI)
+#if defined(CONFIG_FB_STI) || defined(FB_VISUALIZEFX)
 /* check if given fb_info is the primary device */
 int fb_is_primary_device(struct fb_info *info)
 {
drivers/video/fbdev/Kconfig +12 -0
index 974e862cd20d..aa4d3626087b 100644
@@ -561,6 +561,18 @@ config FB_STI
 
 	  It is safe to enable this option, so you should probably say "Y".
 
+config FB_VISUALIZEFX
+	tristate "HP Visualize FX support"
+	depends on FB && PCI && PARISC
+	select RATIONAL
+	select FB_CFB_IMAGEBLIT
+	  help
+	    Frame buffer driver for the HP Visualize FX cards. These cards are
+	    commonly found in PA-RISC workstations. Currently only FX5 has been
+	    tested.
+
+	    Say Y if you have such a card.
+
 config FB_MAC
 	bool "Generic Macintosh display support"
 	depends on (FB = y) && MAC
drivers/video/fbdev/Makefile +1 -1
index 7795c4126706..ad4b24cd437c 100644
@@ -129,6 +129,6 @@ obj-$(CONFIG_FB_MX3)		  += mx3fb.o
 obj-$(CONFIG_FB_DA8XX)		  += da8xx-fb.o
 obj-$(CONFIG_FB_SSD1307)	  += ssd1307fb.o
 obj-$(CONFIG_FB_SIMPLE)           += simplefb.o
-
+obj-$(CONFIG_FB_VISUALIZEFX)	  += visfxfb.o
 # the test framebuffer is last
 obj-$(CONFIG_FB_VIRTUAL)          += vfb.o
drivers/video/fbdev/visfxfb.c new file +1967 -0

1,967 lines not on this page · raw message

#1 lore raw
kernel test robot noticed the following build warnings:

Hi Helge,

kernel test robot noticed the following build warnings:

[auto build test WARNING on deller-parisc/for-next]
[also build test WARNING on linus/master v6.3 next-20230424] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Helge-Deller/fbdev-visfxfb-HP-Visualize-FX-framebufffer-driver/20230424-060227
base:   https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git for-next
patch link:    https://lore.kernel.org/r/ZEWqkJekzyIlhBlW%40p100
patch subject: [PATCH v3] fbdev: visfxfb: HP Visualize-FX framebufffer driver
config: parisc-allyesconfig (https://download.01.org/0day-ci/archive/20230425/[email protected]/config)
compiler: hppa-linux-gcc (GCC) 12.1.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/96fac55bbf4fc2930b24f7a757369196a5d4940c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Helge-Deller/fbdev-visfxfb-HP-Visualize-FX-framebufffer-driver/20230424-060227 git checkout 96fac55bbf4fc2930b24f7a757369196a5d4940c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash drivers/video/fbdev/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>
| Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

>> drivers/video/fbdev/visfxfb.c:1067:5: warning: no previous prototype for 'visfx_sync' [-Wmissing-prototypes]
    1067 | int visfx_sync(struct fb_info *info)
         |     ^~~~~~~~~~
>> drivers/video/fbdev/visfxfb.c:1431:5: warning: no previous prototype for 'visfx_set_default_mode' [-Wmissing-prototypes]

1431 | int visfx_set_default_mode(struct fb_info *info)
| ^~~~~~~~~~~~~~~~~~~~~~

vim +/visfx_sync +1067 drivers/video/fbdev/visfxfb.c

1066

> 1067	int visfx_sync(struct fb_info *info)

1068 {
1069 visfx_wait_write_pipe_empty(info);
1070 return 0;
1071 }
1072

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests