Skip to contentSkip to conversation

selftests/bpf: Add fexit_sleep to DENYLIST.aarch64

PATCH Applied Martin KaFai Lau 5 participants 6 messages Apr 28, 2023

Subsystems (3)
lore
Share & tools
lore

Martin KaFai Lau

author reviewer
#0 lore raw

PATCH 1/1 selftests/bpf: Add fexit_sleep to DENYLIST.aarch64

From: Martin KaFai Lau <[email protected]>

It is reported that the fexit_sleep never returns in aarch64. The remaining tests cannot start. Put this test into DENYLIST.aarch64 for now so that other tests can continue to run in the CI.

---
 tools/testing/selftests/bpf/DENYLIST.aarch64 | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/bpf/DENYLIST.aarch64 +1 -0
index 4b6b18424140..cd42e2825bd2 100644
@@ -1,5 +1,6 @@
 bpf_cookie/multi_kprobe_attach_api               # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
 bpf_cookie/multi_kprobe_link_api                 # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
+fexit_sleep                                      # The test never returns. The remaining tests cannot start.
 kprobe_multi_bench_attach                        # bpf_program__attach_kprobe_multi_opts unexpected error: -95
 kprobe_multi_test/attach_api_addrs               # bpf_program__attach_kprobe_multi_opts unexpected error: -95
 kprobe_multi_test/attach_api_pattern             # bpf_program__attach_kprobe_multi_opts unexpected error: -95
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Martin KaFai Lau

From: Martin KaFai Lau <[email protected]>

It is reported that the fexit_sleep never returns in aarch64. The remaining tests cannot start. Put this test into DENYLIST.aarch64 for now so that other tests can continue to run in the CI.

Thanks

Quoted 20 lines
---
 tools/testing/selftests/bpf/DENYLIST.aarch64 | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/bpf/DENYLIST.aarch64 +1 -0
index 4b6b18424140..cd42e2825bd2 100644
@@ -1,5 +1,6 @@
 bpf_cookie/multi_kprobe_attach_api               # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
 bpf_cookie/multi_kprobe_link_api                 # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
+fexit_sleep                                      # The test never returns. The remaining tests cannot start.
 kprobe_multi_bench_attach                        # bpf_program__attach_kprobe_multi_opts unexpected error: -95
 kprobe_multi_test/attach_api_addrs               # bpf_program__attach_kprobe_multi_opts unexpected error: -95
 kprobe_multi_test/attach_api_pattern             # bpf_program__attach_kprobe_multi_opts unexpected error: -95
Signature · 1 line
2.34.1
#2 lore raw
In reply to Martin KaFai Lau
This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:

Quoted 10 lines · On Thu, 27 Apr 2023 20:47:26 -0700 you wrote:

From: Martin KaFai Lau <[email protected]>

It is reported that the fexit_sleep never returns in aarch64. The remaining tests cannot start. Put this test into DENYLIST.aarch64 for now so that other tests can continue to run in the CI.

[...]

Here is the summary with links:
- [bpf-next] selftests/bpf: Add fexit_sleep to DENYLIST.aarch64

    https://git.kernel.org/bpf/bpf-next/c/af781ba682e8

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#3 lore raw
In reply to Martin KaFai Lau
Quoted 3 lines · Martin KaFai Lau

From: Martin KaFai Lau <[email protected]>

It is reported that the fexit_sleep never returns in aarch64.

Just to clarify, this was only happening against kernels compiled with llvm-16. It was working fine against kernel compiled with gcc.

Quoted 23 lines

The remaining tests cannot start. Put this test into DENYLIST.aarch64 for now so that other tests can continue to run in the CI.

---
 tools/testing/selftests/bpf/DENYLIST.aarch64 | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/bpf/DENYLIST.aarch64 +1 -0
index 4b6b18424140..cd42e2825bd2 100644
@@ -1,5 +1,6 @@
 bpf_cookie/multi_kprobe_attach_api               # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
 bpf_cookie/multi_kprobe_link_api                 # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
+fexit_sleep                                      # The test never returns. The remaining tests cannot start.
 kprobe_multi_bench_attach                        # bpf_program__attach_kprobe_multi_opts unexpected error: -95
 kprobe_multi_test/attach_api_addrs               # bpf_program__attach_kprobe_multi_opts unexpected error: -95
 kprobe_multi_test/attach_api_pattern             # bpf_program__attach_kprobe_multi_opts unexpected error: -95
Signature · 1 line
2.34.1
maintainer
#4 lore raw
Quoted 10 lines · Manu Bretelle
Quoted 3 lines · Martin KaFai Lau

From: Martin KaFai Lau <[email protected]>

It is reported that the fexit_sleep never returns in aarch64.

Just to clarify, this was only happening against kernels compiled with llvm-16. It was working fine against kernel compiled with gcc.

Quoted 2 lines

The remaining tests cannot start. Put this test into DENYLIST.aarch64 for now so that other tests can continue to run in the CI.

+Florent (for visibility and/or if you plan to look into it)

Quoted 20 lines
Quoted 20 lines
---
  tools/testing/selftests/bpf/DENYLIST.aarch64 | 1 +
  1 file changed, 1 insertion(+)
tools/testing/selftests/bpf/DENYLIST.aarch64 +1 -0
index 4b6b18424140..cd42e2825bd2 100644
@@ -1,5 +1,6 @@
  bpf_cookie/multi_kprobe_attach_api               # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
  bpf_cookie/multi_kprobe_link_api                 # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
+fexit_sleep                                      # The test never returns. The remaining tests cannot start.
  kprobe_multi_bench_attach                        # bpf_program__attach_kprobe_multi_opts unexpected error: -95
  kprobe_multi_test/attach_api_addrs               # bpf_program__attach_kprobe_multi_opts unexpected error: -95
  kprobe_multi_test/attach_api_pattern             # bpf_program__attach_kprobe_multi_opts unexpected error: -95
Signature · 1 line
2.34.1
#5 lore raw
Quoted 7 lines · Daniel Borkmann
Quoted 5 lines · Manu Bretelle
Quoted 3 lines · Martin KaFai Lau

From: Martin KaFai Lau <[email protected]>

It is reported that the fexit_sleep never returns in aarch64.

Quoted 7 lines
Quoted 5 lines

Just to clarify, this was only happening against kernels compiled with llvm-16. It was working fine against kernel compiled with gcc.

Quoted 2 lines

The remaining tests cannot start. Put this test into DENYLIST.aarch64 for now so that other tests can continue to run in the CI.

+Florent (for visibility and/or if you plan to look into it)

Ah, thanks for the quick fix Martin & Manu! :) It's an interesting failure mode, I'll try to have a look at it when I get a chance. (I've had my eyes set on the other failing selftests already :) one more eheh)