Skip to contentSkip to conversation

net: libwx: Replace zero-length array with flexible-array member

PATCH Applied Gustavo A. R. Silva 4 participants 4 messages May 15, 2023 – May 18, 2023

Subsystems (3)
Networking Network drivers Wangxun Ethernet driver
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 net: libwx: Replace zero-length array with flexible-array member

Zero-length arrays as fake flexible arrays are deprecated, and we are moving towards adopting C99 flexible-array members instead.

Transform zero-length array into flexible-array member in struct wx_q_vector.

Link https://github.com/KSPP/linux/issues/21
Link https://github.com/KSPP/linux/issues/286
Link https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/net/ethernet/wangxun/libwx/wx_type.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/wangxun/libwx/wx_type.h +1 -1
index 32f952d93009..cbe7f184b50e 100644
@@ -598,7 +598,7 @@ struct wx_q_vector {
 	char name[IFNAMSIZ + 17];
 
 	/* for dynamic allocation of rings associated with this q_vector */
-	struct wx_ring ring[0] ____cacheline_internodealigned_in_smp;
+	struct wx_ring ring[] ____cacheline_internodealigned_in_smp;
 };
 
 enum wx_isb_idx {
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Gustavo A. R. Silva

Zero-length arrays as fake flexible arrays are deprecated, and we are moving towards adopting C99 flexible-array members instead.

Transform zero-length array into flexible-array member in struct wx_q_vector.

Link https://github.com/KSPP/linux/issues/21
Link https://github.com/KSPP/linux/issues/286
Link https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Simon Horman <[email protected]>
Reviewed-by on v1 1/1
#2 lore raw
In reply to Gustavo A. R. Silva
Quoted 10 lines · Gustavo A. R. Silva

Zero-length arrays as fake flexible arrays are deprecated, and we are moving towards adopting C99 flexible-array members instead.

Transform zero-length array into flexible-array member in struct wx_q_vector.

Link https://github.com/KSPP/linux/issues/21
Link https://github.com/KSPP/linux/issues/286
Link https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Kees Cook <[email protected]>
Signature · 1 line
Kees Cook
CI Applied
#3 lore raw
In reply to Gustavo A. R. Silva
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 6 lines · On Mon, 15 May 2023 13:23:46 -0600 you wrote:

Zero-length arrays as fake flexible arrays are deprecated, and we are moving towards adopting C99 flexible-array members instead.

Transform zero-length array into flexible-array member in struct wx_q_vector.

Quoted 6 lines
Link https://github.com/KSPP/linux/issues/21
Link https://github.com/KSPP/linux/issues/286
Link https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
Signed-off-by Gustavo A. R. Silva <[email protected]>

[...]

Here is the summary with links:
- [next] net: libwx: Replace zero-length array with flexible-array member

    https://git.kernel.org/netdev/net-next/c/fe6559fab328

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html