iommu: amd: Use page mode macros in fetch_pte
Subsystems (2)
PATCH 1/1 iommu: amd: Use page mode macros in fetch_pte
Use the page mode macros instead of magic numbers in fetch_pte.
Cc Robin Murphy <[email protected]>
Cc Will Deacon <[email protected]>
Cc Suravee Suthikulpanit <[email protected]>
Cc Joerg Roedel <[email protected]>
Signed-off-by Jerry Snitselaar <[email protected]>
--- drivers/iommu/amd/io_pgtable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iommu/amd/io_pgtable.c +2 -2
@@ -310,8 +310,8 @@ static u64 *fetch_pte(struct amd_io_pgtable *pgtable,return NULL ;/* Large PTE */ -if (PM_PTE_LEVEL (*pte) ==7 || -PM_PTE_LEVEL (*pte) ==0 ) +if (PM_PTE_LEVEL (*pte) ==PAGE_MODE_7_LEVEL || +PM_PTE_LEVEL (*pte) ==PAGE_MODE_NONE )break ;/* No level skipping support yet */
Signature · 1 line
2.38.1
Quoted 7 lines · Jerry Snitselaar
Use the page mode macros instead of magic numbers in
fetch_pte.Cc Robin Murphy <[email protected]>Cc Will Deacon <[email protected]>Cc Suravee Suthikulpanit <[email protected]>Cc Joerg Roedel <[email protected]>Signed-off-by Jerry Snitselaar <[email protected]>
Thanks for the fix.
Reviewed-by Vasant Hegde <[email protected]>
-Vasant
Quoted 19 lines
--- drivers/iommu/amd/io_pgtable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/iommu/amd/io_pgtable.c +2
-2@@ -310,8 +310,8 @@ static u64 *fetch_pte(struct amd_io_pgtable *pgtable,return NULL ;/* Large PTE */ -if (PM_PTE_LEVEL (*pte) ==7 || -PM_PTE_LEVEL (*pte) ==0 ) +if (PM_PTE_LEVEL (*pte) ==PAGE_MODE_7_LEVEL || +PM_PTE_LEVEL (*pte) ==PAGE_MODE_NONE )break ;/* No level skipping support yet */
Quoted 2 lines · Jerry Snitselaar
drivers/iommu/amd/io_pgtable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.