usb: gadget/snps_udc_plat: Fix a signedness bug in probe
Subsystems (2)
PATCH 1/1 usb: gadget/snps_udc_plat: Fix a signedness bug in probe
The irq_of_parse_and_map() function returns negative error codes but "udc->irq" is an unsigned int so the error handling doesn't work.
--- drivers/usb/gadget/udc/snps_udc_plat.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/usb/gadget/udc/snps_udc_plat.c +4 -3
@@ -103,7 +103,7 @@ static int udc_plat_probe(struct platform_device *pdev)struct device *dev = &pdev->dev;struct resource *res;struct udc *udc; -int ret; +int irq, ret; udc =devm_kzalloc (dev,sizeof (*udc),GFP_KERNEL );if (!udc)
@@ -132,11 +132,12 @@ static int udc_plat_probe(struct platform_device *pdev) udc->phys_addr = (unsigned long )res->start; - udc->irq =irq_of_parse_and_map (dev->of_node,0 ); -if (udc->irq <=0 ) { + irq =irq_of_parse_and_map (dev->of_node,0 ); +if (irq <=0 ) {dev_err (dev,"Can't parse and map interrupt\n" );return -EINVAL ; } + udc->irq = irq; udc->udc_phy =devm_of_phy_get_by_index (dev, dev->of_node,0 );if (IS_ERR (udc->udc_phy)) {
Signature · 1 line
2.30.2
Quoted 5 lines · Dan Carpenter
The
irq_of_parse_and_map()function returns negative error codes but "udc->irq" is an unsigned int so the error handling doesn't work.Fixes 1b9f35adb0ff ("usb: gadget: udc: Add Synopsys UDC Platform driver")Signed-off-by Dan Carpenter <[email protected]>
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Quoted 23 lines · Dan Carpenter
The
irq_of_parse_and_map()function returns negative error codes but "udc->irq" is an unsigned int so the error handling doesn't work.Fixes 1b9f35adb0ff ("usb: gadget: udc: Add Synopsys UDC Platform driver")Signed-off-by Dan Carpenter <[email protected]>--- drivers/usb/gadget/udc/snps_udc_plat.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/usb/gadget/udc/snps_udc_plat.c +1
-1@@ -103,7 +103,7 @@ static int udc_plat_probe(struct platform_device *pdev)struct device *dev = &pdev->dev;struct resource *res;struct udc *udc; -int ret; +int irq, ret; udc =devm_kzalloc (dev,sizeof (*udc),GFP_KERNEL );if (!udc)
drivers/usb/gadget/udc/snps_udc_plat.c static int udc_plat_probe(struct platform_device *pdev) · line 136
Quoted 7 lines
drivers/usb/gadget/udc/snps_udc_plat.c +2
-2@@ -132,11 +132,12 @@ static int udc_plat_probe(struct platform_device *pdev) udc->phys_addr = (unsigned long )res->start; - udc->irq =irq_of_parse_and_map (dev->of_node,0 ); -if (udc->irq <=0 ) { + irq =irq_of_parse_and_map (dev->of_node,0 ); +if (irq <=0 ) {
Oops. It turns out that irq_of_parse_and_map() returns zero on error, not negatives so this patch isn't needed and probably the correct thing is to change the error check to if (!irq) { instead.
regards,
dan carpenter