wifi: rsi: Do not set MMC_PM_KEEP_POWER in shutdown
Subsystems (3)
PATCH 1/1 wifi: rsi: Do not set MMC_PM_KEEP_POWER in shutdown
It makes no sense to set MMC_PM_KEEP_POWER in shutdown. The flag indicates to the MMC subsystem to keep the slot powered on during suspend, but in shutdown the slot should actually be powered off. Drop this call.
---
Cc: "David S. Miller" <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Jilin Yuan <[email protected]>
Cc: Kalle Valo <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Paolo Abeni <[email protected]>
Cc: [email protected]
Cc: [email protected]
--- drivers/net/wireless/rsi/rsi_91x_sdio.c | 3 --- 1 file changed, 3 deletions(-)
drivers/net/wireless/rsi/rsi_91x_sdio.c +0 -3
@@ -1479,9 +1479,6 @@ static void rsi_shutdown(struct device *dev)if (sdev->write_fail)rsi_dbg (INFO_ZONE ,"###### Device is not ready #######\n" ); -if (rsi_set_sdio_pm_caps (adapter)) -rsi_dbg (INFO_ZONE ,"Setting power management caps failed\n" ); -rsi_dbg (INFO_ZONE ,"***** RSI module shut down *****\n" ); }
Signature · 1 line
2.39.2
Quoted 7 lines · Marek Vasut
It makes no sense to set
MMC_PM_KEEP_POWERin shutdown. The flag indicates to the MMC subsystem to keep the slot powered on during suspend, but in shutdown the slot should actually be powered off. Drop this call.Fixes 063848c3e155 ("rsi: sdio: Add WOWLAN support for S5 shutdown state")Signed-off-by Marek Vasut <[email protected]>
Quoted 8 lines · Marek Vasut
It makes no sense to set
MMC_PM_KEEP_POWERin shutdown. The flag indicates to the MMC subsystem to keep the slot powered on during suspend, but in shutdown the slot should actually be powered off. Drop this call.Fixes 063848c3e155 ("rsi: sdio: Add WOWLAN support for S5 shutdown state")Signed-off-by Marek Vasut <[email protected]>Reviewed-by Simon Horman <[email protected]>
Patch applied to wireless-next.git, thanks.
e74f562328b0 wifi: rsi: Do not set MMC_PM_KEEP_POWER in shutdown
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches