Skip to contentSkip to conversation

Bug report in reg_user_mr in exe

DISCUSSION Bob Pearson 2 participants 4 messages Jun 13, 2023 InfiniBand

lore
Share & tools
lore
#0 lore raw

Jason,

Recently the code in rxe_reg_user_mr was changed to check if the driver supported the access flags. Since the rxe driver does nothing about relaxed ordering. I assumed that the driver didn't support that option but it turns out that this breaks the perf tests which request relaxed ordering by default.

It looks like the correct fix for this is to go ahead and claim support for relaxed ordering but it will be a no-op.

Thoughts?

Bob

maintainer
#1 lore raw
Quoted 6 lines · Bob Pearson

Jason,

Recently the code in rxe_reg_user_mr was changed to check if the driver supported the access flags. Since the rxe driver does nothing about relaxed ordering. I assumed that the driver didn't support that option but it turns out that this breaks the perf tests which request relaxed ordering by default.

Sounds like rxe is checking the flags wrong, there is a set of optional access flags that should be ignored by the driver.

Jason

#2 lore raw
Quoted 8 lines · Jason Gunthorpe
Quoted 6 lines · Bob Pearson

Jason,

Recently the code in rxe_reg_user_mr was changed to check if the driver supported the access flags. Since the rxe driver does nothing about relaxed ordering. I assumed that the driver didn't support that option but it turns out that this breaks the perf tests which request relaxed ordering by default.

Quoted 4 lines

Sounds like rxe is checking the flags wrong, there is a set of optional access flags that should be ignored by the driver.

Jason

OK. That's easy. I'm just embarrassed I broke ib_send_bw. So mask off the optional ones and check the rest?

Bob

maintainer
#3 lore raw
Quoted 9 lines · Bob Pearson
Quoted 8 lines · Jason Gunthorpe
Quoted 6 lines · Bob Pearson

Jason,

Recently the code in rxe_reg_user_mr was changed to check if the driver supported the access flags. Since the rxe driver does nothing about relaxed ordering. I assumed that the driver didn't support that option but it turns out that this breaks the perf tests which request relaxed ordering by default.

Quoted 7 lines
Quoted 4 lines

Sounds like rxe is checking the flags wrong, there is a set of optional access flags that should be ignored by the driver.

Jason

OK. That's easy. I'm just embarrassed I broke ib_send_bw. So mask off the optional ones and check the rest?

Yes, there is a constant for it too

Jason