perf bench: remove unneeded variable
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 perf bench: remove unneeded variable
fix the following coccicheck warning:
tools/perf/bench/find-bit-bench.c:127:5-8: Unneeded variable: "err". Return "0".
--- tools/perf/bench/find-bit-bench.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/bench/find-bit-bench.c +2 -2
@@ -124,7 +124,7 @@ static int do_for_each_set_bit(unsigned int num_bits)int bench_mem_find_bit (int argc,const char **argv) { -int err =0 , i; +int i; argc =parse_options (argc, argv, options, bench_usage,0 );if (argc) {
@@ -135,5 +135,5 @@ int bench_mem_find_bit(int argc, const char **argv)for (i =1 ; i <=2048 ; i <<=1 )do_for_each_set_bit (i); -return err; +return 0 ; }
Quoted 7 lines · On Tue, Jun 13, 2023 at 8:38 PM <[email protected]> wrote:
fix the following coccicheck warning:
tools/perf/bench/find-bit-bench.c:127:5-8: Unneeded variable: "err". Return "0".
Signed-off-by Mingtong Bao <[email protected]>
Thanks,
Ian
Quoted 26 lines
--- tools/perf/bench/find-bit-bench.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/perf/bench/find-bit-bench.c +1
-1@@ -124,7 +124,7 @@ static int do_for_each_set_bit(unsigned int num_bits)int bench_mem_find_bit (int argc,const char **argv) { -int err =0 , i; +int i; argc =parse_options (argc, argv, options, bench_usage,0 );if (argc) {tools/perf/bench/find-bit-bench.c +1
-1@@ -135,5 +135,5 @@ int bench_mem_find_bit(int argc, const char **argv)for (i =1 ; i <=2048 ; i <<=1 )do_for_each_set_bit (i); -return err; +return 0 ; }
Arnaldo Carvalho de Melo
maintainerEm Wed, Jun 14, 2023 at 11:38:41AM +0800, [email protected] escreveu:
Quoted 4 lines
fix the following coccicheck warning:
tools/perf/bench/find-bit-bench.c:127:5-8: Unneeded variable: "err". Return "0".
⬢[acme@toolbox perf-tools-next]$ patch -p1 < ~/wb/1.patch patching file tools/perf/bench/find-bit-bench.c
patch: **** malformed patch at line 117: num_bits)
⬢[acme@toolbox perf-tools-next]$
Please check the process you're following to generate and send the patch.
There is a doc file for that...
Documentation/process/submitting-patches.rst
Well, two:
Documentation/process/submit-checklist.rst
I'm applying this manually,
Thanks,
- Arnaldo
Quoted 26 lines
Signed-off-by Mingtong Bao <[email protected]>--- tools/perf/bench/find-bit-bench.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/perf/bench/find-bit-bench.c +2
-2@@ -124,7 +124,7 @@ static int do_for_each_set_bit(unsigned int num_bits)int bench_mem_find_bit (int argc,const char **argv) { -int err =0 , i; +int i; argc =parse_options (argc, argv, options, bench_usage,0 );if (argc) {@@ -135,5 +135,5 @@ int bench_mem_find_bit(int argc, const char **argv)for (i =1 ; i <=2048 ; i <<=1 )do_for_each_set_bit (i); -return err; +return 0 ; }
Signature · 1 line
- Arnaldo