counter: Fix menuconfig "Counter support" submenu entries disappearance
PATCH 1/1 counter: Fix menuconfig "Counter support" submenu entries disappearance
The current placement of the I8254 Kconfig entry results in the disappearance of the "Counter support" submenu items in menuconfig. Move the I8254 above the menuconfig COUNTER entry to restore the intended submenu behavior.
--- drivers/counter/Kconfig | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/counter/Kconfig +7 -7
@@ -3,13 +3,6 @@ # Counter devices # -menuconfig COUNTER - tristate "Counter support" - help - This enables counter device support through the Generic Counter - interface. You only need to enable this, if you also want to enable - one or more of the counter device drivers below. - config I8254 tristate select COUNTER
@@ -25,6 +18,13 @@ config I8254 If built as a module its name will be i8254. +menuconfig COUNTER + tristate "Counter support" + help + This enables counter device support through the Generic Counter + interface. You only need to enable this, if you also want to enable + one or more of the counter device drivers below. + if COUNTER config 104_QUAD_8
base-commit: d428487471ba6640ee8bcdabaf830aec08b85400
Signature · 1 line
2.40.1
Hi,
Quoted 9 lines · William Breathitt Gray
The current placement of the I8254
Kconfigentry results in the disappearance of the "Counter support" submenu items in menuconfig. Move the I8254 above the menuconfig COUNTER entry to restore the intended submenu behavior.Fixes d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")Reported-by Jarkko Nikula <[email protected]>Signed-off-by William Breathitt Gray <[email protected]>
but why is I8254 here at all? Users cannot enable it and nothing selects it. Is it a WIP?
Thanks.
Quoted 38 lines
--- drivers/counter/Kconfig | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)drivers/counter/Kconfig +7
-7@@ -3,13 +3,6 @@ # Counter devices # -menuconfig COUNTER - tristate "Counter support" - help - This enables counter device support through the Generic Counter - interface. You only need to enable this, if you also want to enable - one or more of the counter device drivers below. - config I8254 tristate select COUNTER@@ -25,6 +18,13 @@ config I8254 If built as a module its name will be i8254. +menuconfig COUNTER + tristate "Counter support" + help + This enables counter device support through the Generic Counter + interface. You only need to enable this, if you also want to enable + one or more of the counter device drivers below. + if COUNTER config 104_QUAD_8base-commit:
d428487471ba6640ee8bcdabaf830aec08b85400
Signature · 1 line
~Randy
Quoted 13 lines · Randy Dunlap
Hi,
Quoted 9 lines · William Breathitt Gray
The current placement of the I8254
Kconfigentry results in the disappearance of the "Counter support" submenu items in menuconfig. Move the I8254 above the menuconfig COUNTER entry to restore the intended submenu behavior.Fixes d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")Reported-by Jarkko Nikula <[email protected]>Signed-off-by William Breathitt Gray <[email protected]>
Quoted 6 lines
Reviewed-by Randy Dunlap <[email protected]>but why is I8254 here at all? Users cannot enable it and nothing selects it. Is it a WIP?
Thanks.
There are pending patches for two drivers to use it: 104-dio-48e[^1] and stx104[^2]. Those will be picked up in their respective subsystem trees (by Bart and Jonathan I presume).
William Breathitt Gray
[^1]: https://lore.kernel.org/all/dc4d0d5ca6ea28eda18815df114ecb21226cb345.1681665189.git.william.gray@linaro.org/
[^2]: https://lore.kernel.org/all/45d35b6f6e8d51df788b2bc85c456bfd45476b1a.1681665189.git.william.gray@linaro.org/
Quoted 9 lines · William Breathitt Gray
Quoted 8 lines · Randy Dunlap
Hi,
Quoted 5 lines · William Breathitt Gray
The current placement of the I8254
Kconfigentry results in the disappearance of the "Counter support" submenu items in menuconfig. Move the I8254 above the menuconfig COUNTER entry to restore the intended submenu behavior.
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
Fixes d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")Reported-by Jarkko Nikula <[email protected]>Signed-off-by William Breathitt Gray <[email protected]>Reviewed-by Randy Dunlap <[email protected]>
Thanks, this fixes it.
Jonathan Cameron
maintainerQuoted 16 lines · On Tue, 20 Jun 2023 17:12:13 -0400 William Breathitt Gray…
Quoted 15 lines · Randy Dunlap
Hi,
Quoted 9 lines · William Breathitt Gray
The current placement of the I8254
Kconfigentry results in the disappearance of the "Counter support" submenu items in menuconfig. Move the I8254 above the menuconfig COUNTER entry to restore the intended submenu behavior.Fixes d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")Reported-by Jarkko Nikula <[email protected]>Signed-off-by William Breathitt Gray <[email protected]>Reviewed-by Randy Dunlap <[email protected]>
Quoted 9 lines
Quoted 4 lines
but why is I8254 here at all? Users cannot enable it and nothing selects it. Is it a WIP?
Thanks.
There are pending patches for two drivers to use it: 104-dio-48e[^1] and stx104[^2]. Those will be picked up in their respective subsystem trees (by Bart and Jonathan I presume).
I missed the IIO patch in that series. Could you resend please.
Jonathan
Quoted 24 lines · Jonathan Cameron
Quoted 21 lines · On Tue, 20 Jun 2023 17:12:13 -0400 William Breathitt Gray…
Quoted 19 lines · Randy Dunlap
Hi,
Quoted 9 lines · William Breathitt Gray
The current placement of the I8254
Kconfigentry results in the disappearance of the "Counter support" submenu items in menuconfig. Move the I8254 above the menuconfig COUNTER entry to restore the intended submenu behavior.Fixes d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")Reported-by Jarkko Nikula <[email protected]>Signed-off-by William Breathitt Gray <[email protected]>Reviewed-by Randy Dunlap <[email protected]>but why is I8254 here at all? Users cannot enable it and nothing selects it. Is it a WIP?
Thanks.
Quoted 13 lines
Quoted 4 lines
There are pending patches for two drivers to use it: 104-dio-48e[^1] and stx104[^2]. Those will be picked up in their respective subsystem trees (by Bart and Jonathan I presume).
I missed the IIO patch in that series. Could you resend please.
Jonathan
I8254 is expected to land in 6.5 so I'll wait and resend the IIO patch rebased on 6.5-rc1 once it's released in a couple weeks. That'll make things simple for you and avoid the need for an immutable branch.
William Breathitt Gray
William Breathitt Gray
AppliedQuoted 9 lines · William Breathitt Gray
The current placement of the I8254
Kconfigentry results in the disappearance of the "Counter support" submenu items in menuconfig. Move the I8254 above the menuconfig COUNTER entry to restore the intended submenu behavior.Fixes d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")Reported-by Jarkko Nikula <[email protected]>Signed-off-by William Breathitt Gray <[email protected]>
Applied to counter-current.
William Breathitt Gray