Skip to contentSkip to conversation

ext4: Fix warning in blkdev_put()

PATCH Applied Jan Kara 3 participants 3 messages Jun 22, 2023 – Jun 23, 2023

Subsystems (2)
lore
Share & tools
lore

Jan Kara

author reviewer
#0 lore raw

PATCH 1/1 ext4: Fix warning in blkdev_put()

ext4_blkdev_remove() passes a wrong holder pointer to blkdev_put() which triggers a warning there. Fix it.

Fixes 2736e8eeb0cc ("block: use the holder as indication for exclusive opens")
---
 fs/ext4/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Jens, this is another fixup of the block device handling series sitting in your tree.

fs/ext4/super.c +1 -1
index 53d74144ee34..d34b4eb90fe8 100644
@@ -1133,7 +1133,7 @@ static void ext4_blkdev_remove(struct ext4_sb_info *sbi)
 	struct block_device *bdev;
 	bdev = sbi->s_journal_bdev;
 	if (bdev) {
-		blkdev_put(bdev, sbi->s_es);
+		blkdev_put(bdev, sbi->s_sb);
 		sbi->s_journal_bdev = NULL;
 	}
 }
Signature · 1 line
2.35.3
maintainer Applied
#2 lore raw
In reply to Jan Kara
Quoted 4 lines · Jan Kara

ext4_blkdev_remove() passes a wrong holder pointer to blkdev_put() which triggers a warning there. Fix it.

Applied, thanks!

[1/1] ext4: Fix warning in blkdev_put()

      commit: a42fb5a75ccc37dfd69aa9bde5ba2866e802ff3c

Best regards,

Signature · 1 line
Jens Axboe