staging: ks7010: Wrap macro definitions in parenthesis
PATCH 1/1 staging: ks7010: Wrap macro definitions in parenthesis
Wrap the definition of TX_RATE_* constants in parenthesis to prevent incorrect casting during expansion, as recommended by checkpatch.pl.
Signed-off-by Caleb D.S. Brzezinski <[email protected]>
--- drivers/staging/ks7010/ks_hostif.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/staging/ks7010/ks_hostif.h +12 -12
@@ -498,20 +498,20 @@ struct hostif_mic_failure_request {#define TX_RATE_FIXED 5/* 11b rate */ -#define TX_RATE_1M (u8)(10 / 5)/* 11b 11g basic rate */ -#define TX_RATE_2M (u8)(20 / 5)/* 11b 11g basic rate */ -#define TX_RATE_5M (u8)(55 / 5)/* 11g basic rate */ -#define TX_RATE_11M (u8)(110 / 5)/* 11g basic rate */ +#define TX_RATE_1M ((u8)(10 / 5))/* 11b 11g basic rate */ +#define TX_RATE_2M ((u8)(20 / 5))/* 11b 11g basic rate */ +#define TX_RATE_5M ((u8)(55 / 5))/* 11g basic rate */ +#define TX_RATE_11M ((u8)(110 / 5))/* 11g basic rate */ /* 11g rate */ -#define TX_RATE_6M (u8)(60 / 5)/* 11g basic rate */ -#define TX_RATE_12M (u8)(120 / 5)/* 11g basic rate */ -#define TX_RATE_24M (u8)(240 / 5)/* 11g basic rate */ -#define TX_RATE_9M (u8)(90 / 5) -#define TX_RATE_18M (u8)(180 / 5) -#define TX_RATE_36M (u8)(360 / 5) -#define TX_RATE_48M (u8)(480 / 5) -#define TX_RATE_54M (u8)(540 / 5) +#define TX_RATE_6M ((u8)(60 / 5))/* 11g basic rate */ +#define TX_RATE_12M ((u8)(120 / 5))/* 11g basic rate */ +#define TX_RATE_24M ((u8)(240 / 5))/* 11g basic rate */ +#define TX_RATE_9M ((u8)(90 / 5)) +#define TX_RATE_18M ((u8)(180 / 5)) +#define TX_RATE_36M ((u8)(360 / 5)) +#define TX_RATE_48M ((u8)(480 / 5)) +#define TX_RATE_54M ((u8)(540 / 5))static inline bool is_11b_rate (u8 rate) {
Signature · 1 line
2.31.0
Quoted 18 lines · Caleb D.S. Brzezinski
/* 11b rate */
drivers/staging/ks7010/ks_hostif.h +4
-10-#define TX_RATE_1M (u8)(10 / 5)/* 11b 11g basic rate */ -#define TX_RATE_2M (u8)(20 / 5)/* 11b 11g basic rate */ -#define TX_RATE_5M (u8)(55 / 5)/* 11g basic rate */ -#define TX_RATE_11M (u8)(110 / 5)/* 11g basic rate */ +#define TX_RATE_1M ((u8)(10 / 5))/* 11b 11g basic rate */ +#define TX_RATE_2M ((u8)(20 / 5))/* 11b 11g basic rate */ +#define TX_RATE_5M ((u8)(55 / 5))/* 11g basic rate */ +#define TX_RATE_11M ((u8)(110 / 5))/* 11g basic rate */ /* 11g rate */ -#define TX_RATE_6M (u8)(60 / 5)/* 11g basic rate */ -#define TX_RATE_12M (u8)(120 / 5)/* 11g basic rate */ -#define TX_RATE_24M (u8)(240 / 5)/* 11g basic rate */ -#define TX_RATE_9M (u8)(90 / 5) -#define TX_RATE_18M (u8)(180 / 5) -#define TX_RATE_36M (u8)(360 / 5)
drivers/staging/ks7010/ks_hostif.h struct hostif_mic_failure_request { · line 514
Quoted 10 lines
drivers/staging/ks7010/ks_hostif.h +8
-2-#define TX_RATE_48M (u8)(480 / 5) -#define TX_RATE_54M (u8)(540 / 5) +#define TX_RATE_6M ((u8)(60 / 5))/* 11g basic rate */ +#define TX_RATE_12M ((u8)(120 / 5))/* 11g basic rate */ +#define TX_RATE_24M ((u8)(240 / 5))/* 11g basic rate */ +#define TX_RATE_9M ((u8)(90 / 5)) +#define TX_RATE_18M ((u8)(180 / 5)) +#define TX_RATE_36M ((u8)(360 / 5)) +#define TX_RATE_48M ((u8)(480 / 5)) +#define TX_RATE_54M ((u8)(540 / 5))
tl;dr (quoted from Greg's bot):
Quoted 4 lines
You sent a patch that has been sent multiple times in the past few days, and is identical to ones that has been recently rejected. Please always look at the mailing list traffic to determine if you are duplicating other people's work.
Why? See discussions on [1] and [2].
[1]: https://lore.kernel.org/all/[email protected]/
[2]: https://lore.kernel.org/all/20210222062849.GN2087@kadam/
Thanks.
Signature · 1 line
An old man doll... just what I always wanted! - Clara