Skip to contentSkip to conversation

ARM: mm: Fix warnings in context.c

PATCH In review [email protected] 2 participants 2 messages Jul 12, 2023 1 message not in the archive Arm (32-bit)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 ARM: mm: Fix warnings in context.c

The following checkpatch warning is removed:
WARNING: Use #include <linux/mmu_context.h> instead of <asm/mmu_context.h>

---
 arch/arm/mm/context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mm/context.c +1 -1
index 4204ffa2d104..c84ad6c786e7 100644
@@ -13,7 +13,7 @@
 #include <linux/smp.h>
 #include <linux/percpu.h>
 
-#include <asm/mmu_context.h>
+#include <linux/mmu_context.h>
 #include <asm/smp_plat.h>
 #include <asm/thread_notify.h>
 #include <asm/tlbflush.h>

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 14 lines · On Wed, Jul 12, 2023 at 05:06:32PM +0800, [email protected] wrote:

The following checkpatch warning is removed:
WARNING: Use #include <linux/mmu_context.h> instead of <asm/mmu_context.h>

---
 arch/arm/mm/context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mm/context.c +0 -0
index 4204ffa2d104..c84ad6c786e7 100644

arch/arm/mm/context.c line 19

Quoted 8 lines
arch/arm/mm/context.c +1 -1
@@ -13,7 +13,7 @@
 #include <linux/smp.h>
 #include <linux/percpu.h>
 
-#include <asm/mmu_context.h>
+#include <linux/mmu_context.h>
 #include <asm/smp_plat.h>
 #include <asm/thread_notify.h>
 #include <asm/tlbflush.h>

Probably haven't noticed, but linux/ includes are all grouped together, and asm/ includes are all grouped together. Please keep that.

Also, is it really a necessary change, when arch/arm/mm/context.c is only implementing the interfaces provided by asm/mmu_context.h? I think the warning is wrong in this case and should never be fixed as things currently stand.

Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!